[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-28 Thread GitBox 


Klaus-xjp commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495774296



##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
##
@@ -419,6 +419,24 @@ public boolean createNewFile(FsPermission permission) 
throws IOException {
 }
   }
 
+  @Override
+  public boolean createNewFile(Boolean overwrite, FsPermission permission) 
throws IOException {

Review comment:
   done
   

##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission 
permission) throws IOException {
 return file.createNewFile();
   }
 
+  @Override
+  public boolean createNewFile(Boolean overwrite, final FsPermission 
permission)

Review comment:
   done
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox 


Klaus-xjp commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r496844035



##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
##
@@ -293,6 +293,32 @@ public static boolean createNewFile(
 return getCarbonFile(filePath).createNewFile(permission);
   }
 
+  public static boolean createNewFile(String filePath, Boolean overwrite,
+  final FsPermission permission) throws IOException {
+return getCarbonFile(filePath).createNewFile(overwrite, permission);
+  }
+
+  public static long setCurrentTimetoLastModifiedTime(String filePath) throws 
IOException {

Review comment:
   i have renamed this function





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox 


Klaus-xjp commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r496853936



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertFromStageCommand.scala
##
@@ -507,17 +507,17 @@ case class CarbonInsertFromStageCommand(
 override def call(): (CarbonFile, CarbonFile, Boolean) = {
   try {
 // Get the loading files path
-val stageLoadingFile =
-  FileFactory.getCarbonFile(stagePath +
-File.separator + files._1.getName + 
CarbonTablePath.LOADING_FILE_SUFFIX);
+val stageLoadingFilePath = stagePath + File.separator + 
files._1.getName +
+   CarbonTablePath.LOADING_FILE_SUFFIX

Review comment:
   i have reformat this line





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox 


Klaus-xjp commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r496864594



##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission 
permission) throws IOException {
 return file.createNewFile();
   }
 
+  @Override
+  public boolean createNewFile(Boolean overwrite, final FsPermission 
permission)
+  throws IOException {
+return file.createNewFile();

Review comment:
   i have changed this function





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org