[GitHub] [carbondata] kunal642 commented on a change in pull request #3787: [CARBONDATA-3923] support global sort for SI

[GitBox]

kunal642 commented on a change in pull request #3787:
URL: https://github.com/apache/carbondata/pull/3787#discussion_r486246357



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
##
@@ -89,7 +104,7 @@ private[sql] class CarbonLateDecodeStrategy extends 
SparkStrategy {
 try {
   pruneFilterProject(
 l,
-
projects.filterNot(_.name.equalsIgnoreCase(CarbonCommonConstants.POSITION_ID)),

Review comment:
   why is the filter removed?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] kunal642 commented on a change in pull request #3787: [CARBONDATA-3923] support global sort for SI

[GitBox]

kunal642 commented on a change in pull request #3787:
URL: https://github.com/apache/carbondata/pull/3787#discussion_r486243458



##
File path: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
##
@@ -801,6 +802,26 @@ object CommonUtil {
 }
   }
 
+  def validateGlobalSortPartitions(propertiesMap: mutable.Map[String, 
String]): Unit = {
+if (propertiesMap.get("global_sort_partitions").isDefined) {
+  val globalSortPartitionsProp = propertiesMap("global_sort_partitions")
+  var pass = false
+  try {
+val globalSortPartitions = Integer.parseInt(globalSortPartitionsProp)
+if (globalSortPartitions > 0) {
+  pass = true
+}
+  } catch {
+case _ =>
+  }
+  if (!pass) {

Review comment:
   no, keeping this variable doesn't make sense. please catch Parsing 
Exception an throw MalformedCarbonCommandException direclty





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org