[GitHub] [carbondata] lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle rules

2019-10-30 Thread GitBox 
lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle 
rules
URL: https://github.com/apache/carbondata/pull/3401#issuecomment-548202957
 
 
   @jackylk, please cc, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [carbondata] lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle rules

2019-10-24 Thread GitBox 
lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle 
rules
URL: https://github.com/apache/carbondata/pull/3401#issuecomment-545832686
 
 
   > @ajantha-bhat
   > I think these new rules are good for improving code readability.
   > After introducing these rules which is INFO level, we can resolve it in 
the future step by step.
   > So, suggest to merge it. What do you think?
   
   thanks, I'll  resolve it in the future step by step.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [carbondata] lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle rules

2019-10-21 Thread GitBox 
lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle 
rules
URL: https://github.com/apache/carbondata/pull/3401#issuecomment-544403869
 
 
   > How many new error(info, as now the level is set to info) comes after 
adding this checkstyle ?
   > 
   > If we are not fixing those errors why are we adding the rules ?
   > 
   > @ravipesala , @kumarvishal09 please check
   
   Hi, @ajantha-bhat, I'll fix these style errors at the futuer. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [carbondata] lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle rules

2019-10-21 Thread GitBox 
lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle 
rules
URL: https://github.com/apache/carbondata/pull/3401#issuecomment-544375668
 
 
   > @lamber-ken :
   > Please update the description and I have some questions ?
   > 
   > 1. Why this change now ? what is the problem with current check style ? 
these new rules are taken from which reference or project ?
   > 2. Why only java checkstyle modification ? why not scala check style also ?
   > 3. After adding these rules ? no issues found in carbon ?
   
   hi, @ajantha-bhat,
   
   This issus just fucus on java checkstyle, it's a big work to refactor java 
checkstyle already, scala checkstyle needs a new thread to refactor. And some 
new rules, for example bellow.
   
   you can check rulues by `mvn 
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check`.
   
    RedundantImport 
(org.apache.carbondata.core.scan.expression.MatchExpression)
   ```
   import org.apache.carbondata.common.annotations.InterfaceAudience;
   import org.apache.carbondata.core.metadata.datatype.DataTypes;
   import org.apache.carbondata.core.scan.expression.Expression;
   import org.apache.carbondata.core.scan.expression.ExpressionResult;
   import 
org.apache.carbondata.core.scan.expression.exception.FilterIllegalMemberException;
   import 
org.apache.carbondata.core.scan.expression.exception.FilterUnsupportedException;
   import org.apache.carbondata.core.scan.filter.intf.ExpressionType;
   import org.apache.carbondata.core.scan.filter.intf.RowIntf;
   ```
   
    @Override (org.apache.carbondata.datamap.PreAggregateDataMapProvider)
   ```
   @Override
   public boolean supportRebuild() {
 return false;
   }
   
   @Override public boolean rebuildInternal(String newLoadName, Map> segmentMap,
   CarbonTable carbonTable) {
 return false;
   }
   ```
   
    AvoidStarImport (org.apache.carbondata.tool.DataSummary)
   ```
   import java.io.File;
   import java.io.IOException;
   import java.nio.charset.Charset;
   import java.util.*;
   ```
   
    EmptyStatement 
(org.apache.carbondata.datamap.lucene.LuceneDataMapFactoryBase)
   ```
   // validate DataMapSchema and get index columns
   indexedCarbonColumns =  carbonTable.getIndexedColumns(dataMapSchema);;
   flushCacheSize = validateAndGetWriteCacheSize(dataMapSchema);
   storeBlockletWise = validateAndGetStoreBlockletWise(dataMapSchema);
   ```
   and so on.
   
   
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [carbondata] lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle rules

2019-10-03 Thread GitBox 
lamber-ken commented on issue #3401: [CARBONDATA-3528] refactor java checkstyle 
rules
URL: https://github.com/apache/carbondata/pull/3401#issuecomment-538036409
 
 
   Hi @jackylk, if you have time, can you please take a look?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services