[GitHub] [carbondata] marchpure commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

[GitBox]

marchpure commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r496708385



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertFromStageCommand.scala
##
@@ -507,17 +507,17 @@ case class CarbonInsertFromStageCommand(
 override def call(): (CarbonFile, CarbonFile, Boolean) = {
   try {
 // Get the loading files path
-val stageLoadingFile =
-  FileFactory.getCarbonFile(stagePath +
-File.separator + files._1.getName + 
CarbonTablePath.LOADING_FILE_SUFFIX);
+val stageLoadingFilePath = stagePath + File.separator + 
files._1.getName +
+   CarbonTablePath.LOADING_FILE_SUFFIX

Review comment:
   take care about format





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] marchpure commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

[GitBox]

marchpure commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495646765



##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission 
permission) throws IOException {
 return file.createNewFile();
   }
 
+  @Override
+  public boolean createNewFile(Boolean overwrite, final FsPermission 
permission)
+  throws IOException {
+return file.createNewFile();

Review comment:
   we can't discard parameters like this

##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
##
@@ -293,6 +293,32 @@ public static boolean createNewFile(
 return getCarbonFile(filePath).createNewFile(permission);
   }
 
+  public static boolean createNewFile(String filePath, Boolean overwrite,
+  final FsPermission permission) throws IOException {
+return getCarbonFile(filePath).createNewFile(overwrite, permission);
+  }
+
+  public static long setCurrentTimetoLastModifiedTime(String filePath) throws 
IOException {

Review comment:
   setLastModifiedTimetoCurrentTimeto





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org