[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-10-02 Thread xuchuanyin 
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2783
  
OK, I'll close this PR instead


---

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-30 Thread ravipesala 
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2783
  
@xuchuanyin This problem is fixed in PR 
https://github.com/apache/carbondata/pull/2793


---

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-28 Thread xuchuanyin 
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2783
  
@ravipesala @kumarvishal09 We have encountered JVM crash problem.
The dump file complains

![jvmcrash](https://user-images.githubusercontent.com/10445758/46239184-73973e00-c3c7-11e8-9a16-5a27113d974f.png)

Clearly it is unsafe memory related problem. Since in the previous PR, we 
have disabled the unsafe for query, I think in this place we should disable the 
unsafe accordingly.




---

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-28 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2783
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8900/



---

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-28 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2783
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/830/



---

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-28 Thread ravipesala 
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2783
  
@xuchuanyin I don't what is the purpose of doing this? Please elaborate 
problem in PR description.
This variable is added to avoid JVM crash when freed multiple times. I am 
not getting why this should be configurable.


---

[GitHub] carbondata issue #2783: [CARBONDATA-2988] use unsafe for query model based o...

2018-09-28 Thread CarbonDataQA 
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2783
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/635/



---