[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-09 Thread xubo245
Github user xubo245 commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
LGTM! Thanks for you contribution!


---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2445/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10483/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2226/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2225/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10480/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2442/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-08 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2223/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-07 Thread xubo245
Github user xubo245 commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
retest this please


---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-07 Thread zzcclp
Github user zzcclp commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
LGTM


---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10443/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2403/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10441/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2187/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2185/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10438/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2398/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2182/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-04 Thread zzcclp
Github user zzcclp commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Just some nit comments, and others LGTM


---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10352/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2303/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2098/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread xiaohui0318
Github user xiaohui0318 commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
fix already.tks


---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread zzcclp
Github user zzcclp commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
please remove blank before '('


---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10345/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2296/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2091/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10344/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2295/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2090/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2088/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread xiaohui0318
Github user xiaohui0318 commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
> Be sure to do all of the following checklist to help us incorporate
> your contribution quickly and easily:
> 
> * [x]  Any interfaces changed?
NO
> * [x]  Any backward compatibility impacted?
NO
> * [x]  Document update required?
NO
> * [x]  Testing done
NO,only fix style error
> * [x]  For large changes, please consider breaking it into sub-tasks 
under an umbrella JIRA.
NO




---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2287/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2082/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
Build Failed  with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10336/



---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread xubo245
Github user xubo245 commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
add to whitelist


---


[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-29 Thread xubo245
Github user xubo245 commented on the issue:

https://github.com/apache/carbondata/pull/3032
  
 Have you validate with S3?


---