[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

[pawanmalwal]

Github user pawanmalwal closed the pull request at:

https://github.com/apache/carbondata/pull/1281


---

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

[pawanmalwal]

GitHub user pawanmalwal reopened a pull request:

https://github.com/apache/carbondata/pull/1281

[CARBONDATA-1326] Fixed findbug issue and univocity-parsers jar version to 
2.2.1

Updated univocity-parsers jar version from 1.5.6 to 2.2.1 in 
processing/pom.xml and fixed one findbug issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pawanmalwal/carbondata 
findbug_univocity_pom_changes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1281


commit 2a36440af46fc9ed361109990dc9a7c8f367e19e
Author: Pawan Malwal 
Date:   2017-08-22T10:19:00Z

[CARBONDATA-1326] Fixed findbug issue and univocity-parsers jar version to 
2.2.1




---

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

[pawanmalwal]

Github user pawanmalwal closed the pull request at:

https://github.com/apache/carbondata/pull/1281


---

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

[pawanmalwal]

Github user pawanmalwal commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1281#discussion_r134990100
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterExpressionProcessor.java
 ---
@@ -163,17 +163,17 @@ public FilterResolverIntf 
getFilterResolver(Expression expressionTree,
   }
 
   private String joinByteArray(byte[] bytes, char delimiter) {
-StringBuffer byteArrayAsString = new StringBuffer();
-byteArrayAsString.append("");
+String byteArrayAsString = "";
--- End diff --

Changed to StringBuffer per your suggestion. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

[sraghunandan]

Github user sraghunandan commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1281#discussion_r134849821
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterExpressionProcessor.java
 ---
@@ -163,17 +163,17 @@ public FilterResolverIntf 
getFilterResolver(Expression expressionTree,
   }
 
   private String joinByteArray(byte[] bytes, char delimiter) {
-StringBuffer byteArrayAsString = new StringBuffer();
-byteArrayAsString.append("");
+String byteArrayAsString = "";
--- End diff --

do not change this to String,Findbugs will give error.
though java optimises internally when strings are concatenated, findbugs 
doesn't recognise that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] carbondata pull request #1281: [CARBONDATA-1326] Fixed findbug issue and uni...

[pawanmalwal]

GitHub user pawanmalwal opened a pull request:

https://github.com/apache/carbondata/pull/1281

[CARBONDATA-1326] Fixed findbug issue and univocity-parsers jar version to 
2.2.1

Updated univocity-parsers jar version from 1.5.6 to 2.2.1 in 
processing/pom.xml and fixed one findbug issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pawanmalwal/carbondata 
findbug_univocity_pom_changes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1281


commit 218a4d8b44ae5efcc3d591358d5bba7ab813a68f
Author: Pawan Malwal 
Date:   2017-08-22T10:19:00Z

[CARBONDATA-1326] Fixed findbug issue and univocity-parsers jar version to 
2.2.1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---