[GitHub] carbondata pull request #1491: [CARBONDATA-1651] [Supported Boolean Type Whe...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1491


---

[GitHub] carbondata pull request #1491: [CARBONDATA-1651] [Supported Boolean Type Whe...

[anubhav100]

Github user anubhav100 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1491#discussion_r150858848
  
--- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataFrame.scala
 ---
@@ -70,7 +82,17 @@ class TestLoadDataFrame extends QueryTest with 
BeforeAndAfterAll {
 buildTestData
   }
 
-
+test("test the boolean data type"){
+  booldf.write
+.format("carbondata")
+.option("tableName", "carbon10")
+.option("tempCSV", "true")
+.option("compress", "true")
+.mode(SaveMode.Overwrite)
+.save()
+  checkAnswer(
+  sql("SELECT * FROM 
CARBON10"),Seq(Row("anubhav",true),Row("prince",false)))
--- End diff --

@jackylk i have done the changes you can review


---

[GitHub] carbondata pull request #1491: [CARBONDATA-1651] [Supported Boolean Type Whe...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1491#discussion_r150842701
  
--- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataFrame.scala
 ---
@@ -70,7 +82,17 @@ class TestLoadDataFrame extends QueryTest with 
BeforeAndAfterAll {
 buildTestData
   }
 
-
+test("test the boolean data type"){
+  booldf.write
+.format("carbondata")
+.option("tableName", "carbon10")
+.option("tempCSV", "true")
+.option("compress", "true")
+.mode(SaveMode.Overwrite)
+.save()
+  checkAnswer(
+  sql("SELECT * FROM 
CARBON10"),Seq(Row("anubhav",true),Row("prince",false)))
--- End diff --

change to 
```
checkAnswer(
 sql("SELECT * FROM CARBON10"),
 Seq(Row("anubhav", true), Row("prince", false)))
```


---

[GitHub] carbondata pull request #1491: [CARBONDATA-1651] [Supported Boolean Type Whe...

[anubhav100]

GitHub user anubhav100 opened a pull request:

https://github.com/apache/carbondata/pull/1491

[CARBONDATA-1651] [Supported Boolean Type When Saving DataFrame] Provided 
Support For Boolean Data Type In CarbonDataFrameWriter

1.Provided Support For Boolean Data Type In CarbonDataFrameWriter
2.Test Cases are Added For Same



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anubhav100/incubator-carbondata 
CARBONDATA-1651

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1491


commit c9433e46c6a7bd5ae40a747214346f931fa2581a
Author: anubhav100 
Date:   2017-11-13T08:03:15Z

Provided Support For Boolean Data Type In CarbonDataFrameWriter




---