[GitHub] carbondata pull request #1520: [CARBONDATA-1734] Ignore empty line while rea...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1520


---

[GitHub] carbondata pull request #1520: [CARBONDATA-1734] Ignore empty line while rea...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1520#discussion_r151832059
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ---
@@ -1406,6 +1405,13 @@
 
   public static final String LAST_UPDATE_TIME = "Last Update Time";
 
+  /**
+   * this will be used to skip / ignore empty lines while loading
+   */
+  public static final String CARBON_SKIP_EMPTY_LINE = 
"carbon.skip.empty.line";
--- End diff --

I think it should be annoted as  @CarbonProperty 


---

[GitHub] carbondata pull request #1520: [CARBONDATA-1734] Ignore empty line while rea...

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1520#discussion_r151698402
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/constants/CarbonLoadOptionConstants.java
 ---
@@ -45,6 +45,9 @@
   "carbon.options.is.empty.data.bad.record";
   public static final String 
CARBON_OPTIONS_IS_EMPTY_DATA_BAD_RECORD_DEFAULT = "false";
 
+  @CarbonProperty public static final String 
CARBON_OPTIONS_SKIP_EMPTY_LINE =
--- End diff --

Please add documentation 


---

[GitHub] carbondata pull request #1520: [CARBONDATA-1734] Ignore empty line while rea...

[dhatchayani]

GitHub user dhatchayani opened a pull request:

https://github.com/apache/carbondata/pull/1520

[CARBONDATA-1734] Ignore empty line while reading CSV

Ignore / Skip empty lines while loading
Load level and System level properties are added to control it.


 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [X] Document update required?
 New System level property and load level property is added. 
Document should be updated 
 accordingly.

 - [X] Testing done
UT Added
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dhatchayani/incubator-carbondata empty_line

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1520


commit 41b0a259ba94509245383a23029b6a6ce2366760
Author: dhatchayani 
Date:   2017-11-17T07:11:49Z

[CARBONDATA-1734] Ignore empty line while reading CSV




---