[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2306


---

[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...

[ajantha-bhat]

Github user ajantha-bhat commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2306#discussion_r188838995
  
--- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java 
---
@@ -540,4 +543,19 @@ private CarbonLoadModel buildLoadModel(CarbonTable 
table, long UUID, String task
 setCsvHeader(build);
 return build;
   }
+
+  /**
+   * can set the sortScope to NO_SORT
+   *
+   * @param sortScope can be set to "NO_SORT" to avoid sorting during load.
+   * by default sort_scope is "LOCAL_SORT"
+   * @return updated CarbonWriterBuilder
+   */
+  public CarbonWriterBuilder sortScope(String sortScope) {
+if (!sortScope.equalsIgnoreCase("NO_SORT")) {
--- End diff --

Removed it and also avro Timestamp issue


---

[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2306#discussion_r188678446
  
--- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java 
---
@@ -540,4 +543,19 @@ private CarbonLoadModel buildLoadModel(CarbonTable 
table, long UUID, String task
 setCsvHeader(build);
 return build;
   }
+
+  /**
+   * can set the sortScope to NO_SORT
+   *
+   * @param sortScope can be set to "NO_SORT" to avoid sorting during load.
+   * by default sort_scope is "LOCAL_SORT"
+   * @return updated CarbonWriterBuilder
+   */
+  public CarbonWriterBuilder sortScope(String sortScope) {
+if (!sortScope.equalsIgnoreCase("NO_SORT")) {
--- End diff --

Remove NO_SORT from sdk. 


---

[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...

[ajantha-bhat]

GitHub user ajantha-bhat opened a pull request:

https://github.com/apache/carbondata/pull/2306

[CARBONDATA-2479] Multiple issue fixes in SDK writer and external table flow

[CARBONDATA-2479] Multiple issues:
fixed external table path display
fixed default value for array in AVRO
fixed NPE when delete folder before the second select query
fixed primetive time stamp sdk load Issue fix


Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?NA
 
 - [ ] Any backward compatibility impacted?NA
 
 - [ ] Document update required?NA

 - [ ] Testing done
yes updated the UT

 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. NA



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ajantha-bhat/carbondata issue_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2306


commit 2cec0497da785b1c258c9dafbaa52596539335bb
Author: ajantha-bhat 
Date:   2018-05-14T09:58:23Z

[CARBONDATA-2479] Multiple issues:
fixed external table path display
fixed default value for array in AVRO
fixed NPE when delete folder before the second select query
fixed primetive time stamp sdk load Issue fix




---