[GitHub] carbondata pull request #2552: [CARBONDATA-2781] Added fix for Null Pointer ...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2552 ---
[GitHub] carbondata pull request #2552: [CARBONDATA-2781] Added fix for Null Pointer ...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2552#discussion_r206546864
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
---
@@ -181,7 +181,18 @@ case class CarbonCreateDataMapCommand(
override def undoMetadata(sparkSession: SparkSession, exception:
Exception): Seq[Row] = {
if (dataMapProvider != null) {
- dataMapProvider.cleanMeta()
+ if (dataMapSchema.getProviderName
--- End diff --
My suggestion is `CarbonDropDataMapCommand` should be called for all
datamaps not just for pre-aggregate
---
[GitHub] carbondata pull request #2552: [CARBONDATA-2781] Added fix for Null Pointer ...
Github user praveenmeenakshi56 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2552#discussion_r206521693
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
---
@@ -181,7 +181,18 @@ case class CarbonCreateDataMapCommand(
override def undoMetadata(sparkSession: SparkSession, exception:
Exception): Seq[Row] = {
if (dataMapProvider != null) {
- dataMapProvider.cleanMeta()
+ if (dataMapSchema.getProviderName
--- End diff --
We need this check because we want the implementation of cleanMeta() method
in PreAggregregateDataMapProvider. For others, It will take from
IndexDataMapProvider
---
[GitHub] carbondata pull request #2552: [CARBONDATA-2781] Added fix for Null Pointer ...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2552#discussion_r206458961
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
---
@@ -181,7 +181,18 @@ case class CarbonCreateDataMapCommand(
override def undoMetadata(sparkSession: SparkSession, exception:
Exception): Seq[Row] = {
if (dataMapProvider != null) {
- dataMapProvider.cleanMeta()
+ if (dataMapSchema.getProviderName
--- End diff --
I think datamap drop is required for all types of datamap , not just
preaggregate
---
[GitHub] carbondata pull request #2552: [CARBONDATA-2781] Added fix for Null Pointer ...
GitHub user praveenmeenakshi56 opened a pull request: https://github.com/apache/carbondata/pull/2552 [CARBONDATA-2781] Added fix for Null Pointer Excpetion when create datamap killed from UI What was the issue? In undo meta, datamap was not being dropped. What is the solution? Datamap gets dropped when create command is killed from UI during undo meta. - [ ] Any interfaces changed? NA - [ ] Any backward compatibility impacted? NA - [ ] Document update required? NA - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. Tested in Local - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA You can merge this pull request into a Git repository by running: $ git pull https://github.com/praveenmeenakshi56/carbondata preagg_defct Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2552.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2552 commit 0039b4e42df96c41da0321325554a6894d4b613f Author: praveenmeenakshi56 Date: 2018-07-25T06:36:56Z Added fix for Null Pointer Excpetion when create datamap killed from UI ---
