[GitHub] carbondata pull request #2612: [CARBONDATA-2834] Remove unnecessary nested l...

2018-08-07 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2612


---

[GitHub] carbondata pull request #2612: [CARBONDATA-2834] Remove unnecessary nested l...

2018-08-07 Thread ravipesala 
Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2612#discussion_r208211297
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
 ---
@@ -779,6 +779,32 @@ public UpdateVO getInvalidTimestampRange(String 
segmentId) {
 }
 return range;
   }
+
+  /**
+   * Returns the invalid timestamp range of a segment.
+   * @return
+   */
+  public List getInvalidTimestampRange() {
+List ranges = new ArrayList();
+for (LoadMetadataDetails segment : segmentDetails) {
+  if (!(segment.getSegmentStatus().equals(SegmentStatus.SUCCESS) ||
+  
segment.getSegmentStatus().equals(SegmentStatus.LOAD_PARTIAL_SUCCESS))) {
--- End diff --

Please refer SegmentStatusManager for checking the invalid segments


---

[GitHub] carbondata pull request #2612: [CARBONDATA-2834] Remove unnecessary nested l...

2018-08-06 Thread kunal642 
GitHub user kunal642 opened a pull request:

https://github.com/apache/carbondata/pull/2612

[CARBONDATA-2834] Remove unnecessary nested looping over 
loadMetadatadetails.

removed nested for loop which causes query performance degradation if…

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/carbondata nestedloop_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2612


commit ebe22d331dc4ea4ef6904e779702801c3eb5d859
Author: kunal642 
Date:   2018-08-06T12:47:28Z

removed nested for loop which causes query performance degradation if 
number of segments are too many




---