[GitHub] carbondata pull request #2834: [CARBONDATA-3028][32k] Fix bugs in spark file...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2834


---

[GitHub] carbondata pull request #2834: [CARBONDATA-3028][32k] Fix bugs in spark file...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2834#discussion_r227195246
  
--- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java 
---
@@ -412,10 +413,13 @@ private void setCsvHeader(CarbonLoadModel model) {
   public CarbonLoadModel buildLoadModel(Schema carbonSchema)
   throws IOException, InvalidLoadOptionException {
 timestamp = System.nanoTime();
-Set longStringColumns = null;
-if (options != null && options.get("long_string_columns") != null) {
-  longStringColumns =
-  new 
HashSet<>(Arrays.asList(options.get("long_string_columns").toLowerCase().split(",")));
+Set longStringColumns = new HashSet<>();
+if (options != null && 
options.get(CarbonCommonConstants.LONG_STRING_COLUMNS) != null) {
--- End diff --

OK, will fix it


---

[GitHub] carbondata pull request #2834: [CARBONDATA-3028][32k] Fix bugs in spark file...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2834#discussion_r227194616
  
--- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java 
---
@@ -412,10 +413,13 @@ private void setCsvHeader(CarbonLoadModel model) {
   public CarbonLoadModel buildLoadModel(Schema carbonSchema)
   throws IOException, InvalidLoadOptionException {
 timestamp = System.nanoTime();
-Set longStringColumns = null;
-if (options != null && options.get("long_string_columns") != null) {
-  longStringColumns =
-  new 
HashSet<>(Arrays.asList(options.get("long_string_columns").toLowerCase().split(",")));
+Set longStringColumns = new HashSet<>();
+if (options != null && 
options.get(CarbonCommonConstants.LONG_STRING_COLUMNS) != null) {
--- End diff --

please add a comment to describe it is for long string


---

[GitHub] carbondata pull request #2834: [CARBONDATA-3028][32k] Fix bugs in spark file...

[xuchuanyin]

GitHub user xuchuanyin opened a pull request:

https://github.com/apache/carbondata/pull/2834

[CARBONDATA-3028][32k] Fix bugs in spark file format table with multiple 
longstringcolumns

If we create a spark file format table with multiple longstringcolumns
and the option long_string_columns contains blank characters, the
query on that table will fail, cause it didn't recognize the correct
varchar columns. The root cause is that carbondata didn't trim the blank
in long_string_columns while it recognizing the varchar columns.

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xuchuanyin/carbondata 
181019_bug_write_longstring_sparkfileformat

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2834


commit de9768d22a7f019e8019ba4e27d813e44795811f
Author: xuchuanyin 
Date:   2018-10-19T02:37:23Z

Fix bugs in spark file format table with blanks in longstringcolumns

If we create a spark file format table with multiple longstringcolumns
and the option long_string_columns contains blank characters, the
query on that table will fail, cause it didn't recognize the correct
varchar columns. The root cause is that carbondata didn't trim the blank
in long_string_columns while it recognizing the varchar columns.




---