[GitHub] carbondata pull request #966: [CARBONDATA-1101] Avoid widening between wrapp...
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/966 [CARBONDATA-1101] Avoid widening between wrapper classes Modification reason: Widening between wrapper classes throws ClassCastException You can merge this pull request into a Git repository by running: $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata unsafe_sort_widdening_issue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/966.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #966 commit d218cfd01574c38ef83584560c8be5af9248eadf Author: mohammadshahidkhan Date: 2017-05-29T06:10:11Z [CARBONDATA-1101] Avoid widening between wrapper classes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #966: [CARBONDATA-1101] Avoid widening between wrapp...
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/966#discussion_r119805770 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/unsafe/merger/UnsafeIntermediateFileMerger.java --- @@ -314,7 +314,7 @@ private void writeDataTofile(Object[] row) throws CarbonSortKeyAndGroupByExcepti case SHORT: case INT: case LONG: -rowData.putLong(size, (Long) value); +rowData.putLong(size, Long.valueOf(value.toString())); --- End diff -- Should be kept in the respective datatypes, it is already fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #966: [CARBONDATA-1101] Avoid widening between wrapp...
Github user mohammadshahidkhan closed the pull request at: https://github.com/apache/carbondata/pull/966 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
