[jira] [Resolved] (CARBONDATA-284) Abstracting Index and Segment interface
[ https://issues.apache.org/jira/browse/CARBONDATA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Chen resolved CARBONDATA-284. --- Resolution: Fixed > Abstracting Index and Segment interface > --- > > Key: CARBONDATA-284 > URL: https://issues.apache.org/jira/browse/CARBONDATA-284 > Project: CarbonData > Issue Type: Improvement > Components: hadoop-integration >Affects Versions: 0.1.0-incubating >Reporter: Jacky Li >Assignee: Jacky Li > Fix For: 0.3.0-incubating > > > This issue is intended to abstract developer API and user API to achieve > following goals: > Goal 1: User can choose the place to store Index data, it can be stored in > processing framework's memory space (like in spark driver memory) or in > another service outside of the processing framework (like using a > independent database service, which can be shared across client) > Goal 2: Developer can add more index of his choice to CarbonData files. > Besides B+ tree on multi-dimensional key which current CarbonData supports, > developers are free to add other indexing technology to make certain > workload faster. These new indices should be added in a pluggable way. > This Jira has been discussed in maillist: > http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Abstracting-CarbonData-s-Index-Interface-td1587.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CARBONDATA-284) Abstracting Index and Segment interface
[ https://issues.apache.org/jira/browse/CARBONDATA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liang Chen updated CARBONDATA-284: -- Assignee: Jacky Li > Abstracting Index and Segment interface > --- > > Key: CARBONDATA-284 > URL: https://issues.apache.org/jira/browse/CARBONDATA-284 > Project: CarbonData > Issue Type: Improvement > Components: hadoop-integration >Affects Versions: 0.1.0-incubating >Reporter: Jacky Li >Assignee: Jacky Li > Fix For: 0.3.0-incubating > > > This issue is intended to abstract developer API and user API to achieve > following goals: > Goal 1: User can choose the place to store Index data, it can be stored in > processing framework's memory space (like in spark driver memory) or in > another service outside of the processing framework (like using a > independent database service, which can be shared across client) > Goal 2: Developer can add more index of his choice to CarbonData files. > Besides B+ tree on multi-dimensional key which current CarbonData supports, > developers are free to add other indexing technology to make certain > workload faster. These new indices should be added in a pluggable way. > This Jira has been discussed in maillist: > http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Abstracting-CarbonData-s-Index-Interface-td1587.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-284) Abstracting Index and Segment interface
[ https://issues.apache.org/jira/browse/CARBONDATA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15638192#comment-15638192 ] ASF GitHub Bot commented on CARBONDATA-284: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/297 > Abstracting Index and Segment interface > --- > > Key: CARBONDATA-284 > URL: https://issues.apache.org/jira/browse/CARBONDATA-284 > Project: CarbonData > Issue Type: Improvement > Components: hadoop-integration >Affects Versions: 0.1.0-incubating >Reporter: Jacky Li > Fix For: 0.3.0-incubating > > > This issue is intended to abstract developer API and user API to achieve > following goals: > Goal 1: User can choose the place to store Index data, it can be stored in > processing framework's memory space (like in spark driver memory) or in > another service outside of the processing framework (like using a > independent database service, which can be shared across client) > Goal 2: Developer can add more index of his choice to CarbonData files. > Besides B+ tree on multi-dimensional key which current CarbonData supports, > developers are free to add other indexing technology to make certain > workload faster. These new indices should be added in a pluggable way. > This Jira has been discussed in maillist: > http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Abstracting-CarbonData-s-Index-Interface-td1587.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-284) Abstracting Index and Segment interface
[ https://issues.apache.org/jira/browse/CARBONDATA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637497#comment-15637497 ] ASF GitHub Bot commented on CARBONDATA-284: --- GitHub user ravipesala opened a pull request: https://github.com/apache/incubator-carbondata/pull/297 [CARBONDATA-284]Fixed compilation and checkstyle issues of PR 208 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ravipesala/incubator-carbondata pr-208-error-branch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/297.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #297 commit 988ccd8ea5084ddf1d837a3f257dd0b388ecad1a Author: ravipesala Date: 2016-11-04T19:56:26Z Fixed compilation and checkstyle issues of PR 208 > Abstracting Index and Segment interface > --- > > Key: CARBONDATA-284 > URL: https://issues.apache.org/jira/browse/CARBONDATA-284 > Project: CarbonData > Issue Type: Improvement > Components: hadoop-integration >Affects Versions: 0.1.0-incubating >Reporter: Jacky Li > Fix For: 0.3.0-incubating > > > This issue is intended to abstract developer API and user API to achieve > following goals: > Goal 1: User can choose the place to store Index data, it can be stored in > processing framework's memory space (like in spark driver memory) or in > another service outside of the processing framework (like using a > independent database service, which can be shared across client) > Goal 2: Developer can add more index of his choice to CarbonData files. > Besides B+ tree on multi-dimensional key which current CarbonData supports, > developers are free to add other indexing technology to make certain > workload faster. These new indices should be added in a pluggable way. > This Jira has been discussed in maillist: > http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Abstracting-CarbonData-s-Index-Interface-td1587.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-284) Abstracting Index and Segment interface
[ https://issues.apache.org/jira/browse/CARBONDATA-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637276#comment-15637276 ] ASF GitHub Bot commented on CARBONDATA-284: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/208 > Abstracting Index and Segment interface > --- > > Key: CARBONDATA-284 > URL: https://issues.apache.org/jira/browse/CARBONDATA-284 > Project: CarbonData > Issue Type: Improvement > Components: hadoop-integration >Affects Versions: 0.1.0-incubating >Reporter: Jacky Li > Fix For: 0.3.0-incubating > > > This issue is intended to abstract developer API and user API to achieve > following goals: > Goal 1: User can choose the place to store Index data, it can be stored in > processing framework's memory space (like in spark driver memory) or in > another service outside of the processing framework (like using a > independent database service, which can be shared across client) > Goal 2: Developer can add more index of his choice to CarbonData files. > Besides B+ tree on multi-dimensional key which current CarbonData supports, > developers are free to add other indexing technology to make certain > workload faster. These new indices should be added in a pluggable way. > This Jira has been discussed in maillist: > http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Abstracting-CarbonData-s-Index-Interface-td1587.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-382) Like Filter Query Optimization for Dictionary Columns
[ https://issues.apache.org/jira/browse/CARBONDATA-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637174#comment-15637174 ] ASF GitHub Bot commented on CARBONDATA-382: --- GitHub user sujith71955 opened a pull request: https://github.com/apache/incubator-carbondata/pull/296 [CARBONDATA-382]Like Filter Query Optimization for Dictionary Columns **Like Filter Query Optimization for Dictionary Columns** a) Added pushdown mechanism for the Like filters like startsWith,endsWith and contains so that the respective filters will be processed in Carbon layer itself. b) This mechanism can provide significant gain in the performance of Like filter queries applied in the dictionary since block and blocklet level pruning will be done in the carbon layer before applying the filters in dictionary columns. c) Since three new expressions has been added in carbon layer the carbon will be applying the expression only once for startsWith/endsWith/contains filter query, this will make the dictionary lookup also once for applying the Like expression. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sujith71955/incubator-carbondata master_filterstartswith Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/296.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #296 commit 608906a25afc2bbabecfdd3c7bfa1351e83de9a0 Author: sujith71955 Date: 2016-11-04T17:36:18Z [CARBONDATA-382]Like Filter Query Optimization for Dictionary Columns > Like Filter Query Optimization for Dictionary Columns > - > > Key: CARBONDATA-382 > URL: https://issues.apache.org/jira/browse/CARBONDATA-382 > Project: CarbonData > Issue Type: Improvement >Reporter: Sujith >Assignee: Sujith > > Like Filter Query Optimization for Dictionary Columns > a) Added pushdown mechanism for the Like filters like startsWith,endsWith and > contains so that the respective filters will be processed in Carbon layer > itself. > b) This mechanism can provide significant gain in the performance of Like > filter queries applied in the dictionary since block and blocklet level > pruning will be done in the carbon layer before applying the filter. > c) Since three new expressions has been added in carbon layer the carbon will > be applying the expression only once for startsWith/endsWith/contains filter > query, this will make the dictionary lookup also once for applying the > expression. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-361) SMALL INT data showing unsupported datatype
[ https://issues.apache.org/jira/browse/CARBONDATA-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637087#comment-15637087 ] cen yuhai commented on CARBONDATA-361: -- I think we should support smallint, short is really not a type of SQL, it is a type of Java. > SMALL INT data showing unsupported datatype > --- > > Key: CARBONDATA-361 > URL: https://issues.apache.org/jira/browse/CARBONDATA-361 > Project: CarbonData > Issue Type: Bug >Reporter: Prabhat Kashyap > > When I tried executing the following query with SMALLINT datatype > create table testTable2(id SMALLINT, name String) stored by 'carbondata' ; > It is giving me following exception. > Error: org.apache.carbondata.spark.exception.MalformedCarbonCommandException: > Unsupported data type : FieldSchema(name:id, type:smallint, > comment:null).getType (state=,code=0) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CARBONDATA-382) Like Filter Query Optimization for Dictionary Columns
Sujith created CARBONDATA-382: - Summary: Like Filter Query Optimization for Dictionary Columns Key: CARBONDATA-382 URL: https://issues.apache.org/jira/browse/CARBONDATA-382 Project: CarbonData Issue Type: Improvement Reporter: Sujith Assignee: Sujith Like Filter Query Optimization for Dictionary Columns a) Added pushdown mechanism for the Like filters like startsWith,endsWith and contains so that the respective filters will be processed in Carbon layer itself. b) This mechanism can provide significant gain in the performance of Like filter queries applied in the dictionary since block and blocklet level pruning will be done in the carbon layer before applying the filter. c) Since three new expressions has been added in carbon layer the carbon will be applying the expression only once for startsWith/endsWith/contains filter query, this will make the dictionary lookup also once for applying the expression. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings
[ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636207#comment-15636207 ] ASF GitHub Bot commented on CARBONDATA-328: --- Github user PKOfficial closed the pull request at: https://github.com/apache/incubator-carbondata/pull/248 > Improve Code and Fix Warnings > - > > Key: CARBONDATA-328 > URL: https://issues.apache.org/jira/browse/CARBONDATA-328 > Project: CarbonData > Issue Type: Improvement >Reporter: Prabhat Kashyap >Priority: Trivial > > Remove compiler warning and improve the existing code according to the > standards. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CARBONDATA-375) Dictionary cache not getting cleared after task completion in dictionary decoder
[ https://issues.apache.org/jira/browse/CARBONDATA-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkata Ramana G updated CARBONDATA-375: Affects Version/s: 0.1.0-incubating > Dictionary cache not getting cleared after task completion in dictionary > decoder > > > Key: CARBONDATA-375 > URL: https://issues.apache.org/jira/browse/CARBONDATA-375 > Project: CarbonData > Issue Type: Bug >Affects Versions: 0.1.1-incubating >Reporter: Manish Gupta >Assignee: Manish Gupta >Priority: Minor > Fix For: 0.3.0-incubating > > > Currently LRU cache eviction policy is based on dictionary access count. For > cache to remove a entry its access count must be 0. In dictionary decoder > after conversion of surrogate key to actual value the access count for > dictionary columns in query is not getting decremented due to which it will > never be cleared from memory when LRU cache size is configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CARBONDATA-375) Dictionary cache not getting cleared after task completion in dictionary decoder
[ https://issues.apache.org/jira/browse/CARBONDATA-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkata Ramana G updated CARBONDATA-375: Affects Version/s: (was: 0.1.0-incubating) 0.1.1-incubating > Dictionary cache not getting cleared after task completion in dictionary > decoder > > > Key: CARBONDATA-375 > URL: https://issues.apache.org/jira/browse/CARBONDATA-375 > Project: CarbonData > Issue Type: Bug >Affects Versions: 0.1.1-incubating >Reporter: Manish Gupta >Assignee: Manish Gupta >Priority: Minor > Fix For: 0.3.0-incubating > > > Currently LRU cache eviction policy is based on dictionary access count. For > cache to remove a entry its access count must be 0. In dictionary decoder > after conversion of surrogate key to actual value the access count for > dictionary columns in query is not getting decremented due to which it will > never be cleared from memory when LRU cache size is configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CARBONDATA-375) Dictionary cache not getting cleared after task completion in dictionary decoder
[ https://issues.apache.org/jira/browse/CARBONDATA-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkata Ramana G resolved CARBONDATA-375. - Resolution: Fixed Fix Version/s: (was: 0.2.0-incubating) 0.3.0-incubating > Dictionary cache not getting cleared after task completion in dictionary > decoder > > > Key: CARBONDATA-375 > URL: https://issues.apache.org/jira/browse/CARBONDATA-375 > Project: CarbonData > Issue Type: Bug >Reporter: Manish Gupta >Assignee: Manish Gupta >Priority: Minor > Fix For: 0.3.0-incubating > > > Currently LRU cache eviction policy is based on dictionary access count. For > cache to remove a entry its access count must be 0. In dictionary decoder > after conversion of surrogate key to actual value the access count for > dictionary columns in query is not getting decremented due to which it will > never be cleared from memory when LRU cache size is configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-375) Dictionary cache not getting cleared after task completion in dictionary decoder
[ https://issues.apache.org/jira/browse/CARBONDATA-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636189#comment-15636189 ] ASF GitHub Bot commented on CARBONDATA-375: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/292 > Dictionary cache not getting cleared after task completion in dictionary > decoder > > > Key: CARBONDATA-375 > URL: https://issues.apache.org/jira/browse/CARBONDATA-375 > Project: CarbonData > Issue Type: Bug >Reporter: Manish Gupta >Assignee: Manish Gupta >Priority: Minor > Fix For: 0.2.0-incubating > > > Currently LRU cache eviction policy is based on dictionary access count. For > cache to remove a entry its access count must be 0. In dictionary decoder > after conversion of surrogate key to actual value the access count for > dictionary columns in query is not getting decremented due to which it will > never be cleared from memory when LRU cache size is configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-283) Improve the test cases for concurrent scenarios
[ https://issues.apache.org/jira/browse/CARBONDATA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635994#comment-15635994 ] ASF GitHub Bot commented on CARBONDATA-283: --- Github user ManoharVanam commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/207#discussion_r86523287 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonTableStatusUtil.java --- @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.carbondata.processing.util; + +import java.text.SimpleDateFormat; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Date; +import java.util.List; + +import org.apache.carbondata.common.logging.LogService; +import org.apache.carbondata.common.logging.LogServiceFactory; +import org.apache.carbondata.core.constants.CarbonCommonConstants; +import org.apache.carbondata.core.load.LoadMetadataDetails; + +/** + * This class contains all table status file utilities + */ +public final class CarbonTableStatusUtil { + private static final LogService LOGGER = + LogServiceFactory.getLogService(CarbonTableStatusUtil.class.getName()); + + private CarbonTableStatusUtil() { + + } + + /** + * updates table status details using latest metadata + * + * @param oldMetadata + * @param newMetadata + * @return + */ + + public static List updateLatestTableStatusDetails( --- End diff -- ok > Improve the test cases for concurrent scenarios > --- > > Key: CARBONDATA-283 > URL: https://issues.apache.org/jira/browse/CARBONDATA-283 > Project: CarbonData > Issue Type: Bug >Reporter: Manohar Vanam >Assignee: Manohar Vanam >Priority: Minor > > Improve test cases for data retention concurrent scenarios -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-283) Improve the test cases for concurrent scenarios
[ https://issues.apache.org/jira/browse/CARBONDATA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635992#comment-15635992 ] ASF GitHub Bot commented on CARBONDATA-283: --- Github user ManoharVanam commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/207#discussion_r86523222 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonTableStatusUtil.java --- @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.carbondata.processing.util; + +import java.text.SimpleDateFormat; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Date; +import java.util.List; + +import org.apache.carbondata.common.logging.LogService; +import org.apache.carbondata.common.logging.LogServiceFactory; +import org.apache.carbondata.core.constants.CarbonCommonConstants; +import org.apache.carbondata.core.load.LoadMetadataDetails; + +/** + * This class contains all table status file utilities + */ +public final class CarbonTableStatusUtil { + private static final LogService LOGGER = + LogServiceFactory.getLogService(CarbonTableStatusUtil.class.getName()); + + private CarbonTableStatusUtil() { + + } + + /** + * updates table status details using latest metadata + * + * @param oldMetadata + * @param newMetadata + * @return + */ + + public static List updateLatestTableStatusDetails( + LoadMetadataDetails[] oldMetadata, LoadMetadataDetails[] newMetadata) { + +List newListMetadata = +new ArrayList(Arrays.asList(newMetadata)); +for (LoadMetadataDetails oldSegment : oldMetadata) { + if (CarbonCommonConstants.MARKED_FOR_DELETE.equalsIgnoreCase(oldSegment.getLoadStatus())) { + updateSegmentMetadataDetails(newListMetadata.get(newListMetadata.indexOf(oldSegment))); + } +} +return newListMetadata; + } + + /** + * returns current time + * + * @return + */ + private static String readCurrentTime() { +SimpleDateFormat sdf = new SimpleDateFormat(CarbonCommonConstants.CARBON_TIMESTAMP); +String date = null; + +date = sdf.format(new Date()); + +return date; + } + + /** + * updates segment status and modificaton time details + * + * @param loadMetadata + */ + public static void updateSegmentMetadataDetails(LoadMetadataDetails loadMetadata) { --- End diff -- ok > Improve the test cases for concurrent scenarios > --- > > Key: CARBONDATA-283 > URL: https://issues.apache.org/jira/browse/CARBONDATA-283 > Project: CarbonData > Issue Type: Bug >Reporter: Manohar Vanam >Assignee: Manohar Vanam >Priority: Minor > > Improve test cases for data retention concurrent scenarios -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CARBONDATA-381) Unnecessary catalog metadata refresh and array index of bound exception in drop table
[ https://issues.apache.org/jira/browse/CARBONDATA-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkata Ramana G resolved CARBONDATA-381. - Resolution: Fixed Fix Version/s: (was: 0.2.0-incubating) 0.3.0-incubating > Unnecessary catalog metadata refresh and array index of bound exception in > drop table > - > > Key: CARBONDATA-381 > URL: https://issues.apache.org/jira/browse/CARBONDATA-381 > Project: CarbonData > Issue Type: Bug >Reporter: Manish Gupta >Assignee: Manish Gupta >Priority: Minor > Fix For: 0.3.0-incubating > > > Problem: > 1. Whenever a catalog metadata is refreshed it modified the timestamp of > modifiedTime.mdt file which leads to unnecessary refreshing the complete > catalog metadata. > 2. Array Index of bound exception is thrown on failure of table creation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-381) Unnecessary catalog metadata refresh and array index of bound exception in drop table
[ https://issues.apache.org/jira/browse/CARBONDATA-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635803#comment-15635803 ] ASF GitHub Bot commented on CARBONDATA-381: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/294 > Unnecessary catalog metadata refresh and array index of bound exception in > drop table > - > > Key: CARBONDATA-381 > URL: https://issues.apache.org/jira/browse/CARBONDATA-381 > Project: CarbonData > Issue Type: Bug >Reporter: Manish Gupta >Assignee: Manish Gupta >Priority: Minor > Fix For: 0.2.0-incubating > > > Problem: > 1. Whenever a catalog metadata is refreshed it modified the timestamp of > modifiedTime.mdt file which leads to unnecessary refreshing the complete > catalog metadata. > 2. Array Index of bound exception is thrown on failure of table creation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-381) Unnecessary catalog metadata refresh and array index of bound exception in drop table
[ https://issues.apache.org/jira/browse/CARBONDATA-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635746#comment-15635746 ] ASF GitHub Bot commented on CARBONDATA-381: --- GitHub user manishgupta88 opened a pull request: https://github.com/apache/incubator-carbondata/pull/294 [CARBONDATA-381] Unnecessary catalog metadata refresh and array index of bound exception in drop table Problem: 1. Whenever a catalog metadata is refreshed it modified the timestamp of modifiedTime.mdt file which leads to unnecessary refreshing the complete catalog metadata. 2. Array Index of bound exception is thrown on failure of table creation. Analysis: 1. Whenever carbon environment gets initialized it loads the table metadata in the catalog and changes the timestamp of modifiedTime.mdt file. If a parallel beeline session is in progress then it will cause unnecessary refreshing of the catalog metadata. 2. For the very first time if table creation fails then in the exception block it tries to drop that table and clear its metadata. In drop table filter API is used which throws array index out of bound exception if metadata array is empty. Fix: 1. No need to update the timestamp of modifiedTime.mdt file while loading metadata. It should only be refreshed on create and drop table operations. 2. Instead of filter API use find API which will return an Option object. Impact: carbon catalog refresh which will impact query and load flow. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manishgupta88/incubator-carbondata table_meta_refresh_issue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/294.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #294 commit 04d62b54a52b563eab41c2f76c02802bd67aedd9 Author: manishgupta88 Date: 2016-11-04T08:36:52Z Problem: 1. Whenever a catalog metadata is refreshed it modified the timestamp of modifiedTime.mdt file which leads to unnecessary refreshing the complete catalog metadata. 2. Array Index of bound exception is thrown on failure of table creation. Analysis: 1. Whenever carbon environment gets initialized it loads the table metadata in the catalog and changes the timestamp of modifiedTime.mdt file. If a parallel beeline session is in progress then it will cause unnecessary refreshing of the catalog metadata. 2. For the very first time if table creation fails then in the exception block it tries to drop that table and clear its metadata. In drop table filter API is used which throws array index out of bound exception if metadata array is empty. Fix: 1. No need to update the timestamp of modifiedTime.mdt file while loading metadata. It should only be refreshed on create and drop table operations. 2. Instead of filter API use find API which will return an Option object. Impact: carbon catalog refresh which will impact query and load flow. > Unnecessary catalog metadata refresh and array index of bound exception in > drop table > - > > Key: CARBONDATA-381 > URL: https://issues.apache.org/jira/browse/CARBONDATA-381 > Project: CarbonData > Issue Type: Bug >Reporter: Manish Gupta >Assignee: Manish Gupta >Priority: Minor > Fix For: 0.2.0-incubating > > > Problem: > 1. Whenever a catalog metadata is refreshed it modified the timestamp of > modifiedTime.mdt file which leads to unnecessary refreshing the complete > catalog metadata. > 2. Array Index of bound exception is thrown on failure of table creation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CARBONDATA-381) Unnecessary catalog metadata refresh and array index of bound exception in drop table
Manish Gupta created CARBONDATA-381: --- Summary: Unnecessary catalog metadata refresh and array index of bound exception in drop table Key: CARBONDATA-381 URL: https://issues.apache.org/jira/browse/CARBONDATA-381 Project: CarbonData Issue Type: Bug Reporter: Manish Gupta Assignee: Manish Gupta Priority: Minor Fix For: 0.2.0-incubating Problem: 1. Whenever a catalog metadata is refreshed it modified the timestamp of modifiedTime.mdt file which leads to unnecessary refreshing the complete catalog metadata. 2. Array Index of bound exception is thrown on failure of table creation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (CARBONDATA-380) Invalid output of Count function without arguments
[ https://issues.apache.org/jira/browse/CARBONDATA-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhat Kashyap closed CARBONDATA-380. -- Resolution: Duplicate > Invalid output of Count function without arguments > -- > > Key: CARBONDATA-380 > URL: https://issues.apache.org/jira/browse/CARBONDATA-380 > Project: CarbonData > Issue Type: Bug >Reporter: Prabhat Kashyap >Priority: Minor > > Whenever I m trying to run the following query: > select count() from emp5; > It is giving invalid output (0) instead of error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (CARBONDATA-354) Query execute successfully even not argument given in count function
[ https://issues.apache.org/jira/browse/CARBONDATA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhat Kashyap closed CARBONDATA-354. -- Resolution: Duplicate > Query execute successfully even not argument given in count function > > > Key: CARBONDATA-354 > URL: https://issues.apache.org/jira/browse/CARBONDATA-354 > Project: CarbonData > Issue Type: Bug >Reporter: Prabhat Kashyap >Priority: Minor > > When I am executing following command: > select count() from tableName; > It gave me no error and execute successfully but it gives following exception > when I execute the same in Hive: > FAILED: UDFArgumentException Argument expected -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CARBONDATA-380) Invalid output of Count function without arguments
Prabhat Kashyap created CARBONDATA-380: -- Summary: Invalid output of Count function without arguments Key: CARBONDATA-380 URL: https://issues.apache.org/jira/browse/CARBONDATA-380 Project: CarbonData Issue Type: Bug Reporter: Prabhat Kashyap Priority: Minor Whenever I m trying to run the following query: select count() from emp5; It is giving invalid output (0) instead of error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CARBONDATA-379) Test Cases to be added for Scan package under org.apache.carbondata.core
DEEPAK MEHRA created CARBONDATA-379: --- Summary: Test Cases to be added for Scan package under org.apache.carbondata.core Key: CARBONDATA-379 URL: https://issues.apache.org/jira/browse/CARBONDATA-379 Project: CarbonData Issue Type: Improvement Reporter: DEEPAK MEHRA Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CARBONDATA-378) Long datatype is not working
SWATI RAO created CARBONDATA-378: Summary: Long datatype is not working Key: CARBONDATA-378 URL: https://issues.apache.org/jira/browse/CARBONDATA-378 Project: CarbonData Issue Type: Bug Reporter: SWATI RAO As it is mentioned in DataType.java file that long is supported datatype but when I run query using long datatype its displays an error. e.g: create table testTable(id long, name String) stored by 'carbondata' ; Error: org.apache.spark.sql.AnalysisException: cannot recognize input near 'long' ',' 'name' in column type; line 1 pos 29 (state=,code=0) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-374) Short data type is not working.
[ https://issues.apache.org/jira/browse/CARBONDATA-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635547#comment-15635547 ] ASF GitHub Bot commented on CARBONDATA-374: --- Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/293#discussion_r86498453 --- Diff: integration/spark/src/test/scala/org/apache/spark/sql/TestCreateTable.scala --- @@ -0,0 +1,30 @@ +/* --- End diff -- And also please include data load and sql query to retrieve data > Short data type is not working. > --- > > Key: CARBONDATA-374 > URL: https://issues.apache.org/jira/browse/CARBONDATA-374 > Project: CarbonData > Issue Type: Bug >Reporter: SWATI RAO >Assignee: cen yuhai > > Short datatype is not working as you have mentioned it is supported datatype > in the below link: > http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/List-the-supported-datatypes-in-carbondata-td2419.html > e.g: > create table testTable(id Short, name String) stored by 'carbondata' ; > Error: org.apache.spark.sql.AnalysisException: cannot recognize input near > 'Short' ',' 'name' in column type; line 1 pos 26 (state=,code=0) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CARBONDATA-377) Improve code coverage for Core.Cache.Dictionary
[ https://issues.apache.org/jira/browse/CARBONDATA-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhat Kashyap updated CARBONDATA-377: --- Priority: Trivial (was: Major) > Improve code coverage for Core.Cache.Dictionary > --- > > Key: CARBONDATA-377 > URL: https://issues.apache.org/jira/browse/CARBONDATA-377 > Project: CarbonData > Issue Type: Sub-task >Reporter: Prabhat Kashyap >Priority: Trivial > > Write Unit Test Cases for following files: > DictionaryColumnUniqueIdentifier > ForwardDictionary > ReverseDictionary -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CARBONDATA-357) Write unit test for ValueCompressionUtil
[ https://issues.apache.org/jira/browse/CARBONDATA-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhat Kashyap updated CARBONDATA-357: --- Priority: Trivial (was: Major) > Write unit test for ValueCompressionUtil > > > Key: CARBONDATA-357 > URL: https://issues.apache.org/jira/browse/CARBONDATA-357 > Project: CarbonData > Issue Type: Sub-task >Reporter: Prabhat Kashyap >Priority: Trivial > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CARBONDATA-377) Improve code coverage for Core.Cache.Dictionary
Prabhat Kashyap created CARBONDATA-377: -- Summary: Improve code coverage for Core.Cache.Dictionary Key: CARBONDATA-377 URL: https://issues.apache.org/jira/browse/CARBONDATA-377 Project: CarbonData Issue Type: Sub-task Reporter: Prabhat Kashyap Write Unit Test Cases for following files: DictionaryColumnUniqueIdentifier ForwardDictionary ReverseDictionary -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CARBONDATA-376) Value beyond the integer range should not be allowed for storage in integer datatype
SWATI RAO created CARBONDATA-376: Summary: Value beyond the integer range should not be allowed for storage in integer datatype Key: CARBONDATA-376 URL: https://issues.apache.org/jira/browse/CARBONDATA-376 Project: CarbonData Issue Type: Bug Reporter: SWATI RAO Integer datatype is supporting range beyond bigInt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)