[jira] [Commented] (CARBONDATA-763) Add L5 loading support, global sorting like HBase
[ https://issues.apache.org/jira/browse/CARBONDATA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906934#comment-15906934 ] Liang Chen commented on CARBONDATA-763: --- Can you provide more information about "L5 loading support" ? > Add L5 loading support, global sorting like HBase > - > > Key: CARBONDATA-763 > URL: https://issues.apache.org/jira/browse/CARBONDATA-763 > Project: CarbonData > Issue Type: New Feature >Reporter: QiangCai > > Add L5 loading support, global sorting like HBase -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (CARBONDATA-763) Add L5 loading support, global sorting like HBase
[ https://issues.apache.org/jira/browse/CARBONDATA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] QiangCai updated CARBONDATA-763: Issue Type: New Feature (was: Bug) > Add L5 loading support, global sorting like HBase > - > > Key: CARBONDATA-763 > URL: https://issues.apache.org/jira/browse/CARBONDATA-763 > Project: CarbonData > Issue Type: New Feature >Reporter: QiangCai > > Add L5 loading support, global sorting like HBase -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CARBONDATA-765) dataframe wirter need to first drop table unless loading said table not found
QiangCai created CARBONDATA-765: --- Summary: dataframe wirter need to first drop table unless loading said table not found Key: CARBONDATA-765 URL: https://issues.apache.org/jira/browse/CARBONDATA-765 Project: CarbonData Issue Type: Bug Reporter: QiangCai Assignee: QiangCai dataframe wirter need to first drop table unless loading said table not found -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CARBONDATA-764) Improving Non-dictionary storage & performance
QiangCai created CARBONDATA-764: --- Summary: Improving Non-dictionary storage & performance Key: CARBONDATA-764 URL: https://issues.apache.org/jira/browse/CARBONDATA-764 Project: CarbonData Issue Type: Improvement Reporter: QiangCai mail list: http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/Improving-Non-dictionary-storage-amp-performance-td8146.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CARBONDATA-763) Add L5 loading support, global sorting like HBase
QiangCai created CARBONDATA-763: --- Summary: Add L5 loading support, global sorting like HBase Key: CARBONDATA-763 URL: https://issues.apache.org/jira/browse/CARBONDATA-763 Project: CarbonData Issue Type: Bug Reporter: QiangCai Add L5 loading support, global sorting like HBase -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CARBONDATA-762) modify all schemaName->databaseName, cubeName->tableName
QiangCai created CARBONDATA-762: --- Summary: modify all schemaName->databaseName, cubeName->tableName Key: CARBONDATA-762 URL: https://issues.apache.org/jira/browse/CARBONDATA-762 Project: CarbonData Issue Type: Bug Reporter: QiangCai Assignee: QiangCai Priority: Minor modify all schemaName->databaseName, cubeName->tableName -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CARBONDATA-761) Dictionary server should not be shutdown after loading
QiangCai created CARBONDATA-761: --- Summary: Dictionary server should not be shutdown after loading Key: CARBONDATA-761 URL: https://issues.apache.org/jira/browse/CARBONDATA-761 Project: CarbonData Issue Type: Bug Components: data-load Reporter: QiangCai Assignee: QiangCai Priority: Minor Code: CarbonTableSchema/LoadTable -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (CARBONDATA-760) Should to avoid ERROR log for successful select query
QiangCai created CARBONDATA-760: --- Summary: Should to avoid ERROR log for successful select query Key: CARBONDATA-760 URL: https://issues.apache.org/jira/browse/CARBONDATA-760 Project: CarbonData Issue Type: Bug Components: data-query Reporter: QiangCai Assignee: QiangCai Priority: Minor Some table without delete or update operator maybe not have delta files. Select query shouldn't record error log. Code: SegmentUpdateStatusManager.getDeltaFiles Log detail: ERROR 06-03 19:21:37,531 - pool-475-thread-1 Invalid tuple id arbonstore/default/comparetest_carbon/Fact/0/0/0-0-0-1488799238178/0 ERROR 06-03 19:21:37,948 - pool-475-thread-1 Invalid tuple id arbonstore/default/comparetest_carbon/Fact/0/0/0-0-0-1488799238178/1 ERROR 06-03 19:21:38,517 - pool-475-thread-1 Invalid tuple id arbonstore/default/comparetest_carbon/Fact/0/0/0-0-0-1488799238178/2 ERROR 06-03 19:21:38,909 - pool-475-thread-1 Invalid tuple id arbonstore/default/comparetest_carbon/Fact/0/0/0-0-0-1488799238178/3 ERROR 06-03 19:21:39,292 - pool-475-thread-1 Invalid tuple id arbonstore/default/comparetest_carbon/Fact/0/0/0-0-0-1488799238178/4 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-carbondata issue #641: [WIP] Alter table support for carbondata
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/641 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1105/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #622: [CARBONDATA-744] The property "spark.carbon...
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/622 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1104/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #622: [CARBONDATA-744] The property "spark...
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/622#discussion_r105594037
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -116,8 +116,8 @@ class CarbonScanRDD(
i += 1
result.add(partition)
}
- } else if
(sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
-
sparkContext.getConf.getBoolean("spark.carbon.custom.distribution", false)) {
+ } else if (java.lang.Boolean
+
.parseBoolean(CarbonProperties.getInstance().getProperty("carbon.custom.distribution")))
{
--- End diff --
@kumarvishal09 agree will rename to carbon.custom.block.distribution
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #622: [CARBONDATA-744] The property "spark...
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/622#discussion_r105593981
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -116,8 +116,8 @@ class CarbonScanRDD(
i += 1
result.add(partition)
}
- } else if
(sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
-
sparkContext.getConf.getBoolean("spark.carbon.custom.distribution", false)) {
+ } else if (java.lang.Boolean
+
.parseBoolean(CarbonProperties.getInstance().getProperty("carbon.block.distribution")))
{
--- End diff --
fixed review comments
changed property to carbon.custom.block.distribution
added into CarbonCommonConstants
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Updated] (CARBONDATA-744) he property "spark.carbon.custom.distribution" should be change to carbon.custom.block.distribution and should be part of CarbonProperties
[ https://issues.apache.org/jira/browse/CARBONDATA-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Shahid Khan updated CARBONDATA-744: Summary: he property "spark.carbon.custom.distribution" should be change to carbon.custom.block.distribution and should be part of CarbonProperties (was: The property "spark.carbon.custom.distribution" should be part of CarbonProperties) > he property "spark.carbon.custom.distribution" should be change to > carbon.custom.block.distribution and should be part of CarbonProperties > -- > > Key: CARBONDATA-744 > URL: https://issues.apache.org/jira/browse/CARBONDATA-744 > Project: CarbonData > Issue Type: Improvement >Reporter: Mohammad Shahid Khan >Assignee: Mohammad Shahid Khan >Priority: Trivial > Time Spent: 1h 20m > Remaining Estimate: 0h > > The property "spark.carbon.custom.distribution" should be part of > CarbonProperties > As naming style adopted in carbon we should name the key > carbon.custom.distribution -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-carbondata pull request #648: [CARBONDATA-758]remove kettle relate...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/648 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #641: [WIP] Alter table support for carbondata
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/641 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1102/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #630: [CARBONDATA-730]added decimal type i...
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105590522
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/CaseClassDataFrameAPIExample.scala
---
@@ -42,8 +45,25 @@ object CaseClassDataFrameAPIExample {
.mode(SaveMode.Overwrite)
.save()
+val employee = List(Employee("anubhav", 2))
--- End diff --
No I think it's alright I changed my code as u suggested and when I tested
it ,it is working correctly, I am adding the test cases and will be pushing it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #630: [CARBONDATA-730]added decimal type i...
Github user sanoj-mg commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105590219
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/CaseClassDataFrameAPIExample.scala
---
@@ -42,8 +45,25 @@ object CaseClassDataFrameAPIExample {
.mode(SaveMode.Overwrite)
.save()
+val employee = List(Employee("anubhav", 2))
--- End diff --
@anubhav100 @jackylk I am new to carbondata, but any reason for not adding
the precision as below?
case dt: DecimalType => s"${CarbonType.DECIMAL.getName}(${dt.precision},
${dt.scale})
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #624: [CARBONDATA-747] Add simple performance tes...
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/624 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1101/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #639: [CARBONDATA-752] solved bug for complex typ...
Github user jackylk commented on the issue: https://github.com/apache/incubator-carbondata/pull/639 Please add a testcase to verify it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #630: [CARBONDATA-730]added decimal type i...
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105582287
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/CaseClassDataFrameAPIExample.scala
---
@@ -42,8 +45,25 @@ object CaseClassDataFrameAPIExample {
.mode(SaveMode.Overwrite)
.save()
+val employee = List(Employee("anubhav", 2))
--- End diff --
I change the code as suggested in code snippet,earlier I am not giving
precision and scale factor,ya sure I am adding test cases
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #632: [CARBONDATA-732] Exclude netty dependencies...
Github user jackylk commented on the issue: https://github.com/apache/incubator-carbondata/pull/632 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #630: [CARBONDATA-730]added decimal type i...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105579644
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/CaseClassDataFrameAPIExample.scala
---
@@ -42,8 +45,25 @@ object CaseClassDataFrameAPIExample {
.mode(SaveMode.Overwrite)
.save()
+val employee = List(Employee("anubhav", 2))
--- End diff --
And can you add a testcase for both spark1 and spark2 integration?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #630: [CARBONDATA-730]added decimal type i...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/630#discussion_r105579596
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/CaseClassDataFrameAPIExample.scala
---
@@ -42,8 +45,25 @@ object CaseClassDataFrameAPIExample {
.mode(SaveMode.Overwrite)
.save()
+val employee = List(Employee("anubhav", 2))
--- End diff --
I tried with `val employee = List(Employee("anubhav",
BigDecimal(324234353, 4)))`
the output is:
```
+---+--+
| name|salary|
+---+--+
|anubhav| 32423|
+---+--+
```
It is not handling correctly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #642: [CARBONDATA-756] Fixed RLE Encoding ...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/642#discussion_r105578013
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -192,12 +192,23 @@ private void
compressDataMyOwnWay(ColumnWithShortIndex[] indexes) {
}
map.add(start);
map.add(counter);
-this.keyBlock = convertToKeyArray(list);
-if (indexes.length == keyBlock.length) {
- dataIndexMap = new short[0];
-} else {
+boolean useRle = (((list.size() + map.size()) * 100) / indexes.length)
> 70 ? false : true;
--- End diff --
Can we decide this in a more heuristic way? Like if we find there are more
than 5 pages not doing RLE, then do not pay the cost to try to compress it in
all future blocklets.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #642: [CARBONDATA-756] Fixed RLE Encoding ...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/642#discussion_r105577915
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -192,12 +192,23 @@ private void
compressDataMyOwnWay(ColumnWithShortIndex[] indexes) {
}
map.add(start);
map.add(counter);
-this.keyBlock = convertToKeyArray(list);
--- End diff --
This is a comment for `compressMyOwnWay` function, suggest to use
`indexes.length / 2` as the initial size to allocate the ArrayList, instead of
10, which is too small and will cause repeated arraylist expansion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #642: [CARBONDATA-756] Fixed RLE Encoding ...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/642#discussion_r105576295
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -192,12 +192,23 @@ private void
compressDataMyOwnWay(ColumnWithShortIndex[] indexes) {
}
map.add(start);
map.add(counter);
-this.keyBlock = convertToKeyArray(list);
-if (indexes.length == keyBlock.length) {
- dataIndexMap = new short[0];
-} else {
+boolean useRle = (((list.size() + map.size()) * 100) / indexes.length)
> 70 ? false : true;
+if (useRle) {
+ this.keyBlock = convertToKeyArray(list);
dataIndexMap = convertToArray(map);
+} else {
+ this.keyBlock = convertToKeyArray(indexes);
+ dataIndexMap = new short[0];
--- End diff --
So we are judging based on whether it is empty array when reading?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #642: [CARBONDATA-756] Fixed RLE Encoding ...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/642#discussion_r105575706
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -192,12 +192,23 @@ private void
compressDataMyOwnWay(ColumnWithShortIndex[] indexes) {
}
map.add(start);
map.add(counter);
-this.keyBlock = convertToKeyArray(list);
-if (indexes.length == keyBlock.length) {
- dataIndexMap = new short[0];
-} else {
+boolean useRle = (((list.size() + map.size()) * 100) / indexes.length)
> 70 ? false : true;
--- End diff --
suggest to use:
`(((list.size() + map.size()) * 100) / indexes.length) < 70`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #650: [WIP] add intergation with presto
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/650#discussion_r105558847 --- Diff: integration/presto/pom.xml --- @@ -0,0 +1,167 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + + +com.facebook.presto --- End diff -- please change groupId to org.apache.carbondata. you can take integration/spark module as reference, and update accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [WIP] add intergation with presto
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1100/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [WIP] add intergation with presto
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (CARBONDATA-759) How to check a table's properties?
sehriff created CARBONDATA-759: -- Summary: How to check a table's properties? Key: CARBONDATA-759 URL: https://issues.apache.org/jira/browse/CARBONDATA-759 Project: CarbonData Issue Type: Improvement Reporter: sehriff Priority: Minor Is there a way to check what colums of a table is treated as dimensions or measures? How to check default table properties(COLUMN_GROUPS,DICTIONARY_EXCLUDE,DICTIONARY_INCLUDE,NO_INVERTED_INDEX) and what of this tables's mdk looks like? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-carbondata pull request #649: [CARBONDATA-748] put 'if' clause out...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #649: [CARBONDATA-748] put 'if' clause out of the...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/649 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [CARBONDATA-](WIP) add inte...
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #650: [CARBONDATA-](WIP) a...
GitHub user ffpeng90 opened a pull request: https://github.com/apache/incubator-carbondata/pull/650 [CARBONDATA-](WIP) add intergation with presto Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[CARBONDATA-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - What manual testing you have done? - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/ffpeng90/incubator-carbondata add_presto Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/650.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #650 commit 82168f48a07b1757160147551332bb456df2e65a Author: ffpeng90 Date: 2017-03-12T12:27:32Z add presto integration 0.0.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #649: [CARBONDATA-748] put 'if' clause out of the...
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/649 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1099/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #649: [CARBONDATA-748] put 'if' clause out of the...
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/649 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1098/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #649: [CARBONDATA-748] put 'if' clause out of the...
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/649 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1097/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
