[GitHub] incubator-carbondata pull request #816: [CARBONDATA-944] Fixed unwanted exce...
GitHub user bhavya411 opened a pull request: https://github.com/apache/incubator-carbondata/pull/816 [CARBONDATA-944] Fixed unwanted exception in case of Drop table through spark-sql-CLI This PR includes a fix for Table Already Exists exception in case of Drop Table command. Build verification with spark-1.6 successful Build with spark-2.1 successful Verified The defect Manually --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-944 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/816.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #816 commit 7c4ca35681ece52d674120d668c876349caa9131 Author: Bhavya Date: 2017-04-19T07:20:54Z Fixed unwanted exception in case of Drop table through spark-sql-CLI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #779: [CARBONDATA-899] Added Support for DecimalT...
Github user bhavya411 commented on the issue: https://github.com/apache/incubator-carbondata/pull/779 I have fixed the spacing issues as well as indentations , please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #779: [CARBONDATA-899] Added Support for D...
GitHub user bhavya411 opened a pull request: https://github.com/apache/incubator-carbondata/pull/779 [CARBONDATA-899] Added Support for DecimalType and Timestamp for spark-2.1 Added Support for DecimalType and Timestamp with Spark-2.1 Local Build is running fine. Manually Tested the functionality on Presto CLI You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-899 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/779.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #779 commit 2a1df96f100445b26287cb37549740cb45761990 Author: Bhavya Date: 2017-04-04T08:49:49Z Fixed Carbondata-848 commit ef9269b962b1f2332c25bc95a3af3d0aadc6b19e Author: Bhavya Date: 2017-04-04T10:41:20Z remove Presto module ' commit 30017786f948b0f88a385e54029dee00a85f5648 Author: Bhavya Date: 2017-04-11T09:46:39Z Added support for DecimalType and Fixed Date and time issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #728: [CARBONDATA-848] Fixed error Presto ...
Github user bhavya411 closed the pull request at: https://github.com/apache/incubator-carbondata/pull/728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #728: [CARBONDATA-848] Fixed error Presto Connect...
Github user bhavya411 commented on the issue: https://github.com/apache/incubator-carbondata/pull/728 Closing it manually --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #728: [CARBONDATA-848] Fixed error Presto Connect...
Github user bhavya411 commented on the issue: https://github.com/apache/incubator-carbondata/pull/728 @chenliang613 Removed presto module from pom.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #728: [CARBONDATA-848] Fixed error Presto ...
GitHub user bhavya411 opened a pull request: https://github.com/apache/incubator-carbondata/pull/728 [CARBONDATA-848] Fixed error Presto Connector gives an error for select count(*) from table Verified the build for both Spark 2.1 and 1.6 All Tests pass on both Spark 2.1 and 1.6 Manually Tested it on Presto You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-848 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/728.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #728 commit 602a8a6e95874d390a20a91ea72e15d42a1ed4e2 Author: Bhavya Date: 2017-04-04T08:49:49Z Fixed Carbondata-848 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #712: [CARBONDATA-835] Fixed NullPointerEx...
GitHub user bhavya411 opened a pull request: https://github.com/apache/incubator-carbondata/pull/712 [CARBONDATA-835] Fixed NullPointerException for Presto Fixed NullPointerException for Null values in carbon table when quering from Presto. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-835 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/712.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #712 commit 9abf5e4a293fcb5b990f73ecf78cbe4e0f272765 Author: Bhavya Date: 2017-03-30T07:52:55Z Fixed NullPointerException for Null values in carbon table when querying from Presto --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #711: [CARBONDATA-834] Fixed Describe Tabl...
GitHub user bhavya411 opened a pull request: https://github.com/apache/incubator-carbondata/pull/711 [CARBONDATA-834] Fixed Describe Table for Presto You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-834 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/711.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #711 commit abffb4a4d5e38db39d5194efaf0e259339477398 Author: Bhavya Date: 2017-03-30T07:40:22Z Fixed Issue related to Describe table query in Presto --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #697: [CARBONDATA-708] Fixed Between and Logical ...
Github user bhavya411 commented on the issue: https://github.com/apache/incubator-carbondata/pull/697 Fixed the coding styles issues as well as the spacing issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Github user bhavya411 commented on the issue: https://github.com/apache/incubator-carbondata/pull/616 @ravipesala Created a New PR #697 for the fixes that were suggested , added a Unit test class to make sure it runs everytime with the build and removed the example --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #697: [CARBONDATA-708] Fixed Between and L...
GitHub user bhavya411 opened a pull request: https://github.com/apache/incubator-carbondata/pull/697 [CARBONDATA-708] Fixed Between and Logical AND issue - Change CarbonFilters.scala to fix BETWEEN and Logical AND operator - Add Unit Test Cases - Tested on Spark 1.6 and 2.1 - Manual testing done to verify the fix - Build Success with 1.6 and 2.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-708 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/697.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #697 commit b53f711af9324d765cbe9ee3c45ca58fca8b6a85 Author: Bhavya Date: 2017-03-24T11:16:39Z Fixed issue 708 and added testcases for the same --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #616: [CARBONDATA-708] Fixed Between Filte...
Github user bhavya411 closed the pull request at: https://github.com/apache/incubator-carbondata/pull/616 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Github user bhavya411 commented on the issue: https://github.com/apache/incubator-carbondata/pull/616 I have rebased the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #616: [CARBONDATA-708] Fixed Between Filte...
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/616#discussion_r105888634
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala
---
@@ -110,8 +110,16 @@ object CarbonFilters {
}
def getCarbonLiteralExpression(name: String, value: Any):
CarbonExpression = {
- new CarbonLiteralExpression(value,
-CarbonScalaUtil.convertSparkToCarbonDataType(dataTypeOf(name)))
+ val dataTypeOfAttribute =
CarbonScalaUtil.convertSparkToCarbonDataType(dataTypeOf(name))
+ val dataType = if (Option(value).isDefined
+&& dataTypeOfAttribute == DataType.STRING
+&& value.isInstanceOf[Double]) {
--- End diff --
In the scenarios where we have stored the numbers as String (and have
included it as a Dimension) and if we are trying to do operations like >= or <=
or between it is not working correctly
and it gives some random results as it is comparing a String with a Double.
So for those cases this fix will work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #616: [CARBONDATA-708] Fixed Between Filte...
GitHub user bhavya411 opened a pull request: https://github.com/apache/incubator-carbondata/pull/616 [CARBONDATA-708] Fixed Between Filter Issue for Pushed Filters in case it was applied ⦠Fixed Between Filter Issue for Pushed Filters in case it was applied on Dimension Test Add Examples of Between Filter Removed Scalastyle Manually Test BETWEEN Filter Run Unit Test Cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-708 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/616.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #616 commit 1f537953419e7201bb314492656bf58a9a335546 Author: Bhavya Date: 2017-02-28T12:19:21Z Fixed Between Filter Issue for Pushed Filters in case it was applied on Dimension --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
