[GitHub] incubator-carbondata pull request #342: added unit test for FilterScanner

2016-11-22 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/342

added unit test for FilterScanner

Added unit test for FilterScanner

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-438

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/342.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #342


commit 755143aaef1572b18e6b60385f032cc67a35f40e
Author: kunal642 
Date:   2016-11-22T11:09:01Z

added unit test for FilterScanner




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #346: [Carbondata-377] Add unit test for c...

2016-11-23 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/346

[Carbondata-377] Add unit test for core.cache.dictionary package

Added unit test for DictionaryColumnUniqueIdentifier
Added unit test for ReverseDictionary
Added unit test for ForwardDictionary


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-377

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #346


commit 0dbdbcfe982fc9d4519f48c499ae569f6932c9e9
Author: kunal642 
Date:   2016-11-03T09:18:31Z

Added unit test for DictionaryColumnUniqueIdentifierTest

commit 504ac89e7f41d3598e5d92031244aeea8657dad8
Author: kunal642 
Date:   2016-11-03T09:18:54Z

Added unit test for ReverseDictionaryTest

commit 250623946484501c7f463e83bc59baa745800a7d
Author: kunal642 
Date:   2016-11-03T09:19:19Z

Added unit test for ForwardDictionaryTest




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #349: [CARBONDATA-446] Added unit test for...

2016-11-24 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/349

[CARBONDATA-446] Added unit test for scan.collector.impl package

Added unit test for DictionaryBasedResultCollector
Added unit test for RawBasedResultCollector

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata collector.impl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #349


commit 48c6bceb6a41722c62b6d5bb43c9c34d8bb48f17
Author: kunal642 
Date:   2016-11-23T11:02:43Z

Added unit test for DictionaryBasedResultCollector

commit 2974b058c45406613a7efe6ae71e599e14e8ad43
Author: kunal642 
Date:   2016-11-24T08:09:57Z

added unit test for RawBasedResultCollector




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #371: [CARBONDATA-472] Added unit test for...

2016-11-29 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/371

[CARBONDATA-472] Added unit test for cache package

Added unit test for CarbonLRUCacheTest 
Added unit test for ColumnDictionaryChunkIteratorTest
Added unit test for ColumnReverseDictionaryInfoTest 
Added unit test for DictionaryCacheLoaderImplTest 
Updated unit tests for DictionaryChunksWrapperTest 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata cache_unit_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #371


commit 26d18a9954d5a3f2d3525a7a01d7270abaca808e
Author: kunal642 
Date:   2016-11-29T12:50:51Z

Added unit test for cache package




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #381: [CARBONDATA-485] Refactored code for...

2016-12-02 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/381

[CARBONDATA-485] Refactored code for DataGraphExecuter

Removed unused parameters
Added constants


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata code_refactor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #381


commit 4ae9e9f3220e9dc65d2c53698992e7d419d03213
Author: kunal642 
Date:   2016-12-02T11:22:06Z

Refactored code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #381: [CARBONDATA-485] Refactored code for...

2017-03-13 Thread kunal642
Github user kunal642 closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/381


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #656: [CARBONDATA-773] Fixed multiple Dict...

2017-03-15 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/656

[CARBONDATA-773] Fixed multiple DictionaryServer instances issue

Fixed the issue where multiple dictionary server instances were being 
created for parallel load.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata dictionary_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/656.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #656


commit 3a29c2f995f35df7d166e992891ad6b2f27a7823
Author: kunal642 
Date:   2017-03-15T09:08:31Z

fixed multiple dictionary server issue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #656: [CARBONDATA-773] Fixed multiple DictionaryS...

2017-03-15 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/656
  
@ravipesala changes made. Please review 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #678: [CARBONDATA-798] Added support to rename ba...

2017-03-21 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/678
  
@gvramana Changes have been done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #695: Fixed Null Pointer Exception for dou...

2017-03-23 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/695

Fixed Null Pointer Exception for double data type without fraction

Fixed null pointer exception for double data type
Removed unused methods

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-696

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #695


commit aa2f82b841d41ff16e057361da170eae0da74ff3
Author: kunal642 
Date:   2017-03-24T05:14:32Z

Fixed NPE for double data type without fraction




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #695: [CARBONDATA-696] Fixed Null Pointer Excepti...

2017-03-23 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/695
  
@kumarvishal09 review this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #717: [CARBONDATA-839] Fixed issue with me...

2017-03-31 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/717

[CARBONDATA-839] Fixed issue with meta lock not getting deleted for rename 
table

The following things are fixed in this patch:

1. Meta lock location has been changed from "tmp" to table store location.
2. The meta lock file was not being delete when the lock was released in 
case of table rename because the  path stored in the lock would not be updated 
along with the table rename. To fix this, a new method to manually delete the 
lock file has been added in AbstractCarbonLock.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-839

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/717.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #717


commit cab6093bae164f73480c187fdeb88a7749458633
Author: kunal642 
Date:   2017-03-31T10:33:17Z

fixed issue with meta lock not getting deleted for rename table




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #724: [CARBONDATA-847] Fixed NullPointerEx...

2017-04-03 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/724

[CARBONDATA-847] Fixed NullPointerException for 
DictionaryBasedVectorResultCollector during alter table



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-847

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #724


commit 6936e023fdab79a4d6ebd43f1457844261ac30fc
Author: kunal642 
Date:   2017-04-03T17:24:18Z

fixed null pointer exception for DictionaryBasedVectorResultCollector 
during alter table




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #727: [CARBONDATA-846] Added support to re...

2017-04-04 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/727

[CARBONDATA-846] Added support to revert changes if query fails



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata revert_support

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/727.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #727


commit 0621e9b3dfbab254a1b1a8b216d9f786df37d805
Author: kunal642 
Date:   2017-03-15T09:08:31Z

added support to revert changes if query fails




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #717: [CARBONDATA-839] Fixed issue with me...

2017-04-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/717#discussion_r109859846
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
@@ -70,7 +71,8 @@
   LogServiceFactory.getLogService(LocalFileLock.class.getName());
 
   static {
-tmpPath = System.getProperty("java.io.tmpdir");
+tmpPath = 
CarbonProperties.getInstance().getProperty(CarbonCommonConstants.STORE_LOCATION,
+System.getProperty("java.io.tmpdir"));
--- End diff --

An object of HDFSFileLock would be created if the store location is for 
HDFS.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #724: [CARBONDATA-847] Fixed NullPointerEx...

2017-04-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/724#discussion_r109861944
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java
 ---
@@ -51,8 +51,8 @@
 
   public DictionaryBasedVectorResultCollector(BlockExecutionInfo 
blockExecutionInfos) {
 super(blockExecutionInfos);
-queryDimensions = tableBlockExecutionInfos.getQueryDimensions();
-queryMeasures = tableBlockExecutionInfos.getQueryMeasures();
+queryDimensions = tableBlockExecutionInfos.getActualQueryDimensions();
--- End diff --

getQueryDimensions or getQueryMeasures does not contain the newly added 
columns so when we try to get the vector from allColumnInfo which has the size 
[measures + dimensions] we would get a ArrayIndexOutOfBoundException because it 
will not have the space for the new column. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #717: [CARBONDATA-839] Fixed issue with me...

2017-04-05 Thread kunal642
Github user kunal642 commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/717#discussion_r109868326
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
@@ -70,7 +71,8 @@
   LogServiceFactory.getLogService(LocalFileLock.class.getName());
 
   static {
-tmpPath = System.getProperty("java.io.tmpdir");
+tmpPath = 
CarbonProperties.getInstance().getProperty(CarbonCommonConstants.STORE_LOCATION,
+System.getProperty("java.io.tmpdir"));
--- End diff --

For a HDFS store location, HdfsFileLock would be called instead of 
LocalFileLock


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #717: [CARBONDATA-839] Fixed issue with meta lock...

2017-04-05 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/717
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #717: [CARBONDATA-839] Fixed issue with me...

2017-04-05 Thread kunal642
GitHub user kunal642 reopened a pull request:

https://github.com/apache/incubator-carbondata/pull/717

[CARBONDATA-839] Fixed issue with meta lock not getting deleted for rename 
table

The following things are fixed in this patch:

1. Meta lock location has been changed from "tmp" to table store location.
2. The meta lock file was not being delete when the lock was released in 
case of table rename because the  path stored in the lock would not be updated 
along with the table rename. To fix this, a new method to manually delete the 
lock file has been added in AbstractCarbonLock.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-839

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/717.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #717


commit aeadf703237c6325eeb79acb89390d7629c14870
Author: kunal642 
Date:   2017-03-31T10:33:17Z

fixed issue with meta lock not getting deleted for rename table




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #717: [CARBONDATA-839] Fixed issue with me...

2017-04-05 Thread kunal642
Github user kunal642 closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/717


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #717: [CARBONDATA-839] Fixed issue with meta lock...

2017-04-05 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/717
  
@ravipesala Added comments. Please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #727: [CARBONDATA-846] Added support to revert ch...

2017-04-06 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/727
  
@manishgupta88 ok



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #753: [CARBONDATA-877] Fixed ArrayIndexOut...

2017-04-06 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/753

[CARBONDATA-877] Fixed ArrayIndexOutOfBoundException for 
ColumnarVectorWrapper

Row id was being incremented with the column number and eventually the 
index on which we had to put the data would be greater than the array size.





You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-877

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/753.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #753


commit 7e2e0f3dea340a82611c07fc4acd2d79d7f2c8a7
Author: kunal642 
Date:   2017-04-06T13:05:57Z

fixed ArrayIndexOutOfBoundException for ColumnarVectorWrapper




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #771: [CARBONDATA-883] Fixed cast exceptio...

2017-04-09 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/771

[CARBONDATA-883] Fixed cast exception for integer data types in 
RestructureBasedVectorResultCollector

The following issues are fixed in this PR:-
1. In RestructureUtil, int and short datatypes were being parsed as long 
and then being cast to long which was throwing cast exception.

2. Added an entry for SHORT in carbonKeywords because we were allowing the 
user to create a table with short datatype but alter table was failing due to 
missing SHORT keyword.
Now short and smallInt are both acceptable and both will be converted to 
smallint.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-883

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #771


commit 9db005af3022b2221eb8af1077f14a62075a76c3
Author: kunal642 
Date:   2017-04-07T13:26:16Z

fixed cast exception for integer data types in 
RestructureBasedVectorResultCollector

commit 0be853c83a2ce81256a0c54c5fc9d27db6e8c9da
Author: kunal642 
Date:   2017-04-09T08:45:24Z

added parser for short dataype




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #771: [CARBONDATA-883] Fixed cast exception for i...

2017-04-10 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/771
  
@gvramana please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #777: [CARBONDATA-863] Moved AlterTableAdd...

2017-04-11 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/777

[CARBONDATA-863] Moved AlterTableAddColumnRDD call to AlterTableCommands



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-863

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #777


commit d83cec14d02bf3ef828fc978c5a255f2c34ef40a
Author: kunal642 
Date:   2017-04-11T08:45:10Z

added AlterTableAddColumnRDD to AlterTableCommands




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #777: [CARBONDATA-863] Moved AlterTableAddColumnR...

2017-04-11 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/777
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #780: [CARBONDATA-892] Fixed NullPointerEx...

2017-04-11 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/780

[CARBONDATA-892] Fixed NullPointerException for 2nd level subquery



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-892

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #780


commit 59099037b5bca578f562ad3287d9fc789ea3d917
Author: kunal642 
Date:   2017-04-11T11:13:39Z

fixed NullPointerException for 2nd level subquery




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #777: [CARBONDATA-863] Moved AlterTableAddColumnR...

2017-04-13 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/777
  
retest this please



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #777: [CARBONDATA-863] Moved AlterTableAdd...

2017-04-13 Thread kunal642
GitHub user kunal642 reopened a pull request:

https://github.com/apache/incubator-carbondata/pull/777

[CARBONDATA-863] Moved AlterTableAddColumnRDD call to AlterTableCommands

Moved call to AlterTableAddColumnRDD to AlterTableCommands
Refactored code
Added test case

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-863

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #777


commit 7fb101242824175ffce610a1705894ca16c8ba45
Author: kunal642 
Date:   2017-04-11T08:45:10Z

added AlterTableAddColumnRDD to AlterTableCommands




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #777: [CARBONDATA-863] Moved AlterTableAdd...

2017-04-13 Thread kunal642
Github user kunal642 closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/777


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #777: [CARBONDATA-863] Separated column schema ge...

2017-04-14 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/777
  
@gvramana please review this



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #802: [CARBONDATA-926] Changed max columns...

2017-04-15 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/802

[CARBONDATA-926] Changed max columns from static value to configurable 
value in Load DDL

Changes done:-

1. Earlier the value for max columns that can be read by the csv parser was 
hard coded.
Now the value would be read from the query options and if no option is 
provided then the default value of 0 would be taken.

2. Added query id in compaction flow for driver statistics.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-926

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/802.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #802


commit cf854888f2914bec2239b594deb9edefd72c123e
Author: kunal642 
Date:   2017-04-15T08:18:17Z

changed max columns from static value to configurable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #802: [CARBONDATA-926] Changed max columns from s...

2017-04-15 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/incubator-carbondata/pull/802
  
retest this please



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #814: [WIP] Fixed table not found exceptio...

2017-04-18 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/814

[WIP] Fixed table not found exception in rename table after lock acquire 
fa…



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/incubator-carbondata rename_table_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/814.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #814


commit f3b48b5f7df9343906feb782c3d93e5fc76751af
Author: kunal642 
Date:   2017-04-18T11:11:30Z

fixed table not found exception in rename table after lock acquire failure




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---