[GitHub] incubator-carbondata issue #365: [CARBONDATA-463] Extract code to spark-comm...

2016-11-29 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/incubator-carbondata/pull/365
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #365: [CARBONDATA-463] Extract code to spark-comm...

2016-11-29 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/incubator-carbondata/pull/365
  
LGTM except few comments.
It seems there is an issue in pom files while using maven default build and 
using format. I will fix them in new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #365: [CARBONDATA-463] Extract code to spark-comm...

2016-11-28 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/incubator-carbondata/pull/365
  
CI passed
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/696/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #365: [CARBONDATA-463] Extract code to spark-comm...

2016-11-28 Thread scwf
Github user scwf commented on the issue:

https://github.com/apache/incubator-carbondata/pull/365
  
i think we should merge this into our spark2 branch, otherwise it will 
leads to large conflicts


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata issue #365: [CARBONDATA-463] Extract code to spark-comm...

2016-11-28 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/incubator-carbondata/pull/365
  
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/689/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---