[GitHub] incubator-carbondata issue #391: [CARBONDATA-374] support smallint
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/391 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #391: [CARBONDATA-374] support smallint
Github user cenyuhai commented on the issue: https://github.com/apache/incubator-carbondata/pull/391 @ravipesala @chenliang613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #391: [CARBONDATA-374] support smallint
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/391 é误信æ¯å¦ä¸ï¼ **Regression** org.apache.carbondata.core.util.DataTypeUtilTest.testGetDataType Failing for the past 1 build (Since Unstable#748 ) è¿è¡æ¶é´ï¼3 æ¯«ç§ Error Message expected: but was: Stacktrace junit.framework.AssertionFailedError: expected: but was: at junit.framework.Assert.fail(Assert.java:57) at junit.framework.Assert.failNotEquals(Assert.java:329) at junit.framework.Assert.assertEquals(Assert.java:78) at junit.framework.Assert.assertEquals(Assert.java:86) at junit.framework.TestCase.assertEquals(TestCase.java:253) at org.apache.carbondata.core.util.DataTypeUtilTest.testGetDataType(DataTypeUtilTest.java:82) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #391: [CARBONDATA-374] support smallint
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/391 @cenyuhai There is one testcase failing, please fix it. http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/748/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #391: [CARBONDATA-374] support smallint
Github user cenyuhai commented on the issue: https://github.com/apache/incubator-carbondata/pull/391 @jackylk @lion-x pls review the codes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
