[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Reuse the same SegmentProp...

[watermen]

Github user watermen commented on the issue:

https://github.com/apache/incubator-carbondata/pull/659
  
@jackylk If I want to reuse `SegmentProperties` and only check the 
parameters `columnsInTable` and `columnCardinality`, which case I will 
missing(wrong case)? Because compare `SegmentProperties` objects are easier 
than `CarbonDimension` and `CarbonMeasure` objects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Reuse the same SegmentProp...

[jackylk]

Github user jackylk commented on the issue:

https://github.com/apache/incubator-carbondata/pull/659
  
I checked recently merged PR641 for restructuring, it seems that this is 
still used for maintaining metadata for each Segment, so it can’t be changed 
to TableProperties.
One suggestion I have is to abstract and re-use some of the big object 
inside SegmentProperties, like the CarbonDimension and CarbonMeasure objects. 
They should be cached and get by ID, then it can be re-used across Segments.


发件人: Yadong Qi [mailto:notificati...@github.com]
发送时间: 2017年3月17日 10:00
收件人: apache/incubator-carbondata
抄送: Likun (Jacky); Mention
主题: Re: [apache/incubator-carbondata] [CARBONDATA-781] Reuse the same 
SegmentProperties objects to reduce the memory (#659)


@jackylk You mean now we can store properties 
in table level(Maybe called TableProperties) insteads of SegmentProperties?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Reuse the same SegmentProp...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/incubator-carbondata/pull/659
  
Build Success with Spark 1.6.2, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1201/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Reuse the same SegmentProp...

[watermen]

Github user watermen commented on the issue:

https://github.com/apache/incubator-carbondata/pull/659
  
@jackylk You mean now we can store properties in table level(Maybe called 
TableProperties) insteads of SegmentProperties?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Reuse the same SegmentProp...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/incubator-carbondata/pull/659
  
Build Failed  with Spark 1.6.2, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1200/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Reuse the same SegmentProp...

[jackylk]

Github user jackylk commented on the issue:

https://github.com/apache/incubator-carbondata/pull/659
  
Earlier, this was used for handling restructure information. Now it is 
handled in another way, so yes we should change it to reduce the number of 
objects 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Reuse the same SegmentProp...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/incubator-carbondata/pull/659
  
Build Failed  with Spark 1.6.2, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1186/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Reuse the same SegmentProp...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/incubator-carbondata/pull/659
  
Build Failed  with Spark 1.6.2, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1176/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Reuse the same SegmentProp...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/incubator-carbondata/pull/659
  
Build Failed  with Spark 1.6.2, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1168/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---