[GitHub] incubator-carbondata pull request #386: [CARBONDATA-489] Fix spark2 decimal ...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #386: [CARBONDATA-489] Fix spark2 decimal ...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/386#discussion_r90751746
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/CarbonDataSourceSuite.scala
---
@@ -30,14 +30,15 @@ class CarbonDataSourceSuite extends FunSuite with
BeforeAndAfterAll {
.appName("CarbonExample")
.enableHiveSupport()
.config(CarbonCommonConstants.STORE_LOCATION,
-s"examples/spark2/target/store")
+s"/user/hive/warehouse/store")
--- End diff --
Is it ok to hard code this? how about in non-linux?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #386: [CARBONDATA-489] Fix spark2 decimal ...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/386#discussion_r90751754
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -125,6 +125,16 @@ class CarbonMetastore(conf: RuntimeConfig, val
storePath: String) extends Loggin
tableCreationTime
}
+ def cleanStore(): Unit = {
+try {
+ val fileType = FileFactory.getFileType(storePath)
+ FileFactory.deleteFile(storePath, fileType)
+} catch {
+ case e => logError("clean store failed", e)
+}
+
--- End diff --
remove empty line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #386: [CARBONDATA-489] Fix spark2 decimal ...
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/386#discussion_r90751737 --- Diff: pom.xml --- @@ -309,9 +309,6 @@ spark-1.5 - --- End diff -- do not modify this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
