[GitHub] incubator-carbondata pull request #386: Fix spark2 decimal issue

2016-12-02 Thread scwf 
Github user scwf commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/386#discussion_r90750992
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastorage/store/impl/FileFactory.java
 ---
@@ -397,6 +397,38 @@ public static boolean createNewFile(String filePath, 
FileType fileType) throws I
 }
   }
 
+  public static boolean deleteFile(String filePath, FileType fileType) 
throws IOException {
--- End diff --

added for carbon metasore to clean store path


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #386: Fix spark2 decimal issue

2016-12-02 Thread scwf 
GitHub user scwf opened a pull request:

https://github.com/apache/incubator-carbondata/pull/386

Fix spark2 decimal issue

also added a test suite for decimal

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/KirinKing/incubator-carbondata fix-decimal

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #386


commit 4da98d3c54021d8744809df0e779fac2dbc34a5a
Author: wangfei 
Date:   2016-12-03T04:44:07Z

fix spark2 decimal

commit f351c8d6e586019d13a087dddaddb759127ab948
Author: wangfei 
Date:   2016-12-03T04:52:30Z

code clean




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---