[GitHub] incubator-carbondata pull request #481: [CARBONDATA-601]reuse test case for ...

2017-01-07 Thread QiangCai
Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/481#discussion_r95060705
  
--- Diff: 
integration/spark/src/main/scala/org/apache/spark/sql/test/TestQueryExecutorImplV1.scala
 ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.test
+
+import org.apache.spark.{SparkConf, SparkContext}
+import org.apache.spark.sql.{CarbonContext, DataFrame, SQLContext}
+
+import org.apache.carbondata.common.logging.LogServiceFactory
+import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.util.CarbonProperties
+
+class TestQueryExecutorImplV1 extends TestQueryExecutorRegister {
--- End diff --

fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #481: [CARBONDATA-601]reuse test case for ...

2017-01-07 Thread QiangCai
Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/481#discussion_r95060180
  
--- Diff: integration/spark-common-test/pom.xml ---
@@ -0,0 +1,232 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+  4.0.0
+
+  
+org.apache.carbondata
+carbondata-parent
+1.0.0-incubating-SNAPSHOT
+../../pom.xml
+  
+
+  carbondata-spark-common-test
+  Apache CarbonData :: Spark Common Test
+
+  
+${basedir}/../../dev
+  
+
+  
+
+  org.apache.carbondata
+  carbondata-spark-common
+  ${project.version}
+  test
+  
+
+  org.apache.spark
+  spark-hive-thriftserver_2.10
+
+  
+
+
+  org.apache.spark
+  
spark-hive-thriftserver_${scala.binary.version}
+  test
+
+
+  junit
+  junit
+
+
+  org.scalatest
+  scalatest_${scala.binary.version}
+  2.2.1
+  test
+
+  
+
+  
+src/test/scala
+
+  
+src/resources
+  
+  
+.
+
+  CARBON_SPARK_INTERFACELogResource.properties
+
+  
+
+
+  
+org.scala-tools
+maven-scala-plugin
+2.15.2
+
+  
+compile
+
+  compile
+
+compile
+  
+  
+testCompile
+
+  testCompile
+
+test
+  
+  
+process-resources
+
+  compile
+
+  
+
+  
+  
+maven-compiler-plugin
+
+  1.7
+  1.7
+
+  
+  
+org.apache.maven.plugins
+maven-surefire-plugin
+2.18
+
+
+  
+**/Test*.java
+**/*Test.java
+**/*TestCase.java
+**/*Suite.java
+  
+  
${project.build.directory}/surefire-reports
+  -Xmx3g -XX:MaxPermSize=512m 
-XX:ReservedCodeCacheSize=512m
+  
+true
+  
+  false
+
+  
+  
+org.scalatest
+scalatest-maven-plugin
+1.0
+
+
+  
${project.build.directory}/surefire-reports
+  .
+  CarbonTestSuite.txt
+  -ea -Xmx3g -XX:MaxPermSize=512m 
-XX:ReservedCodeCacheSize=512m 
+  
+  
+  
+  
+  
+true
+${use.kettle}
+  
+
+
+  
+test
+
+  test
+
+  
+
+  
+
+  
+  
+
+  spark-1.5
+  
+true
+  
+  
+
+  org.apache.carbondata
+  carbondata-spark
+  ${project.version}
+  test
+  
+
+  org.apache.spark
+  spark-hive-thriftserver_2.10
--- End diff --

This exclusion will be fixed dependency issue of Intellij Idea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-carbondata pull request #481: [CARBONDATA-601]reuse test case for ...

2017-01-07 Thread jackylk
Github user jackylk commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/481#discussion_r95059839
  
--- Diff: integration/spark-common-test/pom.xml ---
@@ -0,0 +1,232 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+  4.0.0
+
+  
+org.apache.carbondata
+carbondata-parent
+1.0.0-incubating-SNAPSHOT
+../../pom.xml
+  
+
+  carbondata-spark-common-test
+  Apache CarbonData :: Spark Common Test
+
+  
+${basedir}/../../dev
+  
+
+  
+
+  org.apache.carbondata
+  carbondata-spark-common
+  ${project.version}
+  test
+  
+
+  org.apache.spark
+  spark-hive-thriftserver_2.10
+
+  
+
+
+  org.apache.spark
+  
spark-hive-thriftserver_${scala.binary.version}
+  test
+
+
+  junit
+  junit
+
+
+  org.scalatest
+  scalatest_${scala.binary.version}
+  2.2.1
+  test
+
+  
+
+  
+src/test/scala
+
+  
+src/resources
+  
+  
+.
+
+  CARBON_SPARK_INTERFACELogResource.properties
+
+  
+
+
+  
+org.scala-tools
+maven-scala-plugin
+2.15.2
+
+  
+compile
+
+  compile
+
+compile
+  
+  
+testCompile
+
+  testCompile
+
+test
+  
+  
+process-resources
+
+  compile
+
+  
+
+  
+  
+maven-compiler-plugin
+
+  1.7
+  1.7
+
+  
+  
+org.apache.maven.plugins
+maven-surefire-plugin
+2.18
+
+
+  
+**/Test*.java
+**/*Test.java
+**/*TestCase.java
+**/*Suite.java
+  
+  
${project.build.directory}/surefire-reports
+  -Xmx3g -XX:MaxPermSize=512m 
-XX:ReservedCodeCacheSize=512m
+  
+true
+  
+  false
+
+  
+  
+org.scalatest
+scalatest-maven-plugin
+1.0
+
+
+  
${project.build.directory}/surefire-reports
+  .
+  CarbonTestSuite.txt
+  -ea -Xmx3g -XX:MaxPermSize=512m 
-XX:ReservedCodeCacheSize=512m 
+  
+  
+  
+  
+  
+true
+${use.kettle}
+  
+
+
+  
+test
+
+  test
+
+  
+
+  
+
+  
+  
+
+  spark-1.5
+  
+true
+  
+  
+
+  org.apache.carbondata
+  carbondata-spark
+  ${project.version}
+  test
+  
+
+  org.apache.spark
+  spark-hive-thriftserver_2.10
--- End diff --

use scala.version instead of 2.10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---