[GitHub] incubator-carbondata pull request #633: [CARBONDATA-739] Avoid creating mult...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-carbondata/pull/633


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #633: [CARBONDATA-739] Avoid creating mult...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/633#discussion_r105079650
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
 ---
@@ -103,6 +101,12 @@ public 
DictionaryBasedResultCollector(BlockExecutionInfo blockExecutionInfos) {
 int[] surrogateResult;
 String[] noDictionaryKeys;
 byte[][] complexTypeKeyArray;
+
+ArrayList directDictionaryGenerators = new 
ArrayList<>(dimSize);
--- End diff --

It would be good to use array instead of arraylist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #633: [CARBONDATA-739] Avoid creating mult...

[lionelcao]

Github user lionelcao commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/633#discussion_r105068561
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
 ---
@@ -37,6 +34,8 @@
 import org.apache.carbondata.core.util.DataTypeUtil;
 
 import org.apache.commons.lang3.ArrayUtils;
+
+
--- End diff --

Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #633: [CARBONDATA-739] Avoid creating mult...

[jackylk]

Github user jackylk commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/633#discussion_r104916295
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
 ---
@@ -37,6 +34,8 @@
 import org.apache.carbondata.core.util.DataTypeUtil;
 
 import org.apache.commons.lang3.ArrayUtils;
+
+
--- End diff --

remove one empty line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #633: [CARBONDATA-739] Avoid creating mult...

[lionelcao]

GitHub user lionelcao opened a pull request:

https://github.com/apache/incubator-carbondata/pull/633

[CARBONDATA-739] Avoid creating multipul instance of 
directDictionaryGenerator

Avoid creating multipul instance of directDictionaryGenerator

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lionelcao/incubator-carbondata carbon739

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #633


commit 7437c64d0bfdd20928302eb93c204ef31f54e542
Author: lucao 
Date:   2017-03-08T09:20:58Z

[CARBONDATA-739] Avoid creating multipul instance of 
directDictionaryGenerator




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---