[GitHub] incubator-carbondata pull request #642: [CARBONDATA-756]Fixed RLE Encoding I...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:


https://github.com/apache/incubator-carbondata/pull/642#discussion_r105408221
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
 ---
@@ -192,12 +192,24 @@ private void 
compressDataMyOwnWay(ColumnWithShortIndex[] indexes) {
 }
 map.add(start);
 map.add(counter);
-this.keyBlock = convertToKeyArray(list);
-if (indexes.length == keyBlock.length) {
-  dataIndexMap = new short[0];
-} else {
+boolean useRle = (list.size() > indexes.length
--- End diff --

I guess you can simply as below.
```
boolean useRle = !list.size() + map.size()) * 100) / indexes.length) > 
70);
```
I think need of `list.size() > indexes.length` is not required as the 
percentage calculation can include this as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #642: [CARBONDATA-756]Fixed RLE Encoding I...

[kumarvishal09]

GitHub user kumarvishal09 opened a pull request:

https://github.com/apache/incubator-carbondata/pull/642

[CARBONDATA-756]Fixed RLE Encoding Issue



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kumarvishal09/incubator-carbondata 
FixedRLEEncodingIssue

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/642.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #642


commit c899d729a79062bcdc14e932d79e2913c92d9ea4
Author: kumarvishal 
Date:   2017-03-10T11:13:24Z

Fixed RLE Encoding Issue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---