[jira] [Assigned] (CLOUDSTACK-9002) VM deployment is successful even when dhcp entry command fails
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kshitij Kansal reassigned CLOUDSTACK-9002: -- Assignee: Kshitij Kansal > VM deployment is successful even when dhcp entry command fails > -- > > Key: CLOUDSTACK-9002 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9002 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Kshitij Kansal >Assignee: Kshitij Kansal > > Repro Steps: > 1. Create a VM in advanced network. > 2. Once its successful, on the router add iptables rule to drop the packets > "iptables -I INPUT 1 -j DROP" > 3. Then deploy another vm using same network. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8991) IP address is not removed from VR even after disabling static NAT
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977825#comment-14977825 ] ASF GitHub Bot commented on CLOUDSTACK-8991: Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/989#issuecomment-151735882 Test results: * Hardware required: true * Management Server + MySQL on CentOS 7.1 * One KVM host on CentOS 7.1 * ACS Agent + Common RPMs built from source ``` Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS === ok Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS === ok Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS === ok Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS === ok Create a redundant VPC with two networks with two VMs in each network and check default routes ... === TestName: test_02_redundant_VPC_default_routes | Status : SUCCESS === ok Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: test_02_routervm_iptables_policies | Status : SUCCESS === ok Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS === ok Create a VPC with two networks with one VM in each network and test nics after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS === ok Create a VPC with two networks with one VM in each network and test default routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS === ok Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS === ok Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS === ok Stop existing router, add a PF rule and check we can access the VM ... === TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS === ok Test redundant router internals ... === TestName: test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS === ok Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS === ok Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS === ok Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS === ok Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS === ok Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS === ok Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS === ok Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS === ok Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS === ok Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat | Status : SUCCESS === ok Test to create Load balancing rule with non source NAT ... === TestName: test_02_create_lb_rule_non_nat | Status : SUCCESS === ok Test for assign & removing load balancing rule ... === TestName: test_assign_and_removal_lb | Status : SUCCESS === ok -- Ran 27 tests in 11516.573s OK (END) ``` Cheers, Wilder > IP address is not removed from VR even after disabling static NAT > - > > Key: CLOUDSTACK-8991 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8991 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Affects Versions: 4.6.0 >Reporter: Wilder Rodrigues >Assignee: Wilder Rodrigues >Priority: Blocker > > Test for port forwarding on
[jira] [Created] (CLOUDSTACK-9002) VM deployment is successful even when dhcp entry command fails
Kshitij Kansal created CLOUDSTACK-9002: -- Summary: VM deployment is successful even when dhcp entry command fails Key: CLOUDSTACK-9002 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9002 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Reporter: Kshitij Kansal Repro Steps: 1. Create a VM in advanced network. 2. Once its successful, on the router add iptables rule to drop the packets "iptables -I INPUT 1 -j DROP" 3. Then deploy another vm using same network. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977814#comment-14977814 ] ASF GitHub Bot commented on CLOUDSTACK-8977: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151734282 @K0zka I have the same issue as @ustcweizhou no log, no error message. Just a blank page environment: management server running on centos 6.6 and tomcat tomcat6-el-2.1-api-6.0.24-49.el6.noarch > cloudstack UI creates a session for users not yet logged in > --- > > Key: CLOUDSTACK-8977 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: UI >Affects Versions: 4.5.2 >Reporter: Laszlo Hornyak >Assignee: Laszlo Hornyak > Fix For: Future > > Original Estimate: 0.1h > Remaining Estimate: 0.1h > > The cloudstack UI always creates a session. By executing a command like 'ab > -n 20 -c 32' the server can be killed reqlly quick. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9001) Modifying snapshot results validation in testpath_uuid_event testpath
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977805#comment-14977805 ] ASF GitHub Bot commented on CLOUDSTACK-9001: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-151733973 Officially we're over 9000 :) > Modifying snapshot results validation in testpath_uuid_event testpath > -- > > Key: CLOUDSTACK-9001 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9001 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > > Currently snapshots results validation is based on length of snapshot result > but if snapshot creation fails then None type object will not have "len" > attribute hence modifying the validation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CLOUDSTACK-9000) Logrotate cloudstack-agent error and out files
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Yadav updated CLOUDSTACK-9000: Status: Reviewable (was: In Progress) > Logrotate cloudstack-agent error and out files > -- > > Key: CLOUDSTACK-9000 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9000 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.5.3, 4.6.0 > > > As defined in cloud-agent.rc ( -errfile $LOGDIR/cloudstack-agent.err -outfile > $LOGDIR/cloudstack-agent.out $CLASS), jsvc can fill up disk very quickly in > case of errors. The fix would be to logrotate, the out and err files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9001) Modifying snapshot results validation in testpath_uuid_event testpath
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977794#comment-14977794 ] ASF GitHub Bot commented on CLOUDSTACK-9001: GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/994 CLOUDSTACK-9001: Modifying snapshot results validation Currently snapshots results validation is based on length of snapshot result but if snapshot creation fails then None type object will not have "len" attribute hence modifying the validation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack snapshot-has-no-attribute-len Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/994.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #994 commit 0e01c7f357cd6596570fd966e0f2ac65c4bbedb1 Author: Priti Sarap Date: 2015-10-28T05:49:36Z CLOUDSTACK-9001: Modifying snapshot results validation in testpath_uuid_event testpath > Modifying snapshot results validation in testpath_uuid_event testpath > -- > > Key: CLOUDSTACK-9001 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9001 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > > Currently snapshots results validation is based on length of snapshot result > but if snapshot creation fails then None type object will not have "len" > attribute hence modifying the validation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9000) Logrotate cloudstack-agent error and out files
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977790#comment-14977790
]
ASF GitHub Bot commented on CLOUDSTACK-9000:
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/992
[master/4.6] CLOUDSTACK-9000: logrotate cloudstack-agent out and err logs
Adds logrotate rules for cloudstack-agent.{err,out}, jsvc err/out log files
may fill up disk. This adds a logrotate config in the rpm packages
cc @remibergsma @wido @wilderrodrigues and others
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack
master-logrotate-kvm-agent-erroutlogs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #992
commit c6bfa051c7f247ba612801371f9ce2f8db6b04aa
Author: Rohit Yadav
Date: 2015-10-28T05:44:49Z
CLOUDSTACK-9000: logrotate cloudstack-agent out and err logs
Adds logrotate rules for cloudstack-agent.{err,out} log files
Signed-off-by: Rohit Yadav
> Logrotate cloudstack-agent error and out files
> --
>
> Key: CLOUDSTACK-9000
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9000
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.5.3, 4.6.0
>
>
> As defined in cloud-agent.rc ( -errfile $LOGDIR/cloudstack-agent.err -outfile
> $LOGDIR/cloudstack-agent.out $CLASS), jsvc can fill up disk very quickly in
> case of errors. The fix would be to logrotate, the out and err files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9000) Logrotate cloudstack-agent error and out files
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977792#comment-14977792
]
ASF GitHub Bot commented on CLOUDSTACK-9000:
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/993
[4.5] CLOUDSTACK-9000: logrotate cloudstack-agent out and err logs
Adds logrotate rules for cloudstack-agent.{err,out} log files
cc @remibergsma @wido @wilderrodrigues and others
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack
4.5-logrotate-kvm-agent-erroutlogs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/993.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #993
commit bacf971220ea97e80ac2fcf28de3ed9a51749522
Author: Rohit Yadav
Date: 2015-10-28T05:44:49Z
CLOUDSTACK-9000: logrotate cloudstack-agent out and err logs
Adds logrotate rules for cloudstack-agent.{err,out} log files
Signed-off-by: Rohit Yadav
> Logrotate cloudstack-agent error and out files
> --
>
> Key: CLOUDSTACK-9000
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9000
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.5.3, 4.6.0
>
>
> As defined in cloud-agent.rc ( -errfile $LOGDIR/cloudstack-agent.err -outfile
> $LOGDIR/cloudstack-agent.out $CLASS), jsvc can fill up disk very quickly in
> case of errors. The fix would be to logrotate, the out and err files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (CLOUDSTACK-9001) Modifying snapshot results validation in testpath_uuid_event testpath
Priti Sarap created CLOUDSTACK-9001: --- Summary: Modifying snapshot results validation in testpath_uuid_event testpath Key: CLOUDSTACK-9001 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9001 Project: CloudStack Issue Type: Improvement Security Level: Public (Anyone can view this level - this is the default.) Components: Automation Reporter: Priti Sarap Currently snapshots results validation is based on length of snapshot result but if snapshot creation fails then None type object will not have "len" attribute hence modifying the validation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CLOUDSTACK-8999) serviceConfig.py does not take in custom kvm resource
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Yadav updated CLOUDSTACK-8999: Status: Reviewable (was: In Progress) > serviceConfig.py does not take in custom kvm resource > - > > Key: CLOUDSTACK-8999 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8999 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.5.3, 4.6.0 > > > if an admin defines a custom resources in agent.properties, it is not picked > up due to hardcoded "resources" in serviceConfig.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CLOUDSTACK-9000) Logrotate cloudstack-agent error and out files
Rohit Yadav created CLOUDSTACK-9000: --- Summary: Logrotate cloudstack-agent error and out files Key: CLOUDSTACK-9000 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9000 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Reporter: Rohit Yadav Assignee: Rohit Yadav Fix For: 4.5.3, 4.6.0 As defined in cloud-agent.rc ( -errfile $LOGDIR/cloudstack-agent.err -outfile $LOGDIR/cloudstack-agent.out $CLASS), jsvc can fill up disk very quickly in case of errors. The fix would be to logrotate, the out and err files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8999) serviceConfig.py does not take in custom kvm resource
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977765#comment-14977765 ] ASF GitHub Bot commented on CLOUDSTACK-8999: GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/991 [master/4.6] CLOUDSTACK-8999: Don't override resource if provided by agent.properties If a custom resource (kvm/libvirt implementation) is defined in agent.properties don't override with the default, but check and fallback to the default if resource property not defined A simple if-else fix, cc @remibergsma @wido @wilderrodrigues @borisroman and others You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack allow-pluggable-kvmresource-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/991.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #991 commit 1e8d39b12e1ade404eb002269b54e518d6aa3309 Author: Rohit Yadav Date: 2015-10-28T05:22:13Z CLOUDSTACK-8999: Don't override resource if provided by agent.properties If a custom resource (kvm/libvirt implementation) is defined in agent.properties don't override with the default, but check and fallback to the default if resource property not defined Signed-off-by: Rohit Yadav (cherry picked from commit 536a8b22c8865dc94281bce6267930a63e03ab77) Signed-off-by: Rohit Yadav > serviceConfig.py does not take in custom kvm resource > - > > Key: CLOUDSTACK-8999 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8999 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.5.3, 4.6.0 > > > if an admin defines a custom resources in agent.properties, it is not picked > up due to hardcoded "resources" in serviceConfig.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8999) serviceConfig.py does not take in custom kvm resource
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977764#comment-14977764 ] ASF GitHub Bot commented on CLOUDSTACK-8999: GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/990 CLOUDSTACK-8999: Don't override resource if provided by agent.properties If a custom resource (kvm/libvirt implementation) is defined in agent.properties don't override with the default, but check and fallback to the default if resource property not defined A simple if-else fix, cc @remibergsma @wido @wilderrodrigues @borisroman and others You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack allow-pluggable-kvmresource Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/990.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #990 commit 536a8b22c8865dc94281bce6267930a63e03ab77 Author: Rohit Yadav Date: 2015-10-28T05:22:13Z CLOUDSTACK-8999: Don't override resource if provided by agent.properties If a custom resource (kvm/libvirt implementation) is defined in agent.properties don't override with the default, but check and fallback to the default if resource property not defined Signed-off-by: Rohit Yadav > serviceConfig.py does not take in custom kvm resource > - > > Key: CLOUDSTACK-8999 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8999 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: 4.5.3, 4.6.0 > > > if an admin defines a custom resources in agent.properties, it is not picked > up due to hardcoded "resources" in serviceConfig.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CLOUDSTACK-8999) serviceConfig.py does not take in custom kvm resource
Rohit Yadav created CLOUDSTACK-8999: --- Summary: serviceConfig.py does not take in custom kvm resource Key: CLOUDSTACK-8999 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8999 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: KVM Reporter: Rohit Yadav Assignee: Rohit Yadav Fix For: 4.5.3, 4.6.0 if an admin defines a custom resources in agent.properties, it is not picked up due to hardcoded "resources" in serviceConfig.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8992) Allow more then 6 disks to be connected to a KVM VM.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977718#comment-14977718 ] ASF GitHub Bot commented on CLOUDSTACK-8992: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/980#issuecomment-151721813 LGTM. All the tests in BVT tests pass. (I see some failures in scalevm and deployvm from iso tests but, they are environment issues) > Allow more then 6 disks to be connected to a KVM VM. > > > Key: CLOUDSTACK-8992 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8992 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM, Storage Controller >Affects Versions: 4.6.0 >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > Currently, only 6 disks are allowed to be connected to a KVM VM. This can be > much more. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8994) Activity of the password server isn't logged.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977719#comment-14977719 ] ASF GitHub Bot commented on CLOUDSTACK-8994: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151721874 LGTM. All the tests in BVT tests pass. (I see some failures in scalevm and deployvm from iso tests but, they are environment issues) > Activity of the password server isn't logged. > - > > Key: CLOUDSTACK-8994 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8994 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Affects Versions: 4.6.0 >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > Activity of the password server in the virtual router isn't logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8975) [Automation]skip test case if niciraNvp settings are not available in config file
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977717#comment-14977717 ] ASF GitHub Bot commented on CLOUDSTACK-8975: Github user nitt10prashant closed the pull request at: https://github.com/apache/cloudstack/pull/960 > [Automation]skip test case if niciraNvp settings are not available in config > file > - > > Key: CLOUDSTACK-8975 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8975 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Affects Versions: 4.7.0 >Reporter: prashant kumar mishra >Assignee: prashant kumar mishra >Priority: Minor > Fix For: 4.7.0 > > > /root/cloudstack/test/integration/smoke/test_nicira_controller.py is > failing if niciraNvp settings are not available in config file. Modifying > script to skip test case if settings are not available > log > === > File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py", > line 46, in setUpClass > cls.nicira_hosts = cls.config.niciraNvp.hosts > AttributeError: 'NoneType' object has no attribute 'hosts' > >> begin captured stdout << - > === TestName: None | Status : EXCEPTION === -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8975) [Automation]skip test case if niciraNvp settings are not available in config file
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977716#comment-14977716 ] ASF GitHub Bot commented on CLOUDSTACK-8975: Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-151720250 based on discussion closing the PR Thanks @remibergsma @runseb @miguelaferreira @pvr9711 for great discussion . > [Automation]skip test case if niciraNvp settings are not available in config > file > - > > Key: CLOUDSTACK-8975 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8975 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Affects Versions: 4.7.0 >Reporter: prashant kumar mishra >Assignee: prashant kumar mishra >Priority: Minor > Fix For: 4.7.0 > > > /root/cloudstack/test/integration/smoke/test_nicira_controller.py is > failing if niciraNvp settings are not available in config file. Modifying > script to skip test case if settings are not available > log > === > File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py", > line 46, in setUpClass > cls.nicira_hosts = cls.config.niciraNvp.hosts > AttributeError: 'NoneType' object has no attribute 'hosts' > >> begin captured stdout << - > === TestName: None | Status : EXCEPTION === -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajani Karuturi resolved CLOUDSTACK-8816.
-
Resolution: Fixed
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Moved] (CLOUDSTACK-8998) I need CloudStack Templetes (.YAML file) like AWS CloudFormation Templete(.JASON file) and need a Jenkin Plugin in Ruby to communicate with all Cloudstack API.Request
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Han moved KYLIN-1107 to CLOUDSTACK-8998: - Assignee: (was: Zhong,Jason) Security: Public Component/s: (was: Web ) Workflow: Cloudstack Workflow (was: jira) Key: CLOUDSTACK-8998 (was: KYLIN-1107) Project: CloudStack (was: Kylin) > I need CloudStack Templetes (.YAML file) like AWS CloudFormation > Templete(.JASON file) and need a Jenkin Plugin in Ruby to communicate with > all Cloudstack API.Requesting you to please help me out with this > -- > > Key: CLOUDSTACK-8998 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8998 > Project: CloudStack > Issue Type: Wish > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Himmat Singh > > project requirement is that our cloud is based on cloudstack API . we need to > automate servers on cloud through puppet before that we have to create some > plugin's in ruby on jenkins. that plugin will get configuration files(.yaml > files) which have the configuration files of server's will get it from Git > repository and call to Cloudstack API of our cloud which will do its job. > please provide some usefull solutions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977212#comment-14977212
]
ASF GitHub Bot commented on CLOUDSTACK-8993:
Github user serbaut commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151652563
Getting errors when running test/systemvm/test_update_config.py.
from envassert import file, process, package, user, group, port,
cron, detect, ip
ImportError: cannot import name ip
Got other errors when setting up devcloud by following
https://cwiki.apache.org/confluence/display/CLOUDSTACK/devcloud-kvm but I
managed to work around it.
Exception Occurred Under createLogs :['Traceback (most recent call
last):\n', ' File
"/usr/local/lib/python2.7/site-packages/Marvin-4.6.0_SNAPSHOT-py2.7.egg/marvin/marvinLog.py",
line 157, in createLogs\n(\'LogFolderPath\' in log_cfg.__dict__.keys())
and\n', "Attri
buteError: 'list' object has no attribute '__dict__'\n"]
Not sure how to proceed. Are these tests supposed to work at all?
> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the
> same IP address.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8991) IP address is not removed from VR even after disabling static NAT
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977124#comment-14977124 ] ASF GitHub Bot commented on CLOUDSTACK-8991: Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/989#discussion_r43184165 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -602,9 +610,8 @@ def compare(self, bag): if self.dev in bag.keys(): for address in bag[self.dev]: self.setAddress(address) -if self.hasIP(ip): -found = True -if self.is_guest_gateway(address, ip): +if (self.hasIP(ip) or self.is_guest_gateway(address, ip)) and addess["add"]: --- End diff -- addess should be address right? > IP address is not removed from VR even after disabling static NAT > - > > Key: CLOUDSTACK-8991 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8991 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Affects Versions: 4.6.0 >Reporter: Wilder Rodrigues >Assignee: Wilder Rodrigues >Priority: Blocker > > Test for port forwarding on source NAT ... === TestName: > test_01_port_fwd_on_src_nat | Status : SUCCESS === > ok > Test for port forwarding on non source NAT ... === TestName: > test_02_port_fwd_on_non_src_nat | Status : SUCCESS === > ok > Test for reboot router ... === TestName: test_reboot_router | Status : > SUCCESS === > ok > Test for Router rules for network rules on acquired public IP ... === > TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : > FAILED === > FAIL > Test for Router rules for network rules on acquired public IP ... === > TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED > === > FAIL > Test for Router rules for network rules on acquired public IP ... === > TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status > : FAILED === > FAIL > == > FAIL: Test for Router rules for network rules on acquired public IP > -- > Traceback (most recent call last): > File "/usr/lib/python2.7/site-packages/ddt.py", line 146, in wrapper > return func(self, *args, **kwargs) > File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", > line 1248, in test_network_rules_acquired_public_ip > not removed from VR even after disabling statin NAT") > AssertionError: IP address isnot removed from VR even after > disabling statin NAT -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8991) IP address is not removed from VR even after disabling static NAT
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977123#comment-14977123
]
ASF GitHub Bot commented on CLOUDSTACK-8991:
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/989#discussion_r43184047
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -602,9 +610,8 @@ def compare(self, bag):
if self.dev in bag.keys():
for address in bag[self.dev]:
self.setAddress(address)
-if self.hasIP(ip):
-found = True
-if self.is_guest_gateway(address, ip):
+if (self.hasIP(ip) or self.is_guest_gateway(address,
ip)) and addess["add"]:
+logging.debig("The IP address in '%s' will be
configured" % address)
--- End diff --
Is logging.debig correct? Shouldn't this be logging.debug?
> IP address is not removed from VR even after disabling static NAT
> -
>
> Key: CLOUDSTACK-8991
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8991
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
>Affects Versions: 4.6.0
>Reporter: Wilder Rodrigues
>Assignee: Wilder Rodrigues
>Priority: Blocker
>
> Test for port forwarding on source NAT ... === TestName:
> test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> Test for port forwarding on non source NAT ... === TestName:
> test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
> ok
> Test for reboot router ... === TestName: test_reboot_router | Status :
> SUCCESS ===
> ok
> Test for Router rules for network rules on acquired public IP ... ===
> TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
> FAILED ===
> FAIL
> Test for Router rules for network rules on acquired public IP ... ===
> TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED
> ===
> FAIL
> Test for Router rules for network rules on acquired public IP ... ===
> TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status
> : FAILED ===
> FAIL
> ==
> FAIL: Test for Router rules for network rules on acquired public IP
> --
> Traceback (most recent call last):
> File "/usr/lib/python2.7/site-packages/ddt.py", line 146, in wrapper
> return func(self, *args, **kwargs)
> File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py",
> line 1248, in test_network_rules_acquired_public_ip
> not removed from VR even after disabling statin NAT")
> AssertionError: IP address isnot removed from VR even after
> disabling statin NAT
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977119#comment-14977119 ] ASF GitHub Bot commented on CLOUDSTACK-8977: Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151636873 @ustcweizhou I'm not experiencing any problems... > cloudstack UI creates a session for users not yet logged in > --- > > Key: CLOUDSTACK-8977 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: UI >Affects Versions: 4.5.2 >Reporter: Laszlo Hornyak >Assignee: Laszlo Hornyak > Fix For: Future > > Original Estimate: 0.1h > Remaining Estimate: 0.1h > > The cloudstack UI always creates a session. By executing a command like 'ab > -n 20 -c 32' the server can be killed reqlly quick. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8990) start a stopped machine on a specific determinable host on UI
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977115#comment-14977115 ] ASF GitHub Bot commented on CLOUDSTACK-8990: Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151636411 @remibergsma LGMT :+1:  > start a stopped machine on a specific determinable host on UI > - > > Key: CLOUDSTACK-8990 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8990 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Minor > > This is already implemented in API ,but not on UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977105#comment-14977105 ] ASF GitHub Bot commented on CLOUDSTACK-8977: Github user K0zka commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151635108 @ustcweizhou * could you try to clear the tomcat work directory? * could you check the service with ```curl -v -o /dev/null``` > cloudstack UI creates a session for users not yet logged in > --- > > Key: CLOUDSTACK-8977 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: UI >Affects Versions: 4.5.2 >Reporter: Laszlo Hornyak >Assignee: Laszlo Hornyak > Fix For: Future > > Original Estimate: 0.1h > Remaining Estimate: 0.1h > > The cloudstack UI always creates a session. By executing a command like 'ab > -n 20 -c 32' the server can be killed reqlly quick. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8991) IP address is not removed from VR even after disabling static NAT
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977071#comment-14977071 ] ASF GitHub Bot commented on CLOUDSTACK-8991: Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/989#issuecomment-151628960 Ping @remibergsma @karuturi @DaanHoogland @bhaisaab @miguelaferreira @michaelandersen Test environment: * ACS built from source * Management Server + MySQL on CentOS 7.1 * One KVM host on CentOS 7.1 * ACS Agent and Common RPMs built from source ``` Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS === ok Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS === ok Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS === ok -- Ran 6 tests in 1515.555s OK /tmp//MarvinLogs/test_network_T2C4HZ/results.txt (END) ``` I'm running more tests and the full report will be added once tests are ready. Cheer, Wilder > IP address is not removed from VR even after disabling static NAT > - > > Key: CLOUDSTACK-8991 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8991 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Affects Versions: 4.6.0 >Reporter: Wilder Rodrigues >Assignee: Wilder Rodrigues >Priority: Blocker > > Test for port forwarding on source NAT ... === TestName: > test_01_port_fwd_on_src_nat | Status : SUCCESS === > ok > Test for port forwarding on non source NAT ... === TestName: > test_02_port_fwd_on_non_src_nat | Status : SUCCESS === > ok > Test for reboot router ... === TestName: test_reboot_router | Status : > SUCCESS === > ok > Test for Router rules for network rules on acquired public IP ... === > TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : > FAILED === > FAIL > Test for Router rules for network rules on acquired public IP ... === > TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED > === > FAIL > Test for Router rules for network rules on acquired public IP ... === > TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status > : FAILED === > FAIL > == > FAIL: Test for Router rules for network rules on acquired public IP > -- > Traceback (most recent call last): > File "/usr/lib/python2.7/site-packages/ddt.py", line 146, in wrapper > return func(self, *args, **kwargs) > File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", > line 1248, in test_network_rules_acquired_public_ip > not removed from VR even after disabling statin NAT") > AssertionError: IP address isnot removed from VR even after > disabling statin NAT -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8991) IP address is not removed from VR even after disabling static NAT
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977065#comment-14977065 ] ASF GitHub Bot commented on CLOUDSTACK-8991: GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/989 CLOUDSTACK-8991 - IP address is not removed from VR even after disabling static NAT This PR fixes the Public IP removal form the virtual routers. It also improves the existing test_network.py. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ekholabs/cloudstack fix/cleanup_vr_ips-CLOUDSTACK-8991 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/989.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #989 commit 99318caa67f25932b652ea53c1742b6c1e5b0927 Author: Wilder Rodrigues Date: 2015-10-27T18:45:34Z CLOUDSTACK-8991 - Make sure the public IP is removed form the router before checking - Adding proper logger to the tests - Changing message that was copied/pasted from another assert commit 7197cf2e24a02dbc5cd4c1964e7c8baadc112340 Author: Wilder Rodrigues Date: 2015-10-27T18:46:13Z CLOUDSTACK-8991 - Remove public IP form interface in case add = false commit e6a3b3bf9cf03ffa189db0a7df81579a57148d8e Author: Wilder Rodrigues Date: 2015-10-27T18:46:48Z CLOUDSTACK-8991 - Process the IPs that have been removed commit 081c6a965e3750df1a4b6c3746a0ffb1b95b62b3 Author: Wilder Rodrigues Date: 2015-10-27T20:03:10Z CLOUDSTACK-8991 - Use the correct IP address object > IP address is not removed from VR even after disabling static NAT > - > > Key: CLOUDSTACK-8991 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8991 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Affects Versions: 4.6.0 >Reporter: Wilder Rodrigues >Assignee: Wilder Rodrigues >Priority: Blocker > > Test for port forwarding on source NAT ... === TestName: > test_01_port_fwd_on_src_nat | Status : SUCCESS === > ok > Test for port forwarding on non source NAT ... === TestName: > test_02_port_fwd_on_non_src_nat | Status : SUCCESS === > ok > Test for reboot router ... === TestName: test_reboot_router | Status : > SUCCESS === > ok > Test for Router rules for network rules on acquired public IP ... === > TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : > FAILED === > FAIL > Test for Router rules for network rules on acquired public IP ... === > TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED > === > FAIL > Test for Router rules for network rules on acquired public IP ... === > TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status > : FAILED === > FAIL > == > FAIL: Test for Router rules for network rules on acquired public IP > -- > Traceback (most recent call last): > File "/usr/lib/python2.7/site-packages/ddt.py", line 146, in wrapper > return func(self, *args, **kwargs) > File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", > line 1248, in test_network_rules_acquired_public_ip > not removed from VR even after disabling statin NAT") > AssertionError: IP address isnot removed from VR even after > disabling statin NAT -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976903#comment-14976903
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit 535ab51b9ad829ed1bd25973b913d4f731440ad5 in cloudstack's branch
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=535ab51 ]
Merge pull request #849 from karuturi/CLOUDSTACK-8816-take2
Cloudstack-8816 some of the events do not have resource uuidsThe key objects in
the context map are sometimes String and sometimes object. This causes missing
uuids when an entity put in the context map with key entity.toString is queried
with key entity
Testing:
manually tested by deploying a vm and checked that the created events in
rabbitmq now has uuids.
events before and after the change are update at
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?focusedCommentId=14805239
unittests
```
$ mvn -pl :cloud-api test -Dtest=CallContextTest
---
T E S T S
---
Running org.apache.cloudstack.context.CallContextTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec - in
org.apache.cloudstack.context.CallContextTest
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 11.445 s
[INFO] Finished at: 2015-09-18T14:58:53+05:30
[INFO] Final Memory: 55M/448M
[INFO]
```
* pr/849:
CLOUDSTACK-8816 added missing events
CLOUDSTACK-8816: fixed missing resource uuid in delete network cmd
CLOUDSTACK-8816: fixed missing resource uuid in destroy vm event
Cloudstack-8816: Fixed missing resource uuid in delete snapshot events
CLOUDSTACK-8816: some of the events do not have resource uuids
CLOUDSTACK-8816: some of the events do not have resource uuids
Signed-off-by: Remi Bergsma
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976910#comment-14976910
]
ASF GitHub Bot commented on CLOUDSTACK-8816:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/849
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976902#comment-14976902
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit 2c0af1f86716714590a1709987f4ad0bf3c9566b in cloudstack's branch
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2c0af1f ]
CLOUDSTACK-8816 added missing events
added missing events for createUser, updateUser, createAccount apis.
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976908#comment-14976908
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit 535ab51b9ad829ed1bd25973b913d4f731440ad5 in cloudstack's branch
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=535ab51 ]
Merge pull request #849 from karuturi/CLOUDSTACK-8816-take2
Cloudstack-8816 some of the events do not have resource uuidsThe key objects in
the context map are sometimes String and sometimes object. This causes missing
uuids when an entity put in the context map with key entity.toString is queried
with key entity
Testing:
manually tested by deploying a vm and checked that the created events in
rabbitmq now has uuids.
events before and after the change are update at
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?focusedCommentId=14805239
unittests
```
$ mvn -pl :cloud-api test -Dtest=CallContextTest
---
T E S T S
---
Running org.apache.cloudstack.context.CallContextTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec - in
org.apache.cloudstack.context.CallContextTest
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 11.445 s
[INFO] Finished at: 2015-09-18T14:58:53+05:30
[INFO] Final Memory: 55M/448M
[INFO]
```
* pr/849:
CLOUDSTACK-8816 added missing events
CLOUDSTACK-8816: fixed missing resource uuid in delete network cmd
CLOUDSTACK-8816: fixed missing resource uuid in destroy vm event
Cloudstack-8816: Fixed missing resource uuid in delete snapshot events
CLOUDSTACK-8816: some of the events do not have resource uuids
CLOUDSTACK-8816: some of the events do not have resource uuids
Signed-off-by: Remi Bergsma
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976905#comment-14976905
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit 535ab51b9ad829ed1bd25973b913d4f731440ad5 in cloudstack's branch
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=535ab51 ]
Merge pull request #849 from karuturi/CLOUDSTACK-8816-take2
Cloudstack-8816 some of the events do not have resource uuidsThe key objects in
the context map are sometimes String and sometimes object. This causes missing
uuids when an entity put in the context map with key entity.toString is queried
with key entity
Testing:
manually tested by deploying a vm and checked that the created events in
rabbitmq now has uuids.
events before and after the change are update at
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?focusedCommentId=14805239
unittests
```
$ mvn -pl :cloud-api test -Dtest=CallContextTest
---
T E S T S
---
Running org.apache.cloudstack.context.CallContextTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec - in
org.apache.cloudstack.context.CallContextTest
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 11.445 s
[INFO] Finished at: 2015-09-18T14:58:53+05:30
[INFO] Final Memory: 55M/448M
[INFO]
```
* pr/849:
CLOUDSTACK-8816 added missing events
CLOUDSTACK-8816: fixed missing resource uuid in delete network cmd
CLOUDSTACK-8816: fixed missing resource uuid in destroy vm event
Cloudstack-8816: Fixed missing resource uuid in delete snapshot events
CLOUDSTACK-8816: some of the events do not have resource uuids
CLOUDSTACK-8816: some of the events do not have resource uuids
Signed-off-by: Remi Bergsma
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976906#comment-14976906
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit 535ab51b9ad829ed1bd25973b913d4f731440ad5 in cloudstack's branch
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=535ab51 ]
Merge pull request #849 from karuturi/CLOUDSTACK-8816-take2
Cloudstack-8816 some of the events do not have resource uuidsThe key objects in
the context map are sometimes String and sometimes object. This causes missing
uuids when an entity put in the context map with key entity.toString is queried
with key entity
Testing:
manually tested by deploying a vm and checked that the created events in
rabbitmq now has uuids.
events before and after the change are update at
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?focusedCommentId=14805239
unittests
```
$ mvn -pl :cloud-api test -Dtest=CallContextTest
---
T E S T S
---
Running org.apache.cloudstack.context.CallContextTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec - in
org.apache.cloudstack.context.CallContextTest
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 11.445 s
[INFO] Finished at: 2015-09-18T14:58:53+05:30
[INFO] Final Memory: 55M/448M
[INFO]
```
* pr/849:
CLOUDSTACK-8816 added missing events
CLOUDSTACK-8816: fixed missing resource uuid in delete network cmd
CLOUDSTACK-8816: fixed missing resource uuid in destroy vm event
Cloudstack-8816: Fixed missing resource uuid in delete snapshot events
CLOUDSTACK-8816: some of the events do not have resource uuids
CLOUDSTACK-8816: some of the events do not have resource uuids
Signed-off-by: Remi Bergsma
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976909#comment-14976909
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit 535ab51b9ad829ed1bd25973b913d4f731440ad5 in cloudstack's branch
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=535ab51 ]
Merge pull request #849 from karuturi/CLOUDSTACK-8816-take2
Cloudstack-8816 some of the events do not have resource uuidsThe key objects in
the context map are sometimes String and sometimes object. This causes missing
uuids when an entity put in the context map with key entity.toString is queried
with key entity
Testing:
manually tested by deploying a vm and checked that the created events in
rabbitmq now has uuids.
events before and after the change are update at
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?focusedCommentId=14805239
unittests
```
$ mvn -pl :cloud-api test -Dtest=CallContextTest
---
T E S T S
---
Running org.apache.cloudstack.context.CallContextTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec - in
org.apache.cloudstack.context.CallContextTest
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 11.445 s
[INFO] Finished at: 2015-09-18T14:58:53+05:30
[INFO] Final Memory: 55M/448M
[INFO]
```
* pr/849:
CLOUDSTACK-8816 added missing events
CLOUDSTACK-8816: fixed missing resource uuid in delete network cmd
CLOUDSTACK-8816: fixed missing resource uuid in destroy vm event
Cloudstack-8816: Fixed missing resource uuid in delete snapshot events
CLOUDSTACK-8816: some of the events do not have resource uuids
CLOUDSTACK-8816: some of the events do not have resource uuids
Signed-off-by: Remi Bergsma
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976904#comment-14976904
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit 535ab51b9ad829ed1bd25973b913d4f731440ad5 in cloudstack's branch
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=535ab51 ]
Merge pull request #849 from karuturi/CLOUDSTACK-8816-take2
Cloudstack-8816 some of the events do not have resource uuidsThe key objects in
the context map are sometimes String and sometimes object. This causes missing
uuids when an entity put in the context map with key entity.toString is queried
with key entity
Testing:
manually tested by deploying a vm and checked that the created events in
rabbitmq now has uuids.
events before and after the change are update at
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?focusedCommentId=14805239
unittests
```
$ mvn -pl :cloud-api test -Dtest=CallContextTest
---
T E S T S
---
Running org.apache.cloudstack.context.CallContextTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec - in
org.apache.cloudstack.context.CallContextTest
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 11.445 s
[INFO] Finished at: 2015-09-18T14:58:53+05:30
[INFO] Final Memory: 55M/448M
[INFO]
```
* pr/849:
CLOUDSTACK-8816 added missing events
CLOUDSTACK-8816: fixed missing resource uuid in delete network cmd
CLOUDSTACK-8816: fixed missing resource uuid in destroy vm event
Cloudstack-8816: Fixed missing resource uuid in delete snapshot events
CLOUDSTACK-8816: some of the events do not have resource uuids
CLOUDSTACK-8816: some of the events do not have resource uuids
Signed-off-by: Remi Bergsma
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976901#comment-14976901
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit 3ff7bf771d1850adbebb62f50cc465ce13604d3a in cloudstack's branch
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3ff7bf7 ]
CLOUDSTACK-8816: fixed missing resource uuid in delete network cmd
*events before*
| management-server.AsyncJobEvent.submit.None.*
| cloudstack-events | 7 |
{"cmdInfo":"{\"id\":\"edf0a16b-54cd-442e-b644-4af933f34229\",\"response\":\"json\",\"ctxDetails\":\"{\\\"interface
com.cloud.network.Network\\\":\\\"edf0a16b-54cd-442e-b644-4af933f34229\\\"}\",\"cmdEventType\":\"NETWORK.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1444805881664\",\"uuid\":\"edf0a16b-54cd-442e-b644-4af933f34229\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"1378\"}","instanceType":"None","jobId":"f7cbf481-49d0-423b-8661-5d3d678f4b96","status":"IN_PROGRESS","processStatus":"0","commandEventType":"NETWORK.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd","account":"bd73dc2e-35c0-11e5-b094-d4ae52cb9af0","user":"bd7ea748-35c0-11e5-b094-d4ae52cb9af0"}
| 736 | string | True| |
management-server.AsyncJobEvent.complete.None.* | cloudstack-events | 6
|
{"cmdInfo":"{\"id\":\"edf0a16b-54cd-442e-b644-4af933f34229\",\"response\":\"json\",\"ctxDetails\":\"{\\\"interface
com.cloud.network.Network\\\":\\\"edf0a16b-54cd-442e-b644-4af933f34229\\\"}\",\"cmdEventType\":\"NETWORK.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1444805881664\",\"uuid\":\"edf0a16b-54cd-442e-b644-4af933f34229\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"1378\"}","instanceType":"None","jobId":"f7cbf481-49d0-423b-8661-5d3d678f4b96","status":"FAILED","processStatus":"0","commandEventType":"NETWORK.DELETE","resultCode":"530","command":"org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd","jobResult":"org.apache.cloudstack.api.response.ExceptionResponse/null/{\"uuidList\":[],\"errorcode\":530,\"errortext\":\"Failed
to delete
network\"}","account":"bd73dc2e-35c0-11e5-b094-d4ae52cb9af0","user":"bd7ea748-35c0-11e5-b094-d4ae52cb9af0"}
| 884 | string | True|
*events after*
|
management-server.AsyncJobEvent.submit.Network.5eccaece-a789-4b93-99c2-8b731ab6e328
| cloudstack-events | 1 |
{"cmdInfo":"{\"id\":\"5eccaece-a789-4b93-99c2-8b731ab6e328\",\"response\":\"json\",\"ctxDetails\":\"{\\\"interface
com.cloud.network.Network\\\":\\\"5eccaece-a789-4b93-99c2-8b731ab6e328\\\"}\",\"cmdEventType\":\"NETWORK.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1444814151636\",\"uuid\":\"5eccaece-a789-4b93-99c2-8b731ab6e328\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"1424\"}","instanceType":"Network","instanceUuid":"5eccaece-a789-4b93-99c2-8b731ab6e328","jobId":"d2cd4b27-acbd-4e56-867f-fe67ebde8261","status":"IN_PROGRESS","processStatus":"0","commandEventType":"NETWORK.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd","account":"bd73dc2e-35c0-11e5-b094-d4ae52cb9af0","user":"bd7ea748-35c0-11e5-b094-d4ae52cb9af0"}
| 793 | string | False |
|
management-server.AsyncJobEvent.complete.Network.5eccaece-a789-4b93-99c2-8b731ab6e328
| cloudstack-events | 0 |
{"cmdInfo":"{\"id\":\"5eccaece-a789-4b93-99c2-8b731ab6e328\",\"response\":\"json\",\"ctxDetails\":\"{\\\"interface
com.cloud.network.Network\\\":\\\"5eccaece-a789-4b93-99c2-8b731ab6e328\\\"}\",\"cmdEventType\":\"NETWORK.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1444814151636\",\"uuid\":\"5eccaece-a789-4b93-99c2-8b731ab6e328\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"1424\"}","instanceType":"Network","instanceUuid":"5eccaece-a789-4b93-99c2-8b731ab6e328","jobId":"d2cd4b27-acbd-4e56-867f-fe67ebde8261","status":"SUCCEEDED","processStatus":"0","commandEventType":"NETWORK.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"bd73dc2e-35c0-11e5-b094-d4ae52cb9af0","user":"bd7ea748-35c0-11e5-b094-d4ae52cb9af0"}
| 880 | string | False |
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karu
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976900#comment-14976900
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit ec03473c2399bde73b0407916b417c9fb46113c6 in cloudstack's branch
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ec03473 ]
CLOUDSTACK-8816: fixed missing resource uuid in destroy vm event
*event before*
| management-server.AsyncJobEvent.complete.VirtualMachine.*
| cloudstack-events | 2 |
{"cmdInfo":"{\"response\":\"json\",\"id\":\"ba45d114-9844-4123-8dc6-7ae46d10581a\",\"ctxDetails\":\"{\\\"interface
com.cloud.vm.VirtualMachine\\\":\\\"ba45d114-9844-4123-8dc6-7ae46d10581a\\\"}\",\"cmdEventType\":\"VM.DESTROY\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1444812001047\",\"uuid\":\"ba45d114-9844-4123-8dc6-7ae46d10581a\",\"ctxAccountId\":\"2\",\"expunge\":\"true\",\"ctxStartEventId\":\"1395\"}","instanceType":"VirtualMachine","jobId":"b46faa05-7b3a-4dbf-a78d-fbc7c66c3ce3","status":"SUCCEEDED","processStatus":"0","commandEventType":"VM.DESTROY","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.vm.DestroyVMCmdByAdmin","jobResult":"org.apache.cloudstack.api.response.UserVmResponse/null/{\"securitygroup\":[],\"nic\":[],\"tags\":[],\"affinitygroup\":[]}","account":"bd73dc2e-35c0-11e5-b094-d4ae52cb9af0","user":"bd7ea748-35c0-11e5-b094-d4ae52cb9af0"}
| 894 | string | True|
*event after*
|
management-server.AsyncJobEvent.complete.VirtualMachine.22e3bf71-91c8-4b18-a57e-af02d79dbb58
| cloudstack-events | 0 |
{"cmdInfo":"{\"response\":\"json\",\"id\":\"22e3bf71-91c8-4b18-a57e-af02d79dbb58\",\"ctxDetails\":\"{\\\"interface
com.cloud.vm.VirtualMachine\\\":\\\"22e3bf71-91c8-4b18-a57e-af02d79dbb58\\\"}\",\"cmdEventType\":\"VM.DESTROY\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1444813240169\",\"uuid\":\"22e3bf71-91c8-4b18-a57e-af02d79dbb58\",\"ctxAccountId\":\"2\",\"expunge\":\"true\",\"ctxStartEventId\":\"1418\"}","instanceType":"VirtualMachine","instanceUuid":"22e3bf71-91c8-4b18-a57e-af02d79dbb58","jobId":"256ca2e7-de05-4b33-b32a-aa8567f05160","status":"SUCCEEDED","processStatus":"0","commandEventType":"VM.DESTROY","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.vm.DestroyVMCmdByAdmin","jobResult":"org.apache.cloudstack.api.response.UserVmResponse/null/{\"securitygroup\":[],\"nic\":[],\"tags\":[],\"affinitygroup\":[]}","account":"bd73dc2e-35c0-11e5-b094-d4ae52cb9af0","user":"bd7ea748-35c0-11e5-b094-d4ae52cb9af0"}
| 948 | string | False |
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8816) rabbitMQ: generated events have wrong or missing uuids
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976907#comment-14976907
]
ASF subversion and git services commented on CLOUDSTACK-8816:
-
Commit 535ab51b9ad829ed1bd25973b913d4f731440ad5 in cloudstack's branch
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=535ab51 ]
Merge pull request #849 from karuturi/CLOUDSTACK-8816-take2
Cloudstack-8816 some of the events do not have resource uuidsThe key objects in
the context map are sometimes String and sometimes object. This causes missing
uuids when an entity put in the context map with key entity.toString is queried
with key entity
Testing:
manually tested by deploying a vm and checked that the created events in
rabbitmq now has uuids.
events before and after the change are update at
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?focusedCommentId=14805239
unittests
```
$ mvn -pl :cloud-api test -Dtest=CallContextTest
---
T E S T S
---
Running org.apache.cloudstack.context.CallContextTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec - in
org.apache.cloudstack.context.CallContextTest
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 11.445 s
[INFO] Finished at: 2015-09-18T14:58:53+05:30
[INFO] Final Memory: 55M/448M
[INFO]
```
* pr/849:
CLOUDSTACK-8816 added missing events
CLOUDSTACK-8816: fixed missing resource uuid in delete network cmd
CLOUDSTACK-8816: fixed missing resource uuid in destroy vm event
Cloudstack-8816: Fixed missing resource uuid in delete snapshot events
CLOUDSTACK-8816: some of the events do not have resource uuids
CLOUDSTACK-8816: some of the events do not have resource uuids
Signed-off-by: Remi Bergsma
> rabbitMQ: generated events have wrong or missing uuids
> --
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>Reporter: Rajani Karuturi
>Assignee: Rajani Karuturi
>Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode:2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-066294db","user":"fcf71ae6-6983-11e4-bb12-066294db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8975) [Automation]skip test case if niciraNvp settings are not available in config file
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976838#comment-14976838 ] ASF GitHub Bot commented on CLOUDSTACK-8975: Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-151584850 @nitt10prashant @pvr9711 please close this thread I will take care of moving the file > [Automation]skip test case if niciraNvp settings are not available in config > file > - > > Key: CLOUDSTACK-8975 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8975 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Affects Versions: 4.7.0 >Reporter: prashant kumar mishra >Assignee: prashant kumar mishra >Priority: Minor > Fix For: 4.7.0 > > > /root/cloudstack/test/integration/smoke/test_nicira_controller.py is > failing if niciraNvp settings are not available in config file. Modifying > script to skip test case if settings are not available > log > === > File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py", > line 46, in setUpClass > cls.nicira_hosts = cls.config.niciraNvp.hosts > AttributeError: 'NoneType' object has no attribute 'hosts' > >> begin captured stdout << - > === TestName: None | Status : EXCEPTION === -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8989) component/test_ps_limits.py can also be run on a "basic" setup
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976640#comment-14976640 ] ASF GitHub Bot commented on CLOUDSTACK-8989: Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151556191 @remibergsma Jenkins happy :) https://builds.apache.org/job/cloudstack-pull-analysis/1008/ > component/test_ps_limits.py can also be run on a "basic" setup > -- > > Key: CLOUDSTACK-8989 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8989 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin, Test >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > The integration test test_ps_limits.py can also be run on a basic setup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8977) cloudstack UI creates a session for users not yet logged in
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976589#comment-14976589 ] ASF GitHub Bot commented on CLOUDSTACK-8977: Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151546189 @K0zka there is no related log, no error message... I tried on CentOS/Ubuntu/Win7 Firefox/Chome, all did not work until revert the commit... weird... anyone has same issue ? > cloudstack UI creates a session for users not yet logged in > --- > > Key: CLOUDSTACK-8977 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8977 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: UI >Affects Versions: 4.5.2 >Reporter: Laszlo Hornyak >Assignee: Laszlo Hornyak > Fix For: Future > > Original Estimate: 0.1h > Remaining Estimate: 0.1h > > The cloudstack UI always creates a session. By executing a command like 'ab > -n 20 -c 32' the server can be killed reqlly quick. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976586#comment-14976586
]
Wido den Hollander commented on CLOUDSTACK-8302:
Yes, that is safe. No problem.
> Cleanup snapshot on KVM with RBD
>
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD
> pool is still exist.
> And I find the code in
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null; //To change body of implemented methods use File |
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with RBD
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976528#comment-14976528
]
Andrei Mikhailovsky commented on CLOUDSTACK-8302:
-
Wido, thanks
is it safe to remove all the primary storage stored snapshots if they have been
successfully backed up to the secondary storage?
Thanks
> Cleanup snapshot on KVM with RBD
>
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: KVM, Snapshot, Storage Controller
>Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
>Reporter: Star Guo
>Assignee: Wido den Hollander
>Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When
> delete a snapshot the UI show OK, but the snapshot of the volume in the RBD
> pool is still exist.
> And I find the code in
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null; //To change body of implemented methods use File |
> Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but
> not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976508#comment-14976508 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user sspans commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/883#discussion_r43131260 --- Diff: scripts/vm/hypervisor/xenserver/logrotate --- @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Version @VERSION@ +# +# script to perform logrotation on xenserver 6.0.2 and later + +/usr/sbin/logrotate /etc/logrotate.d/cloudlog --- End diff -- Should this really be only the cloudlog config? > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976472#comment-14976472 ] ASF GitHub Bot commented on CLOUDSTACK-8746: Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151516059 @ustcweizhou Great to see that these are there! @borisroman has some pending patches as well. If we submit some patches towards libvir-l...@redhat.com we can probably ask for a 0.6.0 release with what we need. > VM Snapshotting implementation for KVM > -- > > Key: CLOUDSTACK-8746 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8746 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou > > Currently it is not supported. > https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8677) Call-home functionality for CloudStack
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976468#comment-14976468 ] ASF GitHub Bot commented on CLOUDSTACK-8677: Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/987#issuecomment-151513310 @wido absolutly right. i'm not burning all these hours (both personal and sponsorred) just for the sake of this great marketing tool ;) > Call-home functionality for CloudStack > -- > > Key: CLOUDSTACK-8677 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8677 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: Future, 4.6.0 >Reporter: Wido den Hollander >Assignee: Wido den Hollander > Fix For: 4.6.0 > > > A call-home feature for the CloudStack management server would send > anonimized reports back to the CloudStack project. > These statistics will contain numbers and details on how CloudStack will be > used. It will NOT contain: > * Hostnames > * IP-Addresses > * Instance names > It will report back: > * Hosts (Number, version, type, hypervisor) > * Clusters (Hypervisor en Management type) > * Primary storage (Type and provider) > * Zones (Network type and providers) > * Instances (Number and types) > This gives the CloudStack project a better insight on how CloudStack is being > used and allows us to develop accordingly. > It will be OPT-OUT, using the "usage.report.interval" users can disable usage > reporting. By default it will run every 7 days and send a JSON document to > https://call-home.cloudstack.org/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8956) NSX/Nicira Plugin does not support NSX v4.2.1
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976464#comment-14976464 ] ASF GitHub Bot commented on CLOUDSTACK-8956: Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-151511065 btw, I'm testing your PR in our setup > NSX/Nicira Plugin does not support NSX v4.2.1 > - > > Key: CLOUDSTACK-8956 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8956 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware >Affects Versions: 4.4.0, 4.5.0, 4.4.1, 4.4.2, 4.4.3, 4.5.1, 4.4.4 > Environment: OS: RHEL 6.6 >Reporter: Nicolas Vazquez > Fix For: 4.5.1, 4.6.0 > > > h3. Description of the problem: > Prior to version 4.2. Nicira/VmWare NSX used a variation of Open vSwitch as > means of integrating SDN into hypervisor layer. Cloudstack NiciraNVP plugin > was written to support OVS as a bridge to NSX. > In version 4.2 VMware introduced NSX vSwitch as a replacement for OVS in ESX > hypervisors. It is a fork of distributed vSwitch leveraging one of the recent > features of ESX called opaque networks. Because of that change the current > version of NiciraNVP plugin doesn’t support versions of NSX-MH above 4.2 > specifically in Vsphere environment. Proposed fix will analyze a version of > NVP/NSX API and use proper support for ESX hypervisors. > vSphere hypervisor mode operations when NV is deployed onto NSX managed > network changes: > * Current mode. A portgroup = UUID of CS VM NIC is created on a local > standard switch of the Hypervisor where VM is starting. VM nic is attached to > that port group. > * New mode. No additional port group is created on a HW. No port group > cleanup is needed after VM/NIC is destroyed. VM is attached to 1st port group > having the following attributes: > ** opaqueNetworkId string "br-int” > ** opaqueNetworkType string "nsx.network" > If portgroup with such attributes is not found a deployment should fail with > exception. > h3. VMware vSphere API version from 5.1 to 5.5: > Since vSphere API version 5.5, > [OpaqueNetworks|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.OpaqueNetwork.html] > are introduced. > Its description says: > bq. This interface defines an opaque network, in the sense that the detail > and configuration of the network is unknown to vShpere and is managed by a > management plane outside of vSphere. However, the identifier and name of > these networks is made available to vSphere so that host and virtual machine > virtual ethernet device can connect to them. > In order to connect a vm's virtual ethernet device to the proper opaque > network when deploying a vm into a NSX managed network, we first need to look > for a particular opaque network on hosts. This opaque network's id has to be > *"br-int"* and its type *"nsx.network"*. > Since vSphere API version 5.5 > [HostNetworkInfo|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.host.NetworkInfo.html#opaqueNetwork] > introduces a list of available opaque networks for each host. > If NSX API version >= 4.2 we look for a > [OpaqueNetworkInfo|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.host.OpaqueNetworkInfo.html] > which satisfies: > * opaqueNetworkId = "br-int" > * opaqueNetworkType = "nsx.netork" > If that opaque network is found, then we need to attach vm's NIC to a virtual > ethernet device which support this, so we use > [VirtualEthernetCardOpaqueNetworkBackingInfo|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.vm.device.VirtualEthernetCard.OpaqueNetworkBackingInfo.html] > setting: > * opaqueNetworkId = "br-int" > * opaqueNetworkType = "nsx.netork" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8956) NSX/Nicira Plugin does not support NSX v4.2.1
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976458#comment-14976458 ] ASF GitHub Bot commented on CLOUDSTACK-8956: Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-151509780 Awesome to see the changes, @nvazquez ! Thanks for being openminded and also for your contributions! Cheers, Wilder > NSX/Nicira Plugin does not support NSX v4.2.1 > - > > Key: CLOUDSTACK-8956 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8956 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VMware >Affects Versions: 4.4.0, 4.5.0, 4.4.1, 4.4.2, 4.4.3, 4.5.1, 4.4.4 > Environment: OS: RHEL 6.6 >Reporter: Nicolas Vazquez > Fix For: 4.5.1, 4.6.0 > > > h3. Description of the problem: > Prior to version 4.2. Nicira/VmWare NSX used a variation of Open vSwitch as > means of integrating SDN into hypervisor layer. Cloudstack NiciraNVP plugin > was written to support OVS as a bridge to NSX. > In version 4.2 VMware introduced NSX vSwitch as a replacement for OVS in ESX > hypervisors. It is a fork of distributed vSwitch leveraging one of the recent > features of ESX called opaque networks. Because of that change the current > version of NiciraNVP plugin doesn’t support versions of NSX-MH above 4.2 > specifically in Vsphere environment. Proposed fix will analyze a version of > NVP/NSX API and use proper support for ESX hypervisors. > vSphere hypervisor mode operations when NV is deployed onto NSX managed > network changes: > * Current mode. A portgroup = UUID of CS VM NIC is created on a local > standard switch of the Hypervisor where VM is starting. VM nic is attached to > that port group. > * New mode. No additional port group is created on a HW. No port group > cleanup is needed after VM/NIC is destroyed. VM is attached to 1st port group > having the following attributes: > ** opaqueNetworkId string "br-int” > ** opaqueNetworkType string "nsx.network" > If portgroup with such attributes is not found a deployment should fail with > exception. > h3. VMware vSphere API version from 5.1 to 5.5: > Since vSphere API version 5.5, > [OpaqueNetworks|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.OpaqueNetwork.html] > are introduced. > Its description says: > bq. This interface defines an opaque network, in the sense that the detail > and configuration of the network is unknown to vShpere and is managed by a > management plane outside of vSphere. However, the identifier and name of > these networks is made available to vSphere so that host and virtual machine > virtual ethernet device can connect to them. > In order to connect a vm's virtual ethernet device to the proper opaque > network when deploying a vm into a NSX managed network, we first need to look > for a particular opaque network on hosts. This opaque network's id has to be > *"br-int"* and its type *"nsx.network"*. > Since vSphere API version 5.5 > [HostNetworkInfo|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.host.NetworkInfo.html#opaqueNetwork] > introduces a list of available opaque networks for each host. > If NSX API version >= 4.2 we look for a > [OpaqueNetworkInfo|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.host.OpaqueNetworkInfo.html] > which satisfies: > * opaqueNetworkId = "br-int" > * opaqueNetworkType = "nsx.netork" > If that opaque network is found, then we need to attach vm's NIC to a virtual > ethernet device which support this, so we use > [VirtualEthernetCardOpaqueNetworkBackingInfo|https://www.vmware.com/support/developer/converter-sdk/conv55_apireference/vim.vm.device.VirtualEthernetCard.OpaqueNetworkBackingInfo.html] > setting: > * opaqueNetworkId = "br-int" > * opaqueNetworkType = "nsx.netork" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8677) Call-home functionality for CloudStack
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976450#comment-14976450 ] ASF GitHub Bot commented on CLOUDSTACK-8677: Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/987#issuecomment-151508583 To add to the PR, it's not only needed for the Call-Home functionality, but we are using a very, very old version of Gson. > Call-home functionality for CloudStack > -- > > Key: CLOUDSTACK-8677 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8677 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: Future, 4.6.0 >Reporter: Wido den Hollander >Assignee: Wido den Hollander > Fix For: 4.6.0 > > > A call-home feature for the CloudStack management server would send > anonimized reports back to the CloudStack project. > These statistics will contain numbers and details on how CloudStack will be > used. It will NOT contain: > * Hostnames > * IP-Addresses > * Instance names > It will report back: > * Hosts (Number, version, type, hypervisor) > * Clusters (Hypervisor en Management type) > * Primary storage (Type and provider) > * Zones (Network type and providers) > * Instances (Number and types) > This gives the CloudStack project a better insight on how CloudStack is being > used and allows us to develop accordingly. > It will be OPT-OUT, using the "usage.report.interval" users can disable usage > reporting. By default it will run every 7 days and send a JSON document to > https://call-home.cloudstack.org/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976435#comment-14976435
]
ASF GitHub Bot commented on CLOUDSTACK-8993:
Github user serbaut commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151505153
Thanks, I will have another go at running the tests to see if I can write a
test for it.
> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the
> same IP address.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8677) Call-home functionality for CloudStack
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976445#comment-14976445 ] ASF GitHub Bot commented on CLOUDSTACK-8677: GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/987 CLOUDSTACK-8677: use wrapper classes for gson serialisation non functional change with great risk: replace all basic type fields of json serializable objects to wrapper class type fields. It is needed for gson upgrade which is needed for phone home functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack wrapper-classes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/987.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #987 commit b708df71e7bf5784684804319958e46e99397edd Author: Daan Hoogland Date: 2015-10-12T06:33:12Z CLOUDSTACK-8677: use wrapper classes for gson serialisation > Call-home functionality for CloudStack > -- > > Key: CLOUDSTACK-8677 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8677 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: Future, 4.6.0 >Reporter: Wido den Hollander >Assignee: Wido den Hollander > Fix For: 4.6.0 > > > A call-home feature for the CloudStack management server would send > anonimized reports back to the CloudStack project. > These statistics will contain numbers and details on how CloudStack will be > used. It will NOT contain: > * Hostnames > * IP-Addresses > * Instance names > It will report back: > * Hosts (Number, version, type, hypervisor) > * Clusters (Hypervisor en Management type) > * Primary storage (Type and provider) > * Zones (Network type and providers) > * Instances (Number and types) > This gives the CloudStack project a better insight on how CloudStack is being > used and allows us to develop accordingly. > It will be OPT-OUT, using the "usage.report.interval" users can disable usage > reporting. By default it will run every 7 days and send a JSON document to > https://call-home.cloudstack.org/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CLOUDSTACK-8997) use wrapper classes on all json marshalled objects for basic types
Daan Hoogland created CLOUDSTACK-8997: - Summary: use wrapper classes on all json marshalled objects for basic types Key: CLOUDSTACK-8997 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8997 Project: CloudStack Issue Type: Improvement Security Level: Public (Anyone can view this level - this is the default.) Affects Versions: 4.6.0 Reporter: Daan Hoogland Assignee: Daan Hoogland Priority: Critical -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976430#comment-14976430 ] ASF GitHub Bot commented on CLOUDSTACK-8832: Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-151504571 @jburwell, I think I've addressed all feedback now. Rebased against current master again. > Update Nuage VSP plugin to work with Nuage VSP release 3.2 > -- > > Key: CLOUDSTACK-8832 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Nick Livens >Assignee: Nick Livens > Attachments: nuageVspMarvinLogs.tar.gz > > > Nuage VSP 3.2 is being released, we want to bring the plugin up to date for > this release -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8940) Wrong value is inserted into nics table netmask field when creating a VM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976398#comment-14976398 ] ASF GitHub Bot commented on CLOUDSTACK-8940: Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/916#issuecomment-151500654 @ remibergsma Thank you very much. I was busy somewhere. Will update this PR with "update script" and rebase it. Sorry for the delayed response. > Wrong value is inserted into nics table netmask field when creating a VM > > > Key: CLOUDSTACK-8940 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8940 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Kshitij Kansal >Priority: Critical > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8989) component/test_ps_limits.py can also be run on a "basic" setup
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976370#comment-14976370 ] ASF GitHub Bot commented on CLOUDSTACK-8989: Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/979 > component/test_ps_limits.py can also be run on a "basic" setup > -- > > Key: CLOUDSTACK-8989 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8989 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin, Test >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > The integration test test_ps_limits.py can also be run on a basic setup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8989) component/test_ps_limits.py can also be run on a "basic" setup
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976375#comment-14976375 ] ASF GitHub Bot commented on CLOUDSTACK-8989: GitHub user borisroman reopened a pull request: https://github.com/apache/cloudstack/pull/979 [4.6] CLOUDSTACK-8989 test_ps_limits.py tests can also be run on a "basic" setup. The tests in the test_ps_limits.py file can all be run on a "basic" setup. This PR adds that functionality. ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-basic.cfg -s -a tags=basic,required_hardware=false smoke/test_vm_life_cycle.py ``` ``` Marvin Init Started === Marvin Parse Config Successful === === Marvin Setting TestData Successful=== Log Folder Path: /tmp//MarvinLogs//Oct_26_2015_09_55_20_4UDZRZ. All logs will be available here === Marvin Init Logging Successful=== Marvin Init Successful === TestName: test_deploy_vm | Status : SUCCESS === === TestName: test_deploy_vm_multiple | Status : SUCCESS === === TestName: test_01_stop_vm | Status : SUCCESS === === TestName: test_02_start_vm | Status : SUCCESS === === TestName: test_03_reboot_vm | Status : SUCCESS === === TestName: test_06_destroy_vm | Status : SUCCESS === === TestName: test_07_restore_vm | Status : SUCCESS === === TestName: test_09_expunge_vm | Status : SUCCESS === ===final results are now copied to: /tmp//MarvinLogs/test_vm_life_cycle_2GU6K4=== ``` ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-basic.cfg -s -a tags=basic,required_hardware=false component/test_ps_limits.py ``` ``` Marvin Init Started === Marvin Parse Config Successful === === Marvin Setting TestData Successful=== Log Folder Path: /tmp//MarvinLogs//Oct_26_2015_10_19_51_ZY3KD5. All logs will be available here === Marvin Init Logging Successful=== Marvin Init Successful === TestName: test_assign_vm_different_account_1_root_domain_admin | Status : SUCCESS === === TestName: test_assign_vm_different_account_2_child_domain_admin | Status : SUCCESS === === TestName: test_attach_detach_volume_1_root_domain_admin | Status : SUCCESS === === TestName: test_attach_detach_volume_2_child_domain_admin | Status : SUCCESS === === TestName: test_create_multiple_volumes_1_root_domain_admin | Status : SUCCESS === === TestName: test_create_multiple_volumes_2_child_domain_admin | Status : SUCCESS === === TestName: test_deploy_multiple_vm_1_root_domain_admin | Status : SUCCESS === === TestName: test_deploy_multiple_vm_2_child_domain_admin | Status : SUCCESS === === TestName: test_stop_start_vm_1_root_domain_admin | Status : SUCCESS === === TestName: test_stop_start_vm_2_child_domain_admin | Status : SUCCESS === ===final results are now copied to: /tmp//MarvinLogs/test_ps_limits_0E1HFP=== ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8989 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/979.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #979 commit a24cbafb15da0159664be344d2981b807c37d6bf Author: Boris Schrijver Date: 2015-10-27T13:30:58Z CLOUDSTACK-8989 test_ps_limits.py tests can also be run on a basic setup. > component/test_ps_limits.py can also be run on a "basic" setup > -- > > Key: CLOUDSTACK-8989 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8989 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin, Test >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > The integration test test_ps_limits.py can also be run on a basic setup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8989) component/test_ps_limits.py can also be run on a "basic" setup
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976363#comment-14976363 ] ASF GitHub Bot commented on CLOUDSTACK-8989: GitHub user borisroman reopened a pull request: https://github.com/apache/cloudstack/pull/979 [4.6] CLOUDSTACK-8989 test_ps_limits.py tests can also be run on a "basic" setup. The tests in the test_ps_limits.py file can all be run on a "basic" setup. This PR adds that functionality. ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-basic.cfg -s -a tags=basic,required_hardware=false smoke/test_vm_life_cycle.py ``` ``` Marvin Init Started === Marvin Parse Config Successful === === Marvin Setting TestData Successful=== Log Folder Path: /tmp//MarvinLogs//Oct_26_2015_09_55_20_4UDZRZ. All logs will be available here === Marvin Init Logging Successful=== Marvin Init Successful === TestName: test_deploy_vm | Status : SUCCESS === === TestName: test_deploy_vm_multiple | Status : SUCCESS === === TestName: test_01_stop_vm | Status : SUCCESS === === TestName: test_02_start_vm | Status : SUCCESS === === TestName: test_03_reboot_vm | Status : SUCCESS === === TestName: test_06_destroy_vm | Status : SUCCESS === === TestName: test_07_restore_vm | Status : SUCCESS === === TestName: test_09_expunge_vm | Status : SUCCESS === ===final results are now copied to: /tmp//MarvinLogs/test_vm_life_cycle_2GU6K4=== ``` ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-basic.cfg -s -a tags=basic,required_hardware=false component/test_ps_limits.py ``` ``` Marvin Init Started === Marvin Parse Config Successful === === Marvin Setting TestData Successful=== Log Folder Path: /tmp//MarvinLogs//Oct_26_2015_10_19_51_ZY3KD5. All logs will be available here === Marvin Init Logging Successful=== Marvin Init Successful === TestName: test_assign_vm_different_account_1_root_domain_admin | Status : SUCCESS === === TestName: test_assign_vm_different_account_2_child_domain_admin | Status : SUCCESS === === TestName: test_attach_detach_volume_1_root_domain_admin | Status : SUCCESS === === TestName: test_attach_detach_volume_2_child_domain_admin | Status : SUCCESS === === TestName: test_create_multiple_volumes_1_root_domain_admin | Status : SUCCESS === === TestName: test_create_multiple_volumes_2_child_domain_admin | Status : SUCCESS === === TestName: test_deploy_multiple_vm_1_root_domain_admin | Status : SUCCESS === === TestName: test_deploy_multiple_vm_2_child_domain_admin | Status : SUCCESS === === TestName: test_stop_start_vm_1_root_domain_admin | Status : SUCCESS === === TestName: test_stop_start_vm_2_child_domain_admin | Status : SUCCESS === ===final results are now copied to: /tmp//MarvinLogs/test_ps_limits_0E1HFP=== ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8989 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/979.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #979 commit 730173041e4c391b78ba3be2dd5d016fff644cae Author: Boris Schrijver Date: 2015-10-27T13:27:18Z CLOUDSTACK-8989 test_ps_limits.py tests can also be run on a basic setup. > component/test_ps_limits.py can also be run on a "basic" setup > -- > > Key: CLOUDSTACK-8989 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8989 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin, Test >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > The integration test test_ps_limits.py can also be run on a basic setup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8989) component/test_ps_limits.py can also be run on a "basic" setup
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976361#comment-14976361 ] ASF GitHub Bot commented on CLOUDSTACK-8989: Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/979 > component/test_ps_limits.py can also be run on a "basic" setup > -- > > Key: CLOUDSTACK-8989 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8989 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin, Test >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > The integration test test_ps_limits.py can also be run on a basic setup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976348#comment-14976348 ] ASF GitHub Bot commented on CLOUDSTACK-8746: Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151491475 @bhaisaab Thanks for your comments. The motivation of CreateSnapshotFromVMSnapshotCmd is, when we create a volume snapshot for a running vm on KVM, it will create a vm snapshot at first then create a volume snapshot from vm snapshot. Hence I think it is useful to create a volume snapshot directly from vm snapshot if it already exists. > VM Snapshotting implementation for KVM > -- > > Key: CLOUDSTACK-8746 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8746 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou > > Currently it is not supported. > https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976345#comment-14976345 ] ASF GitHub Bot commented on CLOUDSTACK-8746: Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151490894 @wido @DaanHoogland I just checked the libvirt-java, the snapshot operations with flags already exist in 0.5.1 , which did not exist in 0.4.9. I will modify the code and test it. > VM Snapshotting implementation for KVM > -- > > Key: CLOUDSTACK-8746 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8746 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou > > Currently it is not supported. > https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8957) VR password server broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976343#comment-14976343 ] Rohit Yadav commented on CLOUDSTACK-8957: - [~wilder.rodrigues] the python based password server should create some message in syslog (when a new password is save or sent to clients), and be able to serve passwords for the VM/IP. When mgmt server would save password, it should create a password- file in /var/cache/cloud/. AFAIK, there is no integration test. > VR password server broken > - > > Key: CLOUDSTACK-8957 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Affects Versions: 4.6.0 > Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt >Reporter: Nux >Assignee: Wilder Rodrigues >Priority: Blocker > > Hello, > When deploying instances from password enabled templates, the instances do > not get the generated passwords. > The VR logs show something like this: > 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested > password not found for 10.1.1.33' > In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is > not, I can see the passwords there. > Symlinking "passwords-10.1.1.1" to "passwords" and restarting the > passwd_server_ip script gets the feature working again, though I am not sure > how correct this approach is. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8957) VR password server broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976344#comment-14976344 ] Rohit Yadav commented on CLOUDSTACK-8957: - Wilder, after you had fixed it I can help run a manual test on your PR. > VR password server broken > - > > Key: CLOUDSTACK-8957 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Affects Versions: 4.6.0 > Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt >Reporter: Nux >Assignee: Wilder Rodrigues >Priority: Blocker > > Hello, > When deploying instances from password enabled templates, the instances do > not get the generated passwords. > The VR logs show something like this: > 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested > password not found for 10.1.1.33' > In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is > not, I can see the passwords there. > Symlinking "passwords-10.1.1.1" to "passwords" and restarting the > passwd_server_ip script gets the feature working again, though I am not sure > how correct this approach is. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8993) DHCP fails with "no address available" when an IP is reused
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976339#comment-14976339
]
ASF GitHub Bot commented on CLOUDSTACK-8993:
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/981#issuecomment-151489464
pinging @wilderrodrigues to have a look
> DHCP fails with "no address available" when an IP is reused
> ---
>
> Key: CLOUDSTACK-8993
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8993
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Joakim Sernbrant
>
> CsDhcp.process() appends new entries to /etc/dhcphosts.txt causing duplicates
> like:
> {code}
> 06:49:14:00:00:4d,10.7.32.107,node1,infinite
> 06:42:b0:00:00:3a,10.7.32.107,node2,infinite
> {code}
> This makes dnsmasq fail with "no address available".
> CsDhcp.process() should repopulate the file to remove old entries with the
> same IP address.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8957) VR password server broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976337#comment-14976337 ] Wilder Rodrigues commented on CLOUDSTACK-8957: -- [~nuxro] [~bhaisaab] [~remibergsma] Is there any integration test that covers this? I'm about to start testing a fix. But, except for looking into the logs, how can I be certain it has been fixed Cheers, Wilder > VR password server broken > - > > Key: CLOUDSTACK-8957 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8957 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Affects Versions: 4.6.0 > Environment: ACS 4.6.0 snapshot, CentOS6 HVs and mgmt >Reporter: Nux >Assignee: Wilder Rodrigues >Priority: Blocker > > Hello, > When deploying instances from password enabled templates, the instances do > not get the generated passwords. > The VR logs show something like this: > 'Oct 15 17:12:27 r-4-VM passwd_server_ip.py: serve_password: requested > password not found for 10.1.1.33' > In /var/cache/cloud the "passwords-10.1.1.1" is empty, but "passwords" is > not, I can see the passwords there. > Symlinking "passwords-10.1.1.1" to "passwords" and restarting the > passwd_server_ip script gets the feature working again, though I am not sure > how correct this approach is. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8990) start a stopped machine on a specific determinable host on UI
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976334#comment-14976334 ] ASF GitHub Bot commented on CLOUDSTACK-8990: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151487786 @borisroman Can you review this again please? > start a stopped machine on a specific determinable host on UI > - > > Key: CLOUDSTACK-8990 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8990 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Minor > > This is already implemented in API ,but not on UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8989) component/test_ps_limits.py can also be run on a "basic" setup
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976290#comment-14976290 ] ASF GitHub Bot commented on CLOUDSTACK-8989: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151476883 @borisroman If you make Jenkins happy, I'll try to run this test as well ;-) > component/test_ps_limits.py can also be run on a "basic" setup > -- > > Key: CLOUDSTACK-8989 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8989 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin, Test >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > The integration test test_ps_limits.py can also be run on a basic setup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8940) Wrong value is inserted into nics table netmask field when creating a VM
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976288#comment-14976288
]
ASF GitHub Bot commented on CLOUDSTACK-8940:
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-151475559
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```
Result:
```
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
EXCEPTION ===
ERROR
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... ===
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName:
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName:
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName:
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status :
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status :
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS
===
ok
Test for port forwarding on source NAT ... === TestName:
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName:
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status :
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status :
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... ===
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status :
FAILED ===
FAIL
FAILED (errors=1, failures=3)
```
The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this
PR. Please try running `test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL`.
Trying again the other failed test:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true component/test_vpc_redundant.py
```
Result:
[jira] [Reopened] (CLOUDSTACK-6812) For storage type which does not support over provisioning ,over provisioning factor should be 1
[ https://issues.apache.org/jira/browse/CLOUDSTACK-6812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sadhu suresh reopened CLOUDSTACK-6812: -- now not allowing to edit over-provisioning factor for non supported types but still over provisioning factor shows 2 instead of 1 so reopening the bug. > For storage type which does not support over provisioning ,over provisioning > factor should be 1 > > > Key: CLOUDSTACK-6812 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6812 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.4.0 >Reporter: prashant kumar mishra >Assignee: Saksham Srivastava > Fix For: 4.4.0 > > > currently over provisioning is supported for only nfs and vmfs ,for storage > type like lvm, iscsi over provisioning is not supported ,default value of > over provisioning factor should be 1 . and it should be non modifiable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8989) component/test_ps_limits.py can also be run on a "basic" setup
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976270#comment-14976270 ] ASF GitHub Bot commented on CLOUDSTACK-8989: Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151467948 Ping @borisroman @remibergsma @karuturi @DaanHoogland This PR LGTM :+1: ``` [root@cs3 integration]# nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone3-kvm3-basic.cfg -s -a tags=basic,required_hardware=false smoke/test_vm_life_cycle.py Marvin Init Started === Marvin Parse Config Successful === === Marvin Setting TestData Successful=== Log Folder Path: /tmp//MarvinLogs//Oct_27_2015_11_21_04_UVR6BU. All logs will be available here === Marvin Init Logging Successful=== Marvin Init Successful === TestName: test_deploy_vm | Status : SUCCESS === === TestName: test_deploy_vm_multiple | Status : SUCCESS === === TestName: test_01_stop_vm | Status : SUCCESS === === TestName: test_02_start_vm | Status : SUCCESS === === TestName: test_03_reboot_vm | Status : SUCCESS === === TestName: test_06_destroy_vm | Status : SUCCESS === === TestName: test_07_restore_vm | Status : SUCCESS === === TestName: test_09_expunge_vm | Status : SUCCESS === ===final results are now copied to: /tmp//MarvinLogs/test_vm_life_cycle_CPQFDY=== ``` Cheers, Wilder > component/test_ps_limits.py can also be run on a "basic" setup > -- > > Key: CLOUDSTACK-8989 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8989 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin, Test >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > The integration test test_ps_limits.py can also be run on a basic setup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8989) component/test_ps_limits.py can also be run on a "basic" setup
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976244#comment-14976244 ] ASF GitHub Bot commented on CLOUDSTACK-8989: Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151460148 Hi @borisroman , I just finish the tests: All looking fine! ``` [root@cs3 integration]# nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone3-kvm3-basic.cfg -s -a tags=basic,required_hardware=false component/test_ps_limits.py Marvin Init Started === Marvin Parse Config Successful === === Marvin Setting TestData Successful=== Log Folder Path: /tmp//MarvinLogs//Oct_27_2015_10_22_08_R41BV1. All logs will be available here === Marvin Init Logging Successful=== Marvin Init Successful === TestName: test_assign_vm_different_account_1_root_domain_admin | Status : SUCCESS === === TestName: test_assign_vm_different_account_2_child_domain_admin | Status : SUCCESS === === TestName: test_attach_detach_volume_1_root_domain_admin | Status : SUCCESS === === TestName: test_attach_detach_volume_2_child_domain_admin | Status : SUCCESS === === TestName: test_create_multiple_volumes_1_root_domain_admin | Status : SUCCESS === === TestName: test_create_multiple_volumes_2_child_domain_admin | Status : SUCCESS === === TestName: test_deploy_multiple_vm_1_root_domain_admin | Status : SUCCESS === === TestName: test_deploy_multiple_vm_2_child_domain_admin | Status : SUCCESS === === TestName: test_stop_start_vm_1_root_domain_admin | Status : SUCCESS === === TestName: test_stop_start_vm_2_child_domain_admin | Status : SUCCESS === ===final results are now copied to: /tmp//MarvinLogs/test_ps_limits_TTWIAZ=== ``` I will also run "test_vm_life_cycle.py". Will let you know once done. Ping @remibergsma @DaanHoogland @karuturi - are anyone of you capable of running/LGTMing this PR? :) Cheers, Wilder > component/test_ps_limits.py can also be run on a "basic" setup > -- > > Key: CLOUDSTACK-8989 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8989 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin, Test >Reporter: Boris Schrijver >Assignee: Boris Schrijver > Fix For: 4.6.0 > > > The integration test test_ps_limits.py can also be run on a basic setup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (CLOUDSTACK-6654) Configkey parameters are not validated
[ https://issues.apache.org/jira/browse/CLOUDSTACK-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sadhu suresh closed CLOUDSTACK-6654. issue verified in the latest build and now showing proper error message. storage.overprovisioning.factor should be greater than or equal to 1 > Configkey parameters are not validated > -- > > Key: CLOUDSTACK-6654 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6654 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.4.0 >Reporter: Saksham Srivastava >Assignee: Saksham Srivastava > Fix For: 4.4.0 > > > There is no validation for the values of ConfigKey variables. So one can give > anything like -5.6 or “pqr” or ‘#*99abc’ as the value of cpu/memory/storage > over-provision factors or any other variables in ConfigKey framework. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8975) [Automation]skip test case if niciraNvp settings are not available in config file
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976215#comment-14976215 ] ASF GitHub Bot commented on CLOUDSTACK-8975: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-151455578 @pvr9711 There are so many things to do for 4.6, do you really want _me_ to send a PR for moving a file? Please send it yourself, and both @miguelaferreira and me will OK it. > [Automation]skip test case if niciraNvp settings are not available in config > file > - > > Key: CLOUDSTACK-8975 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8975 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Affects Versions: 4.7.0 >Reporter: prashant kumar mishra >Assignee: prashant kumar mishra >Priority: Minor > Fix For: 4.7.0 > > > /root/cloudstack/test/integration/smoke/test_nicira_controller.py is > failing if niciraNvp settings are not available in config file. Modifying > script to skip test case if settings are not available > log > === > File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py", > line 46, in setUpClass > cls.nicira_hosts = cls.config.niciraNvp.hosts > AttributeError: 'NoneType' object has no attribute 'hosts' > >> begin captured stdout << - > === TestName: None | Status : EXCEPTION === -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976198#comment-14976198
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104885
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package net.nuage.vsp.acs;
+import net.nuage.vsp.acs.client.NuageVspApiClient;
+import net.nuage.vsp.acs.client.NuageVspElementClient;
+import net.nuage.vsp.acs.client.NuageVspGuruClient;
+import net.nuage.vsp.acs.client.NuageVspManagerClient;
+import net.nuage.vsp.acs.client.NuageVspSyncClient;
+import org.apache.log4j.Logger;
+
+import javax.naming.ConfigurationException;
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLClassLoader;
public class NuageVspPluginClientLoader {
-private static NuageVspPluginClientLoader
nuageVspPluginClientClassloader;
-private ClassLoader loader = null;
+private ClassLoader _loader = null;
+private static final Logger s_logger =
Logger.getLogger(NuageVspPluginClientLoader.class);
+
+private NuageVspApiClient _nuageVspApiClient;
+private NuageVspElementClient _nuageVspElementClient;
+private NuageVspGuruClient _nuageVspGuruClient;
+private NuageVspManagerClient _nuageVspManagerClient;
+private NuageVspSyncClient _nuageVspSyncClient;
+
+private static final String NUAGE_PLUGIN_CLIENT_JAR_FILE =
"/usr/share/nuagevsp/lib/nuage-vsp-acs-client.jar";
+private static final String NUAGE_VSP_API_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspApiClientImpl";
+private static final String NUAGE_VSP_SYNC_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspSyncClientImpl";
+private static final String NUAGE_VSP_ELEMENT_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspElementClientImpl";
+private static final String NUAGE_VSP_GURU_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspGuruClientImpl";
+private static final String NUAGE_VSP_MANAGER_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspManagerClientImpl";
private NuageVspPluginClientLoader(String
nuagePluginClientJarLocation) {
try {
-loader = URLClassLoader.newInstance(new URL[] {new
URL("jar:file:" + nuagePluginClientJarLocation + "!/")},
+_loader = URLClassLoader.newInstance(new URL[] {new
URL("jar:file:" + nuagePluginClientJarLocation + "!/")},
getClass().getClassLoader());
} catch (MalformedURLException e) {
-e.printStackTrace();
+throw new IllegalArgumentException(e);
}
}
-public static ClassLoader getClassLoader(String
nuagePluginClientJarLocation) {
-if (nuageVspPluginClientClassloader == null) {
-nuageVspPluginClientClassloader = new
NuageVspPluginClientLoader(nuagePluginClientJarLocation);
+public static NuageVspPluginClientLoader getClientLoader(String
relativePath, String[] cmsUserInfo, int numRetries, int retryInterval,
+String nuageVspCmsId) throws ConfigurationException {
+NuageVspPluginClientLoader nuageVspPluginClientClassloader = new
NuageVspPluginClientLoader(NUAGE_PLUGIN_CLIENT_JAR_FILE);
+nuageVspPluginClientClassloader.loadClasses(relativePath,
cmsUserInfo, numRetries, retryInterval, nuageVspCmsId);
+return nuageVspPluginClientClassloader;
+}
+
+private void loadClasses(String relativePath, String[] cmsUserInfo,
int numRetries, int retryInterval, String nuageVspCmsId) throws
ConfigurationException {
+try {
+Class nuageVspApiClientClass =
Class.forName(NUAGE_VSP_API_CLIENT_IMPL, true, _loader);
+Class nuageVspSyncClientClass =
Class.forName(NUAGE_VSP_SYNC_CLIENT_IMPL, true, _loader);
+Class nuageVspGuruClientClass =
Class.forName(NUAGE_VSP_GURU_CLIENT_IMPL, true, _loader);
+Class nuageVspElementClientClass =
Class.forName(NUAGE_VSP_ELEMENT_CLIENT_IMPL, true, _loader);
+Class nuageVspManagerClientClass =
Class.forName(NUAGE_VSP_MANAGER_CLIENT_IMPL, true, _loader);
+
+//Instantiate the instances
+_nuageVspApiClient =
(NuageVspApiClient)nuageVspApiClientClass.newInstance();
+_nuageVspApiClient.setNuageVspHost(relativePath, cmsUserInfo,
numRetries, retryInterval, nuageVspCmsId);
+_nuageVspSyncClient =
(NuageVspSyncClient)nuageVspSyncClientClass.newInstance();
+_nuageVs
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976197#comment-14976197
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104880
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package net.nuage.vsp.acs;
+import net.nuage.vsp.acs.client.NuageVspApiClient;
+import net.nuage.vsp.acs.client.NuageVspElementClient;
+import net.nuage.vsp.acs.client.NuageVspGuruClient;
+import net.nuage.vsp.acs.client.NuageVspManagerClient;
+import net.nuage.vsp.acs.client.NuageVspSyncClient;
+import org.apache.log4j.Logger;
+
+import javax.naming.ConfigurationException;
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLClassLoader;
public class NuageVspPluginClientLoader {
-private static NuageVspPluginClientLoader
nuageVspPluginClientClassloader;
-private ClassLoader loader = null;
+private ClassLoader _loader = null;
+private static final Logger s_logger =
Logger.getLogger(NuageVspPluginClientLoader.class);
+
+private NuageVspApiClient _nuageVspApiClient;
+private NuageVspElementClient _nuageVspElementClient;
+private NuageVspGuruClient _nuageVspGuruClient;
+private NuageVspManagerClient _nuageVspManagerClient;
+private NuageVspSyncClient _nuageVspSyncClient;
+
+private static final String NUAGE_PLUGIN_CLIENT_JAR_FILE =
"/usr/share/nuagevsp/lib/nuage-vsp-acs-client.jar";
+private static final String NUAGE_VSP_API_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspApiClientImpl";
+private static final String NUAGE_VSP_SYNC_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspSyncClientImpl";
+private static final String NUAGE_VSP_ELEMENT_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspElementClientImpl";
+private static final String NUAGE_VSP_GURU_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspGuruClientImpl";
+private static final String NUAGE_VSP_MANAGER_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspManagerClientImpl";
private NuageVspPluginClientLoader(String
nuagePluginClientJarLocation) {
try {
-loader = URLClassLoader.newInstance(new URL[] {new
URL("jar:file:" + nuagePluginClientJarLocation + "!/")},
+_loader = URLClassLoader.newInstance(new URL[] {new
URL("jar:file:" + nuagePluginClientJarLocation + "!/")},
getClass().getClassLoader());
} catch (MalformedURLException e) {
-e.printStackTrace();
+throw new IllegalArgumentException(e);
}
}
-public static ClassLoader getClassLoader(String
nuagePluginClientJarLocation) {
-if (nuageVspPluginClientClassloader == null) {
-nuageVspPluginClientClassloader = new
NuageVspPluginClientLoader(nuagePluginClientJarLocation);
+public static NuageVspPluginClientLoader getClientLoader(String
relativePath, String[] cmsUserInfo, int numRetries, int retryInterval,
+String nuageVspCmsId) throws ConfigurationException {
+NuageVspPluginClientLoader nuageVspPluginClientClassloader = new
NuageVspPluginClientLoader(NUAGE_PLUGIN_CLIENT_JAR_FILE);
+nuageVspPluginClientClassloader.loadClasses(relativePath,
cmsUserInfo, numRetries, retryInterval, nuageVspCmsId);
+return nuageVspPluginClientClassloader;
+}
+
+private void loadClasses(String relativePath, String[] cmsUserInfo,
int numRetries, int retryInterval, String nuageVspCmsId) throws
ConfigurationException {
+try {
+Class nuageVspApiClientClass =
Class.forName(NUAGE_VSP_API_CLIENT_IMPL, true, _loader);
+Class nuageVspSyncClientClass =
Class.forName(NUAGE_VSP_SYNC_CLIENT_IMPL, true, _loader);
+Class nuageVspGuruClientClass =
Class.forName(NUAGE_VSP_GURU_CLIENT_IMPL, true, _loader);
+Class nuageVspElementClientClass =
Class.forName(NUAGE_VSP_ELEMENT_CLIENT_IMPL, true, _loader);
+Class nuageVspManagerClientClass =
Class.forName(NUAGE_VSP_MANAGER_CLIENT_IMPL, true, _loader);
+
+//Instantiate the instances
+_nuageVspApiClient =
(NuageVspApiClient)nuageVspApiClientClass.newInstance();
+_nuageVspApiClient.setNuageVspHost(relativePath, cmsUserInfo,
numRetries, retryInterval, nuageVspCmsId);
+_nuageVspSyncClient =
(NuageVspSyncClient)nuageVspSyncClientClass.newInstance();
+_nuageVs
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976196#comment-14976196
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104873
--- Diff:
plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java
---
@@ -19,28 +19,101 @@
package net.nuage.vsp.acs;
+import net.nuage.vsp.acs.client.NuageVspApiClient;
+import net.nuage.vsp.acs.client.NuageVspElementClient;
+import net.nuage.vsp.acs.client.NuageVspGuruClient;
+import net.nuage.vsp.acs.client.NuageVspManagerClient;
+import net.nuage.vsp.acs.client.NuageVspSyncClient;
+import org.apache.log4j.Logger;
+
+import javax.naming.ConfigurationException;
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLClassLoader;
public class NuageVspPluginClientLoader {
-private static NuageVspPluginClientLoader
nuageVspPluginClientClassloader;
-private ClassLoader loader = null;
+private ClassLoader _loader = null;
+private static final Logger s_logger =
Logger.getLogger(NuageVspPluginClientLoader.class);
+
+private NuageVspApiClient _nuageVspApiClient;
+private NuageVspElementClient _nuageVspElementClient;
+private NuageVspGuruClient _nuageVspGuruClient;
+private NuageVspManagerClient _nuageVspManagerClient;
+private NuageVspSyncClient _nuageVspSyncClient;
+
+private static final String NUAGE_PLUGIN_CLIENT_JAR_FILE =
"/usr/share/nuagevsp/lib/nuage-vsp-acs-client.jar";
+private static final String NUAGE_VSP_API_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspApiClientImpl";
+private static final String NUAGE_VSP_SYNC_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspSyncClientImpl";
+private static final String NUAGE_VSP_ELEMENT_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspElementClientImpl";
+private static final String NUAGE_VSP_GURU_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspGuruClientImpl";
+private static final String NUAGE_VSP_MANAGER_CLIENT_IMPL =
"net.nuage.vsp.acs.client.impl.NuageVspManagerClientImpl";
private NuageVspPluginClientLoader(String
nuagePluginClientJarLocation) {
try {
-loader = URLClassLoader.newInstance(new URL[] {new
URL("jar:file:" + nuagePluginClientJarLocation + "!/")},
+_loader = URLClassLoader.newInstance(new URL[] {new
URL("jar:file:" + nuagePluginClientJarLocation + "!/")},
getClass().getClassLoader());
} catch (MalformedURLException e) {
-e.printStackTrace();
+throw new IllegalArgumentException(e);
}
}
-public static ClassLoader getClassLoader(String
nuagePluginClientJarLocation) {
-if (nuageVspPluginClientClassloader == null) {
-nuageVspPluginClientClassloader = new
NuageVspPluginClientLoader(nuagePluginClientJarLocation);
+public static NuageVspPluginClientLoader getClientLoader(String
relativePath, String[] cmsUserInfo, int numRetries, int retryInterval,
+String nuageVspCmsId) throws ConfigurationException {
+NuageVspPluginClientLoader nuageVspPluginClientClassloader = new
NuageVspPluginClientLoader(NUAGE_PLUGIN_CLIENT_JAR_FILE);
+nuageVspPluginClientClassloader.loadClasses(relativePath,
cmsUserInfo, numRetries, retryInterval, nuageVspCmsId);
+return nuageVspPluginClientClassloader;
+}
+
+private void loadClasses(String relativePath, String[] cmsUserInfo,
int numRetries, int retryInterval, String nuageVspCmsId) throws
ConfigurationException {
+try {
+Class nuageVspApiClientClass =
Class.forName(NUAGE_VSP_API_CLIENT_IMPL, true, _loader);
+Class nuageVspSyncClientClass =
Class.forName(NUAGE_VSP_SYNC_CLIENT_IMPL, true, _loader);
+Class nuageVspGuruClientClass =
Class.forName(NUAGE_VSP_GURU_CLIENT_IMPL, true, _loader);
+Class nuageVspElementClientClass =
Class.forName(NUAGE_VSP_ELEMENT_CLIENT_IMPL, true, _loader);
+Class nuageVspManagerClientClass =
Class.forName(NUAGE_VSP_MANAGER_CLIENT_IMPL, true, _loader);
+
+//Instantiate the instances
+_nuageVspApiClient =
(NuageVspApiClient)nuageVspApiClientClass.newInstance();
+_nuageVspApiClient.setNuageVspHost(relativePath, cmsUserInfo,
numRetries, retryInterval, nuageVspCmsId);
+_nuageVspSyncClient =
(NuageVspSyncClient)nuageVspSyncClientClass.newInstance();
+_nuageVs
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976190#comment-14976190
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104632
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -191,36 +188,26 @@ public boolean configure(String name, Map params) throws Configu
return true;
}
-protected void login() throws Exception {
+protected void login() throws ConfigurationException,
ExecutionException {
isNuageVspApiLoaded();
_nuageVspApiClient.login();
}
-protected void loadNuageClient() throws Exception {
+protected void loadNuageClient() {
try {
-ClassLoader loader =
NuageVspPluginClientLoader.getClassLoader(NUAGE_PLUGIN_CLIENT_JAR_FILE);
-
-Class nuageVspApiClientClass =
Class.forName(NUAGE_VSP_API_CLIENT_IMPL, true, loader);
-Class nuageVspSyncClientClass =
Class.forName(NUAGE_VSP_SYNC_CLIENT_IMPL, true, loader);
-Class nuageVspGuruClientClass =
Class.forName(NUAGE_VSP_GURU_CLIENT_IMPL, true, loader);
-Class nuageVspElementClientClass =
Class.forName(NUAGE_VSP_ELEMENT_CLIENT_IMPL, true, loader);
-
-//Instantiate the instances
-_nuageVspApiClient =
(NuageVspApiClient)nuageVspApiClientClass.newInstance();
-_nuageVspApiClient.setNuageVspHost(_relativePath,
_cmsUserInfo, _numRetries, _retryInterval);
-_nuageVspSyncClient =
(NuageVspSyncClient)nuageVspSyncClientClass.newInstance();
-_nuageVspSyncClient.setNuageVspApiClient(_nuageVspApiClient);
-_nuageVspGuruClient =
(NuageVspGuruClient)nuageVspGuruClientClass.newInstance();
-_nuageVspGuruClient.setNuageVspApiClient(_nuageVspApiClient);
-_nuageVspElementClient =
(NuageVspElementClient)nuageVspElementClientClass.newInstance();
-
_nuageVspElementClient.setNuageVspApiClient(_nuageVspApiClient);
+NuageVspPluginClientLoader clientLoader =
NuageVspPluginClientLoader.getClientLoader(_relativePath, _cmsUserInfo,
_numRetries, _retryInterval, _nuageVspCmsId);
+_nuageVspApiClient = clientLoader.getNuageVspApiClient();
+_nuageVspSyncClient = clientLoader.getNuageVspSyncClient();
+_nuageVspGuruClient = clientLoader.getNuageVspGuruClient();
+_nuageVspElementClient =
clientLoader.getNuageVspElementClient();
+_nuageVspManagerClient =
clientLoader.getNuageVspManagerClient();
_isNuageVspClientLoaded = true;
-} catch (Exception e) {
+} catch (ConfigurationException e) {
_isNuageVspClientLoaded = false;
String errorMessage = "Nuage Vsp Plugin client is not yet
installed. Please install NuageVsp plugin client to use NuageVsp plugin in
Cloudstack. ";
s_logger.warn(errorMessage + e.getMessage());
--- End diff --
Done and done.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> --
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976192#comment-14976192 ] ASF GitHub Bot commented on CLOUDSTACK-8746: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151447134 @ustcweizhou Can you add some unit tests for the new methods and classes, thanks > VM Snapshotting implementation for KVM > -- > > Key: CLOUDSTACK-8746 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8746 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou > > Currently it is not supported. > https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976189#comment-14976189
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104591
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -170,20 +169,18 @@ public boolean configure(String name, Map params) throws Configu
throw new ConfigurationException("Unable to find retry
interval");
}
-_relativePath = new
StringBuffer().append("https://";).append(hostname).append(":").append(port).append(apiRelativePath).toString();
+_relativePath = new
StringBuffer().append("https://";).append(_hostName).append(":").append(port).append(apiRelativePath).toString();
String cmsUserPass =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.decodeBase64(cmsUserPassBase64));
_cmsUserInfo = new String[] {CMS_USER_ENTEPRISE_NAME, cmsUser,
cmsUserPass};
-try {
-loadNuageClient();
-} catch (Exception e) {
-throw new CloudRuntimeException("Failed to login to Nuage VSD
on " + name + " as user " + cmsUser, e);
-}
+_nuageVspCmsId = (String)params.get("nuagevspcmsid");
+
+loadNuageClient();
try {
login();
-} catch (Exception e) {
+} catch (ExecutionException | ConfigurationException e) {
s_logger.error("Failed to login to Nuage VSD on " + name + "
as user " + cmsUser + " Exception " + e.getMessage());
--- End diff --
Done.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> --
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976185#comment-14976185
]
ASF GitHub Bot commented on CLOUDSTACK-8746:
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104526
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.snapshot;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseAsyncCreateCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SnapshotResponse;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.PermissionDeniedException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.projects.Project;
+import com.cloud.storage.Snapshot;
+import com.cloud.user.Account;
+import com.cloud.uservm.UserVm;
+import com.cloud.vm.snapshot.VMSnapshot;
+
+@APICommand(name = "createSnapshotFromVMSnapshot", description = "Creates
an instant snapshot of a volume from vm snapshot.", responseObject =
SnapshotResponse.class)
+public class CreateSnapshotFromVMSnapshotCmd extends BaseAsyncCreateCmd {
+public static final Logger s_logger =
Logger.getLogger(CreateSnapshotFromVMSnapshotCmd.class.getName());
+private static final String s_name =
"createsnapshotfromvmsnapshotresponse";
+
+// ///
+// // API parameters /
+// ///
+
+@Parameter(name=ApiConstants.VM_SNAPSHOT_ID, type=CommandType.UUID,
entityType=VMSnapshotResponse.class,
+required=true, description="The ID of the VM snapshot")
+ private Long vmSnapshotId;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "the name of the snapshot")
+private String snapshotName;
+
+private String syncObjectType = BaseAsyncCmd.snapshotHostSyncObject;
+
+// ///
+// / Accessors ///
+// ///
+
+public Long getVMSnapshotId() {
+return vmSnapshotId;
+}
+
+public String getSnapshotName() {
+return snapshotName;
+}
+
+private Long getVmId() {
+VMSnapshot vmsnapshot = _entityMgr.findById(VMSnapshot.class,
getVMSnapshotId());
+if (vmsnapshot == null) {
+throw new InvalidParameterValueException("Unable to find vm
snapshot by id=" + getVMSnapshotId());
+}
+UserVm vm = _entityMgr.findById(UserVm.class,
vmsnapshot.getVmId());
+if (vm == null) {
+throw new InvalidParameterValueException("Unable to find vm by
vm snapshot id=" + getVMSnapshotId());
+}
+return vm.getId();
+}
+private Long getHostId() {
+VMSnapshot vmsnapshot = _entityMgr.findById(VMSnapshot.class,
getVMSnapshotId());
+if (vmsnapshot == null) {
+throw new InvalidParameterValueException("Unable to find vm
snapshot by id=" + getVMSnapshotId());
+}
+
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976184#comment-14976184
]
ASF GitHub Bot commented on CLOUDSTACK-8746:
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104502
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.snapshot;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseAsyncCreateCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SnapshotResponse;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.PermissionDeniedException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.projects.Project;
+import com.cloud.storage.Snapshot;
+import com.cloud.user.Account;
+import com.cloud.uservm.UserVm;
+import com.cloud.vm.snapshot.VMSnapshot;
+
+@APICommand(name = "createSnapshotFromVMSnapshot", description = "Creates
an instant snapshot of a volume from vm snapshot.", responseObject =
SnapshotResponse.class)
+public class CreateSnapshotFromVMSnapshotCmd extends BaseAsyncCreateCmd {
+public static final Logger s_logger =
Logger.getLogger(CreateSnapshotFromVMSnapshotCmd.class.getName());
+private static final String s_name =
"createsnapshotfromvmsnapshotresponse";
+
+// ///
+// // API parameters /
+// ///
+
+@Parameter(name=ApiConstants.VM_SNAPSHOT_ID, type=CommandType.UUID,
entityType=VMSnapshotResponse.class,
+required=true, description="The ID of the VM snapshot")
+ private Long vmSnapshotId;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "the name of the snapshot")
+private String snapshotName;
+
+private String syncObjectType = BaseAsyncCmd.snapshotHostSyncObject;
+
+// ///
+// / Accessors ///
+// ///
+
+public Long getVMSnapshotId() {
+return vmSnapshotId;
+}
+
+public String getSnapshotName() {
+return snapshotName;
+}
+
+private Long getVmId() {
+VMSnapshot vmsnapshot = _entityMgr.findById(VMSnapshot.class,
getVMSnapshotId());
+if (vmsnapshot == null) {
+throw new InvalidParameterValueException("Unable to find vm
snapshot by id=" + getVMSnapshotId());
+}
+UserVm vm = _entityMgr.findById(UserVm.class,
vmsnapshot.getVmId());
+if (vm == null) {
+throw new InvalidParameterValueException("Unable to find vm by
vm snapshot id=" + getVMSnapshotId());
+}
+return vm.getId();
+}
+private Long getHostId() {
+VMSnapshot vmsnapshot = _entityMgr.findById(VMSnapshot.class,
getVMSnapshotId());
+if (vmsnapshot == null) {
+throw new InvalidParameterValueException("Unable to find vm
snapshot by id=" + getVMSnapshotId());
+}
+
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976181#comment-14976181
]
ASF GitHub Bot commented on CLOUDSTACK-8746:
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104400
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.snapshot;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseAsyncCreateCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SnapshotResponse;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.PermissionDeniedException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.projects.Project;
+import com.cloud.storage.Snapshot;
+import com.cloud.user.Account;
+import com.cloud.uservm.UserVm;
+import com.cloud.vm.snapshot.VMSnapshot;
+
+@APICommand(name = "createSnapshotFromVMSnapshot", description = "Creates
an instant snapshot of a volume from vm snapshot.", responseObject =
SnapshotResponse.class)
+public class CreateSnapshotFromVMSnapshotCmd extends BaseAsyncCreateCmd {
+public static final Logger s_logger =
Logger.getLogger(CreateSnapshotFromVMSnapshotCmd.class.getName());
+private static final String s_name =
"createsnapshotfromvmsnapshotresponse";
+
+// ///
+// // API parameters /
+// ///
+
+@Parameter(name=ApiConstants.VM_SNAPSHOT_ID, type=CommandType.UUID,
entityType=VMSnapshotResponse.class,
+required=true, description="The ID of the VM snapshot")
+ private Long vmSnapshotId;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "the name of the snapshot")
+private String snapshotName;
+
+private String syncObjectType = BaseAsyncCmd.snapshotHostSyncObject;
--- End diff --
What's the purpose or use of this?
> VM Snapshotting implementation for KVM
> --
>
> Key: CLOUDSTACK-8746
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8746
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>
> Currently it is not supported.
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976183#comment-14976183
]
ASF GitHub Bot commented on CLOUDSTACK-8746:
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104473
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
---
@@ -0,0 +1,197 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.snapshot;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandJobType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseAsyncCreateCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SnapshotResponse;
+import org.apache.cloudstack.api.response.VMSnapshotResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.PermissionDeniedException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.projects.Project;
+import com.cloud.storage.Snapshot;
+import com.cloud.user.Account;
+import com.cloud.uservm.UserVm;
+import com.cloud.vm.snapshot.VMSnapshot;
+
+@APICommand(name = "createSnapshotFromVMSnapshot", description = "Creates
an instant snapshot of a volume from vm snapshot.", responseObject =
SnapshotResponse.class)
+public class CreateSnapshotFromVMSnapshotCmd extends BaseAsyncCreateCmd {
+public static final Logger s_logger =
Logger.getLogger(CreateSnapshotFromVMSnapshotCmd.class.getName());
+private static final String s_name =
"createsnapshotfromvmsnapshotresponse";
+
+// ///
+// // API parameters /
+// ///
+
+@Parameter(name=ApiConstants.VM_SNAPSHOT_ID, type=CommandType.UUID,
entityType=VMSnapshotResponse.class,
+required=true, description="The ID of the VM snapshot")
+ private Long vmSnapshotId;
+
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "the name of the snapshot")
+private String snapshotName;
+
+private String syncObjectType = BaseAsyncCmd.snapshotHostSyncObject;
+
+// ///
+// / Accessors ///
+// ///
+
+public Long getVMSnapshotId() {
+return vmSnapshotId;
+}
+
+public String getSnapshotName() {
+return snapshotName;
+}
+
+private Long getVmId() {
+VMSnapshot vmsnapshot = _entityMgr.findById(VMSnapshot.class,
getVMSnapshotId());
+if (vmsnapshot == null) {
+throw new InvalidParameterValueException("Unable to find vm
snapshot by id=" + getVMSnapshotId());
+}
+UserVm vm = _entityMgr.findById(UserVm.class,
vmsnapshot.getVmId());
+if (vm == null) {
+throw new InvalidParameterValueException("Unable to find vm by
vm snapshot id=" + getVMSnapshotId());
+}
+return vm.getId();
+}
+private Long getHostId() {
+VMSnapshot vmsnapshot = _entityMgr.findById(VMSnapshot.class,
getVMSnapshotId());
+if (vmsnapshot == null) {
+throw new InvalidParameterValueException("Unable to find vm
snapshot by id=" + getVMSnapshotId());
+}
+
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976178#comment-14976178
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104314
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -112,8 +111,8 @@ public boolean configure(String name, Map params) throws Configu
throw new ConfigurationException("Unable to find zone");
}
-String hostname = (String)params.get("hostname");
-if (hostname == null) {
+_hostName = (String)params.get("hostname");
+if (_hostName == null) {
--- End diff --
Yes, changed for other fields which should not be empty as well.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> --
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976179#comment-14976179 ] ASF GitHub Bot commented on CLOUDSTACK-8746: Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43104351 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,191 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package org.apache.cloudstack.api.command.user.snapshot; + +import org.apache.cloudstack.api.APICommand; +import org.apache.cloudstack.api.ApiCommandJobType; +import org.apache.cloudstack.api.ApiConstants; +import org.apache.cloudstack.api.ApiErrorCode; +import org.apache.cloudstack.api.BaseAsyncCmd; +import org.apache.cloudstack.api.BaseAsyncCreateCmd; +import org.apache.cloudstack.api.Parameter; +import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.api.response.SnapshotResponse; +import org.apache.cloudstack.api.response.VMSnapshotResponse; +import org.apache.cloudstack.context.CallContext; +import org.apache.log4j.Logger; + +import com.cloud.event.EventTypes; +import com.cloud.exception.InvalidParameterValueException; +import com.cloud.exception.PermissionDeniedException; +import com.cloud.exception.ResourceAllocationException; +import com.cloud.projects.Project; +import com.cloud.storage.Snapshot; +import com.cloud.user.Account; +import com.cloud.uservm.UserVm; +import com.cloud.vm.snapshot.VMSnapshot; + +@APICommand(name = "createSnapshotFromVMSnapshot", description = "Creates an instant snapshot of a volume from vm snapshot.", responseObject = SnapshotResponse.class) --- End diff -- Add from version in the @APICommand > VM Snapshotting implementation for KVM > -- > > Key: CLOUDSTACK-8746 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8746 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou > > Currently it is not supported. > https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976175#comment-14976175
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104207
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -348,6 +866,6 @@ public String getConfigComponentName() {
@Override
public ConfigKey[] getConfigKeys() {
-return new ConfigKey[] {NuageVspSyncWorkers,
NuageVspSyncInterval};
+return NUAGE_VSP_CONFIG_KEYS;
--- End diff --
Done.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> --
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976173#comment-14976173
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104184
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuageVspDevice(DeleteNuageVspDeviceCmd cmd) {
return responseList;
}
-@Override
-public boolean configure(String name, Map params)
throws ConfigurationException {
-try {
-initNuageScheduledTasks();
-} catch (Exception ce) {
-s_logger.warn("Failed to load NuageVsp configuration
properties. Check if the NuageVsp properties are configured correctly");
+private void registerNewNuageVspDevice(ConfigurationVO currentConfig,
String registeredNuageVspDevice) {
+if (currentConfig == null) {
+ConfigKey configKey = new
ConfigKey("Advanced", String.class, "nuagevsp.cms.id",
registeredNuageVspDevice,
+": - Do
not edit", false);
+ConfigurationVO configuration = new
ConfigurationVO("management-server", configKey);
+_configDao.persist(configuration);
+} else {
+String newValue;
+String currentValue = currentConfig.getValue();
+if (!Strings.isNullOrEmpty(currentValue)) {
+newValue = currentValue + ";" + registeredNuageVspDevice;
+} else {
+newValue = registeredNuageVspDevice;
+}
+_configDao.update("nuagevsp.cms.id", newValue);
}
-return true;
}
-private void initNuageScheduledTasks() {
-Integer numOfSyncThreads =
Integer.valueOf(_configDao.getValue(NuageVspManager.NuageVspSyncWorkers.key()));
-Integer syncUpIntervalInMinutes =
Integer.valueOf(_configDao.getValue(NuageVspManager.NuageVspSyncInterval.key()));
-
-if (numOfSyncThreads != null && syncUpIntervalInMinutes != null) {
-ThreadFactory threadFactory = new ThreadFactory() {
-public Thread newThread(Runnable runnable) {
-Thread thread = new Thread(runnable, "Nuage Vsp sync
task");
-if (thread.isDaemon())
-thread.setDaemon(false);
-if (thread.getPriority() != Thread.NORM_PRIORITY)
-thread.setPriority(Thread.NORM_PRIORITY);
-return thread;
+private void auditHost(HostVO host) {
+_hostDao.loadDetails(host);
+
+boolean validateDomains = true;
+List nuageVspDevices =
_nuageVspDao.listByHost(host.getId());
+if (!CollectionUtils.isEmpty(nuageVspDevices)) {
+for (NuageVspDeviceVO nuageVspDevice : nuageVspDevices) {
+ConfigurationVO cmsIdConfig =
_configDao.findByName("nuagevsp.cms.id");
+String nuageVspCmsId =
findNuageVspCmsIdForDevice(nuageVspDevice.getId(), cmsIdConfig);
+SyncNuageVspCmsIdCommand syncCmd = new
SyncNuageVspCmsIdCommand(SyncType.AUDIT, nuageVspCmsId);
+SyncNuageVspCmsIdAnswer answer = (SyncNuageVspCmsIdAnswer)
_agentMgr.easySend(nuageVspDevice.getHostId(), syncCmd);
+
+if (answer != null && !answer.getSuccess()) {
+s_logger.error("Nuage VSP Device with ID " +
nuageVspDevice.getId() + " is configured with an unknown CMS ID!");
+validateDomains = false;
+} else if (answer != null && answer.getSyncType() ==
SyncType.REGISTER) {
+registerNewNuageVspDevice(cmsIdConfig,
nuageVspDevice.getId() + ":" + answer.getNuageVspCmsId());
}
-};
-scheduler = Executors.newScheduledThreadPool(numOfSyncThreads,
threadFactory);
-scheduler.scheduleWithFixedDelay(new
NuageVspSyncTask("FLOATING_IP"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes,
-TimeUnit.MILLISECONDS);
-scheduler.scheduleWithFixedDelay(new
NuageVspSyncTask("ENTERPRISE_NTWK_MACRO"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes,
-TimeUnit.MILLISECONDS);
-scheduler
-.scheduleWithFixedDelay(new
NuageVspSyncTask("ENTERPRISE"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes, TimeUnit.MILLISECONDS);
-}
[jira] [Commented] (CLOUDSTACK-8746) VM Snapshotting implementation for KVM
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976174#comment-14976174
]
ASF GitHub Bot commented on CLOUDSTACK-8746:
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/977#discussion_r43104186
--- Diff: ui/scripts/cloudStack.js ---
@@ -22,13 +22,13 @@
var sections = [];
if (isAdmin()) {
-sections = ["dashboard", "instances", "storage",
"network", "templates", "accounts", "domains", "events", "system",
"global-settings", "configuration", "projects", "regions", "affinityGroups"];
+sections = ["dashboard", "instances", "storage",
"network", "templates", "accounts", "domains", "events", "system",
"global-settings", "configuration", "projects", "regions", "affinityGroups",
"vmsnapshots"];
} else if (isDomainAdmin()) {
-sections = ["dashboard", "instances", "storage",
"network", "templates", "accounts", "domains", "events", "projects",
"configuration", "regions", "affinityGroups"];
+sections = ["dashboard", "instances", "storage",
"network", "templates", "accounts", "domains", "events", "projects",
"configuration", "regions", "affinityGroups", "vmsnapshots"];
} else if (g_userProjectsEnabled) {
-sections = ["dashboard", "instances", "storage",
"network", "templates", "accounts", "events", "projects", "regions",
"affinityGroups"];
+sections = ["dashboard", "instances", "storage",
"network", "templates", "accounts", "events", "projects", "regions",
"affinityGroups", "vmsnapshots"];
} else { //normal user
-sections = ["dashboard", "instances", "storage",
"network", "templates", "accounts", "events", "regions", "affinityGroups"];
+sections = ["dashboard", "instances", "storage",
"network", "templates", "accounts", "events", "regions", "affinityGroups",
"vmsnapshots"];
--- End diff --
Add a new section in the storage -> drop down (just like we've volumes and
disk snapshots?) to keep consistency; or break apart Storage tab into two tabs:
volumes and disk snapshots
> VM Snapshotting implementation for KVM
> --
>
> Key: CLOUDSTACK-8746
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8746
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>
> Currently it is not supported.
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976172#comment-14976172
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43104160
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuageVspDevice(DeleteNuageVspDeviceCmd cmd) {
return responseList;
}
-@Override
-public boolean configure(String name, Map params)
throws ConfigurationException {
-try {
-initNuageScheduledTasks();
-} catch (Exception ce) {
-s_logger.warn("Failed to load NuageVsp configuration
properties. Check if the NuageVsp properties are configured correctly");
+private void registerNewNuageVspDevice(ConfigurationVO currentConfig,
String registeredNuageVspDevice) {
+if (currentConfig == null) {
+ConfigKey configKey = new
ConfigKey("Advanced", String.class, "nuagevsp.cms.id",
registeredNuageVspDevice,
+": - Do
not edit", false);
+ConfigurationVO configuration = new
ConfigurationVO("management-server", configKey);
+_configDao.persist(configuration);
+} else {
+String newValue;
+String currentValue = currentConfig.getValue();
+if (!Strings.isNullOrEmpty(currentValue)) {
+newValue = currentValue + ";" + registeredNuageVspDevice;
+} else {
+newValue = registeredNuageVspDevice;
+}
+_configDao.update("nuagevsp.cms.id", newValue);
}
-return true;
}
-private void initNuageScheduledTasks() {
-Integer numOfSyncThreads =
Integer.valueOf(_configDao.getValue(NuageVspManager.NuageVspSyncWorkers.key()));
-Integer syncUpIntervalInMinutes =
Integer.valueOf(_configDao.getValue(NuageVspManager.NuageVspSyncInterval.key()));
-
-if (numOfSyncThreads != null && syncUpIntervalInMinutes != null) {
-ThreadFactory threadFactory = new ThreadFactory() {
-public Thread newThread(Runnable runnable) {
-Thread thread = new Thread(runnable, "Nuage Vsp sync
task");
-if (thread.isDaemon())
-thread.setDaemon(false);
-if (thread.getPriority() != Thread.NORM_PRIORITY)
-thread.setPriority(Thread.NORM_PRIORITY);
-return thread;
+private void auditHost(HostVO host) {
+_hostDao.loadDetails(host);
+
+boolean validateDomains = true;
+List nuageVspDevices =
_nuageVspDao.listByHost(host.getId());
+if (!CollectionUtils.isEmpty(nuageVspDevices)) {
+for (NuageVspDeviceVO nuageVspDevice : nuageVspDevices) {
+ConfigurationVO cmsIdConfig =
_configDao.findByName("nuagevsp.cms.id");
+String nuageVspCmsId =
findNuageVspCmsIdForDevice(nuageVspDevice.getId(), cmsIdConfig);
+SyncNuageVspCmsIdCommand syncCmd = new
SyncNuageVspCmsIdCommand(SyncType.AUDIT, nuageVspCmsId);
+SyncNuageVspCmsIdAnswer answer = (SyncNuageVspCmsIdAnswer)
_agentMgr.easySend(nuageVspDevice.getHostId(), syncCmd);
+
+if (answer != null && !answer.getSuccess()) {
+s_logger.error("Nuage VSP Device with ID " +
nuageVspDevice.getId() + " is configured with an unknown CMS ID!");
+validateDomains = false;
+} else if (answer != null && answer.getSyncType() ==
SyncType.REGISTER) {
+registerNewNuageVspDevice(cmsIdConfig,
nuageVspDevice.getId() + ":" + answer.getNuageVspCmsId());
}
-};
-scheduler = Executors.newScheduledThreadPool(numOfSyncThreads,
threadFactory);
-scheduler.scheduleWithFixedDelay(new
NuageVspSyncTask("FLOATING_IP"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes,
-TimeUnit.MILLISECONDS);
-scheduler.scheduleWithFixedDelay(new
NuageVspSyncTask("ENTERPRISE_NTWK_MACRO"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes,
-TimeUnit.MILLISECONDS);
-scheduler
-.scheduleWithFixedDelay(new
NuageVspSyncTask("ENTERPRISE"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes, TimeUnit.MILLISECONDS);
-}
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976168#comment-14976168
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103718
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuageVspDevice(DeleteNuageVspDeviceCmd cmd) {
return responseList;
}
-@Override
-public boolean configure(String name, Map params)
throws ConfigurationException {
-try {
-initNuageScheduledTasks();
-} catch (Exception ce) {
-s_logger.warn("Failed to load NuageVsp configuration
properties. Check if the NuageVsp properties are configured correctly");
+private void registerNewNuageVspDevice(ConfigurationVO currentConfig,
String registeredNuageVspDevice) {
+if (currentConfig == null) {
+ConfigKey configKey = new
ConfigKey("Advanced", String.class, "nuagevsp.cms.id",
registeredNuageVspDevice,
+": - Do
not edit", false);
+ConfigurationVO configuration = new
ConfigurationVO("management-server", configKey);
+_configDao.persist(configuration);
+} else {
+String newValue;
+String currentValue = currentConfig.getValue();
+if (!Strings.isNullOrEmpty(currentValue)) {
+newValue = currentValue + ";" + registeredNuageVspDevice;
+} else {
+newValue = registeredNuageVspDevice;
+}
+_configDao.update("nuagevsp.cms.id", newValue);
}
-return true;
}
-private void initNuageScheduledTasks() {
-Integer numOfSyncThreads =
Integer.valueOf(_configDao.getValue(NuageVspManager.NuageVspSyncWorkers.key()));
-Integer syncUpIntervalInMinutes =
Integer.valueOf(_configDao.getValue(NuageVspManager.NuageVspSyncInterval.key()));
-
-if (numOfSyncThreads != null && syncUpIntervalInMinutes != null) {
-ThreadFactory threadFactory = new ThreadFactory() {
-public Thread newThread(Runnable runnable) {
-Thread thread = new Thread(runnable, "Nuage Vsp sync
task");
-if (thread.isDaemon())
-thread.setDaemon(false);
-if (thread.getPriority() != Thread.NORM_PRIORITY)
-thread.setPriority(Thread.NORM_PRIORITY);
-return thread;
+private void auditHost(HostVO host) {
+_hostDao.loadDetails(host);
+
+boolean validateDomains = true;
+List nuageVspDevices =
_nuageVspDao.listByHost(host.getId());
+if (!CollectionUtils.isEmpty(nuageVspDevices)) {
+for (NuageVspDeviceVO nuageVspDevice : nuageVspDevices) {
+ConfigurationVO cmsIdConfig =
_configDao.findByName("nuagevsp.cms.id");
+String nuageVspCmsId =
findNuageVspCmsIdForDevice(nuageVspDevice.getId(), cmsIdConfig);
+SyncNuageVspCmsIdCommand syncCmd = new
SyncNuageVspCmsIdCommand(SyncType.AUDIT, nuageVspCmsId);
+SyncNuageVspCmsIdAnswer answer = (SyncNuageVspCmsIdAnswer)
_agentMgr.easySend(nuageVspDevice.getHostId(), syncCmd);
+
+if (answer != null && !answer.getSuccess()) {
+s_logger.error("Nuage VSP Device with ID " +
nuageVspDevice.getId() + " is configured with an unknown CMS ID!");
+validateDomains = false;
+} else if (answer != null && answer.getSyncType() ==
SyncType.REGISTER) {
+registerNewNuageVspDevice(cmsIdConfig,
nuageVspDevice.getId() + ":" + answer.getNuageVspCmsId());
}
-};
-scheduler = Executors.newScheduledThreadPool(numOfSyncThreads,
threadFactory);
-scheduler.scheduleWithFixedDelay(new
NuageVspSyncTask("FLOATING_IP"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes,
-TimeUnit.MILLISECONDS);
-scheduler.scheduleWithFixedDelay(new
NuageVspSyncTask("ENTERPRISE_NTWK_MACRO"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes,
-TimeUnit.MILLISECONDS);
-scheduler
-.scheduleWithFixedDelay(new
NuageVspSyncTask("ENTERPRISE"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes, TimeUnit.MILLISECONDS);
-}
[jira] [Assigned] (CLOUDSTACK-8715) Add support for qemu-guest-agent to libvirt provider
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wido den Hollander reassigned CLOUDSTACK-8715: -- Assignee: Wido den Hollander > Add support for qemu-guest-agent to libvirt provider > > > Key: CLOUDSTACK-8715 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8715 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM >Reporter: Sten Spans >Assignee: Wido den Hollander > Labels: kvm, libvirt, qemu, systemvm > Fix For: Future > > > The qemu guest agent is a newer part of qemu/kvm/libvirt which exposes quite > a lot of useful functionality, which can only be provided by having an agent > on the VM. This includes things like freezing/thawing filesystems (for > backups), reading files on the guest, listing interfaces / ip addresses, etc. > This feature has been requested by users, but is currently not implemented. > http://users.cloudstack.apache.narkive.com/3TTmy3zj/enabling-qemu-guest-agent > The first change needed is to add the following to the XML generated for KVM > virtual machines,: > > > > > This provides the communication channel between libvirt and the agent on the > host. All in all a pretty simple change to LibvirtComputingResource.java / > LibvirtVMDef.java > Secondly the qemu-guest-agent package needs to be added to the systemvm > template. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976161#comment-14976161
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103443
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +529,334 @@ public boolean
deleteNuageVspDevice(DeleteNuageVspDeviceCmd cmd) {
return responseList;
}
-@Override
-public boolean configure(String name, Map params)
throws ConfigurationException {
-try {
-initNuageScheduledTasks();
-} catch (Exception ce) {
-s_logger.warn("Failed to load NuageVsp configuration
properties. Check if the NuageVsp properties are configured correctly");
+private void registerNewNuageVspDevice(ConfigurationVO currentConfig,
String registeredNuageVspDevice) {
+if (currentConfig == null) {
+ConfigKey configKey = new
ConfigKey("Advanced", String.class, "nuagevsp.cms.id",
registeredNuageVspDevice,
+": - Do
not edit", false);
+ConfigurationVO configuration = new
ConfigurationVO("management-server", configKey);
+_configDao.persist(configuration);
+} else {
+String newValue;
+String currentValue = currentConfig.getValue();
+if (!Strings.isNullOrEmpty(currentValue)) {
+newValue = currentValue + ";" + registeredNuageVspDevice;
+} else {
+newValue = registeredNuageVspDevice;
+}
+_configDao.update("nuagevsp.cms.id", newValue);
}
-return true;
}
-private void initNuageScheduledTasks() {
-Integer numOfSyncThreads =
Integer.valueOf(_configDao.getValue(NuageVspManager.NuageVspSyncWorkers.key()));
-Integer syncUpIntervalInMinutes =
Integer.valueOf(_configDao.getValue(NuageVspManager.NuageVspSyncInterval.key()));
-
-if (numOfSyncThreads != null && syncUpIntervalInMinutes != null) {
-ThreadFactory threadFactory = new ThreadFactory() {
-public Thread newThread(Runnable runnable) {
-Thread thread = new Thread(runnable, "Nuage Vsp sync
task");
-if (thread.isDaemon())
-thread.setDaemon(false);
-if (thread.getPriority() != Thread.NORM_PRIORITY)
-thread.setPriority(Thread.NORM_PRIORITY);
-return thread;
+private void auditHost(HostVO host) {
+_hostDao.loadDetails(host);
+
+boolean validateDomains = true;
+List nuageVspDevices =
_nuageVspDao.listByHost(host.getId());
+if (!CollectionUtils.isEmpty(nuageVspDevices)) {
+for (NuageVspDeviceVO nuageVspDevice : nuageVspDevices) {
+ConfigurationVO cmsIdConfig =
_configDao.findByName("nuagevsp.cms.id");
+String nuageVspCmsId =
findNuageVspCmsIdForDevice(nuageVspDevice.getId(), cmsIdConfig);
+SyncNuageVspCmsIdCommand syncCmd = new
SyncNuageVspCmsIdCommand(SyncType.AUDIT, nuageVspCmsId);
+SyncNuageVspCmsIdAnswer answer = (SyncNuageVspCmsIdAnswer)
_agentMgr.easySend(nuageVspDevice.getHostId(), syncCmd);
+
+if (answer != null && !answer.getSuccess()) {
+s_logger.error("Nuage VSP Device with ID " +
nuageVspDevice.getId() + " is configured with an unknown CMS ID!");
+validateDomains = false;
+} else if (answer != null && answer.getSyncType() ==
SyncType.REGISTER) {
+registerNewNuageVspDevice(cmsIdConfig,
nuageVspDevice.getId() + ":" + answer.getNuageVspCmsId());
}
-};
-scheduler = Executors.newScheduledThreadPool(numOfSyncThreads,
threadFactory);
-scheduler.scheduleWithFixedDelay(new
NuageVspSyncTask("FLOATING_IP"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes,
-TimeUnit.MILLISECONDS);
-scheduler.scheduleWithFixedDelay(new
NuageVspSyncTask("ENTERPRISE_NTWK_MACRO"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes,
-TimeUnit.MILLISECONDS);
-scheduler
-.scheduleWithFixedDelay(new
NuageVspSyncTask("ENTERPRISE"), ONE_MINUTE_MULTIPLIER * 15,
ONE_MINUTE_MULTIPLIER * syncUpIntervalInMinutes, TimeUnit.MILLISECONDS);
-}
[jira] [Commented] (CLOUDSTACK-8990) start a stopped machine on a specific determinable host on UI
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976157#comment-14976157 ] ASF GitHub Bot commented on CLOUDSTACK-8990: Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151444216 LGTM Nice feature indeed :) > start a stopped machine on a specific determinable host on UI > - > > Key: CLOUDSTACK-8990 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8990 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Minor > > This is already implemented in API ,but not on UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976159#comment-14976159
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103330
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
addNuageVspDevice(AddNuageVspDeviceCmd cmd) {
throw new CloudRuntimeException("A NuageVsp device is already
configured on this physical network");
}
-Map params = new HashMap();
-params.put("guid", UUID.randomUUID().toString());
-params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
-params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
-params.put("name", "Nuage VSD - " + cmd.getHostName());
-params.put("hostname", cmd.getHostName());
-params.put("cmsuser", cmd.getUserName());
-String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes(Charset.forName("UTF-8";
-params.put("cmsuserpass", cmsUserPasswordBase64);
-int port = cmd.getPort();
-if (0 == port) {
-port = 443;
-}
-params.put("port", String.valueOf(port));
-params.put("apirelativepath", "/nuage/api/" + cmd.getApiVersion());
-params.put("retrycount", String.valueOf(cmd.getApiRetryCount()));
-params.put("retryinterval",
String.valueOf(cmd.getApiRetryInterval()));
+try {
+NuageVspPluginClientLoader clientLoader =
NuageVspPluginClientLoader.getClientLoader(null, null, 1, 1, null);
-Map hostdetails = new HashMap();
-hostdetails.putAll(params);
+Map clientDefaults =
clientLoader.getNuageVspManagerClient().getClientDefaults();
+String apiVersion =
MoreObjects.firstNonNull(cmd.getApiVersion(), (String)
clientDefaults.get("CURRENT_API_VERSION"));
+if
(!clientLoader.getNuageVspManagerClient().isSupportedApiVersion(apiVersion)) {
+throw new CloudRuntimeException("Unsupported API version :
" + apiVersion);
+}
-try {
+Map params = new HashMap();
+params.put("guid", UUID.randomUUID().toString());
+params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
+params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
+params.put("name", "Nuage VSD - " + cmd.getHostName());
+params.put("hostname", cmd.getHostName());
+params.put("cmsuser", cmd.getUserName());
+String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes()));
+params.put("cmsuserpass", cmsUserPasswordBase64);
+int port = cmd.getPort();
+if (0 == port) {
+port = 8443;
+}
+params.put("port", String.valueOf(port));
+params.put("apiversion", apiVersion);
+params.put("apirelativepath", "/nuage/api/" + apiVersion);
+params.put("retrycount",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryCount(),
clientDefaults.get("DEFAULT_API_RETRY_COUNT";
+params.put("retryinterval",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryInterval(),
clientDefaults.get("DEFAULT_API_RETRY_INTERVAL";
+
+final Map hostdetails = new HashMap();
+hostdetails.putAll(params);
resource.configure(cmd.getHostName(), hostdetails);
-final Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
+Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
if (host != null) {
-return Transaction.execute(new
TransactionCallback() {
-@Override
-public NuageVspDeviceVO
doInTransaction(TransactionStatus status) {
-NuageVspDeviceVO nuageVspDevice = new
NuageVspDeviceVO(host.getId(), physicalNetworkId,
ntwkSvcProvider.getProviderName(), deviceName);
-_nuageVspDao.persist(nuageVspDevice);
-
-DetailVO detail = new DetailVO(host.getId(),
"nuagevspdeviceid", String.valueOf(nuageVspDevice.getId()));
-_hostDetail
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976152#comment-14976152
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43103148
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
addNuageVspDevice(AddNuageVspDeviceCmd cmd) {
throw new CloudRuntimeException("A NuageVsp device is already
configured on this physical network");
}
-Map params = new HashMap();
-params.put("guid", UUID.randomUUID().toString());
-params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
-params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
-params.put("name", "Nuage VSD - " + cmd.getHostName());
-params.put("hostname", cmd.getHostName());
-params.put("cmsuser", cmd.getUserName());
-String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes(Charset.forName("UTF-8";
-params.put("cmsuserpass", cmsUserPasswordBase64);
-int port = cmd.getPort();
-if (0 == port) {
-port = 443;
-}
-params.put("port", String.valueOf(port));
-params.put("apirelativepath", "/nuage/api/" + cmd.getApiVersion());
-params.put("retrycount", String.valueOf(cmd.getApiRetryCount()));
-params.put("retryinterval",
String.valueOf(cmd.getApiRetryInterval()));
+try {
+NuageVspPluginClientLoader clientLoader =
NuageVspPluginClientLoader.getClientLoader(null, null, 1, 1, null);
-Map hostdetails = new HashMap();
-hostdetails.putAll(params);
+Map clientDefaults =
clientLoader.getNuageVspManagerClient().getClientDefaults();
+String apiVersion =
MoreObjects.firstNonNull(cmd.getApiVersion(), (String)
clientDefaults.get("CURRENT_API_VERSION"));
+if
(!clientLoader.getNuageVspManagerClient().isSupportedApiVersion(apiVersion)) {
+throw new CloudRuntimeException("Unsupported API version :
" + apiVersion);
+}
-try {
+Map params = new HashMap();
+params.put("guid", UUID.randomUUID().toString());
+params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
+params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
+params.put("name", "Nuage VSD - " + cmd.getHostName());
+params.put("hostname", cmd.getHostName());
+params.put("cmsuser", cmd.getUserName());
+String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes()));
+params.put("cmsuserpass", cmsUserPasswordBase64);
+int port = cmd.getPort();
+if (0 == port) {
+port = 8443;
+}
+params.put("port", String.valueOf(port));
+params.put("apiversion", apiVersion);
+params.put("apirelativepath", "/nuage/api/" + apiVersion);
+params.put("retrycount",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryCount(),
clientDefaults.get("DEFAULT_API_RETRY_COUNT";
+params.put("retryinterval",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryInterval(),
clientDefaults.get("DEFAULT_API_RETRY_INTERVAL";
+
+final Map hostdetails = new HashMap();
+hostdetails.putAll(params);
resource.configure(cmd.getHostName(), hostdetails);
-final Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
+Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
if (host != null) {
-return Transaction.execute(new
TransactionCallback() {
-@Override
-public NuageVspDeviceVO
doInTransaction(TransactionStatus status) {
-NuageVspDeviceVO nuageVspDevice = new
NuageVspDeviceVO(host.getId(), physicalNetworkId,
ntwkSvcProvider.getProviderName(), deviceName);
-_nuageVspDao.persist(nuageVspDevice);
-
-DetailVO detail = new DetailVO(host.getId(),
"nuagevspdeviceid", String.valueOf(nuageVspDevice.getId()));
-_hostDetail
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976146#comment-14976146
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102851
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
addNuageVspDevice(AddNuageVspDeviceCmd cmd) {
throw new CloudRuntimeException("A NuageVsp device is already
configured on this physical network");
}
-Map params = new HashMap();
-params.put("guid", UUID.randomUUID().toString());
-params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
-params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
-params.put("name", "Nuage VSD - " + cmd.getHostName());
-params.put("hostname", cmd.getHostName());
-params.put("cmsuser", cmd.getUserName());
-String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes(Charset.forName("UTF-8";
-params.put("cmsuserpass", cmsUserPasswordBase64);
-int port = cmd.getPort();
-if (0 == port) {
-port = 443;
-}
-params.put("port", String.valueOf(port));
-params.put("apirelativepath", "/nuage/api/" + cmd.getApiVersion());
-params.put("retrycount", String.valueOf(cmd.getApiRetryCount()));
-params.put("retryinterval",
String.valueOf(cmd.getApiRetryInterval()));
+try {
+NuageVspPluginClientLoader clientLoader =
NuageVspPluginClientLoader.getClientLoader(null, null, 1, 1, null);
-Map hostdetails = new HashMap();
-hostdetails.putAll(params);
+Map clientDefaults =
clientLoader.getNuageVspManagerClient().getClientDefaults();
+String apiVersion =
MoreObjects.firstNonNull(cmd.getApiVersion(), (String)
clientDefaults.get("CURRENT_API_VERSION"));
+if
(!clientLoader.getNuageVspManagerClient().isSupportedApiVersion(apiVersion)) {
+throw new CloudRuntimeException("Unsupported API version :
" + apiVersion);
+}
-try {
+Map params = new HashMap();
+params.put("guid", UUID.randomUUID().toString());
+params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
+params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
+params.put("name", "Nuage VSD - " + cmd.getHostName());
+params.put("hostname", cmd.getHostName());
+params.put("cmsuser", cmd.getUserName());
+String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes()));
+params.put("cmsuserpass", cmsUserPasswordBase64);
+int port = cmd.getPort();
+if (0 == port) {
+port = 8443;
+}
+params.put("port", String.valueOf(port));
+params.put("apiversion", apiVersion);
+params.put("apirelativepath", "/nuage/api/" + apiVersion);
+params.put("retrycount",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryCount(),
clientDefaults.get("DEFAULT_API_RETRY_COUNT";
+params.put("retryinterval",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryInterval(),
clientDefaults.get("DEFAULT_API_RETRY_INTERVAL";
+
+final Map hostdetails = new HashMap();
+hostdetails.putAll(params);
resource.configure(cmd.getHostName(), hostdetails);
-final Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
+Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
if (host != null) {
-return Transaction.execute(new
TransactionCallback() {
-@Override
-public NuageVspDeviceVO
doInTransaction(TransactionStatus status) {
-NuageVspDeviceVO nuageVspDevice = new
NuageVspDeviceVO(host.getId(), physicalNetworkId,
ntwkSvcProvider.getProviderName(), deviceName);
-_nuageVspDao.persist(nuageVspDevice);
-
-DetailVO detail = new DetailVO(host.getId(),
"nuagevspdeviceid", String.valueOf(nuageVspDevice.getId()));
-_hostDetail
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976147#comment-14976147
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102867
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
addNuageVspDevice(AddNuageVspDeviceCmd cmd) {
throw new CloudRuntimeException("A NuageVsp device is already
configured on this physical network");
}
-Map params = new HashMap();
-params.put("guid", UUID.randomUUID().toString());
-params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
-params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
-params.put("name", "Nuage VSD - " + cmd.getHostName());
-params.put("hostname", cmd.getHostName());
-params.put("cmsuser", cmd.getUserName());
-String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes(Charset.forName("UTF-8";
-params.put("cmsuserpass", cmsUserPasswordBase64);
-int port = cmd.getPort();
-if (0 == port) {
-port = 443;
-}
-params.put("port", String.valueOf(port));
-params.put("apirelativepath", "/nuage/api/" + cmd.getApiVersion());
-params.put("retrycount", String.valueOf(cmd.getApiRetryCount()));
-params.put("retryinterval",
String.valueOf(cmd.getApiRetryInterval()));
+try {
+NuageVspPluginClientLoader clientLoader =
NuageVspPluginClientLoader.getClientLoader(null, null, 1, 1, null);
-Map hostdetails = new HashMap();
-hostdetails.putAll(params);
+Map clientDefaults =
clientLoader.getNuageVspManagerClient().getClientDefaults();
+String apiVersion =
MoreObjects.firstNonNull(cmd.getApiVersion(), (String)
clientDefaults.get("CURRENT_API_VERSION"));
+if
(!clientLoader.getNuageVspManagerClient().isSupportedApiVersion(apiVersion)) {
+throw new CloudRuntimeException("Unsupported API version :
" + apiVersion);
+}
-try {
+Map params = new HashMap();
+params.put("guid", UUID.randomUUID().toString());
+params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
+params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
+params.put("name", "Nuage VSD - " + cmd.getHostName());
+params.put("hostname", cmd.getHostName());
+params.put("cmsuser", cmd.getUserName());
+String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes()));
+params.put("cmsuserpass", cmsUserPasswordBase64);
+int port = cmd.getPort();
+if (0 == port) {
+port = 8443;
+}
+params.put("port", String.valueOf(port));
+params.put("apiversion", apiVersion);
+params.put("apirelativepath", "/nuage/api/" + apiVersion);
+params.put("retrycount",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryCount(),
clientDefaults.get("DEFAULT_API_RETRY_COUNT";
+params.put("retryinterval",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryInterval(),
clientDefaults.get("DEFAULT_API_RETRY_INTERVAL";
+
+final Map hostdetails = new HashMap();
+hostdetails.putAll(params);
resource.configure(cmd.getHostName(), hostdetails);
-final Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
+Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
if (host != null) {
-return Transaction.execute(new
TransactionCallback() {
-@Override
-public NuageVspDeviceVO
doInTransaction(TransactionStatus status) {
-NuageVspDeviceVO nuageVspDevice = new
NuageVspDeviceVO(host.getId(), physicalNetworkId,
ntwkSvcProvider.getProviderName(), deviceName);
-_nuageVspDao.persist(nuageVspDevice);
-
-DetailVO detail = new DetailVO(host.getId(),
"nuagevspdeviceid", String.valueOf(nuageVspDevice.getId()));
-_hostDetail
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976145#comment-14976145
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102747
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
addNuageVspDevice(AddNuageVspDeviceCmd cmd) {
throw new CloudRuntimeException("A NuageVsp device is already
configured on this physical network");
}
-Map params = new HashMap();
-params.put("guid", UUID.randomUUID().toString());
-params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
-params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
-params.put("name", "Nuage VSD - " + cmd.getHostName());
-params.put("hostname", cmd.getHostName());
-params.put("cmsuser", cmd.getUserName());
-String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes(Charset.forName("UTF-8";
-params.put("cmsuserpass", cmsUserPasswordBase64);
-int port = cmd.getPort();
-if (0 == port) {
-port = 443;
-}
-params.put("port", String.valueOf(port));
-params.put("apirelativepath", "/nuage/api/" + cmd.getApiVersion());
-params.put("retrycount", String.valueOf(cmd.getApiRetryCount()));
-params.put("retryinterval",
String.valueOf(cmd.getApiRetryInterval()));
+try {
+NuageVspPluginClientLoader clientLoader =
NuageVspPluginClientLoader.getClientLoader(null, null, 1, 1, null);
-Map hostdetails = new HashMap();
-hostdetails.putAll(params);
+Map clientDefaults =
clientLoader.getNuageVspManagerClient().getClientDefaults();
+String apiVersion =
MoreObjects.firstNonNull(cmd.getApiVersion(), (String)
clientDefaults.get("CURRENT_API_VERSION"));
+if
(!clientLoader.getNuageVspManagerClient().isSupportedApiVersion(apiVersion)) {
+throw new CloudRuntimeException("Unsupported API version :
" + apiVersion);
+}
-try {
+Map params = new HashMap();
+params.put("guid", UUID.randomUUID().toString());
+params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
+params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
+params.put("name", "Nuage VSD - " + cmd.getHostName());
+params.put("hostname", cmd.getHostName());
+params.put("cmsuser", cmd.getUserName());
+String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes()));
+params.put("cmsuserpass", cmsUserPasswordBase64);
+int port = cmd.getPort();
+if (0 == port) {
+port = 8443;
+}
+params.put("port", String.valueOf(port));
+params.put("apiversion", apiVersion);
+params.put("apirelativepath", "/nuage/api/" + apiVersion);
+params.put("retrycount",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryCount(),
clientDefaults.get("DEFAULT_API_RETRY_COUNT";
+params.put("retryinterval",
String.valueOf(MoreObjects.firstNonNull(cmd.getApiRetryInterval(),
clientDefaults.get("DEFAULT_API_RETRY_INTERVAL";
+
+final Map hostdetails = new HashMap();
+hostdetails.putAll(params);
resource.configure(cmd.getHostName(), hostdetails);
-final Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
+Host host = _resourceMgr.addHost(zoneId, resource,
Host.Type.L2Networking, params);
if (host != null) {
--- End diff --
Done.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> --
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
[jira] [Commented] (CLOUDSTACK-8832) Update Nuage VSP plugin to work with Nuage VSP release 3.2
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976142#comment-14976142
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43102657
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +241,185 @@ public NuageVspDeviceVO
addNuageVspDevice(AddNuageVspDeviceCmd cmd) {
throw new CloudRuntimeException("A NuageVsp device is already
configured on this physical network");
}
-Map params = new HashMap();
-params.put("guid", UUID.randomUUID().toString());
-params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
-params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
-params.put("name", "Nuage VSD - " + cmd.getHostName());
-params.put("hostname", cmd.getHostName());
-params.put("cmsuser", cmd.getUserName());
-String cmsUserPasswordBase64 =
org.apache.commons.codec.binary.StringUtils.newStringUtf8(Base64.encodeBase64(cmd.getPassword().getBytes(Charset.forName("UTF-8";
-params.put("cmsuserpass", cmsUserPasswordBase64);
-int port = cmd.getPort();
-if (0 == port) {
-port = 443;
-}
-params.put("port", String.valueOf(port));
-params.put("apirelativepath", "/nuage/api/" + cmd.getApiVersion());
-params.put("retrycount", String.valueOf(cmd.getApiRetryCount()));
-params.put("retryinterval",
String.valueOf(cmd.getApiRetryInterval()));
+try {
+NuageVspPluginClientLoader clientLoader =
NuageVspPluginClientLoader.getClientLoader(null, null, 1, 1, null);
-Map hostdetails = new HashMap();
-hostdetails.putAll(params);
+Map clientDefaults =
clientLoader.getNuageVspManagerClient().getClientDefaults();
+String apiVersion =
MoreObjects.firstNonNull(cmd.getApiVersion(), (String)
clientDefaults.get("CURRENT_API_VERSION"));
+if
(!clientLoader.getNuageVspManagerClient().isSupportedApiVersion(apiVersion)) {
+throw new CloudRuntimeException("Unsupported API version :
" + apiVersion);
+}
-try {
+Map params = new HashMap();
+params.put("guid", UUID.randomUUID().toString());
+params.put("zoneId",
String.valueOf(physicalNetwork.getDataCenterId()));
+params.put("physicalNetworkId",
String.valueOf(physicalNetwork.getId()));
+params.put("name", "Nuage VSD - " + cmd.getHostName());
--- End diff --
Refactored the whole params approach to be more readable and consistent.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> --
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
