[jira] [Commented] (CLOUDSTACK-8829) Consecutive cold migration fails
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155813#comment-15155813
]
ASF GitHub Bot commented on CLOUDSTACK-8829:
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/797#discussion_r53559299
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1776,19 +1773,26 @@ private void orchestrateStorageMigration(final
String vmUuid, final StoragePool
// If VM was cold migrated between clusters belonging to
two different VMware DCs,
// unregister the VM from the source host and cleanup the
associated VM files.
if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
+Long srcClusterId = null;
+Long srcHostId = vm.getHostId() != null ?
vm.getHostId() : vm.getLastHostId();
+if (srcHostId != null) {
+HostVO srcHost = _hostDao.findById(srcHostId);
--- End diff --
@alexandrelimassantana I don't see any problem with that **if** (line
1778). Both variables (**srcHostId** and **srcClusterId**) are used.
The conditional at the line 1784 uses **srcClusterId**.
The method at line 1793 sends the **UnregisterVMCommand** to a given host
with the **srcHostId**.
> Consecutive cold migration fails
>
>
> Key: CLOUDSTACK-8829
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8829
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Maneesha
>Assignee: Maneesha
>
> The following scenario is broken:
> 1.Deploy VM and stop it
> 2.Migrate stopped VM to a different primary storage pool
> 3.Again migrate the same VM to another/same storage pool. Fails with NPE.
> java.lang.NullPointerException
> at
> com.cloud.vm.VirtualMachineManagerImpl.orchestrateStorageMigration(VirtualMachineManagerImpl.java:1745)
> at
> com.cloud.vm.VirtualMachineManagerImpl.orchestrateStorageMigration(VirtualMachineManagerImpl.java:4716)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
> at
> com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:4723)
> at
> com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:103)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-6928) IOPS throttling setting isn't applied to a dinamically attached volume
[
https://issues.apache.org/jira/browse/CLOUDSTACK-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155741#comment-15155741
]
ASF GitHub Bot commented on CLOUDSTACK-6928:
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1410#discussion_r53556330
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
---
@@ -1006,6 +1006,19 @@ protected synchronized String
attachOrDetachDisk(final Connect conn, final boole
} else if (attachingDisk.getFormat() ==
PhysicalDiskFormat.RAW) {
diskdef.defBlockBasedDisk(attachingDisk.getPath(),
devId, DiskDef.DiskBus.VIRTIO);
}
+
+if ((bytesReadRate != null) && (bytesReadRate > 0)) {
+diskdef.setBytesReadRate(bytesReadRate);
+}
+if ((bytesWriteRate != null) && (bytesWriteRate > 0)) {
+diskdef.setBytesWriteRate(bytesWriteRate);
+}
+if ((iopsReadRate != null) && (iopsReadRate > 0)) {
+diskdef.setIopsReadRate(iopsReadRate);
+}
+if ((iopsWriteRate != null) && (iopsWriteRate > 0)) {
--- End diff --
@ustcweizhou Those conditions coud be done by a method, where the I/O
source (bytesReadRate , bytesWriteRate, iopsReadRate or iopsWriteRate) is
passed as parameter. For example:
`public boolean isIORateNotNullAndBiggerThanZero(Long io) {`
`retun (io != null) && (io > 0);`
`}`
This sugestion could allow a test case, also it makes the code more
readable (in my opinion).
Thanks.
> IOPS throttling setting isn't applied to a dinamically attached volume
> --
>
> Key: CLOUDSTACK-6928
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6928
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: KVM
>Affects Versions: Future, 4.4.0
> Environment: CloudStack 4.4-forward w/ KVM deployment
> Ubuntu Server 14.04
>Reporter: Yoshikazu Nojima
>Assignee: Wei Zhou
>Priority: Critical
> Labels: KVM
>
> IOPS throttling setting is NOT applied to a volume attached while VM is
> running.
> I confirmed the setting is applied to a volume attached while VM is stopped.
> attach volume agent log:
> 2014-06-17 19:07:22,356 DEBUG [cloud.agent.Agent]
> (agentRequest-Handler-3:null) Processing command:
> org.apache.cloudstack.storage.command.AttachCommand
> 2014-06-17 19:07:22,401 DEBUG [kvm.storage.KVMStorageProcessor]
> (agentRequest-Handler-3:null) Attaching device: type='file'>
>
> file='/mnt/ec7a4ea0-a11f-3ab6-89f5-6c2702e3fcf8/e01df6a7-f832-4616-a151-8ad8bcd4cf64'/>
>
>
> start instance agent log:
> 2014-06-17 19:10:47,984 DEBUG [kvm.resource.LibvirtComputingResource]
> (agentRequest-Handler-1:null) starting i-2-3-VM:
> i-2-3-VM
> 8fad689b-d63d-4802-81d9-d11acf91b879
> CentOS 5.5 (64-bit)
>
>
>
>
>
>
>
>
> /usr/bin/kvm-spice
>
>
>
>
>
>
>
>
>
>
>
>
> passwd='987a62e28e4358d8'/>
>
>
> file='/mnt/e70b1e09-b7e8-3f14-8779-cfb75b651119/b1967fe4-6100-4777-8804-26a349ef06ea'/>
>
>
>
>
> file='/mnt/ec7a4ea0-a11f-3ab6-89f5-6c2702e3fcf8/92920d85-1190-43ce-af03-5d2f6a6e1004'/>
>
>
> 200
> 200
>
>
>
>
> file='/mnt/ec7a4ea0-a11f-3ab6-89f5-6c2702e3fcf8/e01df6a7-f832-4616-a151-8ad8bcd4cf64'/>
>
>
> 200
> 200
>
>
>
>
>
>
>
>
>
>
>
>
> 1048576
>
>
>
> 1
>
> hvm
>
>
>
>
> 1000
>
> restart
> destroy
> destroy
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9104) VM naming convention in case vmware is used
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155715#comment-15155715
]
ASF GitHub Bot commented on CLOUDSTACK-9104:
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r53554647
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
return new String[] {datastoreDiskPath};
}
-// Pair
-private Pair composeVmNames(VirtualMachineTO vmSpec) {
-String vmInternalCSName = vmSpec.getName();
-String vmNameOnVcenter = vmSpec.getName();
-if (_instanceNameFlag && vmSpec.getHostName() != null) {
-vmNameOnVcenter = vmSpec.getHostName();
+
+/**
+ * This method gemerate VM name for Vcenter and Cloudstack( when
Hypervisor is VMware).
--- End diff --
Just a little typo in line 2035, "gemerate".
Thanks for taking the time to write the javadoc.
> VM naming convention in case vmware is used
> ---
>
> Key: CLOUDSTACK-9104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9104
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Priyank Parihar
>
> ISSUE
> ==
> VM naming convention in case vmware is used.
> Description
> ==
> User with different account cannot create VMs with the same name, which was
> possible earlier (I am not sure in which CCP version). That time naming
> convention used was like this “I--”
> Currently if vm.instancename.flag is set to true the VM name will be exactly
> as display name given.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (CLOUDSTACK-9293) CloudStack 4.8 on CentOS 6: Unknown API command: addVmwareDc
Arash Shams created CLOUDSTACK-9293: --- Summary: CloudStack 4.8 on CentOS 6: Unknown API command: addVmwareDc Key: CLOUDSTACK-9293 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9293 Project: CloudStack Issue Type: Bug Components: VMware Affects Versions: 4.8.0 Environment: CentOS 6 - Official 4.8 Mirror : https://cloudstack.apache.org/downloads.html Reporter: Arash Shams Hello I installed CloudStack 4.8 from official rpm repository on centos 6 in this url : https://cloudstack.apache.org/downloads.html in adding zone with vmware datacenter creating error appears : Unknown API command: addVmwareDc I searched for this error on jira but cant get a proper answer some of them compile from source some of them not centos and so on . CentOS release 6.7 (Final) vCenter 5.5.0 Server Build 3252642 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
