[jira] [Commented] (CLOUDSTACK-6432) Prevent VR from response to DNS request from outside of network

[Nux (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353747#comment-15353747
 ] 

Nux commented on CLOUDSTACK-6432:
-

Can you make this a proper PR? As it is we're still shipping VRs vulnerable to 
DNS amplification attacks.

Thanks

> Prevent VR from response to DNS request from outside of network
> ---
>
> Key: CLOUDSTACK-6432
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6432
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.4.0, 4.5.0
>Reporter: Sheng Yang
>Assignee: Sheng Yang
> Fix For: 4.4.0, 4.5.0
>
>
> In basic and shared network, VR use private network nic for dhcp/dns 
> services. But if private network is on the internet as well, it would make VR 
> facing outside network.
> We would restrain the VR DNS service inside CloudStack managed network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-6432) Prevent VR from response to DNS request from outside of network

[Nux (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353746#comment-15353746
 ] 

Nux commented on CLOUDSTACK-6432:
-

[~weizhou] that did it, thanks!

> Prevent VR from response to DNS request from outside of network
> ---
>
> Key: CLOUDSTACK-6432
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6432
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.4.0, 4.5.0
>Reporter: Sheng Yang
>Assignee: Sheng Yang
> Fix For: 4.4.0, 4.5.0
>
>
> In basic and shared network, VR use private network nic for dhcp/dns 
> services. But if private network is on the internet as well, it would make VR 
> facing outside network.
> We would restrain the VR DNS service inside CloudStack managed network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9209) Database HA not working on a fresh install on Ubuntu 12.04

[Simon Weller (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353668#comment-15353668
 ] 

Simon Weller commented on CLOUDSTACK-9209:
--

Tom,

This issue is fixed in master (future 4.9).

You can change a couple of config files in your 4.8 install to fix this. Please 
see 
https://github.com/apache/cloudstack/pull/1428/commits/c22659d76d73f00f41c13776c490e17a50aacd20
 for the changes.

- Si



> Database HA not working on a fresh install on Ubuntu 12.04
> --
>
> Key: CLOUDSTACK-9209
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9209
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.7.0
> Environment: Two Ubuntu 12.04 Management Servers, Mysql Master Master 
> Replication, Official community repository: 
> http://cloudstack.apt-get.eu/ubuntu/dists/precise/4.7/
>Reporter: Thomas
>Priority: Blocker
>
> The cloudstack-management service will not come up because of this error:
> 2016-01-05 16:15:00,899 INFO  [c.c.u.d.T.Transaction] (main:null) (logid:) Is 
> Data Base High Availiability enabled? Ans : true
> 2016-01-05 16:15:00,924 INFO  [c.c.u.d.T.Transaction] (main:null) (logid:) 
> The slaves configured for Cloud Data base is/are : 192.168.0.90
> 2016-01-05 16:15:00,974 ERROR [c.c.u.d.Merovingian2] (main:null) (logid:) 
> Unable to get a new db connection
> java.sql.SQLException: Invalid load balancing strategy 
> 'com.cloud.utils.db.StaticStrategy'.
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:934)
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:931)
> at com.mysql.jdbc.Util.loadExtensions(Util.java:588)
> at 
> com.mysql.jdbc.LoadBalancingConnectionProxy.(LoadBalancingConnectionProxy.java:279)
> at 
> com.mysql.jdbc.FailoverConnectionProxy.(FailoverConnectionProxy.java:66)
> at 
> com.mysql.jdbc.NonRegisteringDriver.connectFailover(NonRegisteringDriver.java:382)
> at 
> com.mysql.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:301)
> at java.sql.DriverManager.getConnection(DriverManager.java:571)
> at java.sql.DriverManager.getConnection(DriverManager.java:215)
> at 
> org.apache.commons.dbcp.DriverManagerConnectionFactory.createConnection(DriverManagerConnectionFactory.java:75)
> at 
> org.apache.commons.dbcp.PoolableConnectionFactory.makeObject(PoolableConnectionFactory.java:582)
> at 
> org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:1188)
> at 
> org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106)
> at 
> com.cloud.utils.db.TransactionLegacy.getStandaloneConnectionWithException(TransactionLegacy.java:202)
> at com.cloud.utils.db.Merovingian2.(Merovingian2.java:68)
> at 
> com.cloud.utils.db.Merovingian2.createLockMaster(Merovingian2.java:88)
> at 
> com.cloud.server.LockMasterListener.(LockMasterListener.java:33)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
> at 
> org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:148)
> at 
> org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:121)
> at 
> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:277)
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1077)
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:981)
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:487)
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458)
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:223)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9209) Database HA not working on a fresh install on Ubuntu 12.04

[Tom Wood (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353641#comment-15353641
 ] 

Tom Wood commented on CLOUDSTACK-9209:
--

I get the same error on CloudStack 4.8.0.1 with CentOS 7 and Maria 10.1 setup 
when HA is set to true.  When i set HA to false the bootstrap runs no problem.  
I am installing CloudStack through the offical yum repositories.  Anyway to fix 
this after CloudStack install?

> Database HA not working on a fresh install on Ubuntu 12.04
> --
>
> Key: CLOUDSTACK-9209
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9209
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.7.0
> Environment: Two Ubuntu 12.04 Management Servers, Mysql Master Master 
> Replication, Official community repository: 
> http://cloudstack.apt-get.eu/ubuntu/dists/precise/4.7/
>Reporter: Thomas
>Priority: Blocker
>
> The cloudstack-management service will not come up because of this error:
> 2016-01-05 16:15:00,899 INFO  [c.c.u.d.T.Transaction] (main:null) (logid:) Is 
> Data Base High Availiability enabled? Ans : true
> 2016-01-05 16:15:00,924 INFO  [c.c.u.d.T.Transaction] (main:null) (logid:) 
> The slaves configured for Cloud Data base is/are : 192.168.0.90
> 2016-01-05 16:15:00,974 ERROR [c.c.u.d.Merovingian2] (main:null) (logid:) 
> Unable to get a new db connection
> java.sql.SQLException: Invalid load balancing strategy 
> 'com.cloud.utils.db.StaticStrategy'.
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:934)
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:931)
> at com.mysql.jdbc.Util.loadExtensions(Util.java:588)
> at 
> com.mysql.jdbc.LoadBalancingConnectionProxy.(LoadBalancingConnectionProxy.java:279)
> at 
> com.mysql.jdbc.FailoverConnectionProxy.(FailoverConnectionProxy.java:66)
> at 
> com.mysql.jdbc.NonRegisteringDriver.connectFailover(NonRegisteringDriver.java:382)
> at 
> com.mysql.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:301)
> at java.sql.DriverManager.getConnection(DriverManager.java:571)
> at java.sql.DriverManager.getConnection(DriverManager.java:215)
> at 
> org.apache.commons.dbcp.DriverManagerConnectionFactory.createConnection(DriverManagerConnectionFactory.java:75)
> at 
> org.apache.commons.dbcp.PoolableConnectionFactory.makeObject(PoolableConnectionFactory.java:582)
> at 
> org.apache.commons.pool.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:1188)
> at 
> org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106)
> at 
> com.cloud.utils.db.TransactionLegacy.getStandaloneConnectionWithException(TransactionLegacy.java:202)
> at com.cloud.utils.db.Merovingian2.(Merovingian2.java:68)
> at 
> com.cloud.utils.db.Merovingian2.createLockMaster(Merovingian2.java:88)
> at 
> com.cloud.server.LockMasterListener.(LockMasterListener.java:33)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
> at 
> org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:148)
> at 
> org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:121)
> at 
> org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:277)
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1077)
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:981)
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:487)
> at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458)
> at 
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)
> at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:223)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353375#comment-15353375
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9348:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1549
  
@swill close to two months now. Can you add the mgmt server logs, heap dump 
and any other dumps which can help me fix the issue.
@swill @kiwiflyer Can you please open a JIRA issue where you can put these 
details, without necessary information we cannot find and fix the issue or 
conclude that the issue was caused by something else. I've built latest master 
repository here: http://packages.shapeblue.com/cloudstack/custom/testing
I'll continue this discussion on the ML thread.


> CloudStack Server degrades when a lot of connections on port 8250
> -
>
> Key: CLOUDSTACK-9348
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0
>
>
> An intermittent issue was found with a large CloudStack deployment, where 
> servers could not keep agents connected on port 8250.
> All connections are handled by accept() in NioConnection:
> https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125
> A new connection is handled by accept() which does blocking SSL handshake. A 
> good fix would be to make this non-blocking and handle expensive tasks in 
> separate threads/pool. This way the main IO loop won't be blocked and can 
> continue to serve other agents/clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353263#comment-15353263
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
Good enough.  Thanks...  :)


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353232#comment-15353232
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
@swill. I've fixed the whitespaces and rebased everything. Should be good 
now. 




> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353213#comment-15353213
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1598#discussion_r68779423
  
--- Diff: core/src/com/cloud/storage/template/VhdProcessor.java ---
@@ -91,27 +97,58 @@ public long getVirtualSize(File file) throws 
IOException {
 return file.length();
 }
 
-protected long getTemplateVirtualSize(File file) throws IOException {
+protected long getTemplateVirtualSize(File file) throws 
IOException {
 byte[] currentSize = new byte[8];
+byte[] cookie = new byte[8];
 byte[] creatorApp = new byte[4];
 
-try (FileInputStream strm = new FileInputStream(file)) {
-long skipped = strm.skip(file.length() - vhdFooterSize + 
vhdFooterCreatorAppOffset);
+
+BufferedInputStream fileStream = new BufferedInputStream(new 
FileInputStream(file));
+InputStream strm = fileStream;
+
+boolean isCompressed = checkCompressed(file.getAbsolutePath());
+
+if ( isCompressed ) {
+try {
+strm = new 
CompressorStreamFactory().createCompressorInputStream(fileStream);
+} catch (CompressorException e) {
+s_logger.info("error opening compressed VHD file " + 
file.getName());
+return file.length();
+}
+}
+
+try {
+
--- End diff --

Can you remove the unneeded line break here since I already have another 
change for you to make.  :)  Thx...


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8303) infinite lease times for a Dynamic Host Configuration Protocol should be avoided (like the plague)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353223#comment-15353223
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8303:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1547


> infinite lease times for a Dynamic Host Configuration Protocol should be 
> avoided (like the plague)
> --
>
> Key: CLOUDSTACK-8303
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8303
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Ronald van Zantvoort
>
> The edithosts script in the SystemVM's currently doles out DHCP leases with 
> infinite validity.
> Considering the D in DHCP is for 'Dynamic', and considering it might be 
> useful to change the information in the lease every once in a while (such as 
> resolvers, gateways & searches etc.), it's very bad practice to do this.
> Currently, aside from one very exotic RFC, it's impossible to inform VM's of 
> changing network conditions because they simply won't fetch new leases.
> Please consider changing it to at max 1 week or something, or better: a 
> configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8303) infinite lease times for a Dynamic Host Configuration Protocol should be avoided (like the plague)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353221#comment-15353221
 ] 

ASF subversion and git services commented on CLOUDSTACK-8303:
-

Commit e4ba640a2870f0ed7cd092a1760b2d78e63c6258 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e4ba640 ]

Merge pull request #1547 from PCextreme/vrouter-fixes

Fixes for VirtualRouters in Basic Networking, especially with mutliple ranges 
in VLANsDuring the last few modifications on the SystemVM scripts, it turns out 
quite a lot of stuff broke in our setups.

This PR fixes a number of things:
* Multiple IP's per VLAN interface are now supported & working again, including 
DNS, DHCP ranges, password and metadata services
* `useextdns` fixed (I had a small merge conflict with an attempt to fix this 
at 4.7, but these fixes are more comprehensive)
*  CLOUDSTACK-8303
* Apache configs better in line with best-practices and distro-expected 
locations
* Added a few more helper functions & getters & setters for utility
* some minor cleanup & fixes

* pr/1547:
  Remove /etc/apache2/sites-enabled/000-default in cloud-early-config
  SysVM various fixes to previous refactorings * make CORS include a regular 
glob-matched one * fix NameVirtualHost in CsApp.py as well * even moar cleanups
  SysVM: Cleanup and removal of old (and dangerous) config files * ports.conf * 
default & default-ssl sites * SSL config in httpd.conf * deprecated & dead 
setup_redundant_router in cloud-early-config
  SysVM cloud-early-config: Intermediate fix for SecStore & CORS * Take setup 
from vhost.template rather than default(-ssl)   * should move into Python CS 
code as well * Move CORS setup to separate conf * Modify vhost template to 
Optionally include the cors file * Add NameVirtualHost to vhost template for 
feature parity with ports.conf * Take setup from vhost.template rather than 
default(-ssl)
  VR cloud-early-config: Commonize Apache2 common setup
  VR cloud-early-config: Fix Apache2 alias cleanup
  VR: consistent SSL setup, vhost is not an example, but a template
  VR CsConfig: reintroduce old get_dns() behaviour for redundant non-VPC's
  VR CsAddress fixes: * cleanup imports, * fix to_str(), * improve & fix 
service post_config logic * don't arpPing when there's no gateway
  VR CsApp: Expose config to classes, move vhost confs to proper location, 
allow for multiple IP's per intf, sanitize servername, don't open port 53 if no 
DNS is foreseen
  VR CsConfig: Add is_router(), is_dns(), has_dns(), has_metadata(), 
use_extdns(), fix get_dns() with use_extdns()
  VR CsDhcp: allow multiple ranges & finite lease time (fixes CLOUDSTACK-8303)
  VR CsGuestNetwork obey useextdns
  VR merge.py ipalias fix & dhcpconfig stub notification

Signed-off-by: Will Stevens 


> infinite lease times for a Dynamic Host Configuration Protocol should be 
> avoided (like the plague)
> --
>
> Key: CLOUDSTACK-8303
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8303
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Ronald van Zantvoort
>
> The edithosts script in the SystemVM's currently doles out DHCP leases with 
> infinite validity.
> Considering the D in DHCP is for 'Dynamic', and considering it might be 
> useful to change the information in the lease every once in a while (such as 
> resolvers, gateways & searches etc.), it's very bad practice to do this.
> Currently, aside from one very exotic RFC, it's impossible to inform VM's of 
> changing network conditions because they simply won't fetch new leases.
> Please consider changing it to at max 1 week or something, or better: a 
> configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8303) infinite lease times for a Dynamic Host Configuration Protocol should be avoided (like the plague)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353222#comment-15353222
 ] 

ASF subversion and git services commented on CLOUDSTACK-8303:
-

Commit e4ba640a2870f0ed7cd092a1760b2d78e63c6258 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e4ba640 ]

Merge pull request #1547 from PCextreme/vrouter-fixes

Fixes for VirtualRouters in Basic Networking, especially with mutliple ranges 
in VLANsDuring the last few modifications on the SystemVM scripts, it turns out 
quite a lot of stuff broke in our setups.

This PR fixes a number of things:
* Multiple IP's per VLAN interface are now supported & working again, including 
DNS, DHCP ranges, password and metadata services
* `useextdns` fixed (I had a small merge conflict with an attempt to fix this 
at 4.7, but these fixes are more comprehensive)
*  CLOUDSTACK-8303
* Apache configs better in line with best-practices and distro-expected 
locations
* Added a few more helper functions & getters & setters for utility
* some minor cleanup & fixes

* pr/1547:
  Remove /etc/apache2/sites-enabled/000-default in cloud-early-config
  SysVM various fixes to previous refactorings * make CORS include a regular 
glob-matched one * fix NameVirtualHost in CsApp.py as well * even moar cleanups
  SysVM: Cleanup and removal of old (and dangerous) config files * ports.conf * 
default & default-ssl sites * SSL config in httpd.conf * deprecated & dead 
setup_redundant_router in cloud-early-config
  SysVM cloud-early-config: Intermediate fix for SecStore & CORS * Take setup 
from vhost.template rather than default(-ssl)   * should move into Python CS 
code as well * Move CORS setup to separate conf * Modify vhost template to 
Optionally include the cors file * Add NameVirtualHost to vhost template for 
feature parity with ports.conf * Take setup from vhost.template rather than 
default(-ssl)
  VR cloud-early-config: Commonize Apache2 common setup
  VR cloud-early-config: Fix Apache2 alias cleanup
  VR: consistent SSL setup, vhost is not an example, but a template
  VR CsConfig: reintroduce old get_dns() behaviour for redundant non-VPC's
  VR CsAddress fixes: * cleanup imports, * fix to_str(), * improve & fix 
service post_config logic * don't arpPing when there's no gateway
  VR CsApp: Expose config to classes, move vhost confs to proper location, 
allow for multiple IP's per intf, sanitize servername, don't open port 53 if no 
DNS is foreseen
  VR CsConfig: Add is_router(), is_dns(), has_dns(), has_metadata(), 
use_extdns(), fix get_dns() with use_extdns()
  VR CsDhcp: allow multiple ranges & finite lease time (fixes CLOUDSTACK-8303)
  VR CsGuestNetwork obey useextdns
  VR merge.py ipalias fix & dhcpconfig stub notification

Signed-off-by: Will Stevens 


> infinite lease times for a Dynamic Host Configuration Protocol should be 
> avoided (like the plague)
> --
>
> Key: CLOUDSTACK-8303
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8303
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Reporter: Ronald van Zantvoort
>
> The edithosts script in the SystemVM's currently doles out DHCP leases with 
> infinite validity.
> Considering the D in DHCP is for 'Dynamic', and considering it might be 
> useful to change the information in the lease every once in a while (such as 
> resolvers, gateways & searches etc.), it's very bad practice to do this.
> Currently, aside from one very exotic RFC, it's impossible to inform VM's of 
> changing network conditions because they simply won't fetch new leases.
> Please consider changing it to at max 1 week or something, or better: a 
> configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353219#comment-15353219
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
@syed, can you do a once through and clean up some of the white space 
issues in this diff.  I have highlighted a couple.  The method indent is the 
most important, but there are a few other cases where the white space can be 
cleaned up as well.  Thx...


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353209#comment-15353209
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1598#discussion_r68779079
  
--- Diff: core/src/com/cloud/storage/template/VhdProcessor.java ---
@@ -91,27 +97,58 @@ public long getVirtualSize(File file) throws 
IOException {
 return file.length();
 }
 
-protected long getTemplateVirtualSize(File file) throws IOException {
+protected long getTemplateVirtualSize(File file) throws 
IOException {
--- End diff --

Can you fix the method indentation here.  This should not be indented that 
extra tab.


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353198#comment-15353198
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 458264aac843d4d21500a5f0ab49f8e6a00410cd in cloudstack's branch 
refs/heads/master from [~anshulg]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=458264a ]

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353203#comment-15353203
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 8eedeade750394800a536e8d431f6aade1078277 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8eedead ]

Merge pull request #1596 from anshul1886/CLOUDSTACK-9353

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storageIn turn this also 
fixes VM migration with local storage

This PR is created against 4.7 and can be forward merged to future branches 
also.

* pr/1596:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage

Signed-off-by: Will Stevens 


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9404) Network ACL rules in VPCs are applied in an inverted order

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353199#comment-15353199
 ] 

ASF subversion and git services commented on CLOUDSTACK-9404:
-

Commit 3952e3e83e29fb79fbc409b29255813bd77ee1ac in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3952e3e ]

Merge pull request #1581 from pdube/network-acl-rules-order

CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The 
comparator was inverted.

Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404

In this example, I created rules with the port numbers the same as the rule 
numbers.

Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination
ACCEPT all  --  anywhere 225.0.0.50
ACCEPT all  --  anywhere vrrp.mcast.net
DROP   tcp  --  anywhere anywhere tcp dpt:netstat
DROP   tcp  --  anywhere anywhere tcp dpt:10
DROP   tcp  --  anywhere anywhere tcp dpt:5
DROP   tcp  --  anywhere anywhere tcp dpt:3
DROP   tcp  --  anywhere anywhere tcp dpt:2
DROP   all  --  anywhere anywhere

We can see above that the rules are inverted.

After the fix:

Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination
ACCEPT all  --  anywhere 225.0.0.50
ACCEPT all  --  anywhere vrrp.mcast.net
DROP   tcp  --  anywhere anywhere tcp dpt:2
DROP   tcp  --  anywhere anywhere tcp dpt:3
DROP   tcp  --  anywhere anywhere tcp dpt:5
DROP   tcp  --  anywhere anywhere tcp dpt:10
DROP   tcp  --  anywhere anywhere tcp dpt:netstat
DROP   all  --  anywhere anywhere

* pr/1581:
  Added ASF license to unit test file
  Added unit test to verify ordering
  Fixed ordering of network ACL rules being sent to the VR. The comparator was 
inverted

Signed-off-by: Will Stevens 


> Network ACL rules in VPCs are applied in an inverted order
> --
>
> Key: CLOUDSTACK-9404
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.7.2, 4.8.0, 4.9.0
>Reporter: Patrick D.
>Assignee: Patrick D.
>
> Found the issue in the agent code. The comparator is inverted



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353204#comment-15353204
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 142f07d77f04e8b9a7c3f8b7c6ac5d9b9f079dde in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=142f07d ]

Merge release branch 4.7 to 4.8

* 4.7:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage
  Added ASF license to unit test file
  Added unit test to verify ordering
  Fixed ordering of network ACL rules being sent to the VR. The comparator was 
inverted


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353201#comment-15353201
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 8eedeade750394800a536e8d431f6aade1078277 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8eedead ]

Merge pull request #1596 from anshul1886/CLOUDSTACK-9353

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storageIn turn this also 
fixes VM migration with local storage

This PR is created against 4.7 and can be forward merged to future branches 
also.

* pr/1596:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage

Signed-off-by: Will Stevens 


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353202#comment-15353202
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 8eedeade750394800a536e8d431f6aade1078277 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8eedead ]

Merge pull request #1596 from anshul1886/CLOUDSTACK-9353

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storageIn turn this also 
fixes VM migration with local storage

This PR is created against 4.7 and can be forward merged to future branches 
also.

* pr/1596:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage

Signed-off-by: Will Stevens 


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353205#comment-15353205
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit f7f23ec720b7391cf460f164d8ffbf9a60f79ab8 in cloudstack's branch 
refs/heads/master from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f7f23ec ]

Merge release branch 4.8 to master

* 4.8:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage
  Added ASF license to unit test file
  Added unit test to verify ordering
  Fixed ordering of network ACL rules being sent to the VR. The comparator was 
inverted


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353195#comment-15353195
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 8eedeade750394800a536e8d431f6aade1078277 in cloudstack's branch 
refs/heads/4.8 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8eedead ]

Merge pull request #1596 from anshul1886/CLOUDSTACK-9353

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storageIn turn this also 
fixes VM migration with local storage

This PR is created against 4.7 and can be forward merged to future branches 
also.

* pr/1596:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage

Signed-off-by: Will Stevens 


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353187#comment-15353187
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 8eedeade750394800a536e8d431f6aade1078277 in cloudstack's branch 
refs/heads/4.7 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8eedead ]

Merge pull request #1596 from anshul1886/CLOUDSTACK-9353

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storageIn turn this also 
fixes VM migration with local storage

This PR is created against 4.7 and can be forward merged to future branches 
also.

* pr/1596:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage

Signed-off-by: Will Stevens 


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353188#comment-15353188
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9353:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1596


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353193#comment-15353193
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 8eedeade750394800a536e8d431f6aade1078277 in cloudstack's branch 
refs/heads/4.8 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8eedead ]

Merge pull request #1596 from anshul1886/CLOUDSTACK-9353

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storageIn turn this also 
fixes VM migration with local storage

This PR is created against 4.7 and can be forward merged to future branches 
also.

* pr/1596:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage

Signed-off-by: Will Stevens 


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353190#comment-15353190
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 458264aac843d4d21500a5f0ab49f8e6a00410cd in cloudstack's branch 
refs/heads/4.8 from [~anshulg]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=458264a ]

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353194#comment-15353194
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 8eedeade750394800a536e8d431f6aade1078277 in cloudstack's branch 
refs/heads/4.8 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8eedead ]

Merge pull request #1596 from anshul1886/CLOUDSTACK-9353

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storageIn turn this also 
fixes VM migration with local storage

This PR is created against 4.7 and can be forward merged to future branches 
also.

* pr/1596:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage

Signed-off-by: Will Stevens 


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353196#comment-15353196
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 142f07d77f04e8b9a7c3f8b7c6ac5d9b9f079dde in cloudstack's branch 
refs/heads/4.8 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=142f07d ]

Merge release branch 4.7 to 4.8

* 4.7:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage
  Added ASF license to unit test file
  Added unit test to verify ordering
  Fixed ordering of network ACL rules being sent to the VR. The comparator was 
inverted


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9404) Network ACL rules in VPCs are applied in an inverted order

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353191#comment-15353191
 ] 

ASF subversion and git services commented on CLOUDSTACK-9404:
-

Commit 3952e3e83e29fb79fbc409b29255813bd77ee1ac in cloudstack's branch 
refs/heads/4.8 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3952e3e ]

Merge pull request #1581 from pdube/network-acl-rules-order

CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The 
comparator was inverted.

Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404

In this example, I created rules with the port numbers the same as the rule 
numbers.

Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination
ACCEPT all  --  anywhere 225.0.0.50
ACCEPT all  --  anywhere vrrp.mcast.net
DROP   tcp  --  anywhere anywhere tcp dpt:netstat
DROP   tcp  --  anywhere anywhere tcp dpt:10
DROP   tcp  --  anywhere anywhere tcp dpt:5
DROP   tcp  --  anywhere anywhere tcp dpt:3
DROP   tcp  --  anywhere anywhere tcp dpt:2
DROP   all  --  anywhere anywhere

We can see above that the rules are inverted.

After the fix:

Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination
ACCEPT all  --  anywhere 225.0.0.50
ACCEPT all  --  anywhere vrrp.mcast.net
DROP   tcp  --  anywhere anywhere tcp dpt:2
DROP   tcp  --  anywhere anywhere tcp dpt:3
DROP   tcp  --  anywhere anywhere tcp dpt:5
DROP   tcp  --  anywhere anywhere tcp dpt:10
DROP   tcp  --  anywhere anywhere tcp dpt:netstat
DROP   all  --  anywhere anywhere

* pr/1581:
  Added ASF license to unit test file
  Added unit test to verify ordering
  Fixed ordering of network ACL rules being sent to the VR. The comparator was 
inverted

Signed-off-by: Will Stevens 


> Network ACL rules in VPCs are applied in an inverted order
> --
>
> Key: CLOUDSTACK-9404
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.7.2, 4.8.0, 4.9.0
>Reporter: Patrick D.
>Assignee: Patrick D.
>
> Found the issue in the agent code. The comparator is inverted



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353186#comment-15353186
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 8eedeade750394800a536e8d431f6aade1078277 in cloudstack's branch 
refs/heads/4.7 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8eedead ]

Merge pull request #1596 from anshul1886/CLOUDSTACK-9353

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storageIn turn this also 
fixes VM migration with local storage

This PR is created against 4.7 and can be forward merged to future branches 
also.

* pr/1596:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage

Signed-off-by: Will Stevens 


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353184#comment-15353184
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 458264aac843d4d21500a5f0ab49f8e6a00410cd in cloudstack's branch 
refs/heads/4.7 from [~anshulg]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=458264a ]

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353185#comment-15353185
 ] 

ASF subversion and git services commented on CLOUDSTACK-9353:
-

Commit 8eedeade750394800a536e8d431f6aade1078277 in cloudstack's branch 
refs/heads/4.7 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8eedead ]

Merge pull request #1596 from anshul1886/CLOUDSTACK-9353

CLOUDSTACK-9353: [XenServer] Fixed VM migration with storageIn turn this also 
fixes VM migration with local storage

This PR is created against 4.7 and can be forward merged to future branches 
also.

* pr/1596:
  CLOUDSTACK-9353: [XenServer] Fixed VM migration with storage

Signed-off-by: Will Stevens 


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9404) Network ACL rules in VPCs are applied in an inverted order

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353181#comment-15353181
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9404:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1581


> Network ACL rules in VPCs are applied in an inverted order
> --
>
> Key: CLOUDSTACK-9404
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.7.2, 4.8.0, 4.9.0
>Reporter: Patrick D.
>Assignee: Patrick D.
>
> Found the issue in the agent code. The comparator is inverted



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9404) Network ACL rules in VPCs are applied in an inverted order

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353179#comment-15353179
 ] 

ASF subversion and git services commented on CLOUDSTACK-9404:
-

Commit 3952e3e83e29fb79fbc409b29255813bd77ee1ac in cloudstack's branch 
refs/heads/4.7 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3952e3e ]

Merge pull request #1581 from pdube/network-acl-rules-order

CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The 
comparator was inverted.

Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404

In this example, I created rules with the port numbers the same as the rule 
numbers.

Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination
ACCEPT all  --  anywhere 225.0.0.50
ACCEPT all  --  anywhere vrrp.mcast.net
DROP   tcp  --  anywhere anywhere tcp dpt:netstat
DROP   tcp  --  anywhere anywhere tcp dpt:10
DROP   tcp  --  anywhere anywhere tcp dpt:5
DROP   tcp  --  anywhere anywhere tcp dpt:3
DROP   tcp  --  anywhere anywhere tcp dpt:2
DROP   all  --  anywhere anywhere

We can see above that the rules are inverted.

After the fix:

Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination
ACCEPT all  --  anywhere 225.0.0.50
ACCEPT all  --  anywhere vrrp.mcast.net
DROP   tcp  --  anywhere anywhere tcp dpt:2
DROP   tcp  --  anywhere anywhere tcp dpt:3
DROP   tcp  --  anywhere anywhere tcp dpt:5
DROP   tcp  --  anywhere anywhere tcp dpt:10
DROP   tcp  --  anywhere anywhere tcp dpt:netstat
DROP   all  --  anywhere anywhere

* pr/1581:
  Added ASF license to unit test file
  Added unit test to verify ordering
  Fixed ordering of network ACL rules being sent to the VR. The comparator was 
inverted

Signed-off-by: Will Stevens 


> Network ACL rules in VPCs are applied in an inverted order
> --
>
> Key: CLOUDSTACK-9404
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.7.2, 4.8.0, 4.9.0
>Reporter: Patrick D.
>Assignee: Patrick D.
>
> Found the issue in the agent code. The comparator is inverted



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9404) Network ACL rules in VPCs are applied in an inverted order

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353178#comment-15353178
 ] 

ASF subversion and git services commented on CLOUDSTACK-9404:
-

Commit 3952e3e83e29fb79fbc409b29255813bd77ee1ac in cloudstack's branch 
refs/heads/4.7 from [~williamstev...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3952e3e ]

Merge pull request #1581 from pdube/network-acl-rules-order

CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR. The 
comparator was inverted.

Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404

In this example, I created rules with the port numbers the same as the rule 
numbers.

Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination
ACCEPT all  --  anywhere 225.0.0.50
ACCEPT all  --  anywhere vrrp.mcast.net
DROP   tcp  --  anywhere anywhere tcp dpt:netstat
DROP   tcp  --  anywhere anywhere tcp dpt:10
DROP   tcp  --  anywhere anywhere tcp dpt:5
DROP   tcp  --  anywhere anywhere tcp dpt:3
DROP   tcp  --  anywhere anywhere tcp dpt:2
DROP   all  --  anywhere anywhere

We can see above that the rules are inverted.

After the fix:

Chain ACL_INBOUND_eth2 (1 references)
target prot opt source   destination
ACCEPT all  --  anywhere 225.0.0.50
ACCEPT all  --  anywhere vrrp.mcast.net
DROP   tcp  --  anywhere anywhere tcp dpt:2
DROP   tcp  --  anywhere anywhere tcp dpt:3
DROP   tcp  --  anywhere anywhere tcp dpt:5
DROP   tcp  --  anywhere anywhere tcp dpt:10
DROP   tcp  --  anywhere anywhere tcp dpt:netstat
DROP   all  --  anywhere anywhere

* pr/1581:
  Added ASF license to unit test file
  Added unit test to verify ordering
  Fixed ordering of network ACL rules being sent to the VR. The comparator was 
inverted

Signed-off-by: Will Stevens 


> Network ACL rules in VPCs are applied in an inverted order
> --
>
> Key: CLOUDSTACK-9404
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.7.2, 4.8.0, 4.9.0
>Reporter: Patrick D.
>Assignee: Patrick D.
>
> Found the issue in the agent code. The comparator is inverted



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353146#comment-15353146
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9353:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1596
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 4h 02m 49s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_22_57_23_SVYGMK:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1596/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_22_57_23_SVYGMK/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1596/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_22_57_23_SVYGMK/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1596/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_22_57_23_SVYGMK/runinfo.txt)

**`/tmp/MarvinLogs/test_network_346OKD:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1596/tmp/MarvinLogs/test_network_346OKD/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1596/tmp/MarvinLogs/test_network_346OKD/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1596/tmp/MarvinLogs/test_network_346OKD/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_YO70GO:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1596/tmp/MarvinLogs/test_vpc_routers_YO70GO/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1596/tmp/MarvinLogs/test_vpc_routers_YO70GO/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1596/tmp/MarvinLogs/test_vpc_routers_YO70GO/runinfo.txt)


Uploads will be available until `2016-08-28 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353154#comment-15353154
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  
This is coming back clean.  Since it fixes issues in 4.9, I think it should 
be merged...


> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9353) NullPointerException when migrating VMs with local storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353151#comment-15353151
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9353:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1596
  
Ok, this is coming back clean.  Do you guys agree I should merge this into 
4.9 as it fixes issues?  Thanks...


> NullPointerException when migrating VMs with local storage
> --
>
> Key: CLOUDSTACK-9353
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9353
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.7.1, 4.8.0
> Environment: CloudStack 4.7.1 on CentOS 6.X; XenServer 6.5 with 
> latest patches applied
>Reporter: Dave Garbus
>Priority: Critical
>
> When attempting to live migrate VMs with local storage, the following NPE is 
> received:
> {quote}
> 2016-04-18 12:19:40,264 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) Migration with storage of vm VM[User|i-2-1032-VM] failed. 
> Details: Exception: java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> 2016-04-18 12:19:40,265 ERROR [o.a.c.s.m.XenServerStorageMotionStrategy] 
> (Work-Job-Executor-6:ctx-5f0d0c55 job-214100/job-214101 ctx-a0a3ff72) 
> (logid:f799420c) copy failed
> com.cloud.utils.exception.CloudRuntimeException: Error while migrating the vm 
> VM[User|i-2-1032-VM] to host Host[-41-Routing]. Exception: 
> java.lang.NullPointerException
> Message: null
> Stack: java.lang.NullPointerException
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:86)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xen610.XenServer610MigrateWithStorageCommandWrapper.execute(XenServer610MigrateWithStorageCommandWrapper.java:54)
> at 
> com.cloud.hypervisor.xenserver.resource.wrapper.xenbase.CitrixRequestWrapper.execute(CitrixRequestWrapper.java:122)
> at 
> com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:1676)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)

[jira] [Commented] (CLOUDSTACK-9423) Object storage should get the correct size for compressed templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353149#comment-15353149
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9423:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1598
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 4h 07m 10s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_23_46_56_POC600:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_23_46_56_POC600/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_23_46_56_POC600/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/DeployDataCenter__Jun_27_2016_23_46_56_POC600/runinfo.txt)

**`/tmp/MarvinLogs/test_network_HRWEBW:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_network_HRWEBW/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_network_HRWEBW/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_network_HRWEBW/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_Z3TJCB:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_vpc_routers_Z3TJCB/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_vpc_routers_Z3TJCB/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1598/tmp/MarvinLogs/test_vpc_routers_Z3TJCB/runinfo.txt)


Uploads will be available until `2016-08-28 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



> Object storage should get the correct size for compressed templates
> ---
>
> Key: CLOUDSTACK-9423
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9423
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: syed ahmed
>  Labels: secondary_storage, swift, template
>
> When uploading templates to an object store like Swift, if the template is 
> compressed, we get an invalid size (negative). This fix tries to see if the 
> template is compressed, if so, gets the correct size by partially 
> decompressing the VHD header. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353107#comment-15353107
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9348:


Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1549
  
This was shared in the "4.9/master Testing Coordination" thread.  Simon 
Weller and his team at ENA have run into this on the latest master in both of 
their hardware labs while testing master for me in preparation for the 4.9 RC.

I am still getting the `addHost` issue periodically which showed up a lot 
when this had bigger issues.

I am concerned about this in production to be honest.  How long has this 
been running in production at your client?


> CloudStack Server degrades when a lot of connections on port 8250
> -
>
> Key: CLOUDSTACK-9348
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0
>
>
> An intermittent issue was found with a large CloudStack deployment, where 
> servers could not keep agents connected on port 8250.
> All connections are handled by accept() in NioConnection:
> https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125
> A new connection is handled by accept() which does blocking SSL handshake. A 
> good fix would be to make this non-blocking and handle expensive tasks in 
> separate threads/pool. This way the main IO loop won't be blocked and can 
> continue to serve other agents/clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352522#comment-15352522
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9348:


Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1549#discussion_r68709839
  
--- Diff: utils/src/main/java/com/cloud/utils/nio/NioConnection.java ---
@@ -125,7 +125,7 @@ public boolean isStartup() {
 public Boolean call() throws NioConnectionException {
 while (_isRunning) {
 try {
-_selector.select();
+_selector.select(1000);
--- End diff --

@swill this change ^^ causes the selector loop to never block indefinitely 
but at most 1 second. This ensures that reconnections are fast. If anyone 
experiences the behaviour that tel-netting to port 8250 causes agent to 
reconnect then, either (1) they are not using latest master or (2) they did not 
wait for up to one second (i.e. hit an edge case), in which case we can lower 
this number to 100-500 millisecond at the expense of increasing cpu usage.


> CloudStack Server degrades when a lot of connections on port 8250
> -
>
> Key: CLOUDSTACK-9348
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0
>
>
> An intermittent issue was found with a large CloudStack deployment, where 
> servers could not keep agents connected on port 8250.
> All connections are handled by accept() in NioConnection:
> https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125
> A new connection is handled by accept() which does blocking SSL handshake. A 
> good fix would be to make this non-blocking and handle expensive tasks in 
> separate threads/pool. This way the main IO loop won't be blocked and can 
> continue to serve other agents/clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-9348) CloudStack Server degrades when a lot of connections on port 8250

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352490#comment-15352490
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9348:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1549
  
@swill may I have the mgmt server and agent logs when the failures were 
intercepted. This is to make sure it's not your environment specific issue. 
I'll also need the JRE version in use (openjdk, or oraclejdk, which versions 
specifically?). If possible can you also take a heapdump and share that with me 
(run jmap -dump:file=heap.bin , gzip and scp this bin 
file and please share this somewhere for both mgmt server and agent).

"NIO SSL agent not connecting. when I telnet to 8250, the agent immediately 
came up without me having to restart it." -- this is something which I've fixed 
in latest master (using timeout on selectors), can you ask them if they are 
using latest master?

We've seen this fix deployed in a very large environment with 1000s of 
hosts and I've not heard anything from them. We've not gotten any reported on 
MLs so far, I would appreciate if those people who are experiencing issues can 
share it on public channels. Thanks.


> CloudStack Server degrades when a lot of connections on port 8250
> -
>
> Key: CLOUDSTACK-9348
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: 4.9.0
>
>
> An intermittent issue was found with a large CloudStack deployment, where 
> servers could not keep agents connected on port 8250.
> All connections are handled by accept() in NioConnection:
> https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125
> A new connection is handled by accept() which does blocking SSL handshake. A 
> good fix would be to make this non-blocking and handle expensive tasks in 
> separate threads/pool. This way the main IO loop won't be blocked and can 
> continue to serve other agents/clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)