[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233718#comment-16233718 ] ASF GitHub Bot commented on CLOUDSTACK-10122: - rhtyd commented on issue #2302: CLOUDSTACK-10122: Unrelated error message URL: https://github.com/apache/cloudstack/pull/2302#issuecomment-341006082 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unrelated error message > --- > > Key: CLOUDSTACK-10122 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > > Remove unrelated text "NSX_PLUGIN_LOG" from error message -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233719#comment-16233719 ] ASF GitHub Bot commented on CLOUDSTACK-10122: - blueorangutan commented on issue #2302: CLOUDSTACK-10122: Unrelated error message URL: https://github.com/apache/cloudstack/pull/2302#issuecomment-341006155 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unrelated error message > --- > > Key: CLOUDSTACK-10122 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > > Remove unrelated text "NSX_PLUGIN_LOG" from error message -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233716#comment-16233716 ] ASF GitHub Bot commented on CLOUDSTACK-10122: - blueorangutan commented on issue #2302: CLOUDSTACK-10122: Unrelated error message URL: https://github.com/apache/cloudstack/pull/2302#issuecomment-341005621 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1187 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unrelated error message > --- > > Key: CLOUDSTACK-10122 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > > Remove unrelated text "NSX_PLUGIN_LOG" from error message -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233702#comment-16233702 ] ASF GitHub Bot commented on CLOUDSTACK-10122: - blueorangutan commented on issue #2302: CLOUDSTACK-10122: Unrelated error message URL: https://github.com/apache/cloudstack/pull/2302#issuecomment-341001888 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unrelated error message > --- > > Key: CLOUDSTACK-10122 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > > Remove unrelated text "NSX_PLUGIN_LOG" from error message -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233701#comment-16233701 ] ASF GitHub Bot commented on CLOUDSTACK-10122: - rhtyd commented on issue #2302: CLOUDSTACK-10122: Unrelated error message URL: https://github.com/apache/cloudstack/pull/2302#issuecomment-341001855 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unrelated error message > --- > > Key: CLOUDSTACK-10122 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > > Remove unrelated text "NSX_PLUGIN_LOG" from error message -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10012) Migrate to Embedded Jetty based mgmt server
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233699#comment-16233699 ] ASF GitHub Bot commented on CLOUDSTACK-10012: - rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-341001277 @borisstoyanov thanks, with embedded Jetty until the management server starts the embedded Jetty server does not start to listen on http/https ports which is why you get connection refused quite promptly. Have you also performed in-place upgrade tests, i.e. say upgrading from 4.9.3 to 4.11/fatjar? We can leave reviewing other PRs until this is well tested and merged first. Thanks again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Migrate to Embedded Jetty based mgmt server > --- > > Key: CLOUDSTACK-10012 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10012 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav >Priority: Major > Fix For: Future, 4.11.0.0 > > > CloudStack installation has huge dependency on distro provided tomcat, by > moving to embedded jetty (like we do use jetty for development) we can sync > how developers develop/test mgmt servers and users use it. In addition, it > will be easier to publish pkgs without depending on distro provided > dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CLOUDSTACK-10126) Separate Subnet for CPVM and SSVM
Nicolas Vazquez created CLOUDSTACK-10126: Summary: Separate Subnet for CPVM and SSVM Key: CLOUDSTACK-10126 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10126 Project: CloudStack Issue Type: Improvement Security Level: Public (Anyone can view this level - this is the default.) Affects Versions: 4.11.0.0 Reporter: Nicolas Vazquez Assignee: Nicolas Vazquez Separate Management Subnet for CPVM and SSVM -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9832) Do not assign public IP NIC to the VPC VR when the VPC offering does not contain VpcVirtualRouter as a SourceNat provider
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227314#comment-16227314 ] ASF GitHub Bot commented on CLOUDSTACK-9832: fmaximus commented on issue #2004: CLOUDSTACK-9832: Do not assign public IP NIC to the VPC VR when the VPC offering does not contain VpcVirtualRouter as a SourceNat provider URL: https://github.com/apache/cloudstack/pull/2004#issuecomment-340018338 @remibergsma To summarize: Currently VPN on VR only works if VR is also the gateway/sourcenat provider. So checking on VPN becomes necessary once VR provides VPN, but sourcenat is implemented by another provider. In this case more changes will be necessary to get VPN working, like adding static routes and adding iptables rukes i.c.o. VR not providing Acl. Another point to take into account: for isolated networks a similar check already exists, and that also only checks SourceNat. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Do not assign public IP NIC to the VPC VR when the VPC offering does not > contain VpcVirtualRouter as a SourceNat provider > - > > Key: CLOUDSTACK-9832 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9832 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Reporter: Mani Prashanth Varma Manthena >Assignee: Frank Maximus > Fix For: 4.11.0.0 > > > When the VPC offering does not contain VpcVirtualRouter as a SourceNat > provider, then we will not add the interface in the public network to the > VpcVR. Thus, conserving Public IPs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227171#comment-16227171 ] ASF GitHub Bot commented on CLOUDSTACK-10122: - nvazquez commented on issue #2302: CLOUDSTACK-10122: Unrelated error message URL: https://github.com/apache/cloudstack/pull/2302#issuecomment-340842685 Done. Thanks guys for your input @rhtyd @borisstoyanov @rafaelweingartner @marcaurele @GabrielBrascher This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unrelated error message > --- > > Key: CLOUDSTACK-10122 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > > Remove unrelated text "NSX_PLUGIN_LOG" from error message -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CLOUDSTACK-9751) if a public IP is assigned to a VM when VR is in starting state, it does not get applied to the vport in Nuage VSD
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Maximus updated CLOUDSTACK-9751: -- Fix Version/s: 4.9.3.0 > if a public IP is assigned to a VM when VR is in starting state, it does not > get applied to the vport in Nuage VSD > -- > > Key: CLOUDSTACK-9751 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9751 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.9.0, 4.10.0.0 >Reporter: Raf Smeets >Assignee: Frank Maximus > Fix For: 4.9.3.0 > > > if a public IP is assigned to a VM when VR is in starting state, it does not > get applied to the vport in Nuage VSD. > Steps to reproduce:- > 1) Create a Isolated Network with Dns Network Offering. > 2) Start a vm in it, it will start a VR > 3) At this time accquire a Public IP and enable static nat (assigned it to VM > , Till this time no vport is created for it on the Nuage VSD). No exception > come cloudstack says successfully. > 4) After the VM is in running state, the Public Ip in cloudstack is not > applied to the Nuage VSD. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (CLOUDSTACK-9751) if a public IP is assigned to a VM when VR is in starting state, it does not get applied to the vport in Nuage VSD
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Maximus closed CLOUDSTACK-9751. - > if a public IP is assigned to a VM when VR is in starting state, it does not > get applied to the vport in Nuage VSD > -- > > Key: CLOUDSTACK-9751 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9751 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.9.0, 4.10.0.0 >Reporter: Raf Smeets >Assignee: Frank Maximus > Fix For: 4.9.3.0 > > > if a public IP is assigned to a VM when VR is in starting state, it does not > get applied to the vport in Nuage VSD. > Steps to reproduce:- > 1) Create a Isolated Network with Dns Network Offering. > 2) Start a vm in it, it will start a VR > 3) At this time accquire a Public IP and enable static nat (assigned it to VM > , Till this time no vport is created for it on the Nuage VSD). No exception > come cloudstack says successfully. > 4) After the VM is in running state, the Public Ip in cloudstack is not > applied to the Nuage VSD. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CLOUDSTACK-9751) if a public IP is assigned to a VM when VR is in starting state, it does not get applied to the vport in Nuage VSD
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Maximus resolved CLOUDSTACK-9751. --- Resolution: Fixed > if a public IP is assigned to a VM when VR is in starting state, it does not > get applied to the vport in Nuage VSD > -- > > Key: CLOUDSTACK-9751 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9751 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.9.0, 4.10.0.0 >Reporter: Raf Smeets >Assignee: Frank Maximus > Fix For: 4.9.3.0 > > > if a public IP is assigned to a VM when VR is in starting state, it does not > get applied to the vport in Nuage VSD. > Steps to reproduce:- > 1) Create a Isolated Network with Dns Network Offering. > 2) Start a vm in it, it will start a VR > 3) At this time accquire a Public IP and enable static nat (assigned it to VM > , Till this time no vport is created for it on the Nuage VSD). No exception > come cloudstack says successfully. > 4) After the VM is in running state, the Public Ip in cloudstack is not > applied to the Nuage VSD. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (CLOUDSTACK-10081) CloudUtils getDevInfo function only checks for KVM bridgePort and not OVS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Maximus closed CLOUDSTACK-10081. -- > CloudUtils getDevInfo function only checks for KVM bridgePort and not OVS > - > > Key: CLOUDSTACK-10081 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10081 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 >Reporter: Sigert Goeminne >Assignee: Sigert Goeminne > Fix For: 4.11.0.0 > > > CloudUtils getDevInfo function only checks for KVM bridgePort and not OVS. In > case you provide an ovsbridge, getDevInfo(dev) will say it's a device instead > of a bridge. > h2. Scenario > h3. Expected behaviour > *Given* a KVM Host with openvswitch networking > *and* kvmnetworklabel of the guest traffic type specifying the name of an > existing OVS bridge. > *When* cloudstack-setup-agent is run on the host > *Then* the existing openvswitch bridge is used. > h3. Actual (incorrect) behaviour > A new bridge cloudbr0 is created in openvswitch. > and the networking scripts define the new bridge as OVS_BRIDGE in the ifcfg > of the existing bridge. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CLOUDSTACK-10081) CloudUtils getDevInfo function only checks for KVM bridgePort and not OVS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Maximus resolved CLOUDSTACK-10081. Resolution: Fixed Fix Version/s: 4.11.0.0 > CloudUtils getDevInfo function only checks for KVM bridgePort and not OVS > - > > Key: CLOUDSTACK-10081 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10081 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 >Reporter: Sigert Goeminne >Assignee: Sigert Goeminne > Fix For: 4.11.0.0 > > > CloudUtils getDevInfo function only checks for KVM bridgePort and not OVS. In > case you provide an ovsbridge, getDevInfo(dev) will say it's a device instead > of a bridge. > h2. Scenario > h3. Expected behaviour > *Given* a KVM Host with openvswitch networking > *and* kvmnetworklabel of the guest traffic type specifying the name of an > existing OVS bridge. > *When* cloudstack-setup-agent is run on the host > *Then* the existing openvswitch bridge is used. > h3. Actual (incorrect) behaviour > A new bridge cloudbr0 is created in openvswitch. > and the networking scripts define the new bridge as OVS_BRIDGE in the ifcfg > of the existing bridge. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (CLOUDSTACK-10057) ListNetworkOfferingsCmd does not return the correct count
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Maximus closed CLOUDSTACK-10057. -- > ListNetworkOfferingsCmd does not return the correct count > - > > Key: CLOUDSTACK-10057 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10057 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Affects Versions: 4.11.0.0 >Reporter: Sigert Goeminne >Assignee: Sigert Goeminne > > ListNetworkOfferingsCmd returns a count value which is incorrect (no network > offerings are returned but the count is set to a value higher then 0). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10012) Migrate to Embedded Jetty based mgmt server
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226942#comment-16226942 ] ASF GitHub Bot commented on CLOUDSTACK-10012: - marcaurele commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-340789765 LGTM - thanks @rhtyd for all the extra work This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Migrate to Embedded Jetty based mgmt server > --- > > Key: CLOUDSTACK-10012 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10012 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.11.0.0 > > > CloudStack installation has huge dependency on distro provided tomcat, by > moving to embedded jetty (like we do use jetty for development) we can sync > how developers develop/test mgmt servers and users use it. In addition, it > will be easier to publish pkgs without depending on distro provided > dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9602) Add resource type name in response
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226919#comment-16226919 ] ASF GitHub Bot commented on CLOUDSTACK-9602: marcaurele commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-340786236 @fmaximus comment has been addressed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add resource type name in response > -- > > Key: CLOUDSTACK-9602 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9602 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier > > Output the resource type name along with its id to be more human readable for > all API call returning a resource. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226841#comment-16226841 ] ASF GitHub Bot commented on CLOUDSTACK-10065: - PranaliM commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-340772630 @marcaurele, since this change is related to database queries, a Marvin test will help because the actual result of the db query can be verified. In case of a Unit test case, the db won't be actually queried. So, as per me Marvin test case could be useful in this scenario. Please let me know if you think otherwise. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize SQL queries in listTemplate API to improve performance. > - > > Key: CLOUDSTACK-10065 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Pranali Mande > > *Description*: > The db queries could be optimized to get unique results from the database > which could help in reducing the listTemplate API response time. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226825#comment-16226825
]
ASF GitHub Bot commented on CLOUDSTACK-10065:
-
PranaliM commented on a change in pull request #2260: CLOUDSTACK-10065:
Optimize SQL queries in listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#discussion_r148003324
##
File path: framework/db/src/com/cloud/utils/db/GenericDaoBase.java
##
@@ -1927,6 +1935,54 @@ public Integer getDistinctCount(SearchCriteria sc) {
}
}
+public Integer getDistinctCount(SearchCriteria sc, String[]
distinctColumns) {
+String clause = sc != null ? sc.getWhereClause() : null;
+if (clause != null && clause.length() == 0) {
+clause = null;
+}
+
+final StringBuilder str = createDistinctSelect(sc, clause != null,
distinctColumns);
+if (clause != null) {
+str.append(clause);
+}
+
+Collection>> joins = null;
+if (sc != null) {
+joins = sc.getJoins();
+if (joins != null) {
+addJoins(str, joins);
+}
+}
+
+final TransactionLegacy txn = TransactionLegacy.currentTxn();
+final String sql = "SELECT COUNT(*) FROM (" + str.toString() + ") AS
tmp";
+
+PreparedStatement pstmt = null;
+try {
Review comment:
Refactored to use try-with-resource
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Optimize SQL queries in listTemplate API to improve performance.
> -
>
> Key: CLOUDSTACK-10065
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Pranali Mande
>
> *Description*:
> The db queries could be optimized to get unique results from the database
> which could help in reducing the listTemplate API response time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226826#comment-16226826
]
ASF GitHub Bot commented on CLOUDSTACK-10065:
-
PranaliM commented on a change in pull request #2260: CLOUDSTACK-10065:
Optimize SQL queries in listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#discussion_r148003391
##
File path: framework/db/src/com/cloud/utils/db/SqlGenerator.java
##
@@ -680,4 +680,21 @@ public String buildDistinctIdSql() {
return sql.append("SELECT DISTINCT id FROM
").append(buildTableReferences()).append(" WHERE
").append(buildDiscriminatorClause().first()).toString();
}
+
+public String buildDistinctSql(String[] distinctColumnNames) {
+StringBuilder sbColumn = new StringBuilder();
+
+if(distinctColumnNames != null && distinctColumnNames.length > 0) {
+for (String columnName : distinctColumnNames) {
+sbColumn.append(columnName).append(", ");
+}
+sbColumn.delete(sbColumn.length() - 2, sbColumn.length());
+}
+else{
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Optimize SQL queries in listTemplate API to improve performance.
> -
>
> Key: CLOUDSTACK-10065
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Pranali Mande
>
> *Description*:
> The db queries could be optimized to get unique results from the database
> which could help in reducing the listTemplate API response time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226824#comment-16226824
]
ASF GitHub Bot commented on CLOUDSTACK-10065:
-
PranaliM commented on a change in pull request #2260: CLOUDSTACK-10065:
Optimize SQL queries in listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#discussion_r148003170
##
File path: framework/db/src/com/cloud/utils/db/GenericDaoBase.java
##
@@ -1927,6 +1935,54 @@ public Integer getDistinctCount(SearchCriteria sc) {
}
}
+public Integer getDistinctCount(SearchCriteria sc, String[]
distinctColumns) {
+String clause = sc != null ? sc.getWhereClause() : null;
+if (clause != null && clause.length() == 0) {
Review comment:
Replaced as suggested.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Optimize SQL queries in listTemplate API to improve performance.
> -
>
> Key: CLOUDSTACK-10065
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Pranali Mande
>
> *Description*:
> The db queries could be optimized to get unique results from the database
> which could help in reducing the listTemplate API response time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10012) Migrate to Embedded Jetty based mgmt server
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226822#comment-16226822 ] ASF GitHub Bot commented on CLOUDSTACK-10012: - DaanHoogland commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-340768660 @rhtyd @marcaurele thanks to you both. We might just need a tad more testing but LGTM otherwise This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Migrate to Embedded Jetty based mgmt server > --- > > Key: CLOUDSTACK-10012 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10012 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rohit Yadav >Assignee: Rohit Yadav > Fix For: Future, 4.11.0.0 > > > CloudStack installation has huge dependency on distro provided tomcat, by > moving to embedded jetty (like we do use jetty for development) we can sync > how developers develop/test mgmt servers and users use it. In addition, it > will be easier to publish pkgs without depending on distro provided > dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226815#comment-16226815 ] ASF GitHub Bot commented on CLOUDSTACK-10122: - marcaurele commented on issue #2302: CLOUDSTACK-10122: Unrelated error message URL: https://github.com/apache/cloudstack/pull/2302#issuecomment-340767053 @nvazquez can you change the PR to remove the try/catch block all together? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unrelated error message > --- > > Key: CLOUDSTACK-10122 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez > > Remove unrelated text "NSX_PLUGIN_LOG" from error message -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CLOUDSTACK-10125) Usage Server shows incorrect amount of RAM
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Melnik updated CLOUDSTACK-10125:
-
Description:
I don't know, how to reproduce it, but the usage server reports incorrect
amount of RAM for one of several hundreds VMs: it has 4 GB of RAM, but 8 GB are
being reported:
{noformat}
a4d03771-7267-4281-b615-d5cbae6c6e39
VM-a4d03771-7267-4281-b615-d5cbae6c6e39
VM-a4d03771-7267-4281-b615-d5cbae6c6e39
admin
87417805-cc3c-4244-bdde-ce35d5f83d19
admin
e681b2ae-7d10-44d9-befc-c0facc34cf64
A201***
2017-02-22T15:58:56+0200
Running
false
c8d773fa-76ca-4637-8ecf-88656444fc86
z2.tucha13.net
ed5a7c16-adf3-453a-9238-23c9e2697eb5
h3.c1.p1.z2.tucha13.net
3a8dfd95-96c1-4d86-8365-9645a9ea7996
windows-server-2012-r2-x64-russian
Microsoft Windows Server 2012 R2 x64
Russian
false
5248afa9-f896-4608-bf3b-316262c21b9d
custom-ssd-a1
a7c8489e-214f-41b0-90fc-1a0f5ac537cb
custom-tier-a
2
2499
4096
1.39%
188561
112379
4930471
3153415
4194304
4235640
4194304
231433
128710
b5490e1c-bd31-11e6-b74f-06973a00088a
0
ROOT
29e08f6e-8649-4b1b-bda2-a7872f69485a
e4a97b82-c7c1-420d-b77f-987881064e0b
NET-PUB-193.151.***.0-24
255.255.255.0
193.151.***.***
193.151.***.***
vlan://***
vlan://***
Guest
Shared
true
06:b9:d0***:***:***
KVM
i-1251-386-VM
true
false
168
{noformat}
{noformat}
1
admin
10aa1795-e315-46e7-a09a-3712acb51962
e681b2ae-7d10-44d9-befc-c0facc34cf64
c8d773fa-76ca-4637-8ecf-88656444fc86
VM-a4d03771-7267-4281-b615-d5cbae6c6e39 allocated
(ServiceOffering: 231) (Template: 203)
24 Hrs
2
24
a4d03771-7267-4281-b615-d5cbae6c6e39
VM-a4d03771-7267-4281-b615-d5cbae6c6e39
5248afa9-f896-4608-bf3b-316262c21b9d
3a8dfd95-96c1-4d86-8365-9645a9ea7996
a4d03771-7267-4281-b615-d5cbae6c6e39
KVM
2
2400
8192
2017-10-30'T'00:00:00+00:00
2017-10-30'T'23:59:59+00:00
{noformat}
Are there any data that I could provide with more information that would help
to find and fix the issue? I'd be glad to!
was:
I don't know, how to reproduce it, but the usage server reports incorrect
amount of RAM for one of several hundreds VMs: it has 4 GB of RAM, but 8 GB are
being reported:
{{
a4d03771-7267-4281-b615-d5cbae6c6e39
VM-a4d03771-7267-4281-b615-d5cbae6c6e39
VM-a4d03771-7267-4281-b615-d5cbae6c6e39
admin
87417805-cc3c-4244-bdde-ce35d5f83d19
admin
e681b2ae-7d10-44d9-befc-c0facc34cf64
A201***
2017-02-22T15:58:56+0200
Running
false
c8d773fa-76ca-4637-8ecf-88656444fc86
z2.tucha13.net
ed5a7c16-adf3-453a-9238-23c9e2697eb5
h3.c1.p1.z2.tucha13.net
3a8dfd95-96c1-4d86-8365-9645a9ea7996
windows-server-2012-r2-x64-russian
Microsoft Windows Server 2012 R2 x64
Russian
false
5248afa9-f896-4608-bf3b-316262c21b9d
custom-ssd-a1
a7c8489e-214f-41b0-90fc-1a0f5ac537cb
custom-tier-a
2
2499
4096
1.39%
188561
112379
4930471
3153415
4194304
4235640
4194304
231433
128710
b5490e1c-bd31-11e6-b74f-06973a00088a
0
ROOT
29e08f6e-8649-4b1b-bda2-a7872f69485a
e4a97b82-c7c1-420d-b77f-987881064e0b
NET-PUB-193.151.***.0-24
255.255.255.0
193.151.***.***
193.151.***.***
vlan://***
vlan://***
Guest
Shared
true
06:b9:d0***:***:***
KVM
i-1251-386-VM
true
false
168
}}
{{
1
admin
10aa1795-e315-46e7-a09a-3712acb51962
e681b2ae-7d10-44d9-befc-c0facc34cf64
c8d773fa-76ca-4637-8ecf-88656444fc86
VM-a4d03771-7267-4281-b615-d5cbae6c6e39 allocated
(ServiceOffering: 231) (Template: 203)
24 Hrs
2
24
a4d03771-7267-4281-b615-d5cbae6c6e39
VM-a4d03771-7267-4281-b615-d5cbae6c6e39
5248afa9-f896-4608-bf3b-316262c21b9d
3a8dfd95-96c1-4d86-8365-9645a9ea7996
a4d03771-7267-4281-b615-d5cbae6c6e39
KVM
2
2400
8192
2017-10-30'T'00:00:00+00:00
2017-10-30'T'23:59:59+00:00
}}
Could I provide with more information that would help to find and fix the
issue? I'd be glad to!
> Usage Server shows incorrect amount of RAM
> --
>
> Key: CLOUDSTACK-10125
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10125
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Usage
>Affects Versions: 4.9.0
> Environment: CentOS-6.8-x64
>Reporter: Vladimir Melnik
>Priority: Critical
> Labels: usage
>
> I don't know, how to reproduce it, but the usage server reports incorrect
> amount of RAM for one of several hundreds VMs: it has 4 GB of RAM, but 8 GB
> are being reported:
> {noformat}
>
> a4d03771-7267-4281-b615-d5cbae6c6e39
>
[jira] [Created] (CLOUDSTACK-10125) Usage Server shows incorrect amount of RAM
Vladimir Melnik created CLOUDSTACK-10125:
Summary: Usage Server shows incorrect amount of RAM
Key: CLOUDSTACK-10125
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10125
Project: CloudStack
Issue Type: Bug
Security Level: Public (Anyone can view this level - this is the default.)
Components: Usage
Affects Versions: 4.9.0
Environment: CentOS-6.8-x64
Reporter: Vladimir Melnik
Priority: Critical
I don't know, how to reproduce it, but the usage server reports incorrect
amount of RAM for one of several hundreds VMs: it has 4 GB of RAM, but 8 GB are
being reported:
{{
a4d03771-7267-4281-b615-d5cbae6c6e39
VM-a4d03771-7267-4281-b615-d5cbae6c6e39
VM-a4d03771-7267-4281-b615-d5cbae6c6e39
admin
87417805-cc3c-4244-bdde-ce35d5f83d19
admin
e681b2ae-7d10-44d9-befc-c0facc34cf64
A201***
2017-02-22T15:58:56+0200
Running
false
c8d773fa-76ca-4637-8ecf-88656444fc86
z2.tucha13.net
ed5a7c16-adf3-453a-9238-23c9e2697eb5
h3.c1.p1.z2.tucha13.net
3a8dfd95-96c1-4d86-8365-9645a9ea7996
windows-server-2012-r2-x64-russian
Microsoft Windows Server 2012 R2 x64
Russian
false
5248afa9-f896-4608-bf3b-316262c21b9d
custom-ssd-a1
a7c8489e-214f-41b0-90fc-1a0f5ac537cb
custom-tier-a
2
2499
4096
1.39%
188561
112379
4930471
3153415
4194304
4235640
4194304
231433
128710
b5490e1c-bd31-11e6-b74f-06973a00088a
0
ROOT
29e08f6e-8649-4b1b-bda2-a7872f69485a
e4a97b82-c7c1-420d-b77f-987881064e0b
NET-PUB-193.151.***.0-24
255.255.255.0
193.151.***.***
193.151.***.***
vlan://***
vlan://***
Guest
Shared
true
06:b9:d0***:***:***
KVM
i-1251-386-VM
true
false
168
}}
{{
1
admin
10aa1795-e315-46e7-a09a-3712acb51962
e681b2ae-7d10-44d9-befc-c0facc34cf64
c8d773fa-76ca-4637-8ecf-88656444fc86
VM-a4d03771-7267-4281-b615-d5cbae6c6e39 allocated
(ServiceOffering: 231) (Template: 203)
24 Hrs
2
24
a4d03771-7267-4281-b615-d5cbae6c6e39
VM-a4d03771-7267-4281-b615-d5cbae6c6e39
5248afa9-f896-4608-bf3b-316262c21b9d
3a8dfd95-96c1-4d86-8365-9645a9ea7996
a4d03771-7267-4281-b615-d5cbae6c6e39
KVM
2
2400
8192
2017-10-30'T'00:00:00+00:00
2017-10-30'T'23:59:59+00:00
}}
Could I provide with more information that would help to find and fix the
issue? I'd be glad to!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10051) Mouse Scrolling is not working in instance VM console
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226517#comment-16226517 ] ASF GitHub Bot commented on CLOUDSTACK-10051: - rhtyd commented on a change in pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console URL: https://github.com/apache/cloudstack/pull/2240#discussion_r147935075 ## File path: systemvm/js/jquery.flot.navigate.js ## @@ -0,0 +1,336 @@ +/* Review comment: @vedulasantosh sure, add this new library dependency in maven exclusion list, however, then remove the Apache license unless you authored this library. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Mouse Scrolling is not working in instance VM console > - > > Key: CLOUDSTACK-10051 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10051 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: vedula santosh > > When mouse is scrolled in VM Console it is not working. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10051) Mouse Scrolling is not working in instance VM console
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226515#comment-16226515
]
ASF GitHub Bot commented on CLOUDSTACK-10051:
-
rhtyd commented on a change in pull request #2240: CLOUDSTACK-10051 Mouse
Scrolling is not working in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240#discussion_r147934828
##
File path: systemvm/js/ajaxviewer.js
##
@@ -1230,6 +1230,23 @@ AjaxViewer.prototype = {
e.stopPropagation();
return false;
});
+
+ target.bind('mousewheel DOMMouseScroll',function(e) {
+ if(!ajaxViewer.ptInPanel(e.pageX, e.pageY))
Review comment:
Can you consider adding braces to `if () {}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Mouse Scrolling is not working in instance VM console
> -
>
> Key: CLOUDSTACK-10051
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10051
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: vedula santosh
>
> When mouse is scrolled in VM Console it is not working.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226512#comment-16226512
]
ASF GitHub Bot commented on CLOUDSTACK-10122:
-
rhtyd commented on a change in pull request #2302: CLOUDSTACK-10122: Unrelated
error message
URL: https://github.com/apache/cloudstack/pull/2302#discussion_r147934443
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##
@@ -1423,7 +1423,7 @@ public void prepare(VirtualMachineProfile vm,
DeployDestination dest) throws Sto
}
}
catch (Throwable e){
-s_logger.debug("[NSX_PLUGIN_LOG] ERROR: " +
e.getMessage());
+s_logger.error("ERROR: " + e.getMessage());
Review comment:
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unrelated error message
> ---
>
> Key: CLOUDSTACK-10122
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> Remove unrelated text "NSX_PLUGIN_LOG" from error message
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10051) Mouse Scrolling is not working in instance VM console
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226513#comment-16226513
]
ASF GitHub Bot commented on CLOUDSTACK-10051:
-
rhtyd commented on a change in pull request #2240: CLOUDSTACK-10051 Mouse
Scrolling is not working in instance VM console
URL: https://github.com/apache/cloudstack/pull/2240#discussion_r147934703
##
File path: systemvm/js/ajaxviewer.js
##
@@ -1230,6 +1230,23 @@ AjaxViewer.prototype = {
e.stopPropagation();
return false;
});
+
+ target.bind('mousewheel DOMMouseScroll',function(e) {
+ if(!ajaxViewer.ptInPanel(e.pageX, e.pageY))
+ return true;
+
+ var modifiers = ajaxViewer.getKeyModifiers(e);
+ var sd = e.originalEvent.detail/3;
+
+ var pt = ajaxViewer.pageToPanel(e.clientX, e.clientY);
+
Review comment:
Remove extra newline.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Mouse Scrolling is not working in instance VM console
> -
>
> Key: CLOUDSTACK-10051
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10051
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: vedula santosh
>
> When mouse is scrolled in VM Console it is not working.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10051) Mouse Scrolling is not working in instance VM console
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226518#comment-16226518 ] ASF GitHub Bot commented on CLOUDSTACK-10051: - rhtyd commented on issue #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console URL: https://github.com/apache/cloudstack/pull/2240#issuecomment-340709548 Thanks @vedulasantosh for your PR, since these are purely UI changes we'll need an additional review/LGTM testing that can confirm the UI fix. Regression testing is not strictly required to merge this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Mouse Scrolling is not working in instance VM console > - > > Key: CLOUDSTACK-10051 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10051 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: vedula santosh > > When mouse is scrolled in VM Console it is not working. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10057) ListNetworkOfferingsCmd does not return the correct count
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226508#comment-16226508 ] ASF GitHub Bot commented on CLOUDSTACK-10057: - rhtyd commented on issue #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings. URL: https://github.com/apache/cloudstack/pull/2250#issuecomment-340708220 LGTM, sure @fmaximus @krissterckx we can merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ListNetworkOfferingsCmd does not return the correct count > - > > Key: CLOUDSTACK-10057 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10057 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Affects Versions: 4.11.0.0 >Reporter: Sigert Goeminne >Assignee: Sigert Goeminne > > ListNetworkOfferingsCmd returns a count value which is incorrect (no network > offerings are returned but the count is set to a value higher then 0). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10057) ListNetworkOfferingsCmd does not return the correct count
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226509#comment-16226509
]
ASF GitHub Bot commented on CLOUDSTACK-10057:
-
rhtyd closed pull request #2250: CLOUDSTACK-10057: listNetworkOfferings now
returns the correct number of offerings.
URL: https://github.com/apache/cloudstack/pull/2250
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
index 4dd52632338..6af8723afe3 100755
--- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -4793,7 +4793,7 @@ protected void validateNtwkOffDetails(final Map details, final M
// Now apply pagination
final List wPagination =
StringUtils.applyPagination(supportedOfferings, cmd.getStartIndex(),
cmd.getPageSizeVal());
if (wPagination != null) {
-final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, offerings.size());
+final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, supportedOfferings.size());
return listWPagination;
}
return new Pair,
Integer>(supportedOfferings, supportedOfferings.size());
diff --git a/server/test/com/cloud/configuration/ConfigurationManagerTest.java
b/server/test/com/cloud/configuration/ConfigurationManagerTest.java
index 34f91c4e27c..80c184b0bf9 100644
--- a/server/test/com/cloud/configuration/ConfigurationManagerTest.java
+++ b/server/test/com/cloud/configuration/ConfigurationManagerTest.java
@@ -17,40 +17,34 @@
package com.cloud.configuration;
-import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.anyBoolean;
-import static org.mockito.Matchers.anyInt;
-import static org.mockito.Matchers.anyLong;
-import static org.mockito.Matchers.anyString;
-import static org.mockito.Mockito.doNothing;
-import static org.mockito.Mockito.doThrow;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
import java.lang.reflect.Field;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Random;
import java.util.UUID;
-import com.cloud.user.User;
-import org.apache.cloudstack.engine.subsystem.api.storage.ZoneScope;
-import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
-import org.apache.cloudstack.storage.datastore.db.ImageStoreVO;
import org.apache.log4j.Logger;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
+import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
+
import org.apache.cloudstack.api.command.admin.vlan.DedicatePublicIpRangeCmd;
import org.apache.cloudstack.api.command.admin.vlan.ReleasePublicIpRangeCmd;
+import org.apache.cloudstack.api.command.user.network.ListNetworkOfferingsCmd;
import org.apache.cloudstack.context.CallContext;
import
org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService;
+import org.apache.cloudstack.engine.subsystem.api.storage.ZoneScope;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
+import org.apache.cloudstack.storage.datastore.db.ImageStoreVO;
import com.cloud.configuration.Resource.ResourceType;
import com.cloud.dc.AccountVlanMapVO;
@@ -72,13 +66,17 @@
import com.cloud.host.dao.HostDao;
import com.cloud.network.IpAddressManager;
import com.cloud.network.Network;
-import com.cloud.network.NetworkModel;
import com.cloud.network.Network.Capability;
+import com.cloud.network.NetworkModel;
+import com.cloud.network.Networks;
import com.cloud.network.dao.FirewallRulesDao;
import com.cloud.network.dao.IPAddressDao;
import com.cloud.network.dao.IPAddressVO;
import com.cloud.network.dao.PhysicalNetworkDao;
import com.cloud.network.dao.PhysicalNetworkVO;
+import com.cloud.offering.NetworkOffering;
+import com.cloud.offerings.NetworkOfferingVO;
+import com.cloud.offerings.dao.NetworkOfferingDao;
import com.cloud.projects.ProjectManager;
import com.cloud.storage.VolumeVO;
import com.cloud.storage.dao.VolumeDao;
@@ -86,18 +84,34 @@
import com.cloud.user.AccountManager;
import com.cloud.user.AccountVO;
import com.cloud.user.ResourceLimitService;
+import com.cloud.user.User;
import com.cloud.user.UserVO;
import com.cloud.user.dao.AccountDao;
+import com.clo
[jira] [Commented] (CLOUDSTACK-10057) ListNetworkOfferingsCmd does not return the correct count
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226510#comment-16226510 ] ASF subversion and git services commented on CLOUDSTACK-10057: -- Commit 587b66db71dd417c957f59e80a01e7e08e60be1f in cloudstack's branch refs/heads/master from [~sgoeminn] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=587b66d ] CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings (#2250) Fix paginated response to send correct total resource counts. > ListNetworkOfferingsCmd does not return the correct count > - > > Key: CLOUDSTACK-10057 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10057 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Affects Versions: 4.11.0.0 >Reporter: Sigert Goeminne >Assignee: Sigert Goeminne > > ListNetworkOfferingsCmd returns a count value which is incorrect (no network > offerings are returned but the count is set to a value higher then 0). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10057) ListNetworkOfferingsCmd does not return the correct count
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226507#comment-16226507
]
ASF GitHub Bot commented on CLOUDSTACK-10057:
-
rhtyd commented on a change in pull request #2250: CLOUDSTACK-10057:
listNetworkOfferings now returns the correct number of offerings.
URL: https://github.com/apache/cloudstack/pull/2250#discussion_r147934160
##
File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -4788,7 +4788,7 @@ protected void validateNtwkOffDetails(final Map details, final M
// Now apply pagination
final List wPagination =
StringUtils.applyPagination(supportedOfferings, cmd.getStartIndex(),
cmd.getPageSizeVal());
if (wPagination != null) {
-final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, offerings.size());
+final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, supportedOfferings.size());
Review comment:
@sgoeminn thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ListNetworkOfferingsCmd does not return the correct count
> -
>
> Key: CLOUDSTACK-10057
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10057
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Affects Versions: 4.11.0.0
>Reporter: Sigert Goeminne
>Assignee: Sigert Goeminne
>
> ListNetworkOfferingsCmd returns a count value which is incorrect (no network
> offerings are returned but the count is set to a value higher then 0).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10057) ListNetworkOfferingsCmd does not return the correct count
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226487#comment-16226487
]
ASF GitHub Bot commented on CLOUDSTACK-10057:
-
sgoeminn commented on a change in pull request #2250: CLOUDSTACK-10057:
listNetworkOfferings now returns the correct number of offerings.
URL: https://github.com/apache/cloudstack/pull/2250#discussion_r147928964
##
File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -4788,7 +4788,7 @@ protected void validateNtwkOffDetails(final Map details, final M
// Now apply pagination
final List wPagination =
StringUtils.applyPagination(supportedOfferings, cmd.getStartIndex(),
cmd.getPageSizeVal());
if (wPagination != null) {
-final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, offerings.size());
+final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, supportedOfferings.size());
Review comment:
@rhtyd we always want to return the number of total found offerings and not
only the number of offerings in the page that is returned. This is the same
behavior as all the other list cmds.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ListNetworkOfferingsCmd does not return the correct count
> -
>
> Key: CLOUDSTACK-10057
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10057
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Affects Versions: 4.11.0.0
>Reporter: Sigert Goeminne
>Assignee: Sigert Goeminne
>
> ListNetworkOfferingsCmd returns a count value which is incorrect (no network
> offerings are returned but the count is set to a value higher then 0).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-9590) KVM + CentOS 7.2 + Agent in Alert State for long time
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226481#comment-16226481 ] Rajani Karuturi commented on CLOUDSTACK-9590: - Hi @sven.vogel and @dag.Sonstebo I am facing a similar issue with adding KVM host. Which java is downgraded? The MS java version or host java version? Do you know any reason for this to happen? Is it java issue or cloudstack issue? > KVM + CentOS 7.2 + Agent in Alert State for long time > - > > Key: CLOUDSTACK-9590 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9590 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.9.0 > Environment: entOS Linux release 7.2.1511 (Core) > cloudstack-agent-4.9.0-1.el7.centos.x86_64 >Reporter: Sven Vogel > Fix For: 4.9.1.0 > > Attachments: agent.log, cloudstack-startup.log, management-server.zip > > > Hi, > When i add a new host to cloudstack management server it take some time to > get host out from alert state. > 1. i add the host and host add not possible > 2. values are correct set to agent.properties, restart cloustack agent > 3. agent says connected to server > 4. management server says "alert" > management-server.log > 2016-11-10 13:23:06,783 DEBUG [c.c.h.Status] > (AgentConnectTaskPool-49:ctx-c3b72839) (logid:5a86e1fb) Transition:[Resource > state = Enabled, Agent event = AgentDisconnected, Host > id = 51, name = kvm02.oscloud.local] > 2016-11-10 13:23:06,798 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] > (AgentConnectTaskPool-49:ctx-c3b72839) (logid:5a86e1fb) Notifying other nodes > of to disconnect > 2016-11-10 13:23:06,806 DEBUG [c.c.a.m.AgentManagerImpl] > (AgentConnectTaskPool-49:ctx-c3b72839) (logid:5a86e1fb) Failed to handle host > connection: com.cloud.exception.Connection > Exception: Unable to get an answer to the CheckNetworkCommand from agent: 51 > is there any way to speed up the alert state? is it normal that it take so > long? > thanks > Sven -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226455#comment-16226455
]
ASF GitHub Bot commented on CLOUDSTACK-10122:
-
marcaurele commented on a change in pull request #2302: CLOUDSTACK-10122:
Unrelated error message
URL: https://github.com/apache/cloudstack/pull/2302#discussion_r147920880
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##
@@ -1423,7 +1423,7 @@ public void prepare(VirtualMachineProfile vm,
DeployDestination dest) throws Sto
}
}
catch (Throwable e){
-s_logger.debug("[NSX_PLUGIN_LOG] ERROR: " +
e.getMessage());
Review comment:
Agree with @rafaelweingartner - it should be removed all together. It would
be hard anyway to track the problem since the log output will only output the
message and not the stack trace. If we're trying to catch any error, the stack
is very important to understand the issue. This would normally be done at a
higher level if the exception isn't caught here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unrelated error message
> ---
>
> Key: CLOUDSTACK-10122
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> Remove unrelated text "NSX_PLUGIN_LOG" from error message
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226425#comment-16226425
]
ASF GitHub Bot commented on CLOUDSTACK-10122:
-
rafaelweingartner commented on a change in pull request #2302:
CLOUDSTACK-10122: Unrelated error message
URL: https://github.com/apache/cloudstack/pull/2302#discussion_r147916282
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##
@@ -1423,7 +1423,7 @@ public void prepare(VirtualMachineProfile vm,
DeployDestination dest) throws Sto
}
}
catch (Throwable e){
-s_logger.debug("[NSX_PLUGIN_LOG] ERROR: " +
e.getMessage());
Review comment:
I would remove the try/catch block. I really did not seen any relevant
exception in that piece of code to be dealt if there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unrelated error message
> ---
>
> Key: CLOUDSTACK-10122
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> Remove unrelated text "NSX_PLUGIN_LOG" from error message
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10057) ListNetworkOfferingsCmd does not return the correct count
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226371#comment-16226371
]
ASF GitHub Bot commented on CLOUDSTACK-10057:
-
rhtyd commented on a change in pull request #2250: CLOUDSTACK-10057:
listNetworkOfferings now returns the correct number of offerings.
URL: https://github.com/apache/cloudstack/pull/2250#discussion_r147909203
##
File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -4788,7 +4788,7 @@ protected void validateNtwkOffDetails(final Map details, final M
// Now apply pagination
final List wPagination =
StringUtils.applyPagination(supportedOfferings, cmd.getStartIndex(),
cmd.getPageSizeVal());
if (wPagination != null) {
-final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, offerings.size());
+final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, supportedOfferings.size());
Review comment:
@sgoeminn why not use `wPagination.size()`, or is it that you want to expose
the count value equal to total found/supported offerings however only return
the offerings in the current page?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ListNetworkOfferingsCmd does not return the correct count
> -
>
> Key: CLOUDSTACK-10057
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10057
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Affects Versions: 4.11.0.0
>Reporter: Sigert Goeminne
>Assignee: Sigert Goeminne
>
> ListNetworkOfferingsCmd returns a count value which is incorrect (no network
> offerings are returned but the count is set to a value higher then 0).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-10057) ListNetworkOfferingsCmd does not return the correct count
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226367#comment-16226367
]
ASF GitHub Bot commented on CLOUDSTACK-10057:
-
rhtyd commented on a change in pull request #2250: CLOUDSTACK-10057:
listNetworkOfferings now returns the correct number of offerings.
URL: https://github.com/apache/cloudstack/pull/2250#discussion_r147909203
##
File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -4788,7 +4788,7 @@ protected void validateNtwkOffDetails(final Map details, final M
// Now apply pagination
final List wPagination =
StringUtils.applyPagination(supportedOfferings, cmd.getStartIndex(),
cmd.getPageSizeVal());
if (wPagination != null) {
-final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, offerings.size());
+final Pair, Integer>
listWPagination = new Pair,
Integer>(wPagination, supportedOfferings.size());
Review comment:
@sgoeminn why not use `wPagination.size()` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ListNetworkOfferingsCmd does not return the correct count
> -
>
> Key: CLOUDSTACK-10057
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10057
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Affects Versions: 4.11.0.0
>Reporter: Sigert Goeminne
>Assignee: Sigert Goeminne
>
> ListNetworkOfferingsCmd returns a count value which is incorrect (no network
> offerings are returned but the count is set to a value higher then 0).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
