[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310939#comment-16310939
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159595450
 
 

 ##
 File path: 
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateDataFactoryImpl.java
 ##
 @@ -153,4 +164,67 @@ public TemplateInfo getReadyTemplateOnCache(long 
templateId) {
 return tmplObjs;
 }
 
+/**
+ * Given existing spool refs, return one pool id existing on pools and refs
+ * @param existingRefs
+ * @param pools
+ * @return
+ */
+private Long getOneMatchingPoolIdFromRefs(List 
existingRefs, List pools) {
+for (VMTemplateStoragePoolVO ref : existingRefs) {
+for (StoragePoolVO p : pools) {
+if (ref.getPoolId() == p.getId()) {
+return p.getId();
+}
+}
+}
+return null;
+}
+
+/**
+ * Retrieve storage pools with scope = cluster or zone matching clusterId 
or dataCenterId depending on their scope
+ * @param clusterId
+ * @param dataCenterId
+ * @param hypervisorType
+ * @return
+ */
+private List getStoragePoolsFromClusterOrZone(Long 
clusterId, long dataCenterId, Hypervisor.HypervisorType hypervisorType) {
+List pools = new ArrayList<>();
+if (clusterId != null) {
+List clusterPools = 
primaryDataStoreDao.listPoolsByCluster(clusterId);
+pools.addAll(clusterPools);
+}
+List zonePools = 
primaryDataStoreDao.findZoneWideStoragePoolsByHypervisor(dataCenterId, 
hypervisorType);
+pools.addAll(zonePools);
+return pools;
+}
+
+@Override
+public TemplateInfo getReadyBypassedTemplateOnPrimaryStore(long 
templateId, Long poolId, Long hostId) {
+VMTemplateVO templateVO = imageDataDao.findById(templateId);
+if (templateVO == null || !templateVO.isDirectDownload()) {
+return null;
+}
+Long pool = poolId;
+if (poolId == null) {
+//Get ISO from existing pool ref
+HostVO host = hostDao.findById(hostId);
+List pools = 
getStoragePoolsFromClusterOrZone(host.getClusterId(), host.getDataCenterId(), 
host.getHypervisorType());
+List existingRefs = 
templatePoolDao.listByTemplateId(templateId);
+pool = getOneMatchingPoolIdFromRefs(existingRefs, pools);
+}
+VMTemplateStoragePoolVO spoolRef = 
templatePoolDao.findByPoolTemplate(pool, templateId);
 
 Review comment:
   `pool` can be null here, according to 
https://github.com/apache/cloudstack/pull/2379/files#diff-92e0bb0fd44a51c2c2234ae65d88fbbdR181
   Unsure if `findBYPoolTemplate` will like it or not


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310937#comment-16310937
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159595450
 
 

 ##
 File path: 
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateDataFactoryImpl.java
 ##
 @@ -153,4 +164,67 @@ public TemplateInfo getReadyTemplateOnCache(long 
templateId) {
 return tmplObjs;
 }
 
+/**
+ * Given existing spool refs, return one pool id existing on pools and refs
+ * @param existingRefs
+ * @param pools
+ * @return
+ */
+private Long getOneMatchingPoolIdFromRefs(List 
existingRefs, List pools) {
+for (VMTemplateStoragePoolVO ref : existingRefs) {
+for (StoragePoolVO p : pools) {
+if (ref.getPoolId() == p.getId()) {
+return p.getId();
+}
+}
+}
+return null;
+}
+
+/**
+ * Retrieve storage pools with scope = cluster or zone matching clusterId 
or dataCenterId depending on their scope
+ * @param clusterId
+ * @param dataCenterId
+ * @param hypervisorType
+ * @return
+ */
+private List getStoragePoolsFromClusterOrZone(Long 
clusterId, long dataCenterId, Hypervisor.HypervisorType hypervisorType) {
+List pools = new ArrayList<>();
+if (clusterId != null) {
+List clusterPools = 
primaryDataStoreDao.listPoolsByCluster(clusterId);
+pools.addAll(clusterPools);
+}
+List zonePools = 
primaryDataStoreDao.findZoneWideStoragePoolsByHypervisor(dataCenterId, 
hypervisorType);
+pools.addAll(zonePools);
+return pools;
+}
+
+@Override
+public TemplateInfo getReadyBypassedTemplateOnPrimaryStore(long 
templateId, Long poolId, Long hostId) {
+VMTemplateVO templateVO = imageDataDao.findById(templateId);
+if (templateVO == null || !templateVO.isDirectDownload()) {
+return null;
+}
+Long pool = poolId;
+if (poolId == null) {
+//Get ISO from existing pool ref
+HostVO host = hostDao.findById(hostId);
+List pools = 
getStoragePoolsFromClusterOrZone(host.getClusterId(), host.getDataCenterId(), 
host.getHypervisorType());
+List existingRefs = 
templatePoolDao.listByTemplateId(templateId);
+pool = getOneMatchingPoolIdFromRefs(existingRefs, pools);
+}
+VMTemplateStoragePoolVO spoolRef = 
templatePoolDao.findByPoolTemplate(pool, templateId);
 
 Review comment:
   `pool` can be null here, according to 
https://github.com/apache/cloudstack/pull/2379/files#diff-92e0bb0fd44a51c2c2234ae65d88fbbdR181


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10205) LinkDomainToLdap returns internal id

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310935#comment-16310935
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10205:
-

rhtyd closed pull request #2378: CLOUDSTACK-10205 make LinkDomainToLdap return 
UUID instead of internal id
URL: https://github.com/apache/cloudstack/pull/2378
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java 
b/api/src/org/apache/cloudstack/api/ApiConstants.java
index 55e8c285e6b..98b5ccb99a1 100644
--- a/api/src/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/org/apache/cloudstack/api/ApiConstants.java
@@ -705,6 +705,7 @@
 
 public static final String HAS_ANNOTATION = "hasannotation";
 public static final String LAST_ANNOTATED = "lastannotated";
+public static final String LDAP_DOMAIN = "ldapdomain";
 
 public enum HostDetails {
 all, capacity, events, stats, min;
diff --git 
a/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LinkDomainToLdapResponse.java
 
b/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LinkDomainToLdapResponse.java
index b0032b04b4d..050eb6c3eb5 100644
--- 
a/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LinkDomainToLdapResponse.java
+++ 
b/plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LinkDomainToLdapResponse.java
@@ -27,12 +27,17 @@
 
 @SerializedName(ApiConstants.DOMAIN_ID)
 @Param(description = "id of the Domain which is linked to LDAP")
-private long domainId;
+private String domainId;
 
+@Deprecated
 @SerializedName(ApiConstants.NAME)
 @Param(description = "name of the group or OU in LDAP which is linked to 
the domain")
 private String name;
 
+@SerializedName(ApiConstants.LDAP_DOMAIN)
+@Param(description = "name of the group or OU in LDAP which is linked to 
the domain")
+private String ldapDomain;
+
 @SerializedName(ApiConstants.TYPE)
 @Param(description = "type of the name in LDAP which is linke to the 
domain")
 private String type;
@@ -45,19 +50,25 @@
 @Param(description = "Domain Admin accountId that is created")
 private String adminId;
 
-public LinkDomainToLdapResponse(long domainId, String type, String name, 
short accountType) {
+public LinkDomainToLdapResponse(String domainId, String type, String 
ldapDomain, short accountType) {
 this.domainId = domainId;
-this.name = name;
+this.name = ldapDomain;
+this.ldapDomain = ldapDomain;
 this.type = type;
 this.accountType = accountType;
 }
 
-public long getDomainId() {
+public String getDomainId() {
 return domainId;
 }
 
+public String getLdapDomain() {
+return ldapDomain == null ? name : ldapDomain;
+}
+
+@Deprecated
 public String getName() {
-return name;
+return ldapDomain == null ? name : ldapDomain;
 }
 
 public String getType() {
diff --git 
a/plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
 
b/plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
index a4d340647f4..beb7a61cd70 100644
--- 
a/plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
+++ 
b/plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
@@ -44,6 +44,8 @@
 import org.apache.log4j.Logger;
 import org.springframework.stereotype.Component;
 
+import com.cloud.domain.DomainVO;
+import com.cloud.domain.dao.DomainDao;
 import com.cloud.exception.InvalidParameterValueException;
 import com.cloud.utils.Pair;
 
@@ -54,6 +56,9 @@
 @Inject
 private LdapConfigurationDao _ldapConfigurationDao;
 
+@Inject
+private DomainDao domainDao;
+
 @Inject
 private LdapContextFactory _ldapContextFactory;
 
@@ -270,7 +275,14 @@ public LinkDomainToLdapResponse linkDomainToLdap(Long 
domainId, String type, Str
 Validate.isTrue(accountType==0 || accountType==2, "accountype should 
be either 0(normal user) or 2(domain admin)");
 LinkType linkType = LdapManager.LinkType.valueOf(type.toUpperCase());
 LdapTrustMapVO vo = _ldapTrustMapDao.persist(new 
LdapTrustMapVO(domainId, linkType, name, accountType));
-LinkDomainToLdapResponse response = new 
LinkDomainToLdapResponse(vo.getDomainId(), vo.getType().toString(), 
vo.getName(), vo.getAccountType());
+DomainVO domain = domainDao.findById(vo.getDomainId());
+String domainUuid = "";
+if (domain == null) {
+s_logger.error("no domain in database for id " + 

[jira] [Commented] (CLOUDSTACK-10205) LinkDomainToLdap returns internal id

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310933#comment-16310933
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10205:
-

rhtyd commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap return 
UUID instead of internal id
URL: https://github.com/apache/cloudstack/pull/2378#issuecomment-355219656
 
 
   Merging this based on code reviews (2x) lgtms and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LinkDomainToLdap returns internal id
> 
>
> Key: CLOUDSTACK-10205
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10205
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> The response should contain the uuid for the domain and not the internal db 
> id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10205) LinkDomainToLdap returns internal id

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310934#comment-16310934
 ] 

ASF subversion and git services commented on CLOUDSTACK-10205:
--

Commit 8131bccd979d764cbab44705dd7f1d9539fd06ef in cloudstack's branch 
refs/heads/master from [~dahn]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8131bcc ]

CLOUDSTACK-10205: LinkDomainToLdap returns UUID instead of internal id (#2378)

The internal id is not usefull to the user. It is a bug to return it instead of 
a uuid.
In the process of fixing the above "name" was deprecated in favour of 
"ldap_domain".

> LinkDomainToLdap returns internal id
> 
>
> Key: CLOUDSTACK-10205
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10205
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> The response should contain the uuid for the domain and not the internal db 
> id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310932#comment-16310932
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9889:


yvsubhash commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan 
range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355219610
 
 
   @rhtyd  conflicts are taken care


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dedicate guest vlan  range to a domain
> --
>
> Key: CLOUDSTACK-9889
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: subhash yedugundla
>
> List of scenarios covered
> *Dedication of guest Vlan range*
> Admin should be allowed dedicate guest vlan ranges to a domain
> While dedicating a guest Vlan range
> If the range overlaps with any of the existing dedicated range then extend 
> the existing dedicated range
> Otherwise add it as a new dedicated guest Vlan range
> If the range doesn’t exist in the system then the request should fail
> If any of the vlan in the range is in use by a network that belongs to a 
> different account of different domain then the request should fail
> *Releasing guest Vlan range*
> Admin should be allowed to release a dedicated guest vlan range that is 
> dedicated to a domain back to the system pool
> If the range is not dedicated to the domain then the request should fail
> Even If one/more of the Vlans belonging to the range is in use by a network 
> the range should be released back to the system pool
>  The vlans that are in use should continue to be in use by the network
> *Network implementation*
> If the network belongs to an account that has a dedicated range of Vlans then 
> a Vlan from the account's dedicated range should be allocated to the network
> If an account uses up all of its dedicated Vlan’s the next network being 
> created for the account should be assigned a Vlan that belongs to the domain 
> pool
> Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range 
> belonging to the zone
> *Network creation*
> If a Vlan id is specified and if this id belongs to a dedicated Vlan range of 
> a different account/domain then the creation should fail
> If a Vlan id is specified and if this id belongs to the system pool but the 
> network owner has a range of dedicated range of vlans then the creation 
> should fail
> *Domain deletion*
> Guest Ip ranges and vlans dedicated to the domain should be released back to 
> the free pool 
> *Account deletion*
> When an account is deleted, the IP ranges and vlans associated with the 
> account  should be moved to system pool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310931#comment-16310931
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

borisstoyanov commented on issue #2381: CLOUDSTACK-10117 Account ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355219599
 
 
   I will be running some tests today @rhtyd, I'll post my review by end of day 
today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310928#comment-16310928
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159595127
 
 

 ##
 File path: engine/schema/src/com/cloud/storage/VMTemplateVO.java
 ##
 @@ -605,6 +609,10 @@ public void setUpdated(Date updated) {
 this.updated = updated;
 }
 
+public Boolean isDirectDownload() {
 
 Review comment:
   `boolean`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310927#comment-16310927
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159595094
 
 

 ##
 File path: engine/schema/resources/META-INF/db/schema-41000to41100.sql
 ##
 @@ -516,3 +516,109 @@ UPDATE `cloud`.`vm_template` SET guest_os_id=99 WHERE 
id=8;
 
 -- Network External Ids
 ALTER TABLE `cloud`.`networks` ADD `external_id` varchar(255);
+
+-- CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
+ALTER TABLE `cloud`.`vm_template`
+ADD COLUMN `direct_download` TINYINT(1) DEFAULT '0' COMMENT 'Indicates if 
Secondary Storage is bypassed and template is downloaded to Primary Storage';
+
+DROP VIEW IF EXISTS `cloud`.`template_view`;
+CREATE VIEW `template_view` AS
 
 Review comment:
   Better to put those drop & create in a single statement:
   ```sql
   CREATE OR REPLACE VIEW `template_view` AS
   ``` 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310925#comment-16310925
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159594943
 
 

 ##
 File path: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 ##
 @@ -1273,6 +1273,7 @@ public void prepareForMigration(VirtualMachineProfile 
vm, DeployDestination dest
 for (int i = 0; i < 2; i++) {
 // retry one more time in case of template reload is required for 
Vmware case
 AsyncCallFuture future = null;
+boolean bypassed = false;
 
 Review comment:
   unused variable


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310921#comment-16310921
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159594766
 
 

 ##
 File path: 
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateInfo.java
 ##
 @@ -25,4 +25,6 @@
 String getUniqueName();
 
 String getInstallPath();
+
+boolean isDirectDownload();
 
 Review comment:
   Just for your info, be aware of not mixing `Boolean` and `boolean` types 
since the JVM won't check for those kind of mismatch as it does auto casting to 
the expected type. But you will end up with a NPE when getting a `Boolean` NULL 
on a method expecting a `boolean`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310916#comment-16310916
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159594458
 
 

 ##
 File path: 
core/src/org/apache/cloudstack/agent/directdownload/HttpDirectDownloadCommand.java
 ##
 @@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.agent.directdownload;
+
+import org.apache.cloudstack.storage.to.PrimaryDataStoreTO;
+
+import java.util.Map;
+
+public class HttpDirectDownloadCommand extends DirectDownloadCommand {
+
+private Map headers;
+
+public HttpDirectDownloadCommand(String url, Long templateId, 
PrimaryDataStoreTO destPool, String checksum, Map headers) {
+super(url, templateId, destPool, checksum);
+this.headers = headers;
+}
+
+public Map getHeaders() {
+return headers;
+}
+
+@Override
+public void setExecuteInSequence(boolean inSeq) {
+}
 
 Review comment:
   Function can be removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310918#comment-16310918
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159594529
 
 

 ##
 File path: 
core/src/org/apache/cloudstack/agent/directdownload/NfsDirectDownloadCommand.java
 ##
 @@ -0,0 +1,38 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package org.apache.cloudstack.agent.directdownload;
+
+import org.apache.cloudstack.storage.to.PrimaryDataStoreTO;
+
+public class NfsDirectDownloadCommand extends DirectDownloadCommand {
+
+public NfsDirectDownloadCommand(final String url, final Long templateId, 
final PrimaryDataStoreTO destPool, final String checksum) {
+super(url, templateId, destPool, checksum);
+}
+
+@Override
+public void setExecuteInSequence(boolean inSeq) {
+
+}
 
 Review comment:
   Function can be removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310917#comment-16310917
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159594511
 
 

 ##
 File path: 
core/src/org/apache/cloudstack/agent/directdownload/MetalinkDirectDownloadCommand.java
 ##
 @@ -0,0 +1,38 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package org.apache.cloudstack.agent.directdownload;
+
+import org.apache.cloudstack.storage.to.PrimaryDataStoreTO;
+
+public class MetalinkDirectDownloadCommand extends DirectDownloadCommand {
+
+public MetalinkDirectDownloadCommand(String url, Long templateId, 
PrimaryDataStoreTO destPool, String checksum) {
+super(url, templateId, destPool, checksum);
+}
+
+@Override
+public void setExecuteInSequence(boolean inSeq) {
+
+}
 
 Review comment:
   Function can be removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310913#comment-16310913
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159594157
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
 ##
 @@ -263,6 +269,10 @@ public Boolean isRoutingType() {
 return isRoutingType;
 }
 
+public Boolean isDirectDownload() {
 
 Review comment:
   `boolean` here too


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310912#comment-16310912
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159593979
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java
 ##
 @@ -168,6 +173,10 @@ public Boolean isDynamicallyScalable() {
 return isDynamicallyScalable ==  null ? Boolean.FALSE : 
isDynamicallyScalable;
 }
 
+public Boolean isDirectDownload() {
 
 Review comment:
   can return a `boolean` instead since it cannot be null


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310910#comment-16310910
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159593522
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/HttpDirectTemplateDownloader.java
 ##
 @@ -0,0 +1,158 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.httpclient.Header;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpMethod;
+import org.apache.commons.httpclient.HttpMethodRetryHandler;
+import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
+import org.apache.commons.httpclient.NoHttpResponseException;
+import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.params.HttpMethodParams;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.RandomAccessFile;
+import java.util.Map;
+
+public class HttpDirectTemplateDownloader extends DirectTemplateDownloaderImpl 
{
+
+private HttpClient client;
+private static final MultiThreadedHttpConnectionManager 
s_httpClientManager = new MultiThreadedHttpConnectionManager();
+private static final int CHUNK_SIZE = 1024 * 1024; //1M
+private final HttpMethodRetryHandler myretryhandler;
+public static final Logger s_logger = 
Logger.getLogger(HttpDirectTemplateDownloader.class.getName());
+private GetMethod request;
+private long remoteSize;
+
+public HttpDirectTemplateDownloader(String url, Long templateId, String 
destPoolPath, String checksum, Map headers) {
+super(url, destPoolPath, templateId, checksum);
+client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+request = createRequest(url, headers);
+String downloadDir = getDirectDownloadTempPath(templateId);
+createTemporaryDirectoryAndFile(downloadDir);
+}
+
+private void createTemporaryDirectoryAndFile(String downloadDir) {
+createFolder(getDestPoolPath() + File.separator + downloadDir);
+File f = new File(getDestPoolPath() + File.separator + downloadDir + 
File.separator + getFileNameFromUrl());
+setDownloadedFilePath(f.getAbsolutePath());
+}
+
+private GetMethod createRequest(String downloadUrl, Map 
headers) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER, 
myretryhandler);
+request.setFollowRedirects(true);
+for (String key : headers.keySet()) {
+request.setRequestHeader(key, headers.get(key));
+}
+return request;
+}
+
+private long getRemoteSize(GetMethod request) {
+Header contentLengthHeader = 
request.getResponseHeader("Content-Length");
+long reportedRemoteSize = 0;
+if (contentLengthHeader == null) {
+Header chunkedHeader = 
request.getResponseHeader("Transfer-Encoding");
+if (chunkedHeader == null || 
!"chunked".equalsIgnoreCase(chunkedHeader.getValue())) {
+throw new CloudRuntimeException("Error template remote size");
+}
+} else {
+reportedRemoteSize = 
Long.parseLong(contentLengthHeader.getValue());
+}
+return reportedRemoteSize;
+}
+
+private HttpMethodRetryHandler createRetryTwiceHandler() {
+return new HttpMethodRetryHandler() {
+@Override
+public boolean retryMethod(final HttpMethod method, final 
IOException exception, int executionCount) {
+if (executionCount >= 2) {
+// Do not retry if over max retry count
+return false;
+}

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310893#comment-16310893
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159590751
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/HttpDirectTemplateDownloader.java
 ##
 @@ -0,0 +1,158 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.httpclient.Header;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpMethod;
+import org.apache.commons.httpclient.HttpMethodRetryHandler;
+import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
+import org.apache.commons.httpclient.NoHttpResponseException;
+import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.params.HttpMethodParams;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.RandomAccessFile;
+import java.util.Map;
+
+public class HttpDirectTemplateDownloader extends DirectTemplateDownloaderImpl 
{
+
+private HttpClient client;
+private static final MultiThreadedHttpConnectionManager 
s_httpClientManager = new MultiThreadedHttpConnectionManager();
+private static final int CHUNK_SIZE = 1024 * 1024; //1M
+private final HttpMethodRetryHandler myretryhandler;
+public static final Logger s_logger = 
Logger.getLogger(HttpDirectTemplateDownloader.class.getName());
+private GetMethod request;
+private long remoteSize;
+
+public HttpDirectTemplateDownloader(String url, Long templateId, String 
destPoolPath, String checksum, Map headers) {
+super(url, destPoolPath, templateId, checksum);
+client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+request = createRequest(url, headers);
+String downloadDir = getDirectDownloadTempPath(templateId);
+createTemporaryDirectoryAndFile(downloadDir);
+}
+
+private void createTemporaryDirectoryAndFile(String downloadDir) {
+createFolder(getDestPoolPath() + File.separator + downloadDir);
+File f = new File(getDestPoolPath() + File.separator + downloadDir + 
File.separator + getFileNameFromUrl());
+setDownloadedFilePath(f.getAbsolutePath());
+}
+
+private GetMethod createRequest(String downloadUrl, Map 
headers) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER, 
myretryhandler);
+request.setFollowRedirects(true);
+for (String key : headers.keySet()) {
+request.setRequestHeader(key, headers.get(key));
+}
+return request;
+}
+
+private long getRemoteSize(GetMethod request) {
+Header contentLengthHeader = 
request.getResponseHeader("Content-Length");
+long reportedRemoteSize = 0;
+if (contentLengthHeader == null) {
+Header chunkedHeader = 
request.getResponseHeader("Transfer-Encoding");
+if (chunkedHeader == null || 
!"chunked".equalsIgnoreCase(chunkedHeader.getValue())) {
+throw new CloudRuntimeException("Error template remote size");
+}
+} else {
+reportedRemoteSize = 
Long.parseLong(contentLengthHeader.getValue());
+}
+return reportedRemoteSize;
+}
+
+private HttpMethodRetryHandler createRetryTwiceHandler() {
+return new HttpMethodRetryHandler() {
+@Override
+public boolean retryMethod(final HttpMethod method, final 
IOException exception, int executionCount) {
+if (executionCount >= 2) {
+// Do not retry if over max retry count
+return false;
+}

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310889#comment-16310889
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: 
Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159590751
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/HttpDirectTemplateDownloader.java
 ##
 @@ -0,0 +1,158 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.httpclient.Header;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpMethod;
+import org.apache.commons.httpclient.HttpMethodRetryHandler;
+import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
+import org.apache.commons.httpclient.NoHttpResponseException;
+import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.params.HttpMethodParams;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.RandomAccessFile;
+import java.util.Map;
+
+public class HttpDirectTemplateDownloader extends DirectTemplateDownloaderImpl 
{
+
+private HttpClient client;
+private static final MultiThreadedHttpConnectionManager 
s_httpClientManager = new MultiThreadedHttpConnectionManager();
+private static final int CHUNK_SIZE = 1024 * 1024; //1M
+private final HttpMethodRetryHandler myretryhandler;
+public static final Logger s_logger = 
Logger.getLogger(HttpDirectTemplateDownloader.class.getName());
+private GetMethod request;
+private long remoteSize;
+
+public HttpDirectTemplateDownloader(String url, Long templateId, String 
destPoolPath, String checksum, Map headers) {
+super(url, destPoolPath, templateId, checksum);
+client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+request = createRequest(url, headers);
+String downloadDir = getDirectDownloadTempPath(templateId);
+createTemporaryDirectoryAndFile(downloadDir);
+}
+
+private void createTemporaryDirectoryAndFile(String downloadDir) {
+createFolder(getDestPoolPath() + File.separator + downloadDir);
+File f = new File(getDestPoolPath() + File.separator + downloadDir + 
File.separator + getFileNameFromUrl());
+setDownloadedFilePath(f.getAbsolutePath());
+}
+
+private GetMethod createRequest(String downloadUrl, Map 
headers) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER, 
myretryhandler);
+request.setFollowRedirects(true);
+for (String key : headers.keySet()) {
+request.setRequestHeader(key, headers.get(key));
+}
+return request;
+}
+
+private long getRemoteSize(GetMethod request) {
+Header contentLengthHeader = 
request.getResponseHeader("Content-Length");
+long reportedRemoteSize = 0;
+if (contentLengthHeader == null) {
+Header chunkedHeader = 
request.getResponseHeader("Transfer-Encoding");
+if (chunkedHeader == null || 
!"chunked".equalsIgnoreCase(chunkedHeader.getValue())) {
+throw new CloudRuntimeException("Error template remote size");
+}
+} else {
+reportedRemoteSize = 
Long.parseLong(contentLengthHeader.getValue());
+}
+return reportedRemoteSize;
+}
+
+private HttpMethodRetryHandler createRetryTwiceHandler() {
+return new HttpMethodRetryHandler() {
+@Override
+public boolean retryMethod(final HttpMethod method, final 
IOException exception, int executionCount) {
+if (executionCount >= 2) {
+// Do not retry if over max retry count
+return false;
+}

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310883#comment-16310883
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355213223
 
 
   Tests LGTM - `Smoke tests completed. 66 look OK, 0 have error(s)`
   Additional review requested - @nvazquez @borisstoyanov @rafaelweingartner 
@wido @marcaurele @karuturi and others?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310881#comment-16310881
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account 
ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159589845
 
 

 ##
 File path: server/src/com/cloud/configuration/Config.java
 ##
 @@ -39,6 +39,10 @@
 import com.cloud.vm.UserVmManager;
 import com.cloud.vm.snapshot.VMSnapshotManager;
 
+/**
+ * @deprecated use the more dynamic ConfigKey
+ */
+@Deprecated
 
 Review comment:
   +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310879#comment-16310879
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account 
ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159589659
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java
 ##
 @@ -31,18 +34,27 @@
 @Param(description = "port")
 private int port;
 
+@SerializedName("domain_id")
 
 Review comment:
   This can be `domainid` like used/returned by other responses.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310878#comment-16310878
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account 
ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159589538
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java
 ##
 @@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkAccountToLdapResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
+import java.util.UUID;
+
+@APICommand(name = "linkAccountToLdap", description = "link a cloudstack 
account to a group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.11.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkAccountToLdapCmd extends BaseCmd {
+public static final Logger LOGGER = 
Logger.getLogger(LinkAccountToLdapCmd.class.getName());
+public static final String APINAME = "LinkAccountToLdap";
 
 Review comment:
   Fix the case to `linkAccountToLdap`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310877#comment-16310877
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account 
ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159589519
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java
 ##
 @@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkAccountToLdapResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
+import java.util.UUID;
+
+@APICommand(name = "linkAccountToLdap", description = "link a cloudstack 
account to a group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.11.0",
 
 Review comment:
   `linkAccountToLdap` can be replaced by APINAME


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310882#comment-16310882
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account 
ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159589567
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java
 ##
 @@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.api.command;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+import com.cloud.user.UserAccount;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.LinkAccountToLdapResponse;
+import org.apache.cloudstack.api.response.LinkDomainToLdapResponse;
+import org.apache.cloudstack.ldap.LdapManager;
+import org.apache.cloudstack.ldap.LdapUser;
+import org.apache.cloudstack.ldap.NoLdapUserMatchingQueryException;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
+import java.util.UUID;
+
+@APICommand(name = "linkAccountToLdap", description = "link a cloudstack 
account to a group or OU in ldap", responseObject = 
LinkDomainToLdapResponse.class, since = "4.11.0",
 
 Review comment:
   Also add default `authorized`, admin etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310880#comment-16310880
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account 
ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159589472
 
 

 ##
 File path: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
 ##
 @@ -136,10 +136,11 @@ public void execute() throws ServerApiException {
 }
 final CallContext callContext = getCurrentContext();
 String finalAccountName = getAccountName();
+// TODO add domain id to create account and create user calls
 
 Review comment:
   Remove TODO?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310871#comment-16310871
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355212185
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310870#comment-16310870
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355212051
 
 
   @blueorangutan test centos7 vmware-55u3
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10210) remove test file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310868#comment-16310868
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10210:
-

marcaurele commented on issue #2384: CLOUDSTACK-10210 cleanup testfile
URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355211882
 
 
   typo in nickname ^^, cc @DaanHoogland 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> remove test file
> 
>
> Key: CLOUDSTACK-10210
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10210
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Secondary Storage
>Reporter: Daan Hoogland
>Assignee: Daan Hoogland
>Priority: Trivial
>
> test leaves 'testfile' as remanence. remove in @after test finishes 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10054) Volume download times out in 3600 seconds

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310866#comment-16310866
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10054:
-

rhtyd commented on issue #2244: CLOUDSTACK-10054:Volume download times out in 
3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#issuecomment-355211839
 
 
   Ping @mrunalinikankariya can you address outstanding issues?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Volume download times out in 3600 seconds
> -
>
> Key: CLOUDSTACK-10054
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10054
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: mrunalini
>
> Problem Statement -
> When tried to download a volume of type Vmware with large size, it fails in 
> an hour before generating the URL.
> It can be seen in the ssvm logs that ova generation tar command fails/timed 
> out in an hour. The volume is of 800GB and we should be able to increase the 
> timeout. Unfortunately there is not method to do that. There is no global 
> parameter to update the timeout for this operation.
> Solution
> Add a global parameter 'vmware.backup.session.timeout' for all the tar 
> commands(commands taking long time)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310865#comment-16310865
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


blueorangutan commented on issue #1775: CLOUDSTACK-9606: While IP address is 
released, tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355211808
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310862#comment-16310862
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10065:
-

blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries 
in listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-355211697
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize SQL queries in listTemplate API to improve performance. 
> -
>
> Key: CLOUDSTACK-10065
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Pranali Mande
>
> *Description*:
> The db queries could be optimized to get unique results from the database 
> which could help in reducing the listTemplate API response time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310859#comment-16310859
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10065:
-

rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in 
listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-355211653
 
 
   @blueorangutan test
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize SQL queries in listTemplate API to improve performance. 
> -
>
> Key: CLOUDSTACK-10065
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Pranali Mande
>
> *Description*:
> The db queries could be optimized to get unique results from the database 
> which could help in reducing the listTemplate API response time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310864#comment-16310864
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


rhtyd commented on issue #1775: CLOUDSTACK-9606: While IP address is released, 
tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355211750
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9975) Allow customizing system VM templates for SSVM and Console Proxy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310861#comment-16310861
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9975:


blueorangutan commented on issue #2275: CLOUDSTACK-9975: Allow customizing 
system VM templates for SSVM and Console Proxy
URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-355211694
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow customizing system VM templates for SSVM and Console Proxy
> 
>
> Key: CLOUDSTACK-9975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9975
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Gabriel Beims Bräscher
>Assignee: Gabriel Beims Bräscher
>Priority: Minor
>
> Currently, it is only possible to change the template used by virtual 
> routers, but other system VMs do not have the same feature. The virtual 
> router template is configured according to the respective global settings 
> parameters: router.template.hyperv, router.template.kvm, router.template.lxc, 
> router.template.xenserver, router.template.ovm, router.template.vmware.
> This ticket proposes the configuration of templates for storage system VMs 
> (SSVMs) and console proxy system VMs with parameters similar with the virtual 
> router template configuration: ssvm.template. and 
> consoleproxy.template.
> If a parameter is null then it keeps the current flow for that scenario 
> (systemvm/virtualization tool).
> This proposal allows users to customize virtual machines templates according 
> to specific needs of each system VM. This feature was useful in a practical 
> scenario where it was necessary to perform some changes for the console proxy 
> system VM template.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9975) Allow customizing system VM templates for SSVM and Console Proxy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310860#comment-16310860
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9975:


rhtyd commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM 
templates for SSVM and Console Proxy
URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-355211686
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow customizing system VM templates for SSVM and Console Proxy
> 
>
> Key: CLOUDSTACK-9975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9975
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Gabriel Beims Bräscher
>Assignee: Gabriel Beims Bräscher
>Priority: Minor
>
> Currently, it is only possible to change the template used by virtual 
> routers, but other system VMs do not have the same feature. The virtual 
> router template is configured according to the respective global settings 
> parameters: router.template.hyperv, router.template.kvm, router.template.lxc, 
> router.template.xenserver, router.template.ovm, router.template.vmware.
> This ticket proposes the configuration of templates for storage system VMs 
> (SSVMs) and console proxy system VMs with parameters similar with the virtual 
> router template configuration: ssvm.template. and 
> consoleproxy.template.
> If a parameter is null then it keeps the current flow for that scenario 
> (systemvm/virtualization tool).
> This proposal allows users to customize virtual machines templates according 
> to specific needs of each system VM. This feature was useful in a practical 
> scenario where it was necessary to perform some changes for the console proxy 
> system VM template.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9733) Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "concurrent.snapshots.threshold.perhost"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310863#comment-16310863
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9733:


rhtyd commented on issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of 
a VM are not allowed and are not limited per host as per the global 
configuration parameter "concurrent.snapshots.threshold.perhost".
URL: https://github.com/apache/cloudstack/pull/1897#issuecomment-355211729
 
 
   Ping @sureshanaparti can you fix the conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Concurrent volume snapshots of a VM are not allowed and are not limited per 
> host as per the global configuration parameter 
> "concurrent.snapshots.threshold.perhost".
> 
>
> Key: CLOUDSTACK-9733
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9733
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Snapshot, Volumes
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
> Fix For: 4.10.1.0
>
>
> Pre-CloudStack 4.4.0, before the VM job framework changes (CLOUDSTACK-669), 
> Concurrent volume (both root and data) snapshots were allowed per host based 
> on the value of global config "concurrent.snapshots.threshold.perhost". The 
> volumes could belong to the same VM or spread across multiple VMs on a given 
> host. The synchronisation was done based on the host (Id).
> As part of the VM job framework changes (CLOUDSTACK-669) in CloudStack 4.4.0, 
> a separate job queue was introduced for individual VMs with a concurrency 
> level of 1 (i.e. all operations to a given VM are serialized). Volume 
> snapshot was also considered as a VM operation as part of these changes  and 
> goes through the VM job queue. These changes made the config 
> "concurrent.snapshots.threshold.perhost" obsolete (it was also no longer 
> getting honoured, since there is no single point of enforcement).
> Only one volume snapshot of a VM is allowed at any given point of time as the 
> sync object is the VM (id). So concurrent volume snapshots of a VM are not 
> allowed and are not limited per host as per the global configuration 
> parameter "concurrent.snapshots.threshold.perhost".
> This functionality needs to be re-introduced to execute more than 1 snapshot 
> of a VM at a time (when the underlying hypervisor supports) and snapshots 
> should be limited per host based on the value of 
> "concurrent.snapshots.threshold.perhost" at the cluster level (for more 
> flexibility).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310858#comment-16310858
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9889:


rhtyd commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range 
to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355211613
 
 
   Ping @yvsubhash can you fix the conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dedicate guest vlan  range to a domain
> --
>
> Key: CLOUDSTACK-9889
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: subhash yedugundla
>
> List of scenarios covered
> *Dedication of guest Vlan range*
> Admin should be allowed dedicate guest vlan ranges to a domain
> While dedicating a guest Vlan range
> If the range overlaps with any of the existing dedicated range then extend 
> the existing dedicated range
> Otherwise add it as a new dedicated guest Vlan range
> If the range doesn’t exist in the system then the request should fail
> If any of the vlan in the range is in use by a network that belongs to a 
> different account of different domain then the request should fail
> *Releasing guest Vlan range*
> Admin should be allowed to release a dedicated guest vlan range that is 
> dedicated to a domain back to the system pool
> If the range is not dedicated to the domain then the request should fail
> Even If one/more of the Vlans belonging to the range is in use by a network 
> the range should be released back to the system pool
>  The vlans that are in use should continue to be in use by the network
> *Network implementation*
> If the network belongs to an account that has a dedicated range of Vlans then 
> a Vlan from the account's dedicated range should be allocated to the network
> If an account uses up all of its dedicated Vlan’s the next network being 
> created for the account should be assigned a Vlan that belongs to the domain 
> pool
> Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range 
> belonging to the zone
> *Network creation*
> If a Vlan id is specified and if this id belongs to a dedicated Vlan range of 
> a different account/domain then the creation should fail
> If a Vlan id is specified and if this id belongs to the system pool but the 
> network owner has a range of dedicated range of vlans then the creation 
> should fail
> *Domain deletion*
> Guest Ip ranges and vlans dedicated to the domain should be released back to 
> the free pool 
> *Account deletion*
> When an account is deleted, the IP ranges and vlans associated with the 
> account  should be moved to system pool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10210) remove test file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310854#comment-16310854
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10210:
-

marcaurele commented on a change in pull request #2384: CLOUDSTACK-10210 
cleanup testfile
URL: https://github.com/apache/cloudstack/pull/2384#discussion_r159588962
 
 

 ##
 File path: 
services/secondary-storage/server/test/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResourceTest.java
 ##
 @@ -49,16 +51,22 @@ public void setUp() {
 resource = new NfsSecondaryStorageResource();
 }
 
+String filename = "testfile";
+@After
+public void cleanup() {
+File remnance = new File(filename);
+remnance.deleteOnExit();
 
 Review comment:
   `exists()` check?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> remove test file
> 
>
> Key: CLOUDSTACK-10210
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10210
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Secondary Storage
>Reporter: Daan Hoogland
>Assignee: Daan Hoogland
>Priority: Trivial
>
> test leaves 'testfile' as remanence. remove in @after test finishes 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310855#comment-16310855
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355211594
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1563


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9892) Primary storage resource check is broken when using root disk size override to deploy VM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310853#comment-16310853
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9892:


blueorangutan commented on issue #2088: CLOUDSTACK-9892: Primary storage 
resource check is broken when using …
URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355211366
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary storage resource check is broken when using root disk size override 
> to deploy VM
> 
>
> Key: CLOUDSTACK-9892
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9892
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
>Reporter: Koushik Das
>Assignee: Koushik Das
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> Primary storage resource check for account/domain is broken when using root 
> disk size override to deploy VM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9892) Primary storage resource check is broken when using root disk size override to deploy VM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310852#comment-16310852
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9892:


rhtyd commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check 
is broken when using …
URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355211273
 
 
   Sure @yvsubhash 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary storage resource check is broken when using root disk size override 
> to deploy VM
> 
>
> Key: CLOUDSTACK-9892
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9892
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
>Reporter: Koushik Das
>Assignee: Koushik Das
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> Primary storage resource check for account/domain is broken when using root 
> disk size override to deploy VM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9892) Primary storage resource check is broken when using root disk size override to deploy VM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310848#comment-16310848
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9892:


yvsubhash commented on issue #2088: CLOUDSTACK-9892: Primary storage resource 
check is broken when using …
URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355210769
 
 
   @rhtyd  Most of the failures are related to test cleanup issues. Can you 
please re run the tests as this pr has not been rebased for a long time


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary storage resource check is broken when using root disk size override 
> to deploy VM
> 
>
> Key: CLOUDSTACK-9892
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9892
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
>Reporter: Koushik Das
>Assignee: Koushik Das
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> Primary storage resource check for account/domain is broken when using root 
> disk size override to deploy VM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310812#comment-16310812
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10197:
-

blueorangutan commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso 
for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355207231
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> XenServer 7.1: Cannot mount  xentool iso from cloudstack on VMs
> ---
>
> Key: CLOUDSTACK-10197
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
> Environment: XenServer 7.0+
>Reporter: Khosrow Moossavi
> Fix For: Future
>
>
> In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to 
> *guest-tools* so CloudStack fails to attach it to any VM.
> {code}
> (acs-admin) > attach iso 
> virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e 
> id=e8a56540-0fc3-44de-9911-635d2d8f25c4
> errorcode = 530
> errortext = Failed to attach iso
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310805#comment-16310805
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355207060
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1560


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310809#comment-16310809
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10065:
-

blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries 
in listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-355207147
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1562


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize SQL queries in listTemplate API to improve performance. 
> -
>
> Key: CLOUDSTACK-10065
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Pranali Mande
>
> *Description*:
> The db queries could be optimized to get unique results from the database 
> which could help in reducing the listTemplate API response time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310806#comment-16310806
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10197:
-

blueorangutan commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso 
for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355207062
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1561


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> XenServer 7.1: Cannot mount  xentool iso from cloudstack on VMs
> ---
>
> Key: CLOUDSTACK-10197
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
> Environment: XenServer 7.0+
>Reporter: Khosrow Moossavi
> Fix For: Future
>
>
> In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to 
> *guest-tools* so CloudStack fails to attach it to any VM.
> {code}
> (acs-admin) > attach iso 
> virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e 
> id=e8a56540-0fc3-44de-9911-635d2d8f25c4
> errorcode = 530
> errortext = Failed to attach iso
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310810#comment-16310810
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10197:
-

rhtyd commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for 
XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355207160
 
 
   @blueorangutan test centos7 xenserver-65sp1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> XenServer 7.1: Cannot mount  xentool iso from cloudstack on VMs
> ---
>
> Key: CLOUDSTACK-10197
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
> Environment: XenServer 7.0+
>Reporter: Khosrow Moossavi
> Fix For: Future
>
>
> In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to 
> *guest-tools* so CloudStack fails to attach it to any VM.
> {code}
> (acs-admin) > attach iso 
> virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e 
> id=e8a56540-0fc3-44de-9911-635d2d8f25c4
> errorcode = 530
> errortext = Failed to attach iso
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10210) remove test file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310799#comment-16310799
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10210:
-

rhtyd commented on issue #2384: CLOUDSTACK-10210 cleanup testfile
URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355205963
 
 
   @rafaelweingartner do we have your +1/lgtm from ML applicable here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> remove test file
> 
>
> Key: CLOUDSTACK-10210
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10210
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Secondary Storage
>Reporter: Daan Hoogland
>Assignee: Daan Hoogland
>Priority: Trivial
>
> test leaves 'testfile' as remanence. remove in @after test finishes 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10029) Virtual Router network interfaces are being constantly added by cloudstack.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310794#comment-16310794
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10029:
-

rhtyd closed pull request #2203: [CLOUDSTACK-10029] All private, public, and 
guest interfaceses are marked as untagged ca…
URL: https://github.com/apache/cloudstack/pull/2203
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index 2440e624ffa..c2a759b1e88 100644
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -1695,8 +1695,7 @@ public ExecutionResult prepareNetworkElementCommand(final 
IpAssocCommand cmd) {
 if (nic.getBrName().equalsIgnoreCase(_linkLocalBridgeName)) {
 broadcastUriAllocatedToVM.put("LinkLocal", nicPos);
 } else {
-if (nic.getBrName().equalsIgnoreCase(_publicBridgeName) || 
nic.getBrName().equalsIgnoreCase(_privBridgeName) ||
-
nic.getBrName().equalsIgnoreCase(_guestBridgeName)) {
+if (nic.getBrName() == null) {
 
broadcastUriAllocatedToVM.put(BroadcastDomainType.Vlan.toUri(Vlan.UNTAGGED).toString(),
 nicPos);
 } else {
 final String broadcastUri = 
getBroadcastUriFromBridge(nic.getBrName());
@@ -1749,8 +1748,7 @@ protected ExecutionResult 
cleanupNetworkElementCommand(final IpAssocCommand cmd)
 if (nic.getBrName().equalsIgnoreCase(_linkLocalBridgeName)) {
 broadcastUriAllocatedToVM.put("LinkLocal", nicPos);
 } else {
-if (nic.getBrName().equalsIgnoreCase(_publicBridgeName) || 
nic.getBrName().equalsIgnoreCase(_privBridgeName) ||
-
nic.getBrName().equalsIgnoreCase(_guestBridgeName)) {
+if (nic.getBrName() == null) {
 
broadcastUriAllocatedToVM.put(BroadcastDomainType.Vlan.toUri(Vlan.UNTAGGED).toString(),
 nicPos);
 } else {
 final String broadcastUri = 
getBroadcastUriFromBridge(nic.getBrName());


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Virtual Router network interfaces are being constantly added by cloudstack.
> ---
>
> Key: CLOUDSTACK-10029
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10029
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0
> Environment: Centos 7 x86_64
>Reporter: Konstantin Trushin
>
> When adding static nat eth interfaces are being added constantly to Virtual 
> Router VM till they reach PCI slot limit of libvirt. This is caused by 
> public, private and guest interfaces being marked as untagged and in HashMap 
> and values are overwritten and cleanupNetworkElementCommand dosn't know nic 
> number in VR VM and constantly adds eth interfaces.
> Below is some debugging output:
> 2017-07-25 10:47:21,054 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) Exexutiong 
> cleanupNetworkElementCommand
> 2017-07-25 10:47:21,054 DEBUG [kvm.resource.LibvirtConnection] 
> (agentRequest-Handler-2:null) (logid:57628c13) Looking for libvirtd 
> connection at: qemu:///system
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: 
> {vlan://untagged=0}
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, 
> vlan://untagged=0}
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, 
> vlan://untagged=2}
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) 

[jira] [Commented] (CLOUDSTACK-10029) Virtual Router network interfaces are being constantly added by cloudstack.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310793#comment-16310793
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10029:
-

rhtyd commented on issue #2203: [CLOUDSTACK-10029] All private, public, and 
guest interfaceses are marked as untagged ca…
URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-355205088
 
 
   Given https://github.com/apache/cloudstack/pull/2304 is merged, nics are now 
read from hashmap referenced using the mac address. I'll close this PR given 
this, please re-open/engage if you disagree, thanks for your PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Virtual Router network interfaces are being constantly added by cloudstack.
> ---
>
> Key: CLOUDSTACK-10029
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10029
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.10.0.0
> Environment: Centos 7 x86_64
>Reporter: Konstantin Trushin
>
> When adding static nat eth interfaces are being added constantly to Virtual 
> Router VM till they reach PCI slot limit of libvirt. This is caused by 
> public, private and guest interfaces being marked as untagged and in HashMap 
> and values are overwritten and cleanupNetworkElementCommand dosn't know nic 
> number in VR VM and constantly adds eth interfaces.
> Below is some debugging output:
> 2017-07-25 10:47:21,054 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) Exexutiong 
> cleanupNetworkElementCommand
> 2017-07-25 10:47:21,054 DEBUG [kvm.resource.LibvirtConnection] 
> (agentRequest-Handler-2:null) (logid:57628c13) Looking for libvirtd 
> connection at: qemu:///system
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: 
> {vlan://untagged=0}
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, 
> vlan://untagged=0}
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, 
> vlan://untagged=2}
> 2017-07-25 10:47:21,057 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, 
> vlan://untagged=3}
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, 
> vlan://untagged=4}
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) NIC pos 5
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) HASH MAP DUMP: {LinkLocal=1, 
> vlan://untagged=4}
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) Lokking for BroadcastUri 
> vlan://261
> 2017-07-25 10:47:21,058 ERROR [kvm.resource.LibvirtComputingResource] 
> (agentRequest-Handler-2:null) (logid:57628c13) Plugging in VIF with MAC 
> 1e:00:07:00:02:c8



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9908) Primary Storage allocated capacity goes very high after VM snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310792#comment-16310792
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9908:


blueorangutan commented on issue #2104: CLOUDSTACK-9908 : Primary Storage 
allocated capacity goes very high after VM snapshot
URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-355205002
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary Storage allocated capacity goes very high after VM snapshot
> ---
>
> Key: CLOUDSTACK-9908
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9908
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0
>Reporter: jay
> Fix For: 4.10.1.0
>
>
> Take a VM snapshot, the primary storage allocated capacity goes very high 
> causing the other deployments to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9908) Primary Storage allocated capacity goes very high after VM snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310789#comment-16310789
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9908:


rhtyd commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated 
capacity goes very high after VM snapshot
URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-355204913
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary Storage allocated capacity goes very high after VM snapshot
> ---
>
> Key: CLOUDSTACK-9908
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9908
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.9.0
>Reporter: jay
> Fix For: 4.10.1.0
>
>
> Take a VM snapshot, the primary storage allocated capacity goes very high 
> causing the other deployments to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9896) ListDedicatedXXX doesn't respect pagination

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310786#comment-16310786
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9896:


rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should 
respect pagination
URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-355204884
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ListDedicatedXXX doesn't respect pagination
> ---
>
> Key: CLOUDSTACK-9896
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9896
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> The listDedicatedZones, listDedicatedPods, listDedicatedClusters, 
> listDedicatedHosts are not using the pagination filter to return the results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9743) ODL plugin responds to deleteHost causing other plugin in the chain to be ignored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310788#comment-16310788
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9743:


blueorangutan commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds 
to deleteHost causing other plugin in the chain to be ignored 
URL: https://github.com/apache/cloudstack/pull/1906#issuecomment-355204911
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ODL plugin responds to deleteHost causing other plugin in the chain to be 
> ignored
> -
>
> Key: CLOUDSTACK-9743
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9743
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent, Network Controller
>Reporter: Syed Ahmed
>
> ODL plugin responds to deleteHost causing other plugin in the chain to be 
> ignored



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9896) ListDedicatedXXX doesn't respect pagination

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310787#comment-16310787
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9896:


blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX 
should respect pagination
URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-355204906
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ListDedicatedXXX doesn't respect pagination
> ---
>
> Key: CLOUDSTACK-9896
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9896
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Marc-Aurèle Brothier
>Assignee: Marc-Aurèle Brothier
>Priority: Minor
>
> The listDedicatedZones, listDedicatedPods, listDedicatedClusters, 
> listDedicatedHosts are not using the pagination filter to return the results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9743) ODL plugin responds to deleteHost causing other plugin in the chain to be ignored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310785#comment-16310785
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9743:


rhtyd commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to 
deleteHost causing other plugin in the chain to be ignored 
URL: https://github.com/apache/cloudstack/pull/1906#issuecomment-355204853
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ODL plugin responds to deleteHost causing other plugin in the chain to be 
> ignored
> -
>
> Key: CLOUDSTACK-9743
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9743
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent, Network Controller
>Reporter: Syed Ahmed
>
> ODL plugin responds to deleteHost causing other plugin in the chain to be 
> ignored



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10087) Template registration errors out when template URL is https

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310783#comment-16310783
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10087:
-

rhtyd commented on issue #2271: CLOUDSTACK-10087 Template registration errors 
out when template URL i…
URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-355204721
 
 
   Can you update/fix this for master @SudharmaJain 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Template registration errors out when template URL is https
> ---
>
> Key: CLOUDSTACK-10087
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10087
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> *Management server logs:*
> 2017-08-23 08:55:36,706 DEBUG [c.c.a.t.Request] (AgentManager-Handler-5:null) 
> (logid:) Seq 4-7842174326135586819: Processing:  { Ans: , MgmtId: 4278190080, 
> via: 4, Ver: v1, Flags: 110, 
> [{"com.cloud.agent.api.Answer":{"result":false,"details":"com.amazonaws.SdkClientException:
>  Unable to execute HTTP request: sun.security.validator.ValidatorException: 
> PKIX path building failed: 
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
> valid certification path to requested target\n\tat 
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:972)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:676)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:650)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:633)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$300(AmazonHttpClient.java:601)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:583)\n\tat
>  com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:447)\n\tat 
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4137)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.getBucketRegionViaHeadRequest(AmazonS3Client.java:4856)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.fetchRegionFromCache(AmazonS3Client.java:4830)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4122)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4079)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:819)\n\tat
>  com.cloud.utils.storage.S3.S3Utils.listDirectory(S3Utils.java:179)\n\tat 
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.s3ListVolume(NfsSecondaryStorageResource.java:1667)\n\tat
>  
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.execute(NfsSecondaryStorageResource.java:1721)\n\tat
>  
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.executeRequest(NfsSecondaryStorageResource.java:277)\n\tat
>  
> com.cloud.storage.resource.PremiumSecondaryStorageResource.defaultAction(PremiumSecondaryStorageResource.java:64)\n\tat
>  
> com.cloud.storage.resource.PremiumSecondaryStorageResource.executeRequest(PremiumSecondaryStorageResource.java:60)\n\tat
>  com.cloud.agent.Agent.processRequest(Agent.java:525)\n\tat 
> com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:833)\n\tat 
> com.cloud.utils.nio.Task.call(Task.java:83)\n\tat 
> com.cloud.utils.nio.Task.call(Task.java:29)\n\tat 
> java.util.concurrent.FutureTask.run(FutureTask.java:266)\n\tat 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\n\tat
>  
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\n\tat
>  java.lang.Thread.run(Thread.java:745)\nCaused by: 
> javax.net.ssl.SSLHandshakeException: 
> sun.security.validator.ValidatorException: PKIX path building failed: 
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
> valid certification path to requested target\n\tat 
> sun.security.ssl.Alerts.getSSLException(Alerts.java:192)\n\tat 
> sun.security.ssl.SSLSocketImpl.fatal(SSLSocketImpl.java:1949)\n\tat 
> sun.security.ssl.Handshaker.fatalSE(Handshaker.java:302)\n\tat 
> sun.security.ssl.Handshaker.fatalSE(Handshaker.java:296)\n\tat 
> sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1509)\n\tat
>  
> 

[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310782#comment-16310782
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10096:
-

blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch…
URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355204709
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can't reset api.integration.port and usage.sanity.check.interval back to null
> -
>
> Key: CLOUDSTACK-10096
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> Fix for CLOUDSTACK-7931 enforces a value to be configured for 
> api.integration.port and usage.sanity.check.interval. These global configs 
> can't be reset back to null(default). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310781#comment-16310781
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10096:
-

rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch…
URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355204644
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can't reset api.integration.port and usage.sanity.check.interval back to null
> -
>
> Key: CLOUDSTACK-10096
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> Fix for CLOUDSTACK-7931 enforces a value to be configured for 
> api.integration.port and usage.sanity.check.interval. These global configs 
> can't be reset back to null(default). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9976) Redirect saml2 failed login message to a configurable URL

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310778#comment-16310778
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9976:


rhtyd commented on issue #2185: CLOUDSTACK-9976: Redirect saml2 failed login 
message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#issuecomment-355204137
 
 
   Can you verify/fix the failures @GabrielBrascher 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Redirect saml2 failed login message to a configurable URL
> -
>
> Key: CLOUDSTACK-9976
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9976
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Gabriel Beims Bräscher
>Assignee: Gabriel Beims Bräscher
>Priority: Minor
> Fix For: 4.10.1.0
>
> Attachments: samlLoginResponse.png
>
>
> When a user fails to authenticate with SAML2, it returns an error page 
> showing the content of the attached image.
> To make it more user-friendly and customizable, one could configure a 
> desirable URL to redirect when such authentication failure happens.
> This ticket proposes a global settings variable 
> (saml2.failed.login.redirect.url). If null, the SAML2 authentication flow 
> does not change from the current; however, if the user configures an URL then 
> ACS redirects to that URL.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-8609) [VMware] VM is not accessible after a migration across clusters.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310775#comment-16310775
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8609:


rhtyd commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible 
after migration across clusters
URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-355204065
 
 
   Ping can you fix the conflicts @sureshanaparti 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] VM is not accessible after a migration across clusters.
> 
>
> Key: CLOUDSTACK-8609
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8609
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Likitha Shetty
>Assignee: Suresh Kumar Anaparti
> Fix For: Future
>
>
> +Steps to reproduce+
> 1. Deploy a VMware zone with 2 clusters (a host each, H1 and H2) and one 
> zone-wide primary storage spanning the two clusters.
> 2. Deploy a VM (VM1) on one of the hosts (H1).
> 3. Stop VM1.
> 4. Make the host that contains the VM unsuitable for further VM deployments
> - host runs out of capacity (cpu/memory)
> - host has maximum VMs deployed on it
> 5. Start VM1.
> 6. VM will be powered on H2 but will not be accessible because the .vmx and 
> other VM files associated with the VM have been deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310773#comment-16310773
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10108:
-

blueorangutan commented on issue #2292: CLOUDSTACK-10108:ConfigKey based 
approach for reading 'ping' configua…
URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355203962
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ConfigKey based approach for reading 'ping' configuaration for Management 
> Server
> 
>
> Key: CLOUDSTACK-10108
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: mrunalini
>Priority: Minor
>
> In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using 
> configdao which involves direct reading of DB. So, replace it with ConfigKey 
> based approach



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310772#comment-16310772
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10108:
-

rhtyd commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for 
reading 'ping' configua…
URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355203938
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ConfigKey based approach for reading 'ping' configuaration for Management 
> Server
> 
>
> Key: CLOUDSTACK-10108
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: mrunalini
>Priority: Minor
>
> In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using 
> configdao which involves direct reading of DB. So, replace it with ConfigKey 
> based approach



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9906) Create snapshot after volume resize for the volume with existing snapshot(s)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310769#comment-16310769
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9906:


blueorangutan commented on issue #2079: CLOUDSTACK-9906 Create snapshot after 
volume resize for the volume with existing snapshot(s)
URL: https://github.com/apache/cloudstack/pull/2079#issuecomment-355203857
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create snapshot after volume resize for the volume with existing snapshot(s)
> 
>
> Key: CLOUDSTACK-9906
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9906
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Snapshot, Volumes
> Environment: XenServer
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>
> Snapshot of a volume fails if the volume has an existing snapshot(s) taken 
> before resizing of the volume. This behavior needs to be improved so that 
> taking snapshot would be successful when there is an existing snapshot(s) 
> before volume resizing.
> REPRO STEPS 
> =
> - Create a volume with 10 GB and attach to any VM.
> - Take snapshot  of the volume.
> - Change volume size from 10GB to 15 GB.
> - Take snapshot of the volume after resizing it.
> - Create a volume from the snapshot taken after resizing volume.
> - Attach the volume (created above) to any VM and check the size.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9906) Create snapshot after volume resize for the volume with existing snapshot(s)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310768#comment-16310768
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9906:


rhtyd commented on issue #2079: CLOUDSTACK-9906 Create snapshot after volume 
resize for the volume with existing snapshot(s)
URL: https://github.com/apache/cloudstack/pull/2079#issuecomment-355203812
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create snapshot after volume resize for the volume with existing snapshot(s)
> 
>
> Key: CLOUDSTACK-9906
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9906
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Snapshot, Volumes
> Environment: XenServer
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>
> Snapshot of a volume fails if the volume has an existing snapshot(s) taken 
> before resizing of the volume. This behavior needs to be improved so that 
> taking snapshot would be successful when there is an existing snapshot(s) 
> before volume resizing.
> REPRO STEPS 
> =
> - Create a volume with 10 GB and attach to any VM.
> - Take snapshot  of the volume.
> - Change volume size from 10GB to 15 GB.
> - Take snapshot of the volume after resizing it.
> - Create a volume from the snapshot taken after resizing volume.
> - Attach the volume (created above) to any VM and check the size.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10126) Separate Subnet for CPVM and SSVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310770#comment-16310770
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10126:
-

blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for 
SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-355203863
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Separate Subnet for CPVM and SSVM
> -
>
> Key: CLOUDSTACK-10126
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10126
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> Separate Management Subnet for CPVM and SSVM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310771#comment-16310771
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355203867
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10126) Separate Subnet for CPVM and SSVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310766#comment-16310766
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10126:
-

rhtyd commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and 
CPVM
URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-355203784
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Separate Subnet for CPVM and SSVM
> -
>
> Key: CLOUDSTACK-10126
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10126
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>
> Separate Management Subnet for CPVM and SSVM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310765#comment-16310765
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355203745
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10205) LinkDomainToLdap returns internal id

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310764#comment-16310764
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10205:
-

rhtyd commented on issue #2378: CLOUDSTACK-10205 make LinkDomainToLdap return 
UUID instead of internal id
URL: https://github.com/apache/cloudstack/pull/2378#issuecomment-355203722
 
 
   @nvazquez @borisstoyanov can you review this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LinkDomainToLdap returns internal id
> 
>
> Key: CLOUDSTACK-10205
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10205
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> The response should contain the uuid for the domain and not the internal db 
> id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310761#comment-16310761
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355203515
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310762#comment-16310762
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355203546
 
 
   test_01_create_volume failed on both vmware 55u3 and 65, we'll need another 
re-run. /cc @nvazquez @borisstoyanov 
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310759#comment-16310759
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355203424
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10207) updateVpnCustomerGateway: unexpected changes on optional keys

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310758#comment-16310758
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10207:
-

rhtyd commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix 
defaulting for option…
URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-355203300
 
 
   Additional review requested


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> updateVpnCustomerGateway: unexpected changes on optional keys
> -
>
> Key: CLOUDSTACK-10207
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10207
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: René Moser
>Assignee: René Moser
>Priority: Minor
> Fix For: 4.11.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310757#comment-16310757
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for 
KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355203101
 
 
   Tests LGTM. I'll wait for lgtm from @borisstoyanov @DaanHoogland 
@rafaelweingartner 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310756#comment-16310756
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10065:
-

blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries 
in listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-355203057
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize SQL queries in listTemplate API to improve performance. 
> -
>
> Key: CLOUDSTACK-10065
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Pranali Mande
>
> *Description*:
> The db queries could be optimized to get unique results from the database 
> which could help in reducing the listTemplate API response time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10065) Optimize SQL queries in listTemplate API to improve performance.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310754#comment-16310754
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10065:
-

rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in 
listTemplate API to improve performance
URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-355202998
 
 
   Several failures (env related) seen, I'll rekick tests.
   @blueorangutan package
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize SQL queries in listTemplate API to improve performance. 
> -
>
> Key: CLOUDSTACK-10065
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10065
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Pranali Mande
>
> *Description*:
> The db queries could be optimized to get unique results from the database 
> which could help in reducing the listTemplate API response time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310752#comment-16310752
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10197:
-

rhtyd commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for 
XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355202924
 
 
   @blueorangutan package
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> XenServer 7.1: Cannot mount  xentool iso from cloudstack on VMs
> ---
>
> Key: CLOUDSTACK-10197
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
> Environment: XenServer 7.0+
>Reporter: Khosrow Moossavi
> Fix For: Future
>
>
> In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to 
> *guest-tools* so CloudStack fails to attach it to any VM.
> {code}
> (acs-admin) > attach iso 
> virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e 
> id=e8a56540-0fc3-44de-9911-635d2d8f25c4
> errorcode = 530
> errortext = Failed to attach iso
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310753#comment-16310753
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10197:
-

blueorangutan commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso 
for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355202932
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> XenServer 7.1: Cannot mount  xentool iso from cloudstack on VMs
> ---
>
> Key: CLOUDSTACK-10197
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
> Environment: XenServer 7.0+
>Reporter: Khosrow Moossavi
> Fix For: Future
>
>
> In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to 
> *guest-tools* so CloudStack fails to attach it to any VM.
> {code}
> (acs-admin) > attach iso 
> virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e 
> id=e8a56540-0fc3-44de-9911-635d2d8f25c4
> errorcode = 530
> errortext = Failed to attach iso
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310750#comment-16310750
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

rhtyd commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public 
IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355202707
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9599) UpdateTemplate Response is Missing "isdynamicallyscalable" Field

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310749#comment-16310749
 ] 

ASF subversion and git services commented on CLOUDSTACK-9599:
-

Commit d7e334b1b4aa39c35bc6029c1e5b0f050c097a78 in cloudstack's branch 
refs/heads/master from ernjvr
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=d7e334b ]

CLOUDSTACK-9599: isdynamicallyscalable field missing in updateTemplate Response 
(#2383)

Using cloudmonkey, when invoking the update template api call, it does not 
display the isdynamicallyscalable field as part of its template response.
fix done:
org.apache.cloudstack.api.response.TemplateResponse isdynamicallyscalable field 
is now populated in the 
server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java.newUpdateResponse 
method.
Unit test:
the Unit test server/test/com/cloud/api/query/dao/TemplateJoinDaoImplTest.java 
testNewUpdateResponse() verifies that the TemplateResponse is populated 
correctly.
Marvin test:
the Marvin nosetest integration/smoke/test_templates.py 
test_02_edit_template(self) confirms that the 
template_response.isdynamicallyscalable field gets populated with the correct 
user data.
Test scenario:
Using cloudmonkey, when invoking the 'update template' API call, it should now 
display the isdynamicallyscalable field as part of its template response.

> UpdateTemplate Response is Missing "isdynamicallyscalable" Field
> 
>
> Key: CLOUDSTACK-9599
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9599
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.6.1
>Reporter: John Burwell
>Priority: Minor
> Fix For: 4.9.2.0, 4.10.1.0, 4.11.0.0
>
>
> The response for the UpdateTemplate command does not include the 
> "isdynamicallyscalable" field.  The following is a sample of the output from 
> a call to a 4.6 management server:
> {code}
> cloudmonkey> update template id=7a6c263c-1e16-49dc-866e-7189f3f49052 
> passwordenabled=false
> {
>   "template": {
> "account": "admin",
> "bootable": true,
> "created": "2016-11-01T15:21:07+",
> "crossZones": false,
> "details": {
>   "dataDiskController": "osdefault",
>   "nicAdapter": "Vmxnet3",
>   "rootDiskController": "osdefault"
> },
> "displaytext": "Windows2012R2",
> "domain": "ROOT",
> "domainid": "80ed2086-a02e-11e6-8900-005056aa4c21",
> "format": "OVA",
> "hypervisor": "VMware",
> "id": "7a6c263c-1e16-49dc-866e-7189f3f49052",
> "isfeatured": false,
> "ispublic": true,
> "isready": false,
> "name": "Windows2012R2",
> "ostypeid": "0c1e7989-a034-11e6-8900-005056aa4c21",
> "ostypename": "Windows Server 2012 R2 (64-bit)",
> "tags": [],
> "templatetype": "USER"
>   }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310751#comment-16310751
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355202731
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310745#comment-16310745
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9572:


rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not 
cleaned up after Stor…
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-355202506
 
 
   @blueorangutan test centos7 xenserver-65sp1
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Snapshot on primary storage not cleaned up after Storage migration
> --
>
> Key: CLOUDSTACK-9572
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Affects Versions: 4.8.0
> Environment: Xen Server
>Reporter: subhash yedugundla
> Fix For: 4.8.1
>
>
> Issue Description
> ===
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local 
> storage and is transferring this snapshot to secondary storage. But the 
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage 
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and 
> is staying on local storage. So local storage will fill up with unneeded 
> snapshots.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10210) remove test file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310747#comment-16310747
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10210:
-

rhtyd commented on issue #2384: CLOUDSTACK-10210 cleanup testfile
URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355202554
 
 
   Additional review requested, test LGTM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> remove test file
> 
>
> Key: CLOUDSTACK-10210
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10210
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Secondary Storage
>Reporter: Daan Hoogland
>Assignee: Daan Hoogland
>Priority: Trivial
>
> test leaves 'testfile' as remanence. remove in @after test finishes 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310746#comment-16310746
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9572:


blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary 
storage not cleaned up after Stor…
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-355202539
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Snapshot on primary storage not cleaned up after Storage migration
> --
>
> Key: CLOUDSTACK-9572
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Affects Versions: 4.8.0
> Environment: Xen Server
>Reporter: subhash yedugundla
> Fix For: 4.8.1
>
>
> Issue Description
> ===
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local 
> storage and is transferring this snapshot to secondary storage. But the 
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage 
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and 
> is staying on local storage. So local storage will fill up with unneeded 
> snapshots.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9607) Preventing template deletion when template is in use.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310744#comment-16310744
 ] 

ASF subversion and git services commented on CLOUDSTACK-9607:
-

Commit 25b63f5e737aba00067e39ee0003f4b52713d6d6 in cloudstack's branch 
refs/heads/master from Mowgli
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=25b63f5 ]

CLOUDSTACK-9607: Preventing template deletion when template is in use (#1773)

Consider this scenario:
1. User launches a VM from Template and keep it running
2. Admin logins and deleted that template [CloudPlatform does not check 
existing / running VM etc. while the deletion is done]
3. User resets the VM
4. CloudPlatform fails to star the VM as it cannot find the corresponding 
template.

It throws error as 
java.lang.RuntimeException: Job failed due to exception Resource [Host:11] is 
unreachable: Host 11: Unable to start instance due to can't find ready 
template: 209 for data center 1
at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:113)
at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:495)

Client is requesting better handing of this scenario. We need to check existing 
/ running VM's when the template is deleted and warn admin about the possible 
issue that may occur.

REPRO STEPS
==
1. Launches a VM from Template and keep it running
2. Now delete that template 
3. Reset the VM
4. CloudPlatform fails to star the VM as it cannot find the corresponding 
template.

EXPECTED BEHAVIOR
==
Cloud platform should throw some warning message while the template is deleted 
if that template is being used by existing / running VM's

ACTUAL BEHAVIOR
==
Cloud platform does not throw as waring etc.

> Preventing template deletion when template is in use.
> -
>
> Key: CLOUDSTACK-9607
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9607
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> Consider this scenario:
> 1. User launches a VM from Template and keep it running
> 2. Admin logins and deleted that template [CloudPlatform does not check 
> existing / running VM etc. while the deletion is done]
> 3. User resets the VM
> 4. CloudPlatform fails to star the VM as it cannot find the corresponding 
> template.
> It throws error as 
> java.lang.RuntimeException: Job failed due to exception Resource [Host:11] is 
> unreachable: Host 11: Unable to start instance due to can't find ready 
> template: 209 for data center 1
> at 
> com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:113)
> at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:495)
> Client is requesting better handing of this scenario. We need to check 
> existing / running VM's when the template is deleted and warn admin about the 
> possible issue that may occur.
> REPRO STEPS
> ==
> 1. Launches a VM from Template and keep it running
> 2. Now delete that template 
> 3. Reset the VM
> 4. CloudPlatform fails to star the VM as it cannot find the corresponding 
> template.
> EXPECTED BEHAVIOR
> ==
> Cloud platform should throw some warning message while the template is 
> deleted if that template is being used by existing / running VM's
> ACTUAL BEHAVIOR
> ==
> Cloud platform does not throw as waring etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9607) Preventing template deletion when template is in use.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310743#comment-16310743
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9607:


rhtyd closed pull request #1773: CLOUDSTACK-9607: Preventing template deletion 
when template is in use.
URL: https://github.com/apache/cloudstack/pull/1773
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/api/src/org/apache/cloudstack/api/command/user/template/DeleteTemplateCmd.java
 
b/api/src/org/apache/cloudstack/api/command/user/template/DeleteTemplateCmd.java
old mode 100644
new mode 100755
index 98d53be836e..95b3059
--- 
a/api/src/org/apache/cloudstack/api/command/user/template/DeleteTemplateCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/user/template/DeleteTemplateCmd.java
@@ -52,6 +52,9 @@
 @Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID, 
entityType = ZoneResponse.class, description = "the ID of zone of the template")
 private Long zoneId;
 
+@Parameter(name = ApiConstants.FORCED, type = CommandType.BOOLEAN, 
required = false, description = "Force delete a template.", since = "4.9+")
+private Boolean forced;
+
 /
 /// Accessors ///
 /
@@ -64,6 +67,9 @@ public Long getZoneId() {
 return zoneId;
 }
 
+public boolean isForced() {
+return (forced != null) ? forced : true;
+}
 /
 /// API Implementation///
 /
diff --git a/engine/schema/src/com/cloud/vm/dao/VMInstanceDao.java 
b/engine/schema/src/com/cloud/vm/dao/VMInstanceDao.java
old mode 100644
new mode 100755
index 3c5024b833e..69efea42df9
--- a/engine/schema/src/com/cloud/vm/dao/VMInstanceDao.java
+++ b/engine/schema/src/com/cloud/vm/dao/VMInstanceDao.java
@@ -53,6 +53,14 @@
  */
 List listByPodId(long podId);
 
+/**
+ * Lists non-expunged VMs by  templateId
+ * @param templateId
+ * @return list of VMInstanceVO deployed from the specified template, that 
are not expunged
+ */
+public List listNonExpungedByTemplate(long templateId);
+
+
 /**
  * Lists non-expunged VMs by zone ID and templateId
  * @param zoneId
diff --git a/engine/schema/src/com/cloud/vm/dao/VMInstanceDaoImpl.java 
b/engine/schema/src/com/cloud/vm/dao/VMInstanceDaoImpl.java
old mode 100644
new mode 100755
index 7065350a57e..6e97d1275a6
--- a/engine/schema/src/com/cloud/vm/dao/VMInstanceDaoImpl.java
+++ b/engine/schema/src/com/cloud/vm/dao/VMInstanceDaoImpl.java
@@ -72,6 +72,7 @@
 protected SearchBuilder IdStatesSearch;
 protected SearchBuilder AllFieldsSearch;
 protected SearchBuilder ZoneTemplateNonExpungedSearch;
+protected SearchBuilder TemplateNonExpungedSearch;
 protected SearchBuilder NameLikeSearch;
 protected SearchBuilder StateChangeSearch;
 protected SearchBuilder TransitionSearch;
@@ -165,6 +166,12 @@ protected void init() {
 ZoneTemplateNonExpungedSearch.and("state", 
ZoneTemplateNonExpungedSearch.entity().getState(), Op.NEQ);
 ZoneTemplateNonExpungedSearch.done();
 
+
+TemplateNonExpungedSearch = createSearchBuilder();
+TemplateNonExpungedSearch.and("template", 
TemplateNonExpungedSearch.entity().getTemplateId(), Op.EQ);
+TemplateNonExpungedSearch.and("state", 
TemplateNonExpungedSearch.entity().getState(), Op.NEQ);
+TemplateNonExpungedSearch.done();
+
 NameLikeSearch = createSearchBuilder();
 NameLikeSearch.and("name", NameLikeSearch.entity().getHostName(), 
Op.LIKE);
 NameLikeSearch.done();
@@ -334,6 +341,15 @@ protected void init() {
 return listBy(sc);
 }
 
+@Override
+public List listNonExpungedByTemplate(long templateId) {
+SearchCriteria sc = TemplateNonExpungedSearch.create();
+
+sc.setParameters("template", templateId);
+sc.setParameters("state", State.Expunging);
+return listBy(sc);
+}
+
 @Override
 public List listNonExpungedByZoneAndTemplate(long zoneId, 
long templateId) {
 SearchCriteria sc = 
ZoneTemplateNonExpungedSearch.create();
diff --git a/server/src/com/cloud/template/TemplateManagerImpl.java 
b/server/src/com/cloud/template/TemplateManagerImpl.java
old mode 100644
new mode 100755
index f6494c3b77e..41f11af68d0
--- a/server/src/com/cloud/template/TemplateManagerImpl.java
+++ b/server/src/com/cloud/template/TemplateManagerImpl.java
@@ -38,6 +38,7 @@
 import com.cloud.utils.DateUtil;
 

[jira] [Commented] (CLOUDSTACK-9607) Preventing template deletion when template is in use.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310742#comment-16310742
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9607:


rhtyd commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion 
when template is in use.
URL: https://github.com/apache/cloudstack/pull/1773#issuecomment-35520
 
 
   Merging this based on code review lgtms and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Preventing template deletion when template is in use.
> -
>
> Key: CLOUDSTACK-9607
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9607
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> Consider this scenario:
> 1. User launches a VM from Template and keep it running
> 2. Admin logins and deleted that template [CloudPlatform does not check 
> existing / running VM etc. while the deletion is done]
> 3. User resets the VM
> 4. CloudPlatform fails to star the VM as it cannot find the corresponding 
> template.
> It throws error as 
> java.lang.RuntimeException: Job failed due to exception Resource [Host:11] is 
> unreachable: Host 11: Unable to start instance due to can't find ready 
> template: 209 for data center 1
> at 
> com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:113)
> at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:495)
> Client is requesting better handing of this scenario. We need to check 
> existing / running VM's when the template is deleted and warn admin about the 
> possible issue that may occur.
> REPRO STEPS
> ==
> 1. Launches a VM from Template and keep it running
> 2. Now delete that template 
> 3. Reset the VM
> 4. CloudPlatform fails to star the VM as it cannot find the corresponding 
> template.
> EXPECTED BEHAVIOR
> ==
> Cloud platform should throw some warning message while the template is 
> deleted if that template is being used by existing / running VM's
> ACTUAL BEHAVIOR
> ==
> Cloud platform does not throw as waring etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-7958) Limit user login to specific subnets

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310739#comment-16310739
 ] 

ASF GitHub Bot commented on CLOUDSTACK-7958:


rhtyd closed pull request #2046: CLOUDSTACK-7958: Add configuration for limit 
to CIDRs for Admin API calls
URL: https://github.com/apache/cloudstack/pull/2046
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java 
b/agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java
index 86d3bebb38b..b3b17e7d970 100644
--- a/agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java
+++ b/agent/src/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java
@@ -276,12 +276,12 @@ private void addRouteToInternalIpOrCidr(String localgw, 
String eth1ip, String et
 s_logger.debug("addRouteToInternalIp: destIp is null");
 return;
 }
-if (!NetUtils.isValidIp(destIpOrCidr) && 
!NetUtils.isValidCIDR(destIpOrCidr)) {
+if (!NetUtils.isValidIp4(destIpOrCidr) && 
!NetUtils.isValidIp4Cidr(destIpOrCidr)) {
 s_logger.warn(" destIp is not a valid ip address or cidr destIp=" 
+ destIpOrCidr);
 return;
 }
 boolean inSameSubnet = false;
-if (NetUtils.isValidIp(destIpOrCidr)) {
+if (NetUtils.isValidIp4(destIpOrCidr)) {
 if (eth1ip != null && eth1mask != null) {
 inSameSubnet = NetUtils.sameSubnet(eth1ip, destIpOrCidr, 
eth1mask);
 } else {
diff --git a/api/src/org/apache/cloudstack/api/ApiServerService.java 
b/api/src/org/apache/cloudstack/api/ApiServerService.java
index 2b5768261b5..382b48a5e02 100644
--- a/api/src/org/apache/cloudstack/api/ApiServerService.java
+++ b/api/src/org/apache/cloudstack/api/ApiServerService.java
@@ -24,7 +24,7 @@
 import com.cloud.exception.CloudAuthenticationException;
 
 public interface ApiServerService {
-public boolean verifyRequest(Map requestParameters, Long 
userId) throws ServerApiException;
+public boolean verifyRequest(Map requestParameters, Long 
userId, InetAddress remoteAddress) throws ServerApiException;
 
 public Long fetchDomainId(String domainUUID);
 
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java
 
b/api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java
index 1f14abf4a5a..9299c3ddd2c 100644
--- 
a/api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java
@@ -246,10 +246,10 @@ public void create() {
 String guestCidr = 
_networkService.getNetwork(getNetworkId()).getCidr();
 
 for (String cidr : getSourceCidrList()) {
-if (!NetUtils.isValidCIDR(cidr)) {
+if (!NetUtils.isValidIp4Cidr(cidr) && 
!NetUtils.isValidIp6Cidr(cidr)) {
 throw new ServerApiException(ApiErrorCode.PARAM_ERROR, 
"Source cidrs formatting error " + cidr);
 }
-if (cidr.equals(NetUtils.ALL_CIDRS)) {
+if (cidr.equals(NetUtils.ALL_IP4_CIDRS)) {
 continue;
 }
 if (!NetUtils.isNetworkAWithinNetworkB(cidr, guestCidr)) {
@@ -261,7 +261,7 @@ public void create() {
 //Destination CIDR formatting check. Since it's optional param, no 
need to set a default as in the case of source.
 if(destCidrList != null){
 for(String cidr : destCidrList){
-if(!NetUtils.isValidCIDR(cidr)) {
+if(!NetUtils.isValidIp4Cidr(cidr) && 
!NetUtils.isValidIp6Cidr(cidr)) {
 throw new ServerApiException(ApiErrorCode.PARAM_ERROR, 
"Destination cidrs formatting error" + cidr);
 }
 }
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
 
b/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
index 548b81447fe..fab7d9eef29 100644
--- 
a/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
@@ -108,7 +108,7 @@ public String getProtocol() {
 return cidrlist;
 } else {
 List oneCidrList = new ArrayList();
-oneCidrList.add(NetUtils.ALL_CIDRS);
+oneCidrList.add(NetUtils.ALL_IP4_CIDRS);
 return oneCidrList;
 }
 
@@ -242,7 +242,7 @@ 

[jira] [Commented] (CLOUDSTACK-7958) Limit user login to specific subnets

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310738#comment-16310738
 ] 

ASF GitHub Bot commented on CLOUDSTACK-7958:


rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to 
CIDRs for Admin API calls
URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-355202001
 
 
   Merging this based on 2 code reviews lgtm and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Limit user login to specific subnets
> 
>
> Key: CLOUDSTACK-7958
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7958
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, Management Server
>Affects Versions: Future
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>Priority: Minor
> Fix For: Future
>
>
> When exposing the API there is a potential danger that a user gets his hands 
> on a account with Admin privileges and does bad things to a cloud.
> It would be a useful feature if we could limit certain accounts/users to 
> specific subnets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-7958) Limit user login to specific subnets

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310741#comment-16310741
 ] 

ASF GitHub Bot commented on CLOUDSTACK-7958:


rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to 
CIDRs for Admin API calls
URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-355202001
 
 
   Merging this based on 2 code reviews lgtm and test results. Checked and 
found the one failing smoketest to be env related.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Limit user login to specific subnets
> 
>
> Key: CLOUDSTACK-7958
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7958
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, Management Server
>Affects Versions: Future
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>Priority: Minor
> Fix For: Future
>
>
> When exposing the API there is a potential danger that a user gets his hands 
> on a account with Admin privileges and does bad things to a cloud.
> It would be a useful feature if we could limit certain accounts/users to 
> specific subnets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-7958) Limit user login to specific subnets

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310740#comment-16310740
 ] 

ASF subversion and git services commented on CLOUDSTACK-7958:
-

Commit 9988c269b259b84c0b8436bad17f88dbc1d706e7 in cloudstack's branch 
refs/heads/master from [~widodh]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=9988c26 ]

CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls 
(#2046)

* Cleanup and Improve NetUtils

This class had many unused methods, inconsistent names and redundant code.

This commit cleans up code, renames a few methods and constants.

The global/account setting 'api.allowed.source.cidr.list' is set
to 0.0.0.0/0,::/0 by default preserve the current behavior and thus
allow API calls for accounts from all IPv4 and IPv6 subnets.

Users can set it to a comma-separated list of IPv4/IPv6 subnets to
restrict API calls for Admin accounts to certain parts of their network(s).

This is to improve Security. Should an attacker steal the Access/Secret key
of an account he/she still needs to be in a subnet from where accounts are
allowed to perform API calls.

This is a good security measure for APIs which are connected to the public 
internet.

Signed-off-by: Wido den Hollander 

> Limit user login to specific subnets
> 
>
> Key: CLOUDSTACK-7958
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7958
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API, Management Server
>Affects Versions: Future
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>Priority: Minor
> Fix For: Future
>
>
> When exposing the API there is a potential danger that a user gets his hands 
> on a account with Admin privileges and does bad things to a cloud.
> It would be a useful feature if we could limit certain accounts/users to 
> specific subnets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9932) Snapshot is getting deleted while volume creation from the snapshot is in progress

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310736#comment-16310736
 ] 

ASF subversion and git services commented on CLOUDSTACK-9932:
-

Commit 2adbaeb64128d1b911efc20ee6a2c3a9cdae1eda in cloudstack's branch 
refs/heads/master from pavanaravapalli
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=2adbaeb ]

CLOUDSTACK-9932: Snapshot is getting deleted while volume creation from the 
snapshot is in progress (#2149)

Added validation to check if any volume(s) are in creating state , before 
performing delete snapshot.


> Snapshot is getting deleted while volume creation from the snapshot is in 
> progress 
> ---
>
> Key: CLOUDSTACK-9932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9932
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
> Environment: ACS -4.10.
> http://10.112.3.52:8080/client/
> user : admin
> password : password
>Reporter: veerapuppala
>Assignee: Pavan Kumar Aravapalli
>
> Issue:
> ---
> Snapshot is getting deleted while the volume create request from the snapshot 
> is in progress.
> Steps to reproduce :
> -
> 1) Create root/data volume snapshot
> 2) Create Volumes from the snapshot 
> 3) Delete the snapshot immediately while the volume creation is in progress
> Existing behavior:
> -
> Snapshot is getting deleted from the ACS and status is "Destroyed" in the 
> snapshots table.
> Error message:
> -
> 2017-05-30 04:10:17,120 DEBUG [c.c.a.t.Request] 
> (API-Job-Executor-26:ctx-8ba0012a job-188 ctx-ffe9988e) (logid:fd7a5d83) Seq 
> 1-1570067420092044880: Received:  { Ans: , MgmtId: 196796298644167, via: 
> 1(localhost), Ver: v1, Flags: 110, { CopyCmdAnswer } }
> 2017-05-30 04:10:17,131 WARN  [o.a.c.s.d.ObjectInDataStoreManagerImpl] 
> (API-Job-Executor-26:ctx-8ba0012a job-188 ctx-ffe9988e) (logid:fd7a5d83) 
> Unsupported data object (VOLUME, 
> org.apache.cloudstack.storage.datastore.PrimaryDataStoreImpl@5c07d712), no 
> need to delete from object in store ref table
> 2017-05-30 04:10:17,139 DEBUG [o.a.c.e.o.VolumeOrchestrator] 
> (API-Job-Executor-26:ctx-8ba0012a job-188 ctx-ffe9988e) (logid:fd7a5d83) 
> Failed to create volume from snapshot:null due to Task failed! Task record:   
>   uuid: bf2abdea-bea3-36e2-22f0-8fa62985c614
>nameLabel: Async.VDI.copy
>  nameDescription:
>allowedOperations: []
>currentOperations: {}
>  created: Tue May 30 04:10:10 EDT 2017
> finished: Tue May 30 04:10:16 EDT 2017
>   status: failure
>   residentOn: com.xensource.xenapi.Host@7a705050
> progress: 1.0
> type: 
>   result:
>errorInfo: [INTERNAL_ERROR, End_of_file]
>  otherConfig: {}
>subtaskOf: com.xensource.xenapi.Task@aaf13f6f
> subtasks: []
>  
> 2017-05-30 04:10:17,166 DEBUG [c.c.u.AccountManagerImpl] 
> (API-Job-Executor-26:ctx-8ba0012a job-188 ctx-ffe9988e) (logid:fd7a5d83) 
> Access granted to Acct[def73ff3-3fbb-11e7-b95a-b2fc35794ac7-admin] to 
> Domain:1/ by AffinityGroupAccessChecker
> 2017-05-30 04:10:17,180 ERROR [c.c.a.ApiAsyncJobDispatcher] 
> (API-Job-Executor-26:ctx-8ba0012a job-188) (logid:fd7a5d83) Unexpected 
> exception while executing 
> org.apache.cloudstack.api.command.admin.volume.CreateVolumeCmdByAdmin
> com.cloud.utils.exception.CloudRuntimeException: Failed to create volume: 42
> at 
> com.cloud.storage.VolumeApiServiceImpl.createVolume(VolumeApiServiceImpl.java:803)
> at 
> com.cloud.storage.VolumeApiServiceImpl.createVolume(VolumeApiServiceImpl.java:175)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:333)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
> at 
> org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:168)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9932) Snapshot is getting deleted while volume creation from the snapshot is in progress

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310734#comment-16310734
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9932:


rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted 
while volume is in creating state
URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-355201811
 
 
   Merging this based on code reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Snapshot is getting deleted while volume creation from the snapshot is in 
> progress 
> ---
>
> Key: CLOUDSTACK-9932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9932
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
> Environment: ACS -4.10.
> http://10.112.3.52:8080/client/
> user : admin
> password : password
>Reporter: veerapuppala
>Assignee: Pavan Kumar Aravapalli
>
> Issue:
> ---
> Snapshot is getting deleted while the volume create request from the snapshot 
> is in progress.
> Steps to reproduce :
> -
> 1) Create root/data volume snapshot
> 2) Create Volumes from the snapshot 
> 3) Delete the snapshot immediately while the volume creation is in progress
> Existing behavior:
> -
> Snapshot is getting deleted from the ACS and status is "Destroyed" in the 
> snapshots table.
> Error message:
> -
> 2017-05-30 04:10:17,120 DEBUG [c.c.a.t.Request] 
> (API-Job-Executor-26:ctx-8ba0012a job-188 ctx-ffe9988e) (logid:fd7a5d83) Seq 
> 1-1570067420092044880: Received:  { Ans: , MgmtId: 196796298644167, via: 
> 1(localhost), Ver: v1, Flags: 110, { CopyCmdAnswer } }
> 2017-05-30 04:10:17,131 WARN  [o.a.c.s.d.ObjectInDataStoreManagerImpl] 
> (API-Job-Executor-26:ctx-8ba0012a job-188 ctx-ffe9988e) (logid:fd7a5d83) 
> Unsupported data object (VOLUME, 
> org.apache.cloudstack.storage.datastore.PrimaryDataStoreImpl@5c07d712), no 
> need to delete from object in store ref table
> 2017-05-30 04:10:17,139 DEBUG [o.a.c.e.o.VolumeOrchestrator] 
> (API-Job-Executor-26:ctx-8ba0012a job-188 ctx-ffe9988e) (logid:fd7a5d83) 
> Failed to create volume from snapshot:null due to Task failed! Task record:   
>   uuid: bf2abdea-bea3-36e2-22f0-8fa62985c614
>nameLabel: Async.VDI.copy
>  nameDescription:
>allowedOperations: []
>currentOperations: {}
>  created: Tue May 30 04:10:10 EDT 2017
> finished: Tue May 30 04:10:16 EDT 2017
>   status: failure
>   residentOn: com.xensource.xenapi.Host@7a705050
> progress: 1.0
> type: 
>   result:
>errorInfo: [INTERNAL_ERROR, End_of_file]
>  otherConfig: {}
>subtaskOf: com.xensource.xenapi.Task@aaf13f6f
> subtasks: []
>  
> 2017-05-30 04:10:17,166 DEBUG [c.c.u.AccountManagerImpl] 
> (API-Job-Executor-26:ctx-8ba0012a job-188 ctx-ffe9988e) (logid:fd7a5d83) 
> Access granted to Acct[def73ff3-3fbb-11e7-b95a-b2fc35794ac7-admin] to 
> Domain:1/ by AffinityGroupAccessChecker
> 2017-05-30 04:10:17,180 ERROR [c.c.a.ApiAsyncJobDispatcher] 
> (API-Job-Executor-26:ctx-8ba0012a job-188) (logid:fd7a5d83) Unexpected 
> exception while executing 
> org.apache.cloudstack.api.command.admin.volume.CreateVolumeCmdByAdmin
> com.cloud.utils.exception.CloudRuntimeException: Failed to create volume: 42
> at 
> com.cloud.storage.VolumeApiServiceImpl.createVolume(VolumeApiServiceImpl.java:803)
> at 
> com.cloud.storage.VolumeApiServiceImpl.createVolume(VolumeApiServiceImpl.java:175)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:333)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
> at 
> org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107)
> at 
> 

[jira] [Commented] (CLOUDSTACK-9932) Snapshot is getting deleted while volume creation from the snapshot is in progress

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310735#comment-16310735
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9932:


rhtyd closed pull request #2149: CLOUDSTACK-9932 snapshot is getting deleted 
while volume is in creating state
URL: https://github.com/apache/cloudstack/pull/2149
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
index 185cf567fa0..723d5c7b369 100644
--- 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
+++ 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
@@ -38,6 +38,8 @@
 import com.cloud.storage.dao.SnapshotDetailsDao;
 import com.cloud.storage.dao.SnapshotDetailsVO;
 import com.cloud.storage.dao.VolumeDao;
+import com.cloud.storage.dao.VolumeDetailsDao;
+import com.cloud.storage.VolumeDetailVO;
 import com.cloud.utils.db.DB;
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.utils.fsm.NoTransitionException;
@@ -87,6 +89,7 @@
 @Inject private VMInstanceDao vmInstanceDao;
 @Inject private VolumeDao volumeDao;
 @Inject private VolumeService volService;
+@Inject private VolumeDetailsDao _volumeDetailsDaoImpl;
 
 @Override
 public SnapshotInfo backupSnapshot(SnapshotInfo snapshotInfo) {
@@ -165,6 +168,17 @@ private boolean cleanupSnapshotOnPrimaryStore(long 
snapshotId) {
 
 try {
 snapshotObj.processEvent(Snapshot.Event.DestroyRequested);
+List volumesFromSnapshot;
+volumesFromSnapshot = 
_volumeDetailsDaoImpl.findDetails("SNAPSHOT_ID", String.valueOf(snapshotId), 
null);
+
+if (volumesFromSnapshot.size() > 0) {
+try {
+snapshotObj.processEvent(Snapshot.Event.OperationFailed);
+} catch (NoTransitionException e1) {
+s_logger.debug("Failed to change snapshot state: " + 
e1.toString());
+}
+throw new InvalidParameterValueException("Unable to perform 
delete operation, Snapshot with id: " + snapshotId + " is in use  ");
+}
 }
 catch (NoTransitionException e) {
 s_logger.debug("Failed to set the state to destroying: ", e);
diff --git 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
index a673a462375..479d7b4b670 100644
--- 
a/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
+++ 
b/engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
@@ -53,9 +53,11 @@
 import com.cloud.storage.StoragePoolStatus;
 import com.cloud.storage.Volume;
 import com.cloud.storage.VolumeVO;
+import com.cloud.storage.VolumeDetailVO;
 import com.cloud.storage.dao.SnapshotDao;
 import com.cloud.storage.dao.SnapshotDetailsDao;
 import com.cloud.storage.dao.VolumeDao;
+import com.cloud.storage.dao.VolumeDetailsDao;
 import com.cloud.utils.db.Transaction;
 import com.cloud.utils.db.TransactionCallbackNoReturn;
 import com.cloud.utils.db.TransactionStatus;
@@ -91,6 +93,8 @@
 private SnapshotDetailsDao _snapshotDetailsDao;
 @Inject
 private SyncQueueItemDao _syncQueueItemDao;
+@Inject
+VolumeDetailsDao _volumeDetailsDaoImpl;
 
 @Override
 public SnapshotInfo backupSnapshot(SnapshotInfo snapshot) {
@@ -278,6 +282,17 @@ public boolean deleteSnapshot(Long snapshotId) {
 SnapshotObject obj = (SnapshotObject)snapshotOnImage;
 try {
 obj.processEvent(Snapshot.Event.DestroyRequested);
+List volumesFromSnapshot;
+volumesFromSnapshot = 
_volumeDetailsDaoImpl.findDetails("SNAPSHOT_ID", String.valueOf(snapshotId), 
null);
+
+if (volumesFromSnapshot.size() > 0) {
+try {
+obj.processEvent(Snapshot.Event.OperationFailed);
+} catch (NoTransitionException e1) {
+s_logger.debug("Failed to change snapshot state: " + 
e1.toString());
+}
+throw new InvalidParameterValueException("Unable to perform 
delete operation, Snapshot with id: " + snapshotId + " is in use  ");
+}
 } catch (NoTransitionException e) {
 s_logger.debug("Failed to set the state to 

[jira] [Commented] (CLOUDSTACK-4045) IP address acquired with associateIpAddress is marked as source NAT, causing disassociateIpAddress to fail later

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310733#comment-16310733
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4045:


rhtyd commented on issue #2382: CLOUDSTACK-4045 
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-355201625
 
 
   @houthuis looks like some failures both in travis and trillian results, can 
you check?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> IP address acquired with associateIpAddress is marked as source NAT, causing 
> disassociateIpAddress to fail later
> 
>
> Key: CLOUDSTACK-4045
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4045
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.1.1, 4.2.0
>Reporter: Murali Reddy
>Assignee: Murali Reddy
> Fix For: Future
>
>
> When you can create network, network is in allocated state. when network is 
> implemented CloudStack implicitly should acquire a public IP for source nat. 
> But there is assumption that first IP this is associated with network is 
> always for source NAT IP. So when you do
> 1. create network (network is in allocated state)
> 2. acquire a public IP and associate with the network
> 3. disassociate ip address
> #3 will fail because CloudStack marks the IP acquired in #1 to be source NAT. 
> For users this is counter-intutive because when a IP is acquired, he/she 
> should be able to release it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CLOUDSTACK-9620) Improvements for Managed Storage

[Mike Tutkowski (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Tutkowski updated CLOUDSTACK-9620:
---
Description: 
Allowed zone-wide primary storage based on a custom plug-in to be added via the 
GUI in a KVM-only environment (previously this only worked for XenServer and 
VMware)

Added support for root disks on managed storage with KVM

Added support for volume snapshots with managed storage on KVM

Enabled creating a template directly from a volume (i.e. without having to go 
through a volume snapshot) on KVM with managed storage

Only allowed the resizing of a volume for managed storage on KVM if the volume 
in question is either not attached to a VM or is attached to a VM in the 
Stopped state

Included support for Reinstall VM on KVM with managed storage

Enabled offline migration on KVM from non-managed storage to managed storage 
and vice versa

Included support for online storage migration on KVM with managed storage (NFS 
and Ceph to managed storage)

Added support to download (extract) a managed-storage volume to a QCOW2 file

When uploading a file from outside of CloudStack to CloudStack, set the min and 
max IOPS, if applicable.

Included support for the KVM auto-convergence feature

The compression flag was actually added in version 1.0.3 (103) as opposed 
to version 1.3.0 (1003000) (changed this to reflect the correct version)

On KVM when using iSCSI-based managed storage, if the user shuts a VM down from 
the guest OS (as opposed to doing so from CloudStack), we need to pass to the 
KVM agent a list of applicable iSCSI volumes that need to be disconnected.

Added a new Global Setting: kvm.storage.live.migration.wait

For XenServer, added a check to enforce that only volumes from zone-wide 
managed storage can be storage motioned from a host in one cluster to a host in 
another cluster (cannot do so at the time being with volumes from 
cluster-scoped managed storage)

Don’t allow Storage XenMotion on a VM that has any managed-storage volume with 
one or more snapshots.

Enabled for managed storage with VMware: Template caching, create snapshot, 
delete snapshot, create volume from snapshot, and create template from snapshot

Added an SIOC API plug-in to support VMware SIOC

When starting a VM that uses managed storage in a cluster other than the one it 
last was running in, we need to remove the reference to the iSCSI volume from 
the original cluster.

Added the ability to revert a volume to a snapshot

Enabled cluster-scoped managed storage

Added support for VMware dynamic discovery

  was:
Allowed zone-wide primary storage based on a custom plug-in to be added via the 
GUI in a KVM-only environment (previously this only worked for XenServer and 
VMware)

Added support for root disks on managed storage with KVM

Added support for volume snapshots with managed storage on KVM

Enable creating a template directly from a volume (i.e. without having to go 
through a volume snapshot) on KVM with managed storage

Only allow the resizing of a volume for managed storage on KVM if the volume in 
question is either not attached to a VM or is attached to a VM in the Stopped 
state.

Included support for Reinstall VM on KVM with managed storage

Enabled offline migration on KVM from non-managed storage to managed storage 
and vice versa

Included support for online storage migration on KVM with managed storage (NFS 
and Ceph to managed storage)

Added support to download (extract) a managed-storage volume to a QCOW2 file

When uploading a file from outside of CloudStack to CloudStack, set the min and 
max IOPS, if applicable.

Included support for the KVM auto-convergence feature

The compression flag was actually added in version 1.0.3 (103) as opposed 
to version 1.3.0 (1003000) (changed this to reflect the correct version)

On KVM when using iSCSI-based managed storage, if the user shuts a VM down from 
the guest OS (as opposed to doing so from CloudStack), we need to pass to the 
KVM agent a list of applicable iSCSI volumes that need to be disconnected.

Added a new Global Setting: kvm.storage.live.migration.wait

For XenServer, added a check to enforce that only volumes from zone-wide 
managed storage can be storage motioned from a host in one cluster to a host in 
another cluster (cannot do so at the time being with volumes from 
cluster-scoped managed storage)

Don’t allow Storage XenMotion on a VM that has any managed-storage volume with 
one or more snapshots.

Enabled for managed storage with VMware: Template caching, create snapshot, 
delete snapshot, create volume from snapshot, and create template from snapshot

Added an SIOC API plug-in to support VMware SIOC

When starting a VM that uses managed storage in a cluster other than the one it 
last was running in, we need to remove the reference to the iSCSI volume from 
the original cluster.

Added the ability to 

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310649#comment-16310649
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355185279
 
 
   @rhtyd Just an FYI that I went ahead and refactored the VMware SIOC code to 
remove references to SolidFire. It is now located in plugins/api/vmware-sioc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enable creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allow the resizing of a volume for managed storage on KVM if the volume 
> in question is either not attached to a VM or is attached to a VM in the 
> Stopped state.
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enable cluster-scoped managed storage
> Add support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4045) IP address acquired with associateIpAddress is marked as source NAT, causing disassociateIpAddress to fail later

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310578#comment-16310578
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4045:


blueorangutan commented on issue #2382: CLOUDSTACK-4045 
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-355176386
 
 
   Trillian test result (tid-1992)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35953 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2382-t1992-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestPublicIP>:setup | `Error` | 82.69 | test_network.py
   test_01_create_delete_portforwarding_fornonvpc | `Error` | 6.19 | 
test_portforwardingrules.py
   test_07_resize_fail | `Failure` | 15.34 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 290.23 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 352.21 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 393.02 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> IP address acquired with associateIpAddress is marked as source NAT, causing 
> disassociateIpAddress to fail later
> 
>
> Key: CLOUDSTACK-4045
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4045
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.1.1, 4.2.0
>Reporter: Murali Reddy
>Assignee: Murali Reddy
> Fix For: Future
>
>
> When you can create network, network is in allocated state. when network is 
> implemented CloudStack implicitly should acquire a public IP for source nat. 
> But there is assumption that first IP this is associated with network is 
> always for source NAT IP. So when you do
> 1. create network (network is in allocated state)
> 2. acquire a public IP and associate with the network
> 3. disassociate ip address
> #3 will fail because CloudStack marks the IP acquired in #1 to be source NAT. 
> For users this is counter-intutive because when a IP is acquired, he/she 
> should be able to release it as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)