[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-04-26 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455526#comment-16455526
 ] 

ASF subversion and git services commented on CLOUDSTACK-10240:
--

Commit d6cbd774b76a044efbdbc531acd5c8c1925cc1d2 in cloudstack's branch 
refs/heads/master from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=d6cbd77 ]

[CLOUDSTACK-10323] Allow changing disk offering during volume migration  (#2486)

* [CLOUDSTACK-10323] Allow changing disk offering during volume migration

This is a continuation of work developed on PR #2425 (CLOUDSTACK-10240), which 
provided root admins an override mechanism to move volumes between storage 
systems types (local/shared) even when the disk offering would not allow such 
operation. To complete the work, we will now provide a way for administrators 
to enter a new disk offering that can reflect the new placement of the volume. 
We will add an extra parameter to allow the root admin inform a new disk 
offering for the volume. Therefore, when the volume is being migrated, it will 
be possible to replace the disk offering to reflect the new placement of the 
volume.

The API method will have the following parameters:

* storageid (required)
* volumeid (required)
* livemigrate(optional)
* newdiskofferingid (optional) – this is the new parameter

The expected behavior is the following:

* If “newdiskofferingid” is not provided the current behavior is maintained. 
Override mechanism will also keep working as we have seen so far.
* If the “newdiskofferingid” is provided by the admin, we will execute the 
following checks
** new disk offering mode (local/shared) must match the target storage mode. If 
it does not match, an exception will be thrown and the operator will receive a 
message indicating the problem.
** we will check if the new disk offering tags match the target storage tags. 
If it does not match, an exception will be thrown and the operator will receive 
a message indicating the problem.
** check if the target storage has the capacity for the new volume. If it does 
not have enough space, then an exception is thrown and the operator will 
receive a message indicating the problem.
** check if the size of the volume is the same as the size of the new disk 
offering. If it is not the same, we will ALLOW the change of the service 
offering, and a warning message will be logged.

We execute the change of the Disk offering as soon as the migration of the 
volume finishes. Therefore, if an error happens during the migration and the 
volume remains in the original storage system, the disk offering will keep 
reflecting this situation.

* Code formatting

* Adding a test to cover migration with new disk offering (#4)

* Adding a test to cover migration with new disk offering

* Update test_volumes.py

* Update test_volumes.py

* fix test_11_migrate_volume_and_change_offering

* Fix typo in Java doc


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390258#comment-16390258
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner closed pull request #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index d5fd173d71e..be0bfb12210 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -70,9 +70,10 @@ env:
  smoke/test_password_server
  smoke/test_portable_publicip
  smoke/test_portforwardingrules"
-
-- TESTS="smoke/test_primary_storage
- smoke/test_privategw_acl
+
+- TESTS="smoke/test_primary_storage"
+
+- TESTS="smoke/test_privategw_acl
  smoke/test_projects
  smoke/test_public_ip_range
  smoke/test_pvlan
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java
index 47fa965e7dd..73c596c9e56 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java
@@ -17,10 +17,10 @@
 package org.apache.cloudstack.api.command.admin.storage;
 
 import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
 import java.util.List;
 
-import org.apache.log4j.Logger;
-
 import org.apache.cloudstack.api.APICommand;
 import org.apache.cloudstack.api.ApiCommandJobType;
 import org.apache.cloudstack.api.ApiConstants;
@@ -29,12 +29,14 @@
 import org.apache.cloudstack.api.response.ListResponse;
 import org.apache.cloudstack.api.response.StoragePoolResponse;
 import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.log4j.Logger;
 
 import com.cloud.storage.StoragePool;
 import com.cloud.utils.Pair;
 
 @APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class,
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 public class FindStoragePoolsForMigrationCmd extends BaseListCmd {
 public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmd.class.getName());
 
@@ -81,7 +83,7 @@ public void execute() {
 StoragePoolResponse poolResponse = 
_responseGenerator.createStoragePoolForMigrationResponse(pool);
 Boolean suitableForMigration = false;
 for (StoragePool suitablePool : suitablePoolList) {
-if (suitablePool.getId() == pool.getId()) {
+if (StringUtils.equals(suitablePool.getUuid(), 
pool.getUuid())) {
 suitableForMigration = true;
 break;
 }
@@ -90,9 +92,27 @@ public void execute() {
 poolResponse.setObjectName("storagepool");
 poolResponses.add(poolResponse);
 }
-
+sortPoolsBySuitabilityAndName(poolResponses);
 response.setResponses(poolResponses);
 response.setResponseName(getCommandName());
 this.setResponseObject(response);
 }
+
+protected void sortPoolsBySuitabilityAndName(List 
poolResponses) {
+Collections.sort(poolResponses, new Comparator() {
+@Override
+public int compare(StoragePoolResponse o1, StoragePoolResponse o2) 
{
+if (o1.getSuitableForMigration() && 
o2.getSuitableForMigration()) {
+return o1.getName().compareTo(o2.getName());
+}
+if (o1.getSuitableForMigration()) {
+return -1;
+}
+if (o2.getSuitableForMigration()) {
+return 1;
+}
+return 0;
+}
+});
+}
 }
diff --git 
a/api/src/test/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmdTest.java
 
b/api/src/test/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmdTest.java
new file mode 100644
index 000..2297946bec7
--- /dev/null
+++ 
b/api/src/test/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmdTest.java
@@ -0,0 +1,63 @@
+// Licensed to the Apache Software Foundation 

[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390261#comment-16390261
 ] 

ASF subversion and git services commented on CLOUDSTACK-10240:
--

Commit f2efbcececb3cfb06a51e5d3a2e77417c19c667f in cloudstack's branch 
refs/heads/master from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=f2efbce ]

[CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage (#2425)

* [CLOUDSTACK-10240] ACS cannot migrate a volume from local to shared storage.

CloudStack is logically restricting the migration of local storages to shared 
storage and vice versa. This restriction is a logical one and can be removed 
for XenServer deployments. Therefore, we will enable migration of volumes 
between local-shared storages in XenServers independently of their service 
offering. This will work as an override mechanism to the disk offering used by 
volumes. If administrators want to migrate local volumes to a shared storage, 
they should be able to do so (the hypervisor already allows that). The same the 
other way around.

* Cleanups implemented while working on [CLOUDSTACK-10240]

* Fix test case test_03_migrate_options_storage_tags

The changes applied were:
- When loading hypervisors capabilities we must use "default" instead of nulls
- "Enable" storage migration for simulator hypervisor
- Remove restriction on "ClusterScopeStoragePoolAllocator" to find shared pools


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390260#comment-16390260
 ] 

ASF subversion and git services commented on CLOUDSTACK-10240:
--

Commit f2efbcececb3cfb06a51e5d3a2e77417c19c667f in cloudstack's branch 
refs/heads/master from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=f2efbce ]

[CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage (#2425)

* [CLOUDSTACK-10240] ACS cannot migrate a volume from local to shared storage.

CloudStack is logically restricting the migration of local storages to shared 
storage and vice versa. This restriction is a logical one and can be removed 
for XenServer deployments. Therefore, we will enable migration of volumes 
between local-shared storages in XenServers independently of their service 
offering. This will work as an override mechanism to the disk offering used by 
volumes. If administrators want to migrate local volumes to a shared storage, 
they should be able to do so (the hypervisor already allows that). The same the 
other way around.

* Cleanups implemented while working on [CLOUDSTACK-10240]

* Fix test case test_03_migrate_options_storage_tags

The changes applied were:
- When loading hypervisors capabilities we must use "default" instead of nulls
- "Enable" storage migration for simulator hypervisor
- Remove restriction on "ClusterScopeStoragePoolAllocator" to find shared pools


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390259#comment-16390259
 ] 

ASF subversion and git services commented on CLOUDSTACK-10240:
--

Commit f2efbcececb3cfb06a51e5d3a2e77417c19c667f in cloudstack's branch 
refs/heads/master from [~rafaelweingartner]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=f2efbce ]

[CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage (#2425)

* [CLOUDSTACK-10240] ACS cannot migrate a volume from local to shared storage.

CloudStack is logically restricting the migration of local storages to shared 
storage and vice versa. This restriction is a logical one and can be removed 
for XenServer deployments. Therefore, we will enable migration of volumes 
between local-shared storages in XenServers independently of their service 
offering. This will work as an override mechanism to the disk offering used by 
volumes. If administrators want to migrate local volumes to a shared storage, 
they should be able to do so (the hypervisor already allows that). The same the 
other way around.

* Cleanups implemented while working on [CLOUDSTACK-10240]

* Fix test case test_03_migrate_options_storage_tags

The changes applied were:
- When loading hypervisors capabilities we must use "default" instead of nulls
- "Enable" storage migration for simulator hypervisor
- Remove restriction on "ClusterScopeStoragePoolAllocator" to find shared pools


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390019#comment-16390019
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-371244156
 
 
   If we have no objections I will be merging this one latter today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389353#comment-16389353
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-371089577
 
 
   Thanks @DaanHoogland!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389270#comment-16389270
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-371068913
 
 
   @rafaelweingartner , yes you can. It seems to be a timing issue. the host 
does not have a state needed in some occurences and does have that state in 
other runs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388176#comment-16388176
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370865982
 
 
   @khos2ow would you mind reviewing this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388102#comment-16388102
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370853345
 
 
   @DaanHoogland this test `test_hostha_enable_ha_when_host_in_maintenance` 
error seems to be persistent in other PRs as well. Can I consider that the 
tests finished successfully?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386388#comment-16386388
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

blueorangutan commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370493732
 
 
   Trillian test result (tid-2312)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28936 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2425-t2312-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.86 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385805#comment-16385805
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

blueorangutan commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370348709
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385804#comment-16385804
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370348656
 
 
   :( jenkins had crashed due to disk full, should not be related and should 
not be. acting insane:
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384148#comment-16384148
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370051762
 
 
   Now the failures increased... :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384123#comment-16384123
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

blueorangutan commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370045365
 
 
   Trillian test result (tid-2303)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29005 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2425-t2303-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 60 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 1.06 | 
test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.17 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.29 | 
test_primary_storage.py
   test_04_rvpc_privategw_static_routes | `Failure` | 346.33 | 
test_privategw_acl.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.26 | 
test_snapshots.py
   test_08_migrate_vm | `Error` | 125.28 | test_vm_life_cycle.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 289.85 | 
test_vpc_redundant.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.19 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 3.50 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.14 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383520#comment-16383520
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

blueorangutan commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369904227
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383518#comment-16383518
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369904033
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-03-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383493#comment-16383493
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369898631
 
 
   That is a good question. For me, it is always best to start solving a 
bug/issue/new feature by unit tests because they cost less to run than these 
integration/smoke tests (this is what I have been doing so far). However, this 
requires a level of commitment (code has to be designed to be unit tested).
   
   Regarding revisiting tests, I would check them every-time they fail. 
Otherwise, there is too much for too few hands.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380535#comment-16380535
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369288296
 
 
   @DaanHoogland thanks for the explanations.  Yes I was considering false 
positive/negative differently, but as long as we are able to explain them 
further as you did, we can understand each other.
   
   So, it seems that most of these failures are due to runtime issues, normally 
from timeouts. Moreover, as far as we know it is not possible for the tests to 
return with a "success" message, when there is a problem. Unless, of course, if 
there is a problem/case that the current tests do not cover.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380302#comment-16380302
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369239103
 
 
   @rafaelweingartner , first to clarify; my understanding of flase positive 
and false negitive is reversed from yours;
   a false positive: a bug is reported but it isn't there
   a false negative: a bug is not reported in spite of being there
   kind of like in the doping control mafia; positive means your busted. maybe 
a bit counter intuitive but I'll run with it (pun as happy accident)
   
   So more more to the point, a false positive might be due to a timing issue 
that occurs because of the nested nature of the test environment, and isn't a 
real issue. I can think of no false negative counterpart for that.
   maybe we can think of more examples of the reverse but the issue is that we 
need to assess on each failure if it is noteworthy and we need to keep doing 
code reviews.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380303#comment-16380303
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369239103
 
 
   @rafaelweingartner , first to clarify; my understanding of false positive 
and false negitive is reversed from yours;
   a false positive: a bug is reported but it isn't there
   a false negative: a bug is not reported in spite of being there
   kind of like in the doping control mafia; positive means your busted. maybe 
a bit counter intuitive but I'll run with it (pun as happy accident)
   
   So more more to the point, a false positive might be due to a timing issue 
that occurs because of the nested nature of the test environment, and isn't a 
real issue. I can think of no false negative counterpart for that.
   maybe we can think of more examples of the reverse but the issue is that we 
need to assess on each failure if it is noteworthy and we need to keep doing 
code reviews.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380168#comment-16380168
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369214377
 
 
   The one I remember right now is the HA test, which I have seen failing in 
PRs 2438 and 2469. 
   My doubt is the following, as long as we have false negatives (showing that 
there is a problem, when there isn't), can't we have false positive (showing 
that everything is ok, when it is not) as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380165#comment-16380165
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369212735
 
 
   These are nested environments in which we test so they might be false 
positives as you imply by your question. I think we still need to check the 
errors. What PR shows these? I saw failures today but nowhere the exact same 
bunch, @rafaelweingartner ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379240#comment-16379240
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369015380
 
 
   These failures are the same that appeared in other PR that is changing 
different things. How much can we trust these errors? Or an even better 
question, can we trust in a successful execution?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379238#comment-16379238
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

blueorangutan commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369013790
 
 
   Trillian test result (tid-2285)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34459 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2425-t2285-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 64 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 370.30 | 
test_privategw_acl.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 153.71 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.87 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378346#comment-16378346
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

blueorangutan commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-368820351
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378342#comment-16378342
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-368820104
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368935#comment-16368935
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

blueorangutan commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-366636864
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1726


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368891#comment-16368891
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

blueorangutan commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-366627862
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368889#comment-16368889
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-366627617
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-02-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366022#comment-16366022
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-366009336
 
 
   @DaanHoogland I separated the code changes from formatting one as your 
suggestion. I think it is way better now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342266#comment-16342266
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-361006831
 
 
   ok @DaanHoogland.
   Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342262#comment-16342262
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-361006294
 
 
   no, never mind. (next time better!)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342100#comment-16342100
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-360979844
 
 
   I would say that there is only one formatting style for ACS. However, I have 
seen so many PRs like this one where we see a lot of formatting changes that I 
am starting to doubt if we are all using the same. 
   
   I agree with you. My intention here was never to do code formatting. My 
eclipse is configured to format only edit lines, but for some reason it 
formatted all of the Java files I touched (maybe I pressed a ctrl+shift+f 
without noticing). Would you like me to remove the formatting and leave only 
the real changes I am introducing here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342064#comment-16342064
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-360973959
 
 
   @rafaelweingartner that is the only true formatter for cloudstack, isn't it. 
still i'd like to have reformattings in a different commit. the mindset of 
reviewing reformatting is a bit different than that of reviewing semantic/logic 
changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342047#comment-16342047
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-360971535
 
 
   @Daan, thanks for the feedback here!
   I am starting to doubt that we are all using the same code formatter (I am 
using this one [1]). I can remove the code formatting changes and leave only 
the methods that I created if you prefer.
   
   [1] 
https://cwiki.apache.org/confluence/download/attachments/29687985/ApacheCloudStack.xml?version=1=1382960469000=v2
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-01-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339266#comment-16339266
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on a change in pull request #2425: 
[CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#discussion_r163853936
 
 

 ##
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java
 ##
 @@ -29,14 +29,14 @@
 import org.apache.cloudstack.api.response.ListResponse;
 import org.apache.cloudstack.api.response.StoragePoolResponse;
 import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.log4j.Logger;
 
 import com.cloud.storage.StoragePool;
 import com.cloud.utils.Pair;
 
-@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class,
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class, requestHasSensitiveInfo = false, 
responseHasSensitiveInfo = false)
 public class FindStoragePoolsForMigrationCmd extends BaseListCmd {
-public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmd.class.getName());
+public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmdTest.class.getName());
 
 Review comment:
   I forgot to push :(
   my bad!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-01-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339168#comment-16339168
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on a change in pull request #2425: [CLOUDSTACK-10240] 
ACS cannot migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#discussion_r163831455
 
 

 ##
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java
 ##
 @@ -29,14 +29,14 @@
 import org.apache.cloudstack.api.response.ListResponse;
 import org.apache.cloudstack.api.response.StoragePoolResponse;
 import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.log4j.Logger;
 
 import com.cloud.storage.StoragePool;
 import com.cloud.utils.Pair;
 
-@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class,
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class, requestHasSensitiveInfo = false, 
responseHasSensitiveInfo = false)
 public class FindStoragePoolsForMigrationCmd extends BaseListCmd {
-public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmd.class.getName());
+public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmdTest.class.getName());
 
 Review comment:
   it is stil there, did you push?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-01-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339027#comment-16339027
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

rafaelweingartner commented on a change in pull request #2425: 
[CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#discussion_r163800084
 
 

 ##
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java
 ##
 @@ -29,14 +29,14 @@
 import org.apache.cloudstack.api.response.ListResponse;
 import org.apache.cloudstack.api.response.StoragePoolResponse;
 import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.log4j.Logger;
 
 import com.cloud.storage.StoragePool;
 import com.cloud.utils.Pair;
 
-@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class,
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class, requestHasSensitiveInfo = false, 
responseHasSensitiveInfo = false)
 public class FindStoragePoolsForMigrationCmd extends BaseListCmd {
-public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmd.class.getName());
+public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmdTest.class.getName());
 
 Review comment:
   Thanks! Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)

2018-01-24 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337435#comment-16337435
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10240:
-

DaanHoogland commented on a change in pull request #2425: [CLOUDSTACK-10240] 
ACS cannot migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#discussion_r163481172
 
 

 ##
 File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java
 ##
 @@ -29,14 +29,14 @@
 import org.apache.cloudstack.api.response.ListResponse;
 import org.apache.cloudstack.api.response.StoragePoolResponse;
 import org.apache.cloudstack.api.response.VolumeResponse;
+import org.apache.log4j.Logger;
 
 import com.cloud.storage.StoragePool;
 import com.cloud.utils.Pair;
 
-@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class,
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = "findStoragePoolsForMigration", description = "Lists 
storage pools available for migration of a volume.", responseObject = 
StoragePoolResponse.class, requestHasSensitiveInfo = false, 
responseHasSensitiveInfo = false)
 public class FindStoragePoolsForMigrationCmd extends BaseListCmd {
-public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmd.class.getName());
+public static final Logger s_logger = 
Logger.getLogger(FindStoragePoolsForMigrationCmdTest.class.getName());
 
 Review comment:
   this is not the test class!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ACS cannot migrate a volume from local to shared storage (for XenServer)
> 
>
> Key: CLOUDSTACK-10240
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> CloudStack is logically restricting the migration of local storages to shared 
> storage and vice versa. This restriction is a logical one and can be removed 
> for XenServer deployments. Therefore, we will enable migration of volumes 
> between local-shared storages in XenServers independently of their service 
> offering. This will work as an override mechanism to the disk offering used 
> by volumes. If administrators want to migrate local volumes to a shared 
> storage, they should be able to do so (the hypervisor already allows that). 
> The same the other way around.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)