[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740532#comment-14740532 ] ASF subversion and git services commented on CLOUDSTACK-5863: - Commit d80740347268ae387a02d66f9baaf7646108fc91 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d807403 ] Merge pull request #796 from ustcweizhou/unit-tests-for-snapshot CLOUDSTACK-5863: Add unit tests for volume snapshot * pr/796: Fix coverity scan 1323172 CLOUDSTACK-5863: Add unit tests for take volume snapshot CLOUDSTACK-5863: Add unit tests for create/delete/revert volume snapshot Signed-off-by: Rajani Karuturi > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740534#comment-14740534 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/796 > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740530#comment-14740530 ] ASF subversion and git services commented on CLOUDSTACK-5863: - Commit e586d11a1b666e61cc43d75313f9b9d3c3672f8f in cloudstack's branch refs/heads/master from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e586d11 ] CLOUDSTACK-5863: Add unit tests for take volume snapshot > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740531#comment-14740531 ] ASF subversion and git services commented on CLOUDSTACK-5863: - Commit d80740347268ae387a02d66f9baaf7646108fc91 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d807403 ] Merge pull request #796 from ustcweizhou/unit-tests-for-snapshot CLOUDSTACK-5863: Add unit tests for volume snapshot * pr/796: Fix coverity scan 1323172 CLOUDSTACK-5863: Add unit tests for take volume snapshot CLOUDSTACK-5863: Add unit tests for create/delete/revert volume snapshot Signed-off-by: Rajani Karuturi > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740529#comment-14740529 ] ASF subversion and git services commented on CLOUDSTACK-5863: - Commit 007f5b842d7b0c8d200b562f48ad610b1324ca16 in cloudstack's branch refs/heads/master from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=007f5b8 ] CLOUDSTACK-5863: Add unit tests for create/delete/revert volume snapshot > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740533#comment-14740533 ] ASF subversion and git services commented on CLOUDSTACK-5863: - Commit d80740347268ae387a02d66f9baaf7646108fc91 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d807403 ] Merge pull request #796 from ustcweizhou/unit-tests-for-snapshot CLOUDSTACK-5863: Add unit tests for volume snapshot * pr/796: Fix coverity scan 1323172 CLOUDSTACK-5863: Add unit tests for take volume snapshot CLOUDSTACK-5863: Add unit tests for create/delete/revert volume snapshot Signed-off-by: Rajani Karuturi > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740417#comment-14740417 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/796#issuecomment-139489439 LGTM -> Test run fine and increase coverage. > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738635#comment-14738635 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/796#issuecomment-139215606 :+1: > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738295#comment-14738295 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/796#issuecomment-139134869 great, we need more;) LGTM > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738230#comment-14738230 ] ASF GitHub Bot commented on CLOUDSTACK-5863: GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/796 CLOUDSTACK-5863: Add unit tests for volume snapshot You can merge this pull request into a Git repository by running: $ git pull https://github.com/ustcweizhou/cloudstack unit-tests-for-snapshot Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/796.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #796 commit 007f5b842d7b0c8d200b562f48ad610b1324ca16 Author: Wei Zhou Date: 2015-09-09T12:48:31Z CLOUDSTACK-5863: Add unit tests for create/delete/revert volume snapshot commit e586d11a1b666e61cc43d75313f9b9d3c3672f8f Author: Wei Zhou Date: 2015-09-09T12:49:07Z CLOUDSTACK-5863: Add unit tests for take volume snapshot commit c15729e71afb582d300c608f6b230af15a7d1958 Author: Wei Zhou Date: 2015-09-09T12:57:58Z Fix coverity scan 1323172 > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734217#comment-14734217 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-138426187 @ustcweizhou this caused a new coverity issue. Can you check? ``` 411 SnapshotInfo snapshotOnPrimaryStore = _snapshotFactory.getSnapshot(snapshot.getId(), DataStoreRole.Primary); >>> CID 1323172: Null pointer dereferences (NULL_RETURNS) >>> Calling a method on null object "snapshotOnPrimaryStore". 412 PrimaryDataStore store = (PrimaryDataStore)snapshotOnPrimaryStore.getDataStore(); ``` > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725519#comment-14725519 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user ustcweizhou closed the pull request at: https://github.com/apache/cloudstack/pull/732 > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725511#comment-14725511 ] ASF subversion and git services commented on CLOUDSTACK-5863: - Commit c0a0aec0f9041a3577d96d69260c7aa33482199d in cloudstack's branch refs/heads/master from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c0a0aec ] Merge pull request #732 from ustcweizhou/revert-volume-snapshot-master Guys, can you review it? things need to be discussed: (1) this supports KVM/QCOW2 only. Anyone want to implement for other Hypervisor/format ? (2) The original data volume (on primary storage) will be removed. (3) The script uses the default timeout in libvirtComputingResource. Do we need to add one in global configuration (like copy.volume.wait or backup.snapshot.wait, create.volume.from.snapshot.wait) (4) In scripts/storage/qcow2/managesnapshot.sh, I use "qemu-img convert -f qcow2 -O qcow2" to copy the snapshot from secondary to primary (hence there is no base image file), instead of "cp -f", this is because convert is faster than cp in my testing. * pr/732: CLOUDSTACK-5863: revert volume snapshot for KVM/QCOW2 Signed-off-by: Wei Zhou > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725509#comment-14725509 ] ASF subversion and git services commented on CLOUDSTACK-5863: - Commit 92344c006dfa8abf4ce81e2a25839cbb762d1b17 in cloudstack's branch refs/heads/master from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=92344c0 ] CLOUDSTACK-5863: revert volume snapshot for KVM/QCOW2 > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725510#comment-14725510 ] ASF subversion and git services commented on CLOUDSTACK-5863: - Commit 312cb877b12cd842a1fa8ab7fb6a3cd6a637c61b in cloudstack's branch refs/heads/master from Wei Zhou [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=312cb87 ] CLOUDSTACK-5863: change response from SuccessResponse to SnapshotResponse > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725346#comment-14725346 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-136708467 No, seems good. We can merge this. > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725339#comment-14725339 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-136705849 any other comment about this PR ? If no, I will merge it into master. > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718185#comment-14718185 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-135667378 LGTM > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718145#comment-14718145 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-135661166 @bhaisaab I updated this PR . The reponses is changed to SnapshotResponse for backward compatibility. @karuturi I will add some unit tests for snapshot (create, delete,revert) in another PR. > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[
https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712825#comment-14712825
]
ASF GitHub Bot commented on CLOUDSTACK-5863:
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/732#discussion_r37963222
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java
---
@@ -31,25 +31,36 @@
import org.apache.cloudstack.api.response.SnapshotResponse;
import org.apache.cloudstack.api.response.SuccessResponse;
import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
import com.cloud.event.EventTypes;
import com.cloud.storage.Snapshot;
import com.cloud.user.Account;
-@APICommand(name = "revertSnapshot", description = "revert a volume
snapshot.", responseObject = SnapshotResponse.class, entityType =
{Snapshot.class},
+@APICommand(name = "revertSnapshot", description = "revert a volume
snapshot.", responseObject = SuccessResponse.class, entityType =
{Snapshot.class},
--- End diff --
I will change it to SnapshotResponse for backward compatibility.
> Restore volume snapshot
> ---
>
> Key: CLOUDSTACK-5863
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Snapshot
> Environment: KVM, EL6, QCOW2
>Reporter: Nux
>Assignee: Wei Zhou
> Labels: backup, kvm, restore, snapshot, volumes
> Fix For: 4.6.0
>
>
> Hello,
> Just as users can create backups of volumes, they should be able to restore
> said volumes from them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712452#comment-14712452 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-134820562 Can you add some tests please? > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711096#comment-14711096 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-134558876 In general LGTM, please see if you could fix the response class and object of the API (pl see the comments). > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[
https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711095#comment-14711095
]
ASF GitHub Bot commented on CLOUDSTACK-5863:
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/732#discussion_r37854560
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java
---
@@ -31,25 +31,36 @@
import org.apache.cloudstack.api.response.SnapshotResponse;
import org.apache.cloudstack.api.response.SuccessResponse;
import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
import com.cloud.event.EventTypes;
import com.cloud.storage.Snapshot;
import com.cloud.user.Account;
-@APICommand(name = "revertSnapshot", description = "revert a volume
snapshot.", responseObject = SnapshotResponse.class, entityType =
{Snapshot.class},
+@APICommand(name = "revertSnapshot", description = "revert a volume
snapshot.", responseObject = SuccessResponse.class, entityType =
{Snapshot.class},
--- End diff --
I think for API backward compatibility, please revert this to send
SnapshotResponse as the responseobject, unless this really needs to be fixed
(the older implementation got it wrong). Please comment.
> Restore volume snapshot
> ---
>
> Key: CLOUDSTACK-5863
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Snapshot
> Environment: KVM, EL6, QCOW2
>Reporter: Nux
>Assignee: Wei Zhou
> Labels: backup, kvm, restore, snapshot, volumes
> Fix For: 4.6.0
>
>
> Hello,
> Just as users can create backups of volumes, they should be able to restore
> said volumes from them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[
https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711094#comment-14711094
]
ASF GitHub Bot commented on CLOUDSTACK-5863:
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/732#discussion_r37854506
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java
---
@@ -91,7 +102,6 @@ public void execute() {
boolean result = _snapshotService.revertSnapshot(getId());
if (result) {
SuccessResponse response = new
SuccessResponse(getCommandName());
-response.setResponseName(getCommandName());
--- End diff --
this might cause API response issues.
> Restore volume snapshot
> ---
>
> Key: CLOUDSTACK-5863
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Snapshot
> Environment: KVM, EL6, QCOW2
>Reporter: Nux
>Assignee: Wei Zhou
> Labels: backup, kvm, restore, snapshot, volumes
> Fix For: 4.6.0
>
>
> Hello,
> Just as users can create backups of volumes, they should be able to restore
> said volumes from them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711074#comment-14711074 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-134553590 LGTM to me too. Tested on a master test deployment (Ubuntu 14.04 / KVM / NFS) Success with a manual snapshot from cloudmonkey and web ui Success on bad condition (error message if the VM is running) > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709190#comment-14709190 ] ASF GitHub Bot commented on CLOUDSTACK-5863: Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/732#issuecomment-134179676 LGTM to me. We should however stay as far away as possible from invoking all kinds of scripts. Implementing this for RBD is also a lot easier since you laid some groundwork. The java RBD bindings should be able to do this. > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709000#comment-14709000 ] Loic Lambiel commented on CLOUDSTACK-5863: -- Many thanks ! > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708993#comment-14708993 ] ASF GitHub Bot commented on CLOUDSTACK-5863: GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/732 CLOUDSTACK-5863: revert volume snapshot for KVM/QCOW2 Guys, can you review it? things need to be discussed: (1) this supports KVM/QCOW2 only. Anyone want to implement for other Hypervisor/format ? (2) The original data volume (on primary storage) will be removed. (3) The script uses the default timeout in libvirtComputingResource. Do we need to add one in global configuration (like copy.volume.wait or backup.snapshot.wait, create.volume.from.snapshot.wait) (4) In scripts/storage/qcow2/managesnapshot.sh, I use "qemu-img convert -f qcow2 -O qcow2" to copy the snapshot from secondary to primary (hence there is no base image file), instead of "cp -f", this is because convert is faster than cp in my testing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ustcweizhou/cloudstack revert-volume-snapshot-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/732.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #732 commit 92344c006dfa8abf4ce81e2a25839cbb762d1b17 Author: Wei Zhou Date: 2015-08-24T09:01:50Z CLOUDSTACK-5863: revert volume snapshot for KVM/QCOW2 > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708934#comment-14708934 ] Loic Lambiel commented on CLOUDSTACK-5863: -- Could you please maybe post the link of your fork so we could test it as well ? > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703662#comment-14703662 ] Loic Lambiel commented on CLOUDSTACK-5863: -- Good news !, waiting in the starting block ! > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703657#comment-14703657 ] Wei Zhou commented on CLOUDSTACK-5863: -- testing now. I will create a PR in the next days. > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703638#comment-14703638 ] Loic Lambiel commented on CLOUDSTACK-5863: -- Hi guys, any update on this ? > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555717#comment-14555717 ] Erik Weber commented on CLOUDSTACK-5863: Any update on this [~weizhou]? > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227633#comment-14227633 ] Nux commented on CLOUDSTACK-5863: - Awesome, I'll be waiting, ready to test! > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227626#comment-14227626 ] Wei Zhou commented on CLOUDSTACK-5863: -- Nux, I will made it work in upstream at first, then let's see if it is working in 4.5 as well. > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227621#comment-14227621 ] Nux commented on CLOUDSTACK-5863: - Wei, No way to sneak this in 4.5? > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux >Assignee: Wei Zhou > Labels: backup, kvm, restore, snapshot, volumes > Fix For: 4.6.0 > > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967520#comment-13967520 ] Srinivas Avasarala commented on CLOUDSTACK-5863: Thank you for your email. I am currently at CloudStack Collab Conference, returning on 4/14. Please expect a delay in response during this time. For issues that need my urgent attention, please contact #CloudPlatform-PM email alias. Thanks, Srinivas > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux > Labels: backup, kvm, restore, snapshot, volumes > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967519#comment-13967519 ] Chris Suich commented on CLOUDSTACK-5863: - Yes, the framework is in place for snapshot revert, however it isn't implemented for hypervisors. It was put in place to allow storage vendors to perform volume reverts. You'll notice that the UI should dynamically show the 'Revert Snapshot' button if the underlying snapshot provider supports it. > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux > Labels: backup, kvm, restore, snapshot, volumes > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902015#comment-13902015 ] Nux commented on CLOUDSTACK-5863: - Hello, This is to let you know I want to test the revertSnapshot. What's next? > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux > Labels: backup, kvm, restore, snapshot, volumes > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872181#comment-13872181 ] Nux commented on CLOUDSTACK-5863: - Wow, that's great. I'd love to test this. What do I have to do? > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux > Labels: backup, kvm, restore, snapshot, volumes > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872131#comment-13872131 ] Wei Zhou commented on CLOUDSTACK-5863: -- I have implemented revertSnapshot in KVM based on CS 4.2.0. If you want to test it, please let me know > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux > Labels: backup, kvm, restore, snapshot, volumes > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CLOUDSTACK-5863) Restore volume snapshot
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869615#comment-13869615 ] Wei Zhou commented on CLOUDSTACK-5863: -- FYI. Chris Suich has committed some patches in Oct, 2013. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=search;s=Chris+Suich;st=author However, it is not implemented. > Restore volume snapshot > --- > > Key: CLOUDSTACK-5863 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5863 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Snapshot > Environment: KVM, EL6, QCOW2 >Reporter: Nux > Labels: backup, kvm, restore, snapshot, volumes > > Hello, > Just as users can create backups of volumes, they should be able to restore > said volumes from them. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
