[jira] [Commented] (CLOUDSTACK-6486) Isolation network creation fails when isolationMethod is set in lower case for the corresponding physical network

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091493#comment-14091493
 ] 

ASF subversion and git services commented on CLOUDSTACK-6486:
-

Commit 354756219cb5ca0b941f9091d847e8dda099547f in cloudstack's branch 
refs/heads/master from [~alena1108]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3547562 ]

CLOUDSTACK-6486: Guest network guru - when add network, validate isolation 
method in case insensitive manner


 Isolation network creation fails when isolationMethod is set in lower case 
 for the corresponding physical network
 -

 Key: CLOUDSTACK-6486
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6486
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
  Components: Network Controller
Affects Versions: 4.4.0
Reporter: Alena Prokharchyk
Assignee: Alena Prokharchyk
 Fix For: 4.4.0


 Steps to reproduce:
 ==
 1) login as root admin
 2) Try to create an isolated network, either from the deploy vm dialog, or 
 from Networks tab. following error occurs:
 ERROR [c.c.a.ApiServer] (2128435204@qtp-415454110-20:ctx-fe01b290 
 ctx-c27f313c) unhandled exception executing api command: 
 [Ljava.lang.String;@33607ddc
 com.cloud.utils.exception.CloudRuntimeException: Unable to convert network 
 offering with specified id to network profile
   at 
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.setupNetwork(NetworkOrchestrator.java:691)
   at 
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$8.doInTransaction(NetworkOrchestrator.java:1940)
   at 
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$8.doInTransaction(NetworkOrchestrator.java:1901)
   at com.cloud.utils.db.Transaction$2.doInTransaction(Transaction.java:49)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:37)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:46)
   at 
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.createGuestNetwork(NetworkOrchestrator.java:1901)
   at 
 com.cloud.network.NetworkServiceImpl$4.doInTransaction(NetworkServiceImpl.java:1362)
   at 
 com.cloud.network.NetworkServiceImpl$4.doInTransaction(NetworkServiceImpl.java:1310)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:37)
   at 
 com.cloud.network.NetworkServiceImpl.commitNetwork(NetworkServiceImpl.java:1310)
   at 
 com.cloud.network.NetworkServiceImpl.createGuestNetwork(NetworkServiceImpl.java:1273)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:606)
   at 
 org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
   at 
 org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
   at 
 com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
   at 
 org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
   at 
 org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
   at com.sun.proxy.$Proxy157.createGuestNetwork(Unknown Source)
   at 
 org.apache.cloudstack.api.command.admin.network.CreateNetworkCmdByAdmin.execute(CreateNetworkCmdByAdmin.java:57)
   at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:134)
   at com.cloud.api.ApiServer.queueCommand(ApiServer.java:593)
   at com.cloud.api.ApiServer.handleRequest(ApiServer.java:416)
   at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:330)
   at com.cloud.api.ApiServlet.access$000(ApiServlet.java:54)
   at com.cloud.api.ApiServlet$1.run(ApiServlet.java:118)
   at 
 

[jira] [Commented] (CLOUDSTACK-6486) Isolation network creation fails when isolationMethod is set in lower case for the corresponding physical network

[Alena Prokharchyk (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979039#comment-13979039
 ] 

Alena Prokharchyk commented on CLOUDSTACK-6486:
---

Steps to reproduce:

1) Create the zone
2) Add physical network to the zone with the API:

http://localhost:8096/?command=createPhysicalNetworkzoneId=1name=alenaisolationmethods=vlan

make sure vlan is passed in lower case

3) Try to create an isolated network. It will fail as this part of the code in 
GuestNetworkGuru does isolation methods comparison in case sensitive manner:

 ListString methods = physicalNetwork.getIsolationMethods();
if (methods.isEmpty()) {
// The empty isolation method is assumed to be VLAN
s_logger.debug(Empty physical isolation type for physical network 
 + physicalNetwork.getUuid());
methods = new ArrayListString(1);
methods.add(VLAN);
}

for (IsolationMethod m : _isolationMethods) {
if (methods.contains(m.toString())) {
return true;
}
}


 Isolation network creation fails when isolationMethod is set in lower case 
 for the corresponding physical network
 -

 Key: CLOUDSTACK-6486
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6486
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
  Components: Network Controller
Affects Versions: 4.4.0
Reporter: Alena Prokharchyk
 Fix For: 4.4.0


 Steps to reproduce:
 ==
 1) login as root admin
 2) Try to create an isolated network, either from the deploy vm dialog, or 
 from Networks tab. following error occurs:
 ERROR [c.c.a.ApiServer] (2128435204@qtp-415454110-20:ctx-fe01b290 
 ctx-c27f313c) unhandled exception executing api command: 
 [Ljava.lang.String;@33607ddc
 com.cloud.utils.exception.CloudRuntimeException: Unable to convert network 
 offering with specified id to network profile
   at 
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.setupNetwork(NetworkOrchestrator.java:691)
   at 
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$8.doInTransaction(NetworkOrchestrator.java:1940)
   at 
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator$8.doInTransaction(NetworkOrchestrator.java:1901)
   at com.cloud.utils.db.Transaction$2.doInTransaction(Transaction.java:49)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:37)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:46)
   at 
 org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.createGuestNetwork(NetworkOrchestrator.java:1901)
   at 
 com.cloud.network.NetworkServiceImpl$4.doInTransaction(NetworkServiceImpl.java:1362)
   at 
 com.cloud.network.NetworkServiceImpl$4.doInTransaction(NetworkServiceImpl.java:1310)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:37)
   at 
 com.cloud.network.NetworkServiceImpl.commitNetwork(NetworkServiceImpl.java:1310)
   at 
 com.cloud.network.NetworkServiceImpl.createGuestNetwork(NetworkServiceImpl.java:1273)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:606)
   at 
 org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
   at 
 org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
   at 
 com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
   at 
 org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
   at 
 org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
   at 
 org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
   at com.sun.proxy.$Proxy157.createGuestNetwork(Unknown Source)
   at