[jira] [Commented] (CLOUDSTACK-6835) db abstraction layer in upgrade path
[ https://issues.apache.org/jira/browse/CLOUDSTACK-6835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237684#comment-14237684 ] Rajani Karuturi commented on CLOUDSTACK-6835: - if reusing GenericDaoBase is possible, that would be better. I havent put a lot of thought into it. db abstraction layer in upgrade path Key: CLOUDSTACK-6835 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6835 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Reporter: Rajani Karuturi Priority: Critical Fix For: 4.6.0 about 198 of the issues reported by covery scan[1] on 26 May, 2014 are in the Upgrade###to###.java code and many of them related to Resource leaks and not closing the prepared statements. I think we should have a DB abstraction layer in the upgrade path so the the developer who needs to do select/insert/update data in the upgrade path need not write native sqls and worry about these recurring issues. [1] https://scan.coverity.com/projects/943 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-6835) db abstraction layer in upgrade path
[ https://issues.apache.org/jira/browse/CLOUDSTACK-6835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235546#comment-14235546 ] Rohit Yadav commented on CLOUDSTACK-6835: - That's a great idea [~rajanik]! We can either make a DBUtils (instead of implementing helps in DBUpgrade class), what do you suggest? db abstraction layer in upgrade path Key: CLOUDSTACK-6835 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6835 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Reporter: Rajani Karuturi Priority: Critical Fix For: 4.6.0 about 198 of the issues reported by covery scan[1] on 26 May, 2014 are in the Upgrade###to###.java code and many of them related to Resource leaks and not closing the prepared statements. I think we should have a DB abstraction layer in the upgrade path so the the developer who needs to do select/insert/update data in the upgrade path need not write native sqls and worry about these recurring issues. [1] https://scan.coverity.com/projects/943 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
