[jira] [Commented] (CLOUDSTACK-6864) UploadSSlCert API requires double encoding of URL params
[ https://issues.apache.org/jira/browse/CLOUDSTACK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029001#comment-14029001 ] ASF subversion and git services commented on CLOUDSTACK-6864: - Commit 23b7993d581563108199c9930827c042245fb8c5 in cloudstack's branch refs/heads/4.4 from [~saksham] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=23b7993 ] CLOUDSTACK-6864: UploadSSlCert API requires double encoding of URL params (cherry picked from commit c5ee5ad5c828d9f0b128e3d7280a30dcf717e045) UploadSSlCert API requires double encoding of URL params Key: CLOUDSTACK-6864 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6864 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.4.0 Reporter: Saksham Srivastava Assignee: Saksham Srivastava Fix For: 4.4.0 uploadSslCert API requires double UTF-8 encoding of the parameters (certificate, privatekey, certchain) in the URL. This is because there are 2 decodes happening (First in API Server : handle paramList = URLEncodedUtils.parse )new URI(request.getRequestLine().getUri()), UTF_8) and the Second one in the API definition: CertServiceImpl:uploadSslCert String cert = URLDecoder.decode(certCmd.getCert(), UTF-8); ) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLOUDSTACK-6864) UploadSSlCert API requires double encoding of URL params
[ https://issues.apache.org/jira/browse/CLOUDSTACK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028851#comment-14028851 ] ASF subversion and git services commented on CLOUDSTACK-6864: - Commit f2464e418284d366bbe09dced9084966d17ce265 in cloudstack's branch refs/heads/master from [~saksham] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f2464e4 ] CLOUDSTACK-6864: UploadSSlCert API requires double encoding of URL params UploadSSlCert API requires double encoding of URL params Key: CLOUDSTACK-6864 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6864 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.4.0 Reporter: Saksham Srivastava Assignee: Saksham Srivastava uploadSslCert API requires double UTF-8 encoding of the parameters (certificate, privatekey, certchain) in the URL. This is because there are 2 decodes happening (First in API Server : handle paramList = URLEncodedUtils.parse )new URI(request.getRequestLine().getUri()), UTF_8) and the Second one in the API definition: CertServiceImpl:uploadSslCert String cert = URLDecoder.decode(certCmd.getCert(), UTF-8); ) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLOUDSTACK-6864) UploadSSlCert API requires double encoding of URL params
[ https://issues.apache.org/jira/browse/CLOUDSTACK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026335#comment-14026335 ] ASF subversion and git services commented on CLOUDSTACK-6864: - Commit c5ee5ad5c828d9f0b128e3d7280a30dcf717e045 in cloudstack's branch refs/heads/4.4-forward from [~saksham] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c5ee5ad ] CLOUDSTACK-6864: UploadSSlCert API requires double encoding of URL params UploadSSlCert API requires double encoding of URL params Key: CLOUDSTACK-6864 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6864 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.4.0 Reporter: Saksham Srivastava Assignee: Saksham Srivastava uploadSslCert API requires double UTF-8 encoding of the parameters (certificate, privatekey, certchain) in the URL. This is because there are 2 decodes happening (First in API Server : handle paramList = URLEncodedUtils.parse )new URI(request.getRequestLine().getUri()), UTF_8) and the Second one in the API definition: CertServiceImpl:uploadSslCert String cert = URLDecoder.decode(certCmd.getCert(), UTF-8); ) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CLOUDSTACK-6864) UploadSSlCert API requires double encoding of URL params
[ https://issues.apache.org/jira/browse/CLOUDSTACK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14021658#comment-14021658 ] Nitin Mehta commented on CLOUDSTACK-6864: - The correct fix should be removing the double encoding in the api definition ie removing this CertServiceImpl:uploadSslCert String cert = URLDecoder.decode(certCmd.getCert(), UTF-8); ) UploadSSlCert API requires double encoding of URL params Key: CLOUDSTACK-6864 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6864 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: API Affects Versions: 4.4.0 Reporter: Saksham Srivastava Assignee: Saksham Srivastava uploadSslCert API requires double UTF-8 encoding of the parameters (certificate, privatekey, certchain) in the URL. This is because there are 2 decodes happening (First in API Server : handle paramList = URLEncodedUtils.parse )new URI(request.getRequestLine().getUri()), UTF_8) and the Second one in the API definition: CertServiceImpl:uploadSslCert String cert = URLDecoder.decode(certCmd.getCert(), UTF-8); ) -- This message was sent by Atlassian JIRA (v6.2#6252)
