[jira] [Commented] (CLOUDSTACK-7605) [Basic zone] Restart network with clean up set to true in a zone with multiple pods leave routers in stopped state

2015-02-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308999#comment-14308999
 ] 

ASF subversion and git services commented on CLOUDSTACK-7605:
-

Commit 405ed3ca50a33adfcb04f960a4420d54619ab4f1 in cloudstack's branch 
refs/heads/4.5 from [~yasker]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=405ed3c ]

CLOUDSTACK-7605: Fix basic zone multiple pod network restart with cleanup=true

1. getRouters() doesn't handle RestartNetwork with cleanup=true for basic zone,
because pod wouldn't be specific at the time.

2. The regression caused by the following fix. The variable "routers" was
overrided with some local values, result in only one of the routers in multiple
pods would return, thus only one router would be started.

commit 6dd5c3fd42c70855d75156243dddc4933436baaf
Author: Rohit Yadav 
Date: Thu Oct 11 18:30:00 2012 +0530
CLOUDSTACK-70: Improve restart network behaviour for basic network

(cherry picked from commit aaeadc5c44e3fe16a1deea5348b085b08b5f4f4d)
Signed-off-by: Rohit Yadav 


> [Basic zone] Restart network with clean up set to true in a zone with 
> multiple pods leave routers in stopped state
> --
>
> Key: CLOUDSTACK-7605
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7605
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Sheng Yang
>Assignee: Sheng Yang
>Priority: Critical
> Fix For: 4.5.0
>
>
> In a basic zone with more than one pod, if network is restarted with clean up 
> set to true, routers in all Pods get recreated but remain in Stopped state. 
> Only one router gets started up.
> Exception like this:
> 2014-09-22 15:42:21,583 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32 ctx-79fd1959) Wake up jobs 
> joined with job- 32 and disjoin all subjobs created from job- 32
> 2014-09-22 15:42:21,587 DEBUG [c.c.v.VmWorkJobDispatcher] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done with run of VM work 
> job: com.cloud.vm.VmWorkStart for VM 13, job origin: 25
> 2014-09-22 15:42:21,587 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done executing 
> com.cloud.vm.VmWorkStart for job-32
> 2014-09-22 15:42:21,594 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Asking 
> SecurityGroupProvider to implemenet Ntwk[204|Guest|6]
> 2014-09-22 15:42:21,595 WARN  [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Failed to implement 
> network Ntwk[204|Guest|6] elements and resources as a part of network restart 
> due to 
> java.lang.NullPointerException
> at 
> com.cloud.network.element.VirtualRouterElement.getRouters(VirtualRouterElement.java:971)
> at 
> com.cloud.network.element.VirtualRouterElement.prepareAggregatedExecution(VirtualRouterElement.java:1118)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.implementNetworkElementsAndResources(NetworkOrchestrator.java:1120)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.restartNetwork(NetworkOrchestrator.java:2484)
> at 
> com.cloud.network.NetworkServiceImpl.restartNetwork(NetworkServiceImpl.java:1873)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
> at 
> org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
> at 
> org.springframework.aop.framework.ReflectiveMethodIn

[jira] [Commented] (CLOUDSTACK-7605) [Basic zone] Restart network with clean up set to true in a zone with multiple pods leave routers in stopped state

2014-09-22 Thread Sheng Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144172#comment-14144172
 ] 

Sheng Yang commented on CLOUDSTACK-7605:


There are two issues with it:
1. getRouters() mentioned above in the log, doesn't handle RestartNetwork with 
cleanup=true for basic zone, because pod wouldn't be specific at the time.
2. There is one bug introduced by Rohit, overrided the variable "routers" with 
some local values, result in only one of the routers in multiple pods would 
return, thus only one router would be started.

commit 6dd5c3fd42c70855d75156243dddc4933436baaf
Author: Rohit Yadav 
Date:   Thu Oct 11 18:30:00 2012 +0530

CLOUDSTACK-70: Improve restart network behaviour for basic network

If cleanup=true, network elements and resources are shutdown and
reimplemented. Else, shutdown/reimplementation is skipped. Enabled
cleanup checkbox in CS UI.

For both cases, VRs are only deployed for Pods with no running
or starting VRs and Pods having running or starting user vms.

New DAO helpers introduced:
HostPodDao: listByDataCenterIdVMTypeAndStates
DomainRouterDao: listByPodId and listByPodIdAndStates
VMInstanceDao: listByPodId and corrected definition of listByTypeAndState

Signed-off-by: Rohit Yadav 



> [Basic zone] Restart network with clean up set to true in a zone with 
> multiple pods leave routers in stopped state
> --
>
> Key: CLOUDSTACK-7605
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7605
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Sheng Yang
>Assignee: Sheng Yang
>Priority: Critical
>
> In a basic zone with more than one pod, if network is restarted with clean up 
> set to true, routers in all Pods get recreated but remain in Stopped state. 
> Only one router gets started up.
> Exception like this:
> 2014-09-22 15:42:21,583 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32 ctx-79fd1959) Wake up jobs 
> joined with job- 32 and disjoin all subjobs created from job- 32
> 2014-09-22 15:42:21,587 DEBUG [c.c.v.VmWorkJobDispatcher] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done with run of VM work 
> job: com.cloud.vm.VmWorkStart for VM 13, job origin: 25
> 2014-09-22 15:42:21,587 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done executing 
> com.cloud.vm.VmWorkStart for job-32
> 2014-09-22 15:42:21,594 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Asking 
> SecurityGroupProvider to implemenet Ntwk[204|Guest|6]
> 2014-09-22 15:42:21,595 WARN  [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Failed to implement 
> network Ntwk[204|Guest|6] elements and resources as a part of network restart 
> due to 
> java.lang.NullPointerException
> at 
> com.cloud.network.element.VirtualRouterElement.getRouters(VirtualRouterElement.java:971)
> at 
> com.cloud.network.element.VirtualRouterElement.prepareAggregatedExecution(VirtualRouterElement.java:1118)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.implementNetworkElementsAndResources(NetworkOrchestrator.java:1120)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.restartNetwork(NetworkOrchestrator.java:2484)
> at 
> com.cloud.network.NetworkServiceImpl.restartNetwork(NetworkServiceImpl.java:1873)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
> at 
> org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvoca

[jira] [Commented] (CLOUDSTACK-7605) [Basic zone] Restart network with clean up set to true in a zone with multiple pods leave routers in stopped state

2014-09-23 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145508#comment-14145508
 ] 

ASF subversion and git services commented on CLOUDSTACK-7605:
-

Commit aaeadc5c44e3fe16a1deea5348b085b08b5f4f4d in cloudstack's branch 
refs/heads/master from [~yasker]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=aaeadc5 ]

CLOUDSTACK-7605: Fix basic zone multiple pod network restart with cleanup=true

1. getRouters() doesn't handle RestartNetwork with cleanup=true for basic zone,
because pod wouldn't be specific at the time.

2. The regression caused by the following fix. The variable "routers" was
overrided with some local values, result in only one of the routers in multiple
pods would return, thus only one router would be started.

commit 6dd5c3fd42c70855d75156243dddc4933436baaf
Author: Rohit Yadav 
Date: Thu Oct 11 18:30:00 2012 +0530
CLOUDSTACK-70: Improve restart network behaviour for basic network


> [Basic zone] Restart network with clean up set to true in a zone with 
> multiple pods leave routers in stopped state
> --
>
> Key: CLOUDSTACK-7605
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7605
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Sheng Yang
>Assignee: Sheng Yang
>Priority: Critical
>
> In a basic zone with more than one pod, if network is restarted with clean up 
> set to true, routers in all Pods get recreated but remain in Stopped state. 
> Only one router gets started up.
> Exception like this:
> 2014-09-22 15:42:21,583 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32 ctx-79fd1959) Wake up jobs 
> joined with job- 32 and disjoin all subjobs created from job- 32
> 2014-09-22 15:42:21,587 DEBUG [c.c.v.VmWorkJobDispatcher] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done with run of VM work 
> job: com.cloud.vm.VmWorkStart for VM 13, job origin: 25
> 2014-09-22 15:42:21,587 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done executing 
> com.cloud.vm.VmWorkStart for job-32
> 2014-09-22 15:42:21,594 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Asking 
> SecurityGroupProvider to implemenet Ntwk[204|Guest|6]
> 2014-09-22 15:42:21,595 WARN  [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Failed to implement 
> network Ntwk[204|Guest|6] elements and resources as a part of network restart 
> due to 
> java.lang.NullPointerException
> at 
> com.cloud.network.element.VirtualRouterElement.getRouters(VirtualRouterElement.java:971)
> at 
> com.cloud.network.element.VirtualRouterElement.prepareAggregatedExecution(VirtualRouterElement.java:1118)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.implementNetworkElementsAndResources(NetworkOrchestrator.java:1120)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.restartNetwork(NetworkOrchestrator.java:2484)
> at 
> com.cloud.network.NetworkServiceImpl.restartNetwork(NetworkServiceImpl.java:1873)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
> at 
> org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
> at 
> org.springframework.aop.framework.JdkDynamicAopProxy.inv

[jira] [Commented] (CLOUDSTACK-7605) [Basic zone] Restart network with clean up set to true in a zone with multiple pods leave routers in stopped state

2014-09-23 Thread Sheng Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145577#comment-14145577
 ] 

Sheng Yang commented on CLOUDSTACK-7605:


We should add automation test case for this one.

> [Basic zone] Restart network with clean up set to true in a zone with 
> multiple pods leave routers in stopped state
> --
>
> Key: CLOUDSTACK-7605
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7605
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Sheng Yang
>Assignee: Sheng Yang
>Priority: Critical
> Fix For: 4.5.0
>
>
> In a basic zone with more than one pod, if network is restarted with clean up 
> set to true, routers in all Pods get recreated but remain in Stopped state. 
> Only one router gets started up.
> Exception like this:
> 2014-09-22 15:42:21,583 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32 ctx-79fd1959) Wake up jobs 
> joined with job- 32 and disjoin all subjobs created from job- 32
> 2014-09-22 15:42:21,587 DEBUG [c.c.v.VmWorkJobDispatcher] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done with run of VM work 
> job: com.cloud.vm.VmWorkStart for VM 13, job origin: 25
> 2014-09-22 15:42:21,587 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done executing 
> com.cloud.vm.VmWorkStart for job-32
> 2014-09-22 15:42:21,594 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Asking 
> SecurityGroupProvider to implemenet Ntwk[204|Guest|6]
> 2014-09-22 15:42:21,595 WARN  [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Failed to implement 
> network Ntwk[204|Guest|6] elements and resources as a part of network restart 
> due to 
> java.lang.NullPointerException
> at 
> com.cloud.network.element.VirtualRouterElement.getRouters(VirtualRouterElement.java:971)
> at 
> com.cloud.network.element.VirtualRouterElement.prepareAggregatedExecution(VirtualRouterElement.java:1118)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.implementNetworkElementsAndResources(NetworkOrchestrator.java:1120)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.restartNetwork(NetworkOrchestrator.java:2484)
> at 
> com.cloud.network.NetworkServiceImpl.restartNetwork(NetworkServiceImpl.java:1873)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
> at 
> org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
> at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
> at com.sun.proxy.$Proxy173.restartNetwork(Unknown Source)
> at 
> org.apache.cloudstack.api.command.user.network.RestartNetworkCmd.execute(RestartNetworkCmd.java:95)
> at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:141)
> at 
> com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108)
> at 
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:513)
> at 
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.jav

[jira] [Commented] (CLOUDSTACK-7605) [Basic zone] Restart network with clean up set to true in a zone with multiple pods leave routers in stopped state

2014-10-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157880#comment-14157880
 ] 

ASF subversion and git services commented on CLOUDSTACK-7605:
-

Commit a8cb7c1480499b1c901ff4f69ebf7ccb3587c541 in cloudstack's branch 
refs/heads/vpc-refactor from [~wilder.rodrigues]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a8cb7c1 ]

Applygin fix from commit ID aaeadc5c44e3fe16a1deea5348b085b08b5f4f4d

Sheng Yang changed 2 classes, ut only one was related to the bug 
CLOUDSTACK-7605.
I applied the changed on the routerslist, used during the deployment of the 
virtual routers.

Tested Advanced Zone against the simulator. 69 happy tests in place


> [Basic zone] Restart network with clean up set to true in a zone with 
> multiple pods leave routers in stopped state
> --
>
> Key: CLOUDSTACK-7605
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7605
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Sheng Yang
>Assignee: Sheng Yang
>Priority: Critical
> Fix For: 4.5.0
>
>
> In a basic zone with more than one pod, if network is restarted with clean up 
> set to true, routers in all Pods get recreated but remain in Stopped state. 
> Only one router gets started up.
> Exception like this:
> 2014-09-22 15:42:21,583 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32 ctx-79fd1959) Wake up jobs 
> joined with job- 32 and disjoin all subjobs created from job- 32
> 2014-09-22 15:42:21,587 DEBUG [c.c.v.VmWorkJobDispatcher] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done with run of VM work 
> job: com.cloud.vm.VmWorkStart for VM 13, job origin: 25
> 2014-09-22 15:42:21,587 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done executing 
> com.cloud.vm.VmWorkStart for job-32
> 2014-09-22 15:42:21,594 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Asking 
> SecurityGroupProvider to implemenet Ntwk[204|Guest|6]
> 2014-09-22 15:42:21,595 WARN  [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Failed to implement 
> network Ntwk[204|Guest|6] elements and resources as a part of network restart 
> due to 
> java.lang.NullPointerException
> at 
> com.cloud.network.element.VirtualRouterElement.getRouters(VirtualRouterElement.java:971)
> at 
> com.cloud.network.element.VirtualRouterElement.prepareAggregatedExecution(VirtualRouterElement.java:1118)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.implementNetworkElementsAndResources(NetworkOrchestrator.java:1120)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.restartNetwork(NetworkOrchestrator.java:2484)
> at 
> com.cloud.network.NetworkServiceImpl.restartNetwork(NetworkServiceImpl.java:1873)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
> at 
> org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
> at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
> at com.sun.proxy.$Proxy173.restartNetwork(Unknown Source)
> at 
> org.apache.cloudstack.api.command.user.network.RestartNetworkCmd.execute(RestartNetworkCmd.java:95)
> at 

[jira] [Commented] (CLOUDSTACK-7605) [Basic zone] Restart network with clean up set to true in a zone with multiple pods leave routers in stopped state

2014-10-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171297#comment-14171297
 ] 

ASF subversion and git services commented on CLOUDSTACK-7605:
-

Commit db86bdfb2cae2673a10dac31995ee5e5af64a994 in cloudstack's branch 
refs/heads/master from [~wilder.rodrigues]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=db86bdf ]

Applygin fix from commit ID aaeadc5c44e3fe16a1deea5348b085b08b5f4f4d

Sheng Yang changed 2 classes, ut only one was related to the bug 
CLOUDSTACK-7605.
I applied the changed on the routerslist, used during the deployment of the 
virtual routers.

Tested Advanced Zone against the simulator. 69 happy tests in place


> [Basic zone] Restart network with clean up set to true in a zone with 
> multiple pods leave routers in stopped state
> --
>
> Key: CLOUDSTACK-7605
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7605
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Sheng Yang
>Assignee: Sheng Yang
>Priority: Critical
> Fix For: 4.5.0
>
>
> In a basic zone with more than one pod, if network is restarted with clean up 
> set to true, routers in all Pods get recreated but remain in Stopped state. 
> Only one router gets started up.
> Exception like this:
> 2014-09-22 15:42:21,583 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32 ctx-79fd1959) Wake up jobs 
> joined with job- 32 and disjoin all subjobs created from job- 32
> 2014-09-22 15:42:21,587 DEBUG [c.c.v.VmWorkJobDispatcher] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done with run of VM work 
> job: com.cloud.vm.VmWorkStart for VM 13, job origin: 25
> 2014-09-22 15:42:21,587 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (Work-Job-Executor-14:ctx-51d3b3f9 job-25/job-32) Done executing 
> com.cloud.vm.VmWorkStart for job-32
> 2014-09-22 15:42:21,594 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Asking 
> SecurityGroupProvider to implemenet Ntwk[204|Guest|6]
> 2014-09-22 15:42:21,595 WARN  [o.a.c.e.o.NetworkOrchestrator] 
> (API-Job-Executor-13:ctx-693acbb4 job-25 ctx-5a20d246) Failed to implement 
> network Ntwk[204|Guest|6] elements and resources as a part of network restart 
> due to 
> java.lang.NullPointerException
> at 
> com.cloud.network.element.VirtualRouterElement.getRouters(VirtualRouterElement.java:971)
> at 
> com.cloud.network.element.VirtualRouterElement.prepareAggregatedExecution(VirtualRouterElement.java:1118)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.implementNetworkElementsAndResources(NetworkOrchestrator.java:1120)
> at 
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.restartNetwork(NetworkOrchestrator.java:2484)
> at 
> com.cloud.network.NetworkServiceImpl.restartNetwork(NetworkServiceImpl.java:1873)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
> at 
> org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
> at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
> at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
> at com.sun.proxy.$Proxy173.restartNetwork(Unknown Source)
> at 
> org.apache.cloudstack.api.command.user.network.RestartNetworkCmd.execute(RestartNetworkCmd.java:95)
> at com.cl