[jira] [Commented] (CLOUDSTACK-7931) Setting Null for global network throttling params doesn't trigger suitable error, fails silently
[ https://issues.apache.org/jira/browse/CLOUDSTACK-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215864#comment-14215864 ] ASF subversion and git services commented on CLOUDSTACK-7931: - Commit b008d78b57d318336e8e36091e64d19966ea518b in cloudstack's branch refs/heads/master from [~anshulg] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b008d78 ] CLOUDSTACK-7930, CLOUDSTACK-7931: Do not allow to set invalid values for global settings which are of type integer and float This closes #41 > Setting Null for global network throttling params doesn't trigger suitable > error, fails silently > > > Key: CLOUDSTACK-7931 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7931 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Anshul Gangwar >Assignee: Anshul Gangwar >Priority: Critical > Fix For: 4.5.0 > > > Set global configs network.throttling.rate and vm.network.throttling.rate to > NULL value. > Then launch VM in a new network > Result > = > VM fails to launch but it fails without any ERROR logs or suitable exceptions. > A corresponding INFO log seems to have nothing but "null" > Generally, for few global configs NULL is an acceptable value in some cases. > If this is not the case, then we should not allow to set such a value for the > config. The API should error out suitably. This is one issue. > Further, it should throw an appropriate error when the deploy VM fails to > design network. The error in this case is not handled suitably and there's > nothing in ERROR logs as well. > Looking at the below logs, it's impossible to figure out the reason for the > failure of deploy VM. So at some point, if a user inadvertently sets it to > NULL, neither does the updateConfiguration API result in error nor does the > deployVirtualMachine throw a suitable error. > Here's the log: > 2014-11-13 13:29:15,584 DEBUG [c.c.a.ApiServlet] > (catalina-exec-18:ctx-285ce7d9) ===START=== 10.144.7.5 – GET > command=createNetwork&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&networkOfferingId=e8746c6b-e945-4084-9290-37cea253e262&name=newtest1&displayText=newtest1&zoneId=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789 > 2014-11-13 13:29:15,617 DEBUG [o.a.c.n.c.m.ContrailGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,617 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) design called > 2014-11-13 13:29:15,618 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network, > the physical isolation type is not MIDO > 2014-11-13 13:29:15,619 DEBUG [c.c.n.g.NiciraNvpGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,620 DEBUG [o.a.c.n.o.OpendaylightGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,621 DEBUG [c.c.n.g.OvsGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,644 DEBUG [o.a.c.n.g.SspGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) SSP not configured to be active > 2014-11-13 13:29:15,645 DEBUG [c.c.n.g.BrocadeVcsGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,646 DEBUG [c.c.n.g.NuageVspGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,648 DEBUG [o.a.c.e.o.NetworkOrchestrator] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Releasing lock for > Acct[467a4f66-698f-11e4-be18-42407779c24b-admin] > 2014-11-13 13:29:15,688 DEBUG [c.c.a.ApiServlet] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) ===END=== 10.144.7.5 – GET > command=createNetwork&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&networkOfferingId=e8746c6b-e945-4084-9290-37cea253e262&name=newtest1&displayText=newtest1&zoneId=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789 > 2014-11-13 13:29:15,727 DEBUG [c.c.a.ApiServlet] > (catalina-exec-9:ctx-54781545) ===START=== 10.144.7.5 – GET > command=deployVirtualMachine&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&zoneid=b642a92a-3480-4818-99bf-6546a28df624&templateid=f7df5ef0-698e-11e4-be18-42407779c24b&hypervisor=XenServer&serviceofferingid=04840780-04d0-4b41-847a-dda08ad460f4&iptonetworklist%5B0%5D.networkid=c0e24f7a-fe03-4a3b-a11e-ab29150b803b&displayname=throttlingvm1&name=throttlingvm1&_=1415866216945 > 2014-11-13 13:29:15,753 DEBUG [c.c.n
[jira] [Commented] (CLOUDSTACK-7931) Setting Null for global network throttling params doesn't trigger suitable error, fails silently
[ https://issues.apache.org/jira/browse/CLOUDSTACK-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215930#comment-14215930 ] ASF subversion and git services commented on CLOUDSTACK-7931: - Commit 8307dd9105cdb70a0fe09c059bacfcec43a29024 in cloudstack's branch refs/heads/4.5 from [~anshulg] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8307dd9 ] CLOUDSTACK-7930, CLOUDSTACK-7931: Do not allow to set invalid values for global settings which are of type integer and float This closes #41 > Setting Null for global network throttling params doesn't trigger suitable > error, fails silently > > > Key: CLOUDSTACK-7931 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7931 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Anshul Gangwar >Assignee: Anshul Gangwar >Priority: Critical > Fix For: 4.5.0 > > > Set global configs network.throttling.rate and vm.network.throttling.rate to > NULL value. > Then launch VM in a new network > Result > = > VM fails to launch but it fails without any ERROR logs or suitable exceptions. > A corresponding INFO log seems to have nothing but "null" > Generally, for few global configs NULL is an acceptable value in some cases. > If this is not the case, then we should not allow to set such a value for the > config. The API should error out suitably. This is one issue. > Further, it should throw an appropriate error when the deploy VM fails to > design network. The error in this case is not handled suitably and there's > nothing in ERROR logs as well. > Looking at the below logs, it's impossible to figure out the reason for the > failure of deploy VM. So at some point, if a user inadvertently sets it to > NULL, neither does the updateConfiguration API result in error nor does the > deployVirtualMachine throw a suitable error. > Here's the log: > 2014-11-13 13:29:15,584 DEBUG [c.c.a.ApiServlet] > (catalina-exec-18:ctx-285ce7d9) ===START=== 10.144.7.5 – GET > command=createNetwork&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&networkOfferingId=e8746c6b-e945-4084-9290-37cea253e262&name=newtest1&displayText=newtest1&zoneId=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789 > 2014-11-13 13:29:15,617 DEBUG [o.a.c.n.c.m.ContrailGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,617 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) design called > 2014-11-13 13:29:15,618 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network, > the physical isolation type is not MIDO > 2014-11-13 13:29:15,619 DEBUG [c.c.n.g.NiciraNvpGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,620 DEBUG [o.a.c.n.o.OpendaylightGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,621 DEBUG [c.c.n.g.OvsGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,644 DEBUG [o.a.c.n.g.SspGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) SSP not configured to be active > 2014-11-13 13:29:15,645 DEBUG [c.c.n.g.BrocadeVcsGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,646 DEBUG [c.c.n.g.NuageVspGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,648 DEBUG [o.a.c.e.o.NetworkOrchestrator] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Releasing lock for > Acct[467a4f66-698f-11e4-be18-42407779c24b-admin] > 2014-11-13 13:29:15,688 DEBUG [c.c.a.ApiServlet] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) ===END=== 10.144.7.5 – GET > command=createNetwork&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&networkOfferingId=e8746c6b-e945-4084-9290-37cea253e262&name=newtest1&displayText=newtest1&zoneId=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789 > 2014-11-13 13:29:15,727 DEBUG [c.c.a.ApiServlet] > (catalina-exec-9:ctx-54781545) ===START=== 10.144.7.5 – GET > command=deployVirtualMachine&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&zoneid=b642a92a-3480-4818-99bf-6546a28df624&templateid=f7df5ef0-698e-11e4-be18-42407779c24b&hypervisor=XenServer&serviceofferingid=04840780-04d0-4b41-847a-dda08ad460f4&iptonetworklist%5B0%5D.networkid=c0e24f7a-fe03-4a3b-a11e-ab29150b803b&displayname=throttlingvm1&name=throttlingvm1&_=1415866216945 > 2014-11-13 13:29:15,753 DEBUG [c.c.n.Ne
[jira] [Commented] (CLOUDSTACK-7931) Setting Null for global network throttling params doesn't trigger suitable error, fails silently
[ https://issues.apache.org/jira/browse/CLOUDSTACK-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313385#comment-16313385 ] ASF subversion and git services commented on CLOUDSTACK-7931: - Commit b16dcb7174cc493efc92f0960a8cac1d59c11b67 in cloudstack's branch refs/heads/master from [~sudharmaj] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b16dcb7 ] CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.check.interval (#2274) Fix for CLOUDSTACK-7931 enforces a valid integer value to be configured for integration.api.port and usage.sanity.check.interval. These global configs can't be reset back to null(default). > Setting Null for global network throttling params doesn't trigger suitable > error, fails silently > > > Key: CLOUDSTACK-7931 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7931 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Anshul Gangwar >Assignee: Anshul Gangwar >Priority: Critical > Fix For: 4.5.0 > > > Set global configs network.throttling.rate and vm.network.throttling.rate to > NULL value. > Then launch VM in a new network > Result > = > VM fails to launch but it fails without any ERROR logs or suitable exceptions. > A corresponding INFO log seems to have nothing but "null" > Generally, for few global configs NULL is an acceptable value in some cases. > If this is not the case, then we should not allow to set such a value for the > config. The API should error out suitably. This is one issue. > Further, it should throw an appropriate error when the deploy VM fails to > design network. The error in this case is not handled suitably and there's > nothing in ERROR logs as well. > Looking at the below logs, it's impossible to figure out the reason for the > failure of deploy VM. So at some point, if a user inadvertently sets it to > NULL, neither does the updateConfiguration API result in error nor does the > deployVirtualMachine throw a suitable error. > Here's the log: > 2014-11-13 13:29:15,584 DEBUG [c.c.a.ApiServlet] > (catalina-exec-18:ctx-285ce7d9) ===START=== 10.144.7.5 – GET > command=createNetwork&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&networkOfferingId=e8746c6b-e945-4084-9290-37cea253e262&name=newtest1&displayText=newtest1&zoneId=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789 > 2014-11-13 13:29:15,617 DEBUG [o.a.c.n.c.m.ContrailGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,617 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) design called > 2014-11-13 13:29:15,618 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network, > the physical isolation type is not MIDO > 2014-11-13 13:29:15,619 DEBUG [c.c.n.g.NiciraNvpGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,620 DEBUG [o.a.c.n.o.OpendaylightGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,621 DEBUG [c.c.n.g.OvsGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,644 DEBUG [o.a.c.n.g.SspGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) SSP not configured to be active > 2014-11-13 13:29:15,645 DEBUG [c.c.n.g.BrocadeVcsGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,646 DEBUG [c.c.n.g.NuageVspGuestNetworkGuru] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network > 2014-11-13 13:29:15,648 DEBUG [o.a.c.e.o.NetworkOrchestrator] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Releasing lock for > Acct[467a4f66-698f-11e4-be18-42407779c24b-admin] > 2014-11-13 13:29:15,688 DEBUG [c.c.a.ApiServlet] > (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) ===END=== 10.144.7.5 – GET > command=createNetwork&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&networkOfferingId=e8746c6b-e945-4084-9290-37cea253e262&name=newtest1&displayText=newtest1&zoneId=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789 > 2014-11-13 13:29:15,727 DEBUG [c.c.a.ApiServlet] > (catalina-exec-9:ctx-54781545) ===START=== 10.144.7.5 – GET > command=deployVirtualMachine&response=json&sessionkey=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D&zoneid=b642a92a-3480-4818-99bf-6546a28df624&templateid=f7df5ef0-698e-11e4-be18-42407779c24b&hypervisor=XenServer&serviceofferingid=04840780-04d0-4b41-847a-dda08ad460f4&iptonetworklist%5B0%5D.networkid
