[jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
[
https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215727#comment-14215727
]
ASF GitHub Bot commented on CLOUDSTACK-7932:
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/39
CLOUDSTACK-7932: Fixed wrong semantics for isVmAlive() method in
HypervInvestigator
Fixed wrong semantics for isVmAlive() method in HypervInvestigator
Findbugs will report error on this as it is expecting true/false for
Boolean value.
But we have diffrent meaning for null so it is false positive case from
findbug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-7932
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
commit fe07c08c0093bbe89732bf6509f12ec8a8a0a8f2
Author: Anshul Gangwar
Date: 2014-11-17T07:30:42Z
CLOUDSTACK-7932: Fixed wrong semantics for isVmAlive() method in
HypervInvestigator
Findbugs will report error on this as it is expecting true/false for
Boolean value.
But we have diffrent meaning for null so it is false positive case from
findbug
> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> --
>
> Key: CLOUDSTACK-7932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively
> determine if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined
> that VM is not alive. How can HypervInvestigator determine status of a VM
> running on Simulator or any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HypervInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) Processing
> HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Unable to reach the agent for
> VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is unreachable: Host 1: Host
> with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) SimpleInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) XenServerInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Not a User Vm, unable to determine state of
> VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) PingInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is
> alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Sending { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver:
> v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pi
[jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
[
https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215771#comment-14215771
]
ASF GitHub Bot commented on CLOUDSTACK-7932:
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63428603
From the method definition (isVmAlive), looks like what it is doing is
right.
ideally, we should change the return type from Boolean to boolean in the
interface.
Maybe in the caller(HighAvailabilityManagerImpl), you could check for both
null and false for now.
Also, can you add some unittests?
> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> --
>
> Key: CLOUDSTACK-7932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively
> determine if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined
> that VM is not alive. How can HypervInvestigator determine status of a VM
> running on Simulator or any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HypervInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) Processing
> HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Unable to reach the agent for
> VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is unreachable: Host 1: Host
> with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) SimpleInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) XenServerInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Not a User Vm, unable to determine state of
> VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) PingInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is
> alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Sending { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver:
> v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't know')
> 2014-11-15 13:35:21,678 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Sending { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,679 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Executing: { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-
[jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
[
https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215785#comment-14215785
]
ASF GitHub Bot commented on CLOUDSTACK-7932:
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63429460
Actually null has different meaning than false. False means that vm is not
alive while null means it cannot be determined whether it is alive or not.
This is existing functionality for all hypervisor investigators so it
doesn't make sense to write unit tests for this. This got changed to this
behavior while fixing findbug bugs. Better would be to use enum to represent
various better states. But that will require many changes and can be taken for
next release.
> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> --
>
> Key: CLOUDSTACK-7932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively
> determine if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined
> that VM is not alive. How can HypervInvestigator determine status of a VM
> running on Simulator or any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HypervInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) Processing
> HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Unable to reach the agent for
> VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is unreachable: Host 1: Host
> with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) SimpleInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) XenServerInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Not a User Vm, unable to determine state of
> VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) PingInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is
> alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Sending { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver:
> v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't know')
> 2014-11-15 13:35:21,678 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Sending { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,679 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Executing: { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.
[jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
[
https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215811#comment-14215811
]
ASF GitHub Bot commented on CLOUDSTACK-7932:
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63430873
In the second return statement, should it return false since the agent is
alive and returned some status?
I didnt understand the argument for not adding unittests. I see that as an
only way to avoid the same changes in future as findbugs would report it again
and someone would attempt to fix it again.
adding some documentation might help.
> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> --
>
> Key: CLOUDSTACK-7932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively
> determine if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined
> that VM is not alive. How can HypervInvestigator determine status of a VM
> running on Simulator or any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HypervInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) Processing
> HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Unable to reach the agent for
> VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is unreachable: Host 1: Host
> with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) SimpleInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) XenServerInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Not a User Vm, unable to determine state of
> VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) PingInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is
> alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Sending { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver:
> v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't know')
> 2014-11-15 13:35:21,678 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Sending { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,679 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Executing: { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.a.t.Request]
[jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
[
https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215839#comment-14215839
]
ASF GitHub Bot commented on CLOUDSTACK-7932:
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63432886
No. Because agent is reporting status of host. We cannot determine the
status of VMs from that.
> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> --
>
> Key: CLOUDSTACK-7932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively
> determine if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined
> that VM is not alive. How can HypervInvestigator determine status of a VM
> running on Simulator or any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HypervInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) Processing
> HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Unable to reach the agent for
> VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is unreachable: Host 1: Host
> with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) SimpleInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) XenServerInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Not a User Vm, unable to determine state of
> VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) PingInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is
> alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Sending { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver:
> v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't know')
> 2014-11-15 13:35:21,678 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Sending { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,679 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Executing: { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Received: { Ans: , MgmtId: 1, via: 3, Ver:
> v1, Flags: 10, { Answer }
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74
[jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
[
https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215867#comment-14215867
]
ASF subversion and git services commented on CLOUDSTACK-7932:
-
Commit 055f6ad318466ed88ed07085f4facc152038b25c in cloudstack's branch
refs/heads/master from [~anshulg]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=055f6ad ]
CLOUDSTACK-7932: Fixed wrong semantics for isVmAlive() method in
HypervInvestigator
Findbugs will report error on this as it is expecting true/false for Boolean
value.
But we have diffrent meaning for null so it is false positive case from findbug
This closes #39
> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> --
>
> Key: CLOUDSTACK-7932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively
> determine if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined
> that VM is not alive. How can HypervInvestigator determine status of a VM
> running on Simulator or any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HypervInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) Processing
> HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Unable to reach the agent for
> VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is unreachable: Host 1: Host
> with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) SimpleInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) XenServerInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Not a User Vm, unable to determine state of
> VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) PingInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is
> alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Sending { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver:
> v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't know')
> 2014-11-15 13:35:21,678 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Sending { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,679 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Executing: { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.a.t.Request] (HA-Worke
[jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
[
https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215931#comment-14215931
]
ASF subversion and git services commented on CLOUDSTACK-7932:
-
Commit 4d583a4a71313d9f62438818c9d657a7c4a5d43d in cloudstack's branch
refs/heads/4.5 from [~anshulg]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d583a4 ]
CLOUDSTACK-7932: Fixed wrong semantics for isVmAlive() method in
HypervInvestigator
Findbugs will report error on this as it is expecting true/false for Boolean
value.
But we have diffrent meaning for null so it is false positive case from findbug
This closes #39
> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> --
>
> Key: CLOUDSTACK-7932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively
> determine if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined
> that VM is not alive. How can HypervInvestigator determine status of a VM
> running on Simulator or any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HypervInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) Processing
> HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Unable to reach the agent for
> VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is unreachable: Host 1: Host
> with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) SimpleInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) XenServerInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Not a User Vm, unable to determine state of
> VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) PingInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is
> alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Sending { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver:
> v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't know')
> 2014-11-15 13:35:21,678 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Sending { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,679 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Executing: { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.a.t.Request] (HA-Worker-1
[jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
[
https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215938#comment-14215938
]
ASF GitHub Bot commented on CLOUDSTACK-7932:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/39
> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> --
>
> Key: CLOUDSTACK-7932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively
> determine if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined
> that VM is not alive. How can HypervInvestigator determine status of a VM
> running on Simulator or any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HypervInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) Processing
> HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Unable to reach the agent for
> VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is unreachable: Host 1: Host
> with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) SimpleInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) XenServerInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Not a User Vm, unable to determine state of
> VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) PingInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is
> alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Sending { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver:
> v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't know')
> 2014-11-15 13:35:21,678 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Sending { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,679 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Executing: { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Received: { Ans: , MgmtId: 1, via: 3, Ver:
> v1, Flags: 10, { Answer }
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't know')
> 2014-11-15 13:35:21,691 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (H
[jira] [Commented] (CLOUDSTACK-7932) [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
[
https://issues.apache.org/jira/browse/CLOUDSTACK-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215962#comment-14215962
]
ASF GitHub Bot commented on CLOUDSTACK-7932:
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63441065
I dont see a case when it could return false then.
> [Hyper-V] Wrong semantics for isVmAlive() method in HypervInvestigator
> --
>
> Key: CLOUDSTACK-7932
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7932
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
> Fix For: 4.5.0
>
>
> The isVmAlive() method should return null when it is unable to conclusively
> determine if the VM is alive or not.
> I ran some tests using Simulator and found that HypervInvestigator determined
> that VM is not alive. How can HypervInvestigator determine status of a VM
> running on Simulator or any other HV?
> 2014-11-15 13:35:21,692 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HypervInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? false
> Full logs for the HA worker thread
> 2014-11-15 13:35:21,642 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) Processing
> HAWork[1-HA-1-Running-Investigating]
> 2014-11-15 13:35:21,648 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) HA on VM[SecondaryStorageVm|s-1-VM]
> 2014-11-15 13:35:21,658 DEBUG [c.c.h.CheckOnAgentInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Unable to reach the agent for
> VM[SecondaryStorageVm|s-1-VM]: Resource [Host:1] is unreachable: Host 1: Host
> with specified id is not in the right state: Down
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) SimpleInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) XenServerInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.UserVmDomRInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Not a User Vm, unable to determine state of
> VM[SecondaryStorageVm|s-1-VM] returning null
> 2014-11-15 13:35:21,659 INFO [c.c.h.HighAvailabilityManagerImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) PingInvestigator found
> VM[SecondaryStorageVm|s-1-VM]to be alive? null
> 2014-11-15 13:35:21,659 DEBUG [c.c.h.ManagementIPSystemVMInvestigator]
> (HA-Worker-1:ctx-e0b5183c work-1) Testing if VM[SecondaryStorageVm|s-1-VM] is
> alive
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Sending { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,670 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Executing: { Cmd , MgmtId: 1, via:
> 2(SimulatedAgent.08984ca6-967c-49b0-84c1-968076cd6992), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,675 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 2-5786281096240955453: Received: { Ans: , MgmtId: 1, via: 2, Ver:
> v1, Flags: 10,
> { Answer } }
> 2014-11-15 13:35:21,675 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't know')
> 2014-11-15 13:35:21,678 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Sending { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,679 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Executing: { Cmd , MgmtId: 1, via:
> 3(SimulatedAgent.9bcff565-4ae7-492a-8e39-30d11f1cbbd7), Ver: v1, Flags:
> 100011,
> [{"com.cloud.agent.api.PingTestCommand":{"_computingHostIp":"172.16.15.74","wait":20}}]
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.a.t.Request] (HA-Worker-1:ctx-e0b5183c
> work-1) Seq 3-248260929458798725: Received: { Ans: , MgmtId: 1, via: 3, Ver:
> v1, Flags: 10, { Answer }
> }
> 2014-11-15 13:35:21,691 DEBUG [c.c.h.AbstractInvestigatorImpl]
> (HA-Worker-1:ctx-e0b5183c work-1) host (172.16.15.74) cannot be pinged,
> returning null ('I don't
