[jira] [Commented] (CLOUDSTACK-8303) infinite lease times for a Dynamic Host Configuration Protocol should be avoided (like the plague)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353223#comment-15353223 ] ASF GitHub Bot commented on CLOUDSTACK-8303: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1547 > infinite lease times for a Dynamic Host Configuration Protocol should be > avoided (like the plague) > -- > > Key: CLOUDSTACK-8303 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8303 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Reporter: Ronald van Zantvoort > > The edithosts script in the SystemVM's currently doles out DHCP leases with > infinite validity. > Considering the D in DHCP is for 'Dynamic', and considering it might be > useful to change the information in the lease every once in a while (such as > resolvers, gateways & searches etc.), it's very bad practice to do this. > Currently, aside from one very exotic RFC, it's impossible to inform VM's of > changing network conditions because they simply won't fetch new leases. > Please consider changing it to at max 1 week or something, or better: a > configurable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8303) infinite lease times for a Dynamic Host Configuration Protocol should be avoided (like the plague)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353221#comment-15353221 ] ASF subversion and git services commented on CLOUDSTACK-8303: - Commit e4ba640a2870f0ed7cd092a1760b2d78e63c6258 in cloudstack's branch refs/heads/master from [~williamstev...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e4ba640 ] Merge pull request #1547 from PCextreme/vrouter-fixes Fixes for VirtualRouters in Basic Networking, especially with mutliple ranges in VLANsDuring the last few modifications on the SystemVM scripts, it turns out quite a lot of stuff broke in our setups. This PR fixes a number of things: * Multiple IP's per VLAN interface are now supported & working again, including DNS, DHCP ranges, password and metadata services * `useextdns` fixed (I had a small merge conflict with an attempt to fix this at 4.7, but these fixes are more comprehensive) * CLOUDSTACK-8303 * Apache configs better in line with best-practices and distro-expected locations * Added a few more helper functions & getters & setters for utility * some minor cleanup & fixes * pr/1547: Remove /etc/apache2/sites-enabled/000-default in cloud-early-config SysVM various fixes to previous refactorings * make CORS include a regular glob-matched one * fix NameVirtualHost in CsApp.py as well * even moar cleanups SysVM: Cleanup and removal of old (and dangerous) config files * ports.conf * default & default-ssl sites * SSL config in httpd.conf * deprecated & dead setup_redundant_router in cloud-early-config SysVM cloud-early-config: Intermediate fix for SecStore & CORS * Take setup from vhost.template rather than default(-ssl) * should move into Python CS code as well * Move CORS setup to separate conf * Modify vhost template to Optionally include the cors file * Add NameVirtualHost to vhost template for feature parity with ports.conf * Take setup from vhost.template rather than default(-ssl) VR cloud-early-config: Commonize Apache2 common setup VR cloud-early-config: Fix Apache2 alias cleanup VR: consistent SSL setup, vhost is not an example, but a template VR CsConfig: reintroduce old get_dns() behaviour for redundant non-VPC's VR CsAddress fixes: * cleanup imports, * fix to_str(), * improve & fix service post_config logic * don't arpPing when there's no gateway VR CsApp: Expose config to classes, move vhost confs to proper location, allow for multiple IP's per intf, sanitize servername, don't open port 53 if no DNS is foreseen VR CsConfig: Add is_router(), is_dns(), has_dns(), has_metadata(), use_extdns(), fix get_dns() with use_extdns() VR CsDhcp: allow multiple ranges & finite lease time (fixes CLOUDSTACK-8303) VR CsGuestNetwork obey useextdns VR merge.py ipalias fix & dhcpconfig stub notification Signed-off-by: Will Stevens > infinite lease times for a Dynamic Host Configuration Protocol should be > avoided (like the plague) > -- > > Key: CLOUDSTACK-8303 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8303 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Reporter: Ronald van Zantvoort > > The edithosts script in the SystemVM's currently doles out DHCP leases with > infinite validity. > Considering the D in DHCP is for 'Dynamic', and considering it might be > useful to change the information in the lease every once in a while (such as > resolvers, gateways & searches etc.), it's very bad practice to do this. > Currently, aside from one very exotic RFC, it's impossible to inform VM's of > changing network conditions because they simply won't fetch new leases. > Please consider changing it to at max 1 week or something, or better: a > configurable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8303) infinite lease times for a Dynamic Host Configuration Protocol should be avoided (like the plague)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353222#comment-15353222 ] ASF subversion and git services commented on CLOUDSTACK-8303: - Commit e4ba640a2870f0ed7cd092a1760b2d78e63c6258 in cloudstack's branch refs/heads/master from [~williamstev...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e4ba640 ] Merge pull request #1547 from PCextreme/vrouter-fixes Fixes for VirtualRouters in Basic Networking, especially with mutliple ranges in VLANsDuring the last few modifications on the SystemVM scripts, it turns out quite a lot of stuff broke in our setups. This PR fixes a number of things: * Multiple IP's per VLAN interface are now supported & working again, including DNS, DHCP ranges, password and metadata services * `useextdns` fixed (I had a small merge conflict with an attempt to fix this at 4.7, but these fixes are more comprehensive) * CLOUDSTACK-8303 * Apache configs better in line with best-practices and distro-expected locations * Added a few more helper functions & getters & setters for utility * some minor cleanup & fixes * pr/1547: Remove /etc/apache2/sites-enabled/000-default in cloud-early-config SysVM various fixes to previous refactorings * make CORS include a regular glob-matched one * fix NameVirtualHost in CsApp.py as well * even moar cleanups SysVM: Cleanup and removal of old (and dangerous) config files * ports.conf * default & default-ssl sites * SSL config in httpd.conf * deprecated & dead setup_redundant_router in cloud-early-config SysVM cloud-early-config: Intermediate fix for SecStore & CORS * Take setup from vhost.template rather than default(-ssl) * should move into Python CS code as well * Move CORS setup to separate conf * Modify vhost template to Optionally include the cors file * Add NameVirtualHost to vhost template for feature parity with ports.conf * Take setup from vhost.template rather than default(-ssl) VR cloud-early-config: Commonize Apache2 common setup VR cloud-early-config: Fix Apache2 alias cleanup VR: consistent SSL setup, vhost is not an example, but a template VR CsConfig: reintroduce old get_dns() behaviour for redundant non-VPC's VR CsAddress fixes: * cleanup imports, * fix to_str(), * improve & fix service post_config logic * don't arpPing when there's no gateway VR CsApp: Expose config to classes, move vhost confs to proper location, allow for multiple IP's per intf, sanitize servername, don't open port 53 if no DNS is foreseen VR CsConfig: Add is_router(), is_dns(), has_dns(), has_metadata(), use_extdns(), fix get_dns() with use_extdns() VR CsDhcp: allow multiple ranges & finite lease time (fixes CLOUDSTACK-8303) VR CsGuestNetwork obey useextdns VR merge.py ipalias fix & dhcpconfig stub notification Signed-off-by: Will Stevens > infinite lease times for a Dynamic Host Configuration Protocol should be > avoided (like the plague) > -- > > Key: CLOUDSTACK-8303 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8303 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Reporter: Ronald van Zantvoort > > The edithosts script in the SystemVM's currently doles out DHCP leases with > infinite validity. > Considering the D in DHCP is for 'Dynamic', and considering it might be > useful to change the information in the lease every once in a while (such as > resolvers, gateways & searches etc.), it's very bad practice to do this. > Currently, aside from one very exotic RFC, it's impossible to inform VM's of > changing network conditions because they simply won't fetch new leases. > Please consider changing it to at max 1 week or something, or better: a > configurable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8303) infinite lease times for a Dynamic Host Configuration Protocol should be avoided (like the plague)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738403#comment-14738403 ] Ronald van Zantvoort commented on CLOUDSTACK-8303: -- scripts/network/exdhcp/dnsmasq_edithosts.sh scripts/network/exdhcp/dhcpd_edithosts.py both contain the offending 'infinite' > infinite lease times for a Dynamic Host Configuration Protocol should be > avoided (like the plague) > -- > > Key: CLOUDSTACK-8303 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8303 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Reporter: Ronald van Zantvoort > > The edithosts script in the SystemVM's currently doles out DHCP leases with > infinite validity. > Considering the D in DHCP is for 'Dynamic', and considering it might be > useful to change the information in the lease every once in a while (such as > resolvers, gateways & searches etc.), it's very bad practice to do this. > Currently, aside from one very exotic RFC, it's impossible to inform VM's of > changing network conditions because they simply won't fetch new leases. > Please consider changing it to at max 1 week or something, or better: a > configurable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8303) infinite lease times for a Dynamic Host Configuration Protocol should be avoided (like the plague)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357540#comment-14357540 ] Erik Weber commented on CLOUDSTACK-8303: I agree that it shouldn't be infinite. > infinite lease times for a Dynamic Host Configuration Protocol should be > avoided (like the plague) > -- > > Key: CLOUDSTACK-8303 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8303 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router >Reporter: Ronald van Zantvoort > > The edithosts script in the SystemVM's currently doles out DHCP leases with > infinite validity. > Considering the D in DHCP is for 'Dynamic', and considering it might be > useful to change the information in the lease every once in a while (such as > resolvers, gateways & searches etc.), it's very bad practice to do this. > Currently, aside from one very exotic RFC, it's impossible to inform VM's of > changing network conditions because they simply won't fetch new leases. > Please consider changing it to at max 1 week or something, or better: a > configurable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
