[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457506#comment-16457506 ] ASF GitHub Bot commented on CLOUDSTACK-8415: DaanHoogland commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-385161954 @sureshanaparti sorry for totally missing this. Yes this looks like what I asked for. please rebase as @rhtyd asked so we can test and merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Suresh Kumar Anaparti >Priority: Major > Fix For: Future > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449852#comment-16449852 ] ASF GitHub Bot commented on CLOUDSTACK-8415: rhtyd commented on issue #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind URL: https://github.com/apache/cloudstack/pull/2090#issuecomment-383932004 ping @sureshanaparti can you fix the conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Suresh Kumar Anaparti >Priority: Major > Fix For: Future > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409002#comment-15409002 ] ASF GitHub Bot commented on CLOUDSTACK-8415: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/540 @jburwell Likitha has moved on, unlikely we'll hear from her or see further development activity > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Likitha Shetty > Fix For: Future > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408555#comment-15408555 ] ASF GitHub Bot commented on CLOUDSTACK-8415: Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/540 @likitha is this PR still pertinent? > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Likitha Shetty > Fix For: Future > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266311#comment-15266311 ] ASF GitHub Bot commented on CLOUDSTACK-8415: Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-216185889 tag:vmware-pickup > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Likitha Shetty > Fix For: Future > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679289#comment-14679289 ] ASF GitHub Bot commented on CLOUDSTACK-8415: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-129227064 Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-). > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Likitha Shetty > Fix For: 4.6.0 > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14663149#comment-14663149 ] ASF GitHub Bot commented on CLOUDSTACK-8415: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-129041806 @likitha Any updates? > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Likitha Shetty > Fix For: 4.6.0 > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629484#comment-14629484
]
ASF GitHub Bot commented on CLOUDSTACK-8415:
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34769880
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public DataObject create(DataObject obj, DataStore
dataStore) {
if (snapshotDataStoreVO != null) {
ss.setParentSnapshotId(snapshotDataStoreVO.getSnapshotId());
}
-
ss.setInstallPath(TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" +
snapshot.getVolumeId());
+String snapshotInstallPath =
TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" + snapshot.getVolumeId();
+if
(snapshot.getHypervisorType().equals(HypervisorType.VMware)) {
+snapshotInstallPath =
snapshotInstallPath.concat("/" + UUID.randomUUID().toString());
--- End diff --
Yep... I edited. :)
> [VMware] SSVM shutdown during snapshot operation results in disks to be left
> behind
>
>
> Key: CLOUDSTACK-8415
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Likitha Shetty
>Assignee: Likitha Shetty
> Fix For: 4.6.0
>
>
> Partial disks are residue of a failed snapshot operation caused by SSVM
> reboot/shutdown. The disks do not get cleaned up on secondary storage and
> need to be cleaned up manually to release storage.
> +Steps to reproduce+
> 1. Initiate a volume snapshot operation.
> 2. Destroy SSVM while the operation is in progress.
> 3. Check the snapshot folder in secondary storage - Files including disks are
> present in the folder and are never cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629481#comment-14629481
]
ASF GitHub Bot commented on CLOUDSTACK-8415:
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34769780
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public DataObject create(DataObject obj, DataStore
dataStore) {
if (snapshotDataStoreVO != null) {
ss.setParentSnapshotId(snapshotDataStoreVO.getSnapshotId());
}
-
ss.setInstallPath(TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" +
snapshot.getVolumeId());
+String snapshotInstallPath =
TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" + snapshot.getVolumeId();
+if
(snapshot.getHypervisorType().equals(HypervisorType.VMware)) {
+snapshotInstallPath =
snapshotInstallPath.concat("/" + UUID.randomUUID().toString());
--- End diff --
auto spell typo? contact == concat
> [VMware] SSVM shutdown during snapshot operation results in disks to be left
> behind
>
>
> Key: CLOUDSTACK-8415
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Likitha Shetty
>Assignee: Likitha Shetty
> Fix For: 4.6.0
>
>
> Partial disks are residue of a failed snapshot operation caused by SSVM
> reboot/shutdown. The disks do not get cleaned up on secondary storage and
> need to be cleaned up manually to release storage.
> +Steps to reproduce+
> 1. Initiate a volume snapshot operation.
> 2. Destroy SSVM while the operation is in progress.
> 3. Check the snapshot folder in secondary storage - Files including disks are
> present in the folder and are never cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629461#comment-14629461
]
ASF GitHub Bot commented on CLOUDSTACK-8415:
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767845
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public DataObject create(DataObject obj, DataStore
dataStore) {
if (snapshotDataStoreVO != null) {
ss.setParentSnapshotId(snapshotDataStoreVO.getSnapshotId());
}
-
ss.setInstallPath(TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" +
snapshot.getVolumeId());
+String snapshotInstallPath =
TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" + snapshot.getVolumeId();
+if
(snapshot.getHypervisorType().equals(HypervisorType.VMware)) {
+snapshotInstallPath =
snapshotInstallPath.concat("/" + UUID.randomUUID().toString());
--- End diff --
I would also call contact twice: 1 for the "/"; and the 2nd time for the
UUID.randomUUID().toString().
> [VMware] SSVM shutdown during snapshot operation results in disks to be left
> behind
>
>
> Key: CLOUDSTACK-8415
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Likitha Shetty
>Assignee: Likitha Shetty
> Fix For: 4.6.0
>
>
> Partial disks are residue of a failed snapshot operation caused by SSVM
> reboot/shutdown. The disks do not get cleaned up on secondary storage and
> need to be cleaned up manually to release storage.
> +Steps to reproduce+
> 1. Initiate a volume snapshot operation.
> 2. Destroy SSVM while the operation is in progress.
> 3. Check the snapshot folder in secondary storage - Files including disks are
> present in the folder and are never cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629460#comment-14629460
]
ASF GitHub Bot commented on CLOUDSTACK-8415:
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767796
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public DataObject create(DataObject obj, DataStore
dataStore) {
if (snapshotDataStoreVO != null) {
ss.setParentSnapshotId(snapshotDataStoreVO.getSnapshotId());
}
-
ss.setInstallPath(TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" +
snapshot.getVolumeId());
+String snapshotInstallPath =
TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" + snapshot.getVolumeId();
+if
(snapshot.getHypervisorType().equals(HypervisorType.VMware)) {
--- End diff --
It seems like it should be applied to any hypervisor.
Is that another one we can take in and fix?
> [VMware] SSVM shutdown during snapshot operation results in disks to be left
> behind
>
>
> Key: CLOUDSTACK-8415
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Likitha Shetty
>Assignee: Likitha Shetty
> Fix For: 4.6.0
>
>
> Partial disks are residue of a failed snapshot operation caused by SSVM
> reboot/shutdown. The disks do not get cleaned up on secondary storage and
> need to be cleaned up manually to release storage.
> +Steps to reproduce+
> 1. Initiate a volume snapshot operation.
> 2. Destroy SSVM while the operation is in progress.
> 3. Check the snapshot folder in secondary storage - Files including disks are
> present in the folder and are never cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629453#comment-14629453
]
ASF GitHub Bot commented on CLOUDSTACK-8415:
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767521
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1120,14 +1123,60 @@ public void cleanupStorage(boolean recurring) {
}
// remove snapshots in Error state
-List snapshots =
_snapshotDao.listAllByStatus(Snapshot.State.Error);
+List snapshots =
_snapshotDao.listAllByStatusIncludingRemoved(Snapshot.State.Error);
for (SnapshotVO snapshotVO : snapshots) {
try {
List storeRefs =
_snapshotStoreDao.findBySnapshotId(snapshotVO.getId());
+boolean isVMware =
snapshotVO.getHypervisorType().equals(HypervisorType.VMware);
+boolean removeSnapshot = true;
for (SnapshotDataStoreVO ref : storeRefs) {
-_snapshotStoreDao.expunge(ref.getId());
+// Cleanup corresponding items (if any)
from secondary storage.
+if (isVMware) {
--- End diff --
Good catch!
We would have to get the PR in and test it, without the IF, against Xen and
KVM, at least. What do you think?
> [VMware] SSVM shutdown during snapshot operation results in disks to be left
> behind
>
>
> Key: CLOUDSTACK-8415
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Likitha Shetty
>Assignee: Likitha Shetty
> Fix For: 4.6.0
>
>
> Partial disks are residue of a failed snapshot operation caused by SSVM
> reboot/shutdown. The disks do not get cleaned up on secondary storage and
> need to be cleaned up manually to release storage.
> +Steps to reproduce+
> 1. Initiate a volume snapshot operation.
> 2. Destroy SSVM while the operation is in progress.
> 3. Check the snapshot folder in secondary storage - Files including disks are
> present in the folder and are never cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629447#comment-14629447 ] ASF GitHub Bot commented on CLOUDSTACK-8415: Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-121883348 This seems to me to be a solution for vmware for a more generic problem. in the generic code conditions for hypervisortype == vmware are set while the problem is generic over hypervisor typos. > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Likitha Shetty > Fix For: 4.6.0 > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629443#comment-14629443
]
ASF GitHub Bot commented on CLOUDSTACK-8415:
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767146
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1120,14 +1123,60 @@ public void cleanupStorage(boolean recurring) {
}
// remove snapshots in Error state
-List snapshots =
_snapshotDao.listAllByStatus(Snapshot.State.Error);
+List snapshots =
_snapshotDao.listAllByStatusIncludingRemoved(Snapshot.State.Error);
for (SnapshotVO snapshotVO : snapshots) {
try {
List storeRefs =
_snapshotStoreDao.findBySnapshotId(snapshotVO.getId());
+boolean isVMware =
snapshotVO.getHypervisorType().equals(HypervisorType.VMware);
+boolean removeSnapshot = true;
for (SnapshotDataStoreVO ref : storeRefs) {
-_snapshotStoreDao.expunge(ref.getId());
+// Cleanup corresponding items (if any)
from secondary storage.
+if (isVMware) {
--- End diff --
only for vmware???
> [VMware] SSVM shutdown during snapshot operation results in disks to be left
> behind
>
>
> Key: CLOUDSTACK-8415
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Likitha Shetty
>Assignee: Likitha Shetty
> Fix For: 4.6.0
>
>
> Partial disks are residue of a failed snapshot operation caused by SSVM
> reboot/shutdown. The disks do not get cleaned up on secondary storage and
> need to be cleaned up manually to release storage.
> +Steps to reproduce+
> 1. Initiate a volume snapshot operation.
> 2. Destroy SSVM while the operation is in progress.
> 3. Check the snapshot folder in secondary storage - Files including disks are
> present in the folder and are never cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629440#comment-14629440
]
ASF GitHub Bot commented on CLOUDSTACK-8415:
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767004
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public DataObject create(DataObject obj, DataStore
dataStore) {
if (snapshotDataStoreVO != null) {
ss.setParentSnapshotId(snapshotDataStoreVO.getSnapshotId());
}
-
ss.setInstallPath(TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" +
snapshot.getVolumeId());
+String snapshotInstallPath =
TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" + snapshot.getVolumeId();
+if
(snapshot.getHypervisorType().equals(HypervisorType.VMware)) {
--- End diff --
Is this really only true for vmware? It seems that adding a uuid to the
path is a rather universal action in the ssvm, no?
> [VMware] SSVM shutdown during snapshot operation results in disks to be left
> behind
>
>
> Key: CLOUDSTACK-8415
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Likitha Shetty
>Assignee: Likitha Shetty
> Fix For: 4.6.0
>
>
> Partial disks are residue of a failed snapshot operation caused by SSVM
> reboot/shutdown. The disks do not get cleaned up on secondary storage and
> need to be cleaned up manually to release storage.
> +Steps to reproduce+
> 1. Initiate a volume snapshot operation.
> 2. Destroy SSVM while the operation is in progress.
> 3. Check the snapshot folder in secondary storage - Files including disks are
> present in the folder and are never cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629343#comment-14629343 ] ASF GitHub Bot commented on CLOUDSTACK-8415: Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-121854348 LGTM :+1: > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Likitha Shetty > Fix For: 4.6.0 > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8415) [VMware] SSVM shutdown during snapshot operation results in disks to be left behind
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607603#comment-14607603 ] ASF GitHub Bot commented on CLOUDSTACK-8415: GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/540 CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin… …d partial unusable disks and VM snapshots in secondary storage. Enhance storage garbage collector to delete corresponding partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot. You can merge this pull request into a Git repository by running: $ git pull https://github.com/likitha/cloudstack CLOUDSTACK-8415 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/540.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #540 commit da8f25e33ca41057aac26910fe6b667a41adcaa5 Author: Likitha Shetty Date: 2015-04-07T13:24:40Z CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behind partial unusable disks and VM snapshots in secondary storage. Enhance storage garbage collector to delete corresponding partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot. > [VMware] SSVM shutdown during snapshot operation results in disks to be left > behind > > > Key: CLOUDSTACK-8415 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Likitha Shetty > Fix For: 4.6.0 > > > Partial disks are residue of a failed snapshot operation caused by SSVM > reboot/shutdown. The disks do not get cleaned up on secondary storage and > need to be cleaned up manually to release storage. > +Steps to reproduce+ > 1. Initiate a volume snapshot operation. > 2. Destroy SSVM while the operation is in progress. > 3. Check the snapshot folder in secondary storage - Files including disks are > present in the folder and are never cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
