[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642450#comment-14642450 ] ASF subversion and git services commented on CLOUDSTACK-8483: - Commit fd17e47e152f161d4d5a66b102dc8832c8858607 in cloudstack's branch refs/heads/reporter from Sudhansu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fd17e47 ] BUG-ID: CLOUDSTACK-8483 - Private template not visible in project added new 'projectId' parameter in createTemplate command and based current user, account and projectid decide the owner of the template. Signed-off-by: Pierre-Luc Dion pdion...@apache.org Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641982#comment-14641982 ] ASF GitHub Bot commented on CLOUDSTACK-8483: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/334 Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641978#comment-14641978 ] ASF subversion and git services commented on CLOUDSTACK-8483: - Commit f8ef13c5e6fe833c923dbcda9d0e61381ded3de5 in cloudstack's branch refs/heads/master from Sudhansu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f8ef13c ] BUG-ID: CLOUDSTACK-8483 - Private template not visible in project added new 'projectId' parameter in createTemplate command and based current user, account and projectid decide the owner of the template. Signed-off-by: Pierre-Luc Dion pdion...@apache.org Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641979#comment-14641979 ] ASF subversion and git services commented on CLOUDSTACK-8483: - Commit fd17e47e152f161d4d5a66b102dc8832c8858607 in cloudstack's branch refs/heads/master from Sudhansu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fd17e47 ] BUG-ID: CLOUDSTACK-8483 - Private template not visible in project added new 'projectId' parameter in createTemplate command and based current user, account and projectid decide the owner of the template. Signed-off-by: Pierre-Luc Dion pdion...@apache.org Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636237#comment-14636237 ] ASF GitHub Bot commented on CLOUDSTACK-8483: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-123562895 @sudhansu7 can you please rebase the changes for master? Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631262#comment-14631262 ] ASF GitHub Bot commented on CLOUDSTACK-8483: Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-122262701 @karuturi @kishankavala can you answer @bhaisaab or add your LGTM? Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629196#comment-14629196 ] ASF GitHub Bot commented on CLOUDSTACK-8483: Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/334#discussion_r34755962 --- Diff: api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java --- @@ -124,6 +127,9 @@ description = true if template contains XS/VMWare tools inorder to support dynamic scaling of VM cpu/memory) protected Boolean isDynamicallyScalable; +@Parameter(name = ApiConstants.PROJECT_ID, type = CommandType.UUID, entityType = ProjectResponse.class, description = create template for the project) +private Long projectId; --- End diff -- Ping. Since, this is an append only API change. IMO we can merge on 4.5 as well. Updates, is this good to go? Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612884#comment-14612884 ] ASF GitHub Bot commented on CLOUDSTACK-8483: Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-118248786 There is an API change. Should this go into master only? Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611825#comment-14611825
]
ASF GitHub Bot commented on CLOUDSTACK-8483:
Github user sudhansu7 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/334#discussion_r33769718
--- Diff:
api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
---
@@ -215,33 +221,39 @@ public long getEntityOwnerId() {
if (volumeId != null) {
Volume volume = _entityMgr.findById(Volume.class, volumeId);
if (volume != null) {
-accountId = volume.getAccountId();
--- End diff --
I will make this change
Private template not visible in project
---
Key: CLOUDSTACK-8483
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483
Project: CloudStack
Issue Type: Bug
Security Level: Public(Anyone can view this level - this is the
default.)
Components: Projects
Affects Versions: 4.5.0
Reporter: Sudhansu Sahu
Assignee: Sudhansu Sahu
Private template get created outside the project context. These templates are
not visible in project view.
STEPS TO REPRODUCE:
1 Select a project view, and go into volumes view
2 Create a template from a Volume and wait until the process is complete
3 The template cannot be found in the project
4 Navigate back to the Default view The template can be found in the
templates screen in this view
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611824#comment-14611824 ] ASF GitHub Bot commented on CLOUDSTACK-8483: Github user sudhansu7 commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-118006807 @karuturi When a user switches to project view the ownership changes to project account. So any resource created inside project view should be mapped to project account. Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611707#comment-14611707 ] ASF GitHub Bot commented on CLOUDSTACK-8483: Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-117978565 @sudhansu7 can you reply to @karuturi ? thanks. Otherwise this will stay stuck waiting for your answer. Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572109#comment-14572109
]
ASF GitHub Bot commented on CLOUDSTACK-8483:
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/334#discussion_r31692655
--- Diff:
api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
---
@@ -215,33 +221,39 @@ public long getEntityOwnerId() {
if (volumeId != null) {
Volume volume = _entityMgr.findById(Volume.class, volumeId);
if (volume != null) {
-accountId = volume.getAccountId();
--- End diff --
accountId is unused. Can we initialize it with
CallContext.current().getCallingAccount() and use it (which saves some function
calls)?
Private template not visible in project
---
Key: CLOUDSTACK-8483
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483
Project: CloudStack
Issue Type: Bug
Security Level: Public(Anyone can view this level - this is the
default.)
Components: Projects
Affects Versions: 4.5.0
Reporter: Sudhansu Sahu
Assignee: Sudhansu Sahu
Private template get created outside the project context. These templates are
not visible in project view.
STEPS TO REPRODUCE:
1 Select a project view, and go into volumes view
2 Create a template from a Volume and wait until the process is complete
3 The template cannot be found in the project
4 Navigate back to the Default view The template can be found in the
templates screen in this view
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572106#comment-14572106 ] ASF GitHub Bot commented on CLOUDSTACK-8483: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-108717787 Do we really need projectId here? The api doc says A template created from this command is automatically designated as a private template visible to the account that created it. Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8483) Private template not visible in project
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565878#comment-14565878 ] ASF GitHub Bot commented on CLOUDSTACK-8483: GitHub user sudhansu7 opened a pull request: https://github.com/apache/cloudstack/pull/334 BUG-ID: CLOUDSTACK-8483 - Private template not visible in project added new 'projectId' parameter in createTemplate command and based current user, account and projectid decide the owner of the template. Problem: Template created using createTemplte API within project context is not visible in project view. Root Cause: CeateTemplate API does not have projectId parameter and hence it creates the template against the caller's account id. Solution: A new parameter 'projectId' has been added to createTemplate command and the ownership is decided based on current user account and projectid. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sudhansu7/cloudstack CLOUDSTACK-8483 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/334.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #334 commit a5c256d752b19fe3eb58b448486f95bd1d2fc6bb Author: Sudhansu sudhansu.s...@citrix.com Date: 2015-03-13T12:18:47Z BUG-ID: CLOUDSTACK-8483 - Private template not visible in project added new 'projectId' parameter in createTemplate command and based current user, account and projectid decide the owner of the template. Private template not visible in project --- Key: CLOUDSTACK-8483 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8483 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Projects Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Private template get created outside the project context. These templates are not visible in project view. STEPS TO REPRODUCE: 1 Select a project view, and go into volumes view 2 Create a template from a Volume and wait until the process is complete 3 The template cannot be found in the project 4 Navigate back to the Default view The template can be found in the templates screen in this view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
