[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614601#comment-14614601 ] ASF GitHub Bot commented on CLOUDSTACK-8484: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/335 Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614600#comment-14614600 ] ASF subversion and git services commented on CLOUDSTACK-8484: - Commit 510fc11319fc90a57fd552597891842a58aa256e in cloudstack's branch refs/heads/master from Sudhansu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=510fc11 ] BUG-ID: CLOUDSTACK-8484 - Hosts without tag are not listed while listing the hosts for migration for instance with tag Added marvin test for this issue. Steps 1. Create a Compute service offering with the tag. 2. Create a Guest VM with the compute service offering created above. 3. find hosts to migrate the vm crated above Validations 1. Ensure that the offering is created with the tag.The listServiceOffering API should list show tag 2. findHostsForMigration cmd should list both suitable and not-suitable hosts Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614599#comment-14614599 ] ASF subversion and git services commented on CLOUDSTACK-8484: - Commit b593657503c4743c6e74c76c083df744ed0bb2ae in cloudstack's branch refs/heads/master from Sudhansu [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b593657 ] BUG-ID: CLOUDSTACK-8484 - Hosts without tag are not listed while listing the hosts for migration for instance with tag While preparing the suitable hosts we are accidentally removing the incompatible (host does not have host tag) hosts from otherhost list( incorrect use of List.retainAll). Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614510#comment-14614510 ] ASF GitHub Bot commented on CLOUDSTACK-8484: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-118706569 Awesome @sudhansu7. Congratulations on the first marvin test :+1: :) I will push this to master in sometime. Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613156#comment-14613156
]
ASF GitHub Bot commented on CLOUDSTACK-8484:
Github user sudhansu7 commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-118331438
@remibergsma @karuturi
I have added marvin test for this issue.
Test result from local setup:
Sudhansus-MAC:cloudstack sudhansu$ nosetests --with-marvin
--marvin-config=setup/dev/advanced.cfg
./test/integration/smoke/find_hosts_for_migration.py
Marvin Init Started
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
Log Folder Path: /tmp//MarvinLogs//Jul_03_2015_17_38_01_JVMT7H. All
logs will be available here
=== Marvin Init Logging Successful===
Marvin Init Successful
===final results are now copied to:
/tmp//MarvinLogs/find_hosts_for_migration_FKMWAR===
Sudhansus-MAC:cloudstack sudhansu$ cat
/tmp//MarvinLogs/find_hosts_for_migration_FKMWAR/results.txt
Test find suitable and not-suitable list of hosts for migration ... ===
TestName: test_01_find_hosts_for_migration | Status : SUCCESS ===
ok
--
Ran 1 test in 27.003s
OK
Sudhansus-MAC:cloudstack sudhansu$ cat
/tmp//MarvinLogs/find_hosts_for_migration_FKMWAR/failed_plus_exceptions.txt
Sudhansus-MAC:cloudstack sudhansu$ cat
/tmp//MarvinLogs/find_hosts_for_migration_FKMWAR/runinfo.txt | grep -i
'Suitable Hosts'
2015-07-03 17:38:18,171 - DEBUG - Suitable Hosts: set([])
2015-07-03 17:38:18,171 - DEBUG - Not suitable Hosts:
set([{cpuwithoverprovisioning : u'32000.0', version : u'4.5.2-SNAPSHOT',
memorytotal : 8589934592, jobstatus : 0, zoneid :
u'7a83176c-4ae7-49cc-88ff-a794716e74f9', cpunumber : 4, managementserverid :
4278190080, cpuallocated : u'0%', memoryused : 0, id :
u'b1b25f17-18f7-4b4d-a8e1-a353ebf33660', cpuused : u'0%', suitableformigration
: False, clusterid : u'c138587b-c149-4819-9d30-d4fa9d6d5da4', capabilities :
u'hvm', state : u'Up', memoryallocated : 1879048192, networkkbswrite : 16384,
cpuspeed : 8000, type : u'Routing', events : u'Ping; StartAgentRebalance;
ShutdownRequested; ManagementServerDown; HostDown; AgentDisconnected;
PingTimeout; Remove; AgentConnected', zonename : u'Sandbox-simulator', podid :
u'b0b72cfb-db0a-4e9c-a9da-84854d8c4a1f', clustertype : u'CloudManaged', hahost
: False, lastpinged : u'1970-01-17T11:01:01+0530', ipaddress : u'172.16.15.21',
disconnected : u'2015-07-03T14:32:16+0530', name :
u'SimulatedAgent.3481871b-7626-450a-b2c1-ab4e6a2e5965', networkkbsread : 32768,
created : u'2015-07-03T13:39:27+0530', clustername : u'C0', hypervisor :
u'Simulator', islocalstorageactive : False, resourcestate : u'Enabled',
requiresStorageMotion : False, podname : u'POD0'}])
Hosts without tag are not listed while listing the hosts for migration for
instance with tag
Key: CLOUDSTACK-8484
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484
Project: CloudStack
Issue Type: Bug
Security Level: Public(Anyone can view this level - this is the
default.)
Components: Management Server
Affects Versions: 4.5.0
Reporter: Sudhansu Sahu
Assignee: Sudhansu Sahu
Hosts without tag are not listed while listing the hosts for migration for
instance with tag.
Ideally system should list all available hosts with not suitable suffix.
Steps to reproduce:
1) Create a compute offering with a host tag eg: 'tag-1'
2) Tag a host in your cluster as 'tag-1'
3) Deploy an instance using this offering.
4) Instance will get deployed to the tagged host
5) Try listing the hosts for migration,it would return no host is available
for migration.
6) Tag other hosts with 'tag-1' and they would start appearing in the list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611629#comment-14611629 ] ASF GitHub Bot commented on CLOUDSTACK-8484: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-117951281 Code looks good, although I didn't test it yet. Before I do, I'd like to understand why do you want to push this to 4.5 and not to master? Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611831#comment-14611831 ] ASF GitHub Bot commented on CLOUDSTACK-8484: Github user sudhansu7 commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-118007318 @remibergsma @runseb This issue exists in 4.5 , hence fixed it in 4.5. this can me merged to master as well. Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611705#comment-14611705 ] ASF GitHub Bot commented on CLOUDSTACK-8484: Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-117978306 @sudhansu7 there is a question here from @remibergsma , can you answer it so it can get merged. Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611899#comment-14611899 ] ASF GitHub Bot commented on CLOUDSTACK-8484: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-118020313 @sudhansu7 Let's first merge this to master, then it can go to 4.5. I just tried to merge your PR on master and that seems to work just fine so that is nice. There were two other questions: about unit tests and one about the commit message. If you could respond to that please? In the mean time, I'll go ahead and give it a test run. Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14583316#comment-14583316 ] ASF GitHub Bot commented on CLOUDSTACK-8484: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-111468788 LGTM, I guess unit tests would be cool. Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572113#comment-14572113 ] ASF GitHub Bot commented on CLOUDSTACK-8484: Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/335#issuecomment-108718604 Can you add some unit/marvin tests? Also, fix the commit msg header to 72 :) http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Assignee: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8484) Hosts without tag are not listed while listing the hosts for migration for instance with tag
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565893#comment-14565893 ] ASF GitHub Bot commented on CLOUDSTACK-8484: GitHub user sudhansu7 opened a pull request: https://github.com/apache/cloudstack/pull/335 BUG-ID: CLOUDSTACK-8484 - Hosts without tag are not listed while list… …ing the hosts for migration for instance with tag While preparing the suitable hosts we are accidentally removing the incompatible (host does not have host tag) hosts from other host list(incorrect use of List.retainAll). You can merge this pull request into a Git repository by running: $ git pull https://github.com/sudhansu7/cloudstack CLOUDSTACK-8484 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/335.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #335 commit fac22e3ffc3026362f77d0fc9ef36a2e7b37483d Author: Sudhansu sudhansu.s...@citrix.com Date: 2015-03-12T12:28:31Z BUG-ID: CLOUDSTACK-8484 - Hosts without tag are not listed while listing the hosts for migration for instance with tag While preparing the suitable hosts we are accidentally removing the incompatible (host does not have host tag) hosts from otherhost list(incorrect use of List.retainAll). Hosts without tag are not listed while listing the hosts for migration for instance with tag Key: CLOUDSTACK-8484 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8484 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.5.0 Reporter: Sudhansu Sahu Hosts without tag are not listed while listing the hosts for migration for instance with tag. Ideally system should list all available hosts with not suitable suffix. Steps to reproduce: 1) Create a compute offering with a host tag eg: 'tag-1' 2) Tag a host in your cluster as 'tag-1' 3) Deploy an instance using this offering. 4) Instance will get deployed to the tagged host 5) Try listing the hosts for migration,it would return no host is available for migration. 6) Tag other hosts with 'tag-1' and they would start appearing in the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
