[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629199#comment-14629199 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/532 Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629198#comment-14629198 ] ASF subversion and git services commented on CLOUDSTACK-8582: - Commit d73f64a518f1f6b3721570afb3a7e0be99b120b5 in cloudstack's branch refs/heads/master from [~gauravaradhye] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d73f64a ] CLOUDSTACK-8582: Skipping unsuitable test cases for simulator Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com This closes #532 Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629193#comment-14629193 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-121829768 LGTM Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624353#comment-14624353 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-120846548 @runseb Sorry for delayed response, I was away for two weeks. As said by Sanjeev, the tests were wrongly tagged. required_hardware = true implies test can't be run on simulator and should not be, as it requires resources other than just management server. I have only corrected the tags in this test and did not make any other changes such fixing pep8 issues, as it would confuse the reviewer. I hope this answers your questions, please let me know in case anything unclear. Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611701#comment-14611701 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-117977659 @gauravaradhye if you answer my questions I can give a LGTM :) Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605284#comment-14605284 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-116523709 Need a second LGTM, anyone? Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605302#comment-14605302 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-116534604 these tests used to be required_hardware=true, and now it's false. So when are we running these tests ? Are they included in Travis runs, in which case we are loosing tests with this ? Also does this pass pep8, flake8 etc ? Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602560#comment-14602560 ] ASF GitHub Bot commented on CLOUDSTACK-8582: GitHub user gauravaradhye opened a pull request: https://github.com/apache/cloudstack/pull/532 CLOUDSTACK-8582: Skipping unsuitable test cases for simulator Modifying tags for test cases which shouldn't be run on simulator (Test cases requiring download of templates/ISOs and creation of templates from snapshots) You can merge this pull request into a Git repository by running: $ git pull https://github.com/gauravaradhye/cloudstack 8582 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/532.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #532 commit d39ddb18ff2f780e95db4978400d964329364b0c Author: Gaurav Aradhye gaurav.arad...@clogeny.com Date: 2015-06-26T08:09:07Z CLOUDSTACK-8582: Skipping unsuitable test cases for simulator Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602579#comment-14602579 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/532#discussion_r8559 --- Diff: test/integration/component/test_ps_domain_limits.py --- @@ -194,7 +194,7 @@ def setupAccounts(self): return [FAIL, e, None] return [PASS, None, users] -@attr(tags=[advanced, selfservice]) +@attr(tags=[advanced, selfservice], required_hardware=false) --- End diff -- Yes it can run, it only concerns primary storage counts. Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602576#comment-14602576 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/532#discussion_r8448 --- Diff: test/integration/component/test_ps_domain_limits.py --- @@ -194,7 +194,7 @@ def setupAccounts(self): return [FAIL, e, None] return [PASS, None, users] -@attr(tags=[advanced, selfservice]) +@attr(tags=[advanced, selfservice], required_hardware=false) --- End diff -- Is this test needs to be run on simulator? Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602619#comment-14602619 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-115609404 LGTM Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598986#comment-14598986 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/519#issuecomment-114757147 LGTM Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598998#comment-14598998 ] ASF subversion and git services commented on CLOUDSTACK-8582: - Commit 230cf2eefa70bc686fe01ae2f7fd4a0253ae35c2 in cloudstack's branch refs/heads/master from [~gauravaradhye] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=230cf2e ] CLOUDSTACK-8582: Tagging test cases which should not be run on simulator accordingly Signed-off-by: Gaurav Aradhye gaurav.arad...@clogeny.com This closes #519 Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598999#comment-14598999 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/519 Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598981#comment-14598981 ] ASF GitHub Bot commented on CLOUDSTACK-8582: GitHub user gauravaradhye opened a pull request: https://github.com/apache/cloudstack/pull/519 CLOUDSTACK-8582: Tagging test cases which should not be run on simulator accordingly Template and ISO download test cases should not be run on simulator as they require SSVM and secondary storage to be present. On SImulator we are only testing management server code. Added the tags accordingly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gauravaradhye/cloudstack 8582 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/519.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #519 commit 18ecccb36b908c37f9b54c84fc20df42cc959a36 Author: Gaurav Aradhye gaurav.arad...@clogeny.com Date: 2015-06-24T07:04:13Z CLOUDSTACK-8582: Tagging test cases which should not be run on simulator accordingly Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599238#comment-14599238 ] ASF GitHub Bot commented on CLOUDSTACK-8582: Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/521#issuecomment-114822650 LGTM Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8582) Fix test cases failing on simulator
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599235#comment-14599235 ] ASF GitHub Bot commented on CLOUDSTACK-8582: GitHub user gauravaradhye opened a pull request: https://github.com/apache/cloudstack/pull/521 CLOUDSTACK-8582: Modifying tag for test cases which should not be run on simulator The test case tries to ssh to router through host and take down the services. This is not a right candidate to run on simulator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gauravaradhye/cloudstack 8582 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/521.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #521 commit 81716b718267515153bc52aae9797497bfca6c08 Author: Gaurav Aradhye gaurav.arad...@clogeny.com Date: 2015-06-24T10:37:22Z CLOUDSTACK-8582: Modifying tag for test cases which should not be run on simulator Fix test cases failing on simulator --- Key: CLOUDSTACK-8582 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8582 Project: CloudStack Issue Type: Test Security Level: Public(Anyone can view this level - this is the default.) Components: Automation Affects Versions: 4.6.0 Reporter: Gaurav Aradhye Assignee: Gaurav Aradhye Labels: automation Fix For: 4.6.0 Fix the test cases failing on simulator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
