[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057462#comment-15057462 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user kishankavala closed the pull request at: https://github.com/apache/cloudstack/pull/577 > KVM: Config Drive and getVmIp support > - > > Key: CLOUDSTACK-8605 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 > Project: CloudStack > Issue Type: Sub-task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM >Affects Versions: 4.6.0 >Reporter: Kishan Kavala >Assignee: Kishan Kavala > Fix For: 4.6.1 > > > Add support for > - creating config drive > - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1490#comment-1490 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-142064215 @kishankavala There are 5 merge commits now... please remove them. > KVM: Config Drive and getVmIp support > - > > Key: CLOUDSTACK-8605 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 > Project: CloudStack > Issue Type: Sub-task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM >Affects Versions: 4.6.0 >Reporter: Kishan Kavala >Assignee: Kishan Kavala > Fix For: 4.6.0 > > > Add support for > - creating config drive > - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739073#comment-14739073 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-139304798 @kishankavala Please remove the 4 merge commits, thanks. > KVM: Config Drive and getVmIp support > - > > Key: CLOUDSTACK-8605 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 > Project: CloudStack > Issue Type: Sub-task > Security Level: Public(Anyone can view this level - this is the > default.) > Components: KVM >Affects Versions: 4.6.0 >Reporter: Kishan Kavala >Assignee: Kishan Kavala > Fix For: 4.6.0 > > > Add support for > - creating config drive > - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712824#comment-14712824 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-134923025 LGTM. KVM: Config Drive and getVmIp support - Key: CLOUDSTACK-8605 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 Project: CloudStack Issue Type: Sub-task Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: 4.6.0 Reporter: Kishan Kavala Assignee: Kishan Kavala Fix For: 4.6.0 Add support for - creating config drive - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712826#comment-14712826 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-134923368 maybe rebase and fix any issues, to get Travis green before merging this once @wido can review this. KVM: Config Drive and getVmIp support - Key: CLOUDSTACK-8605 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 Project: CloudStack Issue Type: Sub-task Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: 4.6.0 Reporter: Kishan Kavala Assignee: Kishan Kavala Fix For: 4.6.0 Add support for - creating config drive - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703236#comment-14703236 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132647888 @kishankavala Thanks for the update! When you're ready, also be sure to ping @wido so he can have another look. KVM: Config Drive and getVmIp support - Key: CLOUDSTACK-8605 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 Project: CloudStack Issue Type: Sub-task Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: 4.6.0 Reporter: Kishan Kavala Assignee: Kishan Kavala Fix For: 4.6.0 Add support for - creating config drive - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700749#comment-14700749 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132073238 @remibergsma I've update the PR. There is still one issue open regarding the usage of /tmp KVM: Config Drive and getVmIp support - Key: CLOUDSTACK-8605 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 Project: CloudStack Issue Type: Sub-task Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: 4.6.0 Reporter: Kishan Kavala Assignee: Kishan Kavala Fix For: 4.6.0 Add support for - creating config drive - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700747#comment-14700747 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132073136 Updated code to use local.storage.path config instead of hard-coded /var/lib/libvirt/images/. Local Storage pool is also created using same config. Removed /usr/bin path for mkisofs. Other issue was regarding using /tmp for temporary directories. Should I change this also to use local storage path? KVM: Config Drive and getVmIp support - Key: CLOUDSTACK-8605 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 Project: CloudStack Issue Type: Sub-task Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: 4.6.0 Reporter: Kishan Kavala Assignee: Kishan Kavala Fix For: 4.6.0 Add support for - creating config drive - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697555#comment-14697555 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-131209754 @kishankavala Any update on this? KVM: Config Drive and getVmIp support - Key: CLOUDSTACK-8605 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 Project: CloudStack Issue Type: Sub-task Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: 4.6.0 Reporter: Kishan Kavala Assignee: Kishan Kavala Fix For: 4.6.0 Add support for - creating config drive - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631031#comment-14631031 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-122219752 @wido @bhaisaab Made the suggested changes KVM: Config Drive and getVmIp support - Key: CLOUDSTACK-8605 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 Project: CloudStack Issue Type: Sub-task Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: 4.6.0 Reporter: Kishan Kavala Assignee: Kishan Kavala Fix For: 4.6.0 Add support for - creating config drive - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631194#comment-14631194 ] ASF GitHub Bot commented on CLOUDSTACK-8605: Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-122247318 Code-wise I'm not to happy. There are all kinds of assumptions about paths. mkisofs for example always being there in /usr/bin. Using /tmp for temporary directories, who says that /tmp is big enough on every system? Always using /var/lib/libvirt to place the ISO? Why not fetch the local storage pool and figure out what the path is. It's not guaranteerd that it will be /var/lib/libvirt/images on all systems. Imho there are to many assumptions in the code which makes it fragile. KVM: Config Drive and getVmIp support - Key: CLOUDSTACK-8605 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 Project: CloudStack Issue Type: Sub-task Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: 4.6.0 Reporter: Kishan Kavala Assignee: Kishan Kavala Fix For: 4.6.0 Add support for - creating config drive - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629180#comment-14629180
]
ASF GitHub Bot commented on CLOUDSTACK-8605:
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/577#discussion_r34755687
--- Diff: packaging/centos63/cloud.spec ---
@@ -129,6 +129,8 @@ Requires: perl
Requires: libvirt-python
Requires: qemu-img
Requires: qemu-kvm
+Requires: genisoimage
--- End diff --
you'll need to add this to other cloud.spec files in
packages/{centos7,fedora20,fedora21}
KVM: Config Drive and getVmIp support
-
Key: CLOUDSTACK-8605
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605
Project: CloudStack
Issue Type: Sub-task
Security Level: Public(Anyone can view this level - this is the
default.)
Components: KVM
Affects Versions: 4.6.0
Reporter: Kishan Kavala
Assignee: Kishan Kavala
Fix For: 4.6.0
Add support for
- creating config drive
- Fetch IP from guest Vm which is assigned by external DHCP
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628198#comment-14628198
]
ASF GitHub Bot commented on CLOUDSTACK-8605:
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/577#issuecomment-121645521
/var/lib/libvirt/images is used for local storage also.
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource#configure
_localStoragePath = (String)params.get(local.storage.path);
if (_localStoragePath == null) {
_localStoragePath = /var/lib/libvirt/images/;
}
I'll update the patch to use _localStoragePath instead of hard-coded
/var/lib/libvirt/images
KVM: Config Drive and getVmIp support
-
Key: CLOUDSTACK-8605
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605
Project: CloudStack
Issue Type: Sub-task
Security Level: Public(Anyone can view this level - this is the
default.)
Components: KVM
Affects Versions: 4.6.0
Reporter: Kishan Kavala
Assignee: Kishan Kavala
Fix For: 4.6.0
Add support for
- creating config drive
- Fetch IP from guest Vm which is assigned by external DHCP
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8605) KVM: Config Drive and getVmIp support
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622032#comment-14622032 ] ASF GitHub Bot commented on CLOUDSTACK-8605: GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/577 CLOUDSTACK-8605: KVM: Config Drive and getVmIp support - CLOUDSTACK-8324 added support for External DHCP/DNS support along with ConfigDrive for XenServer - FS link: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=53740797 - This PR adds KVM support for config drive and getVmIpAddress assigned by external DHCP - genisoimage package dependency is added for creating config drive ISO - libguestfs is used to get IPAddress from guest VM. Linux: From dhcp leases file. Windows: From registry You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishankavala/cloudstack master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/577.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #577 commit faab39fdd52026ba7c03f8143331d1004338f5ff Author: Kishan Kavala kishan.kav...@citrix.com Date: 2015-06-26T09:48:01Z kvm config drive commit 220e714b5194a33471fc5728c1a6dc69ca0c98e9 Author: Kishan Kavala kis...@apache.org Date: 2015-07-01T12:40:02Z Unit test for GetVmIpAddressCommand commit b2e8bfdff5cc8013a9d50132a941f7849a2949b2 Author: Kishan Kavala kis...@apache.org Date: 2015-07-01T14:51:01Z Test IP not in CIDR commit 3fc60e31d9bcf68a4901dbc059e02c2868943035 Author: Kishan Kavala kis...@apache.org Date: 2015-07-10T08:24:30Z Merge remote-tracking branch 'upstream/master' Conflicts: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java commit e1d1974a06b334bc1be603823f5f44b51bdb3ab2 Author: Kishan Kavala kis...@apache.org Date: 2015-07-10T08:26:26Z Merge remote-tracking branch 'upstream/master' Conflicts: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java commit a3fe3ae233a23f8ac7dcc7485adac9089a7810a8 Author: Kishan Kavala kis...@apache.org Date: 2015-07-10T08:58:52Z Fix Libvirt getVmIP unit test KVM: Config Drive and getVmIp support - Key: CLOUDSTACK-8605 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8605 Project: CloudStack Issue Type: Sub-task Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: 4.6.0 Reporter: Kishan Kavala Assignee: Kishan Kavala Fix For: 4.6.0 Add support for - creating config drive - Fetch IP from guest Vm which is assigned by external DHCP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
