[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-08-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712845#comment-14712845
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8610:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/554


 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Suresh Kumar Anaparti
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-08-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712846#comment-14712846
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8610:


Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/554#issuecomment-134925991
  
LGTM, merging. Someone needs to add the unit test, later. I'm trying to 
build my skills around vmware related codebase.


 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Suresh Kumar Anaparti
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-08-26 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712844#comment-14712844
 ] 

ASF subversion and git services commented on CLOUDSTACK-8610:
-

Commit cb50d1d82714f8178b6aefb32826719a97214b11 in cloudstack's branch 
refs/heads/master from [~likithas]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cb50d1d ]

CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 instance. 
During disk attach, while trying to obtain the controller key for SCSI 
controller, look for device with the generic SCSI controller type i.e. 
VirtualSCSIController.

Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com

This closes #554


 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Suresh Kumar Anaparti
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-08-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679284#comment-14679284
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8610:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/554#issuecomment-129227018
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Likitha Shetty
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-07-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642526#comment-14642526
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8610:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/554#issuecomment-125155019
  
+1 for @DaanHoogland's comments: please add unit tests to cover the changes.


 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Likitha Shetty
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-07-25 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641745#comment-14641745
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8610:


Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/554#issuecomment-124869104
  
please add (unit) tests


 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Likitha Shetty
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-07-24 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640271#comment-14640271
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8610:


Github user sureshanaparti commented on the pull request:

https://github.com/apache/cloudstack/pull/554#issuecomment-124468346
  
Looks good to me.


 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Likitha Shetty
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-07-24 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640305#comment-14640305
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8610:


Github user sateesh-chodapuneedi commented on the pull request:

https://github.com/apache/cloudstack/pull/554#issuecomment-124474599
  
Looks like all checks are good and there are 2 LGTM too.
Should we merge this branch?


 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Likitha Shetty
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-07-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630889#comment-14630889
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8610:


Github user sateesh-chodapuneedi commented on the pull request:

https://github.com/apache/cloudstack/pull/554#issuecomment-122200420
  
LGTM.
Device id 7 on virtual SCSI (can be of any sub type : LsiLogic, LsiSAS, 
BusLogic, Paravirtual) controller is reserved for controller itself, rest all 
virtual nodes could be used for virtual disks.


 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Likitha Shetty
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CLOUDSTACK-8610) [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance

2015-07-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611767#comment-14611767
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8610:


GitHub user likitha opened a pull request:

https://github.com/apache/cloudstack/pull/554

CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 …

…instance.

During disk attach, while trying to obtain the controller key for SCSI 
controller, look for device with the generic SCSI controller type i.e. 
VirtualSCSIController.

While trying to obtain the SCSI id to attach a disk to, CS should ignore 
the reserved SCSI id 7. But this is not being honored in case of VMs with SCSI 
controller of type 'VirtualLsiLogicSASController'. And so in case of Windows 
2012 R2 VMs, CS chooses to attach the 7th disk on the reserved SCSI id and this 
fails on vCenter.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/likitha/cloudstack CLOUDSTACK-8610

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #554


commit cbfcf7cccf75c54decdcfa0c1185c42cb69d0a7a
Author: Likitha Shetty likitha.she...@citrix.com
Date:   2015-06-01T08:53:56Z

CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 
instance.
During disk attach, while trying to obtain the controller key for SCSI 
controller, look for device with the generic SCSI controller type i.e. 
VirtualSCSIController.




 [VMWARE] Unable to attach 7th Disk to a Windows server 2012R2 instance
 --

 Key: CLOUDSTACK-8610
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8610
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
Reporter: Likitha Shetty
Assignee: Likitha Shetty
 Fix For: 4.6.0


 +Steps to reproduce+
 1. Set global config vmware.root.disk.controller to 'osdefault'.
 2. Deploy a VM and attach 6 disks to the VM.
 3. Try to attach a 7th disk to the VM.
 Step 3 will fail with the below error
 {noformat}
 2015-06-22 11:03:22,673 ERROR [c.c.s.r.VmwareStorageProcessor] 
 (DirectAgent-636:ctx-8e72c2d9 s1p-z1-esxic-001.es.local, job-9286/job-9287, 
 cmd: AttachCommand) (logid:6372e940) Failed to attach volume: Failed to add 
 disk scsi0:7. 
 java.lang.RuntimeException: Failed to add disk scsi0:7. 
 at 
 com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:336)
  
 at 
 com.cloud.hypervisor.vmware.mo.VirtualMachineMO.attachDisk(VirtualMachineMO.java:1206)
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)