[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736740#comment-14736740
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/788
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:40 errors:0 dropped:0 overruns:0 frame:0
> TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:4308 (4.2 KiB) TX bytes:294 (294.0 B)
> loLink encap:Local Loopback
> inet addr:127.0.0.1 Mask:255.0.0.0
> UP LOOPBACK RUNNING MTU:16436 Metric:1
>
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736736#comment-14736736
]
ASF subversion and git services commented on CLOUDSTACK-8814:
-
Commit 5e9e9b84fb1a4ca029c32e5b1c305124bfa4d4af in cloudstack's branch
refs/heads/master from [~wilder.rodrigues]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5e9e9b8 ]
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers nics
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:40 errors:0 dropped:0 overruns:0 frame:0
> TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
>
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736737#comment-14736737
]
ASF subversion and git services commented on CLOUDSTACK-8814:
-
Commit 2d90f18b82a0c52fdfc815e0f8efb565f96788e3 in cloudstack's branch
refs/heads/master from [~wilder.rodrigues]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2d90f18 ]
Merge pull request #788 from ekholabs/fix/iso_net-CLOUDSTACK-8814
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers
nicsHi there,
I refactored the configureDefaultNics() method in order to split the
implementations for Routers and VPC Routers.
The following tests were executed:
* test_vm_life_cycle
* test_routers
* test_vpc_router_nics
* test_vpc_routers
* test_vpc_offerings
@remibergsma @bhaisaab @koushik-das @miguelaferreira @DaanHoogland @karuturi ,
could you please have a look/test this PR?
Thanks in advance.
Cheers,
Wilder
* pr/788:
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers
nics
Signed-off-by: wilderrodrigues
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736739#comment-14736739
]
ASF subversion and git services commented on CLOUDSTACK-8814:
-
Commit 2d90f18b82a0c52fdfc815e0f8efb565f96788e3 in cloudstack's branch
refs/heads/master from [~wilder.rodrigues]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2d90f18 ]
Merge pull request #788 from ekholabs/fix/iso_net-CLOUDSTACK-8814
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers
nicsHi there,
I refactored the configureDefaultNics() method in order to split the
implementations for Routers and VPC Routers.
The following tests were executed:
* test_vm_life_cycle
* test_routers
* test_vpc_router_nics
* test_vpc_routers
* test_vpc_offerings
@remibergsma @bhaisaab @koushik-das @miguelaferreira @DaanHoogland @karuturi ,
could you please have a look/test this PR?
Thanks in advance.
Cheers,
Wilder
* pr/788:
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers
nics
Signed-off-by: wilderrodrigues
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736738#comment-14736738
]
ASF subversion and git services commented on CLOUDSTACK-8814:
-
Commit 2d90f18b82a0c52fdfc815e0f8efb565f96788e3 in cloudstack's branch
refs/heads/master from [~wilder.rodrigues]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2d90f18 ]
Merge pull request #788 from ekholabs/fix/iso_net-CLOUDSTACK-8814
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers
nicsHi there,
I refactored the configureDefaultNics() method in order to split the
implementations for Routers and VPC Routers.
The following tests were executed:
* test_vm_life_cycle
* test_routers
* test_vpc_router_nics
* test_vpc_routers
* test_vpc_offerings
@remibergsma @bhaisaab @koushik-das @miguelaferreira @DaanHoogland @karuturi ,
could you please have a look/test this PR?
Thanks in advance.
Cheers,
Wilder
* pr/788:
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers
nics
Signed-off-by: wilderrodrigues
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736735#comment-14736735
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138889015
Will proceed with the merge.
Thanks, guys!
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:40 errors:0 dropped:0 overruns:0 frame:0
> TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:4308 (4.2 KiB) TX bytes:294 (294.0 B)
> loLink encap:Local Loopback
> inet ad
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736733#comment-14736733
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/788#discussion_r39034047
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -610,20 +608,22 @@ protected HypervisorType
getClusterToStartDomainRouterForOvm(final long podId) {
throw new CloudRuntimeException(errMsg);
}
-@Override
-public LinkedHashMap>
configureDefaultNics(final RouterDeploymentDefinition
routerDeploymentDefinition) throws ConcurrentOperationException,
InsufficientAddressCapacityException {
-
-final LinkedHashMap> networks
= new LinkedHashMap>(3);
+protected LinkedHashMap>
configureControlNic(final RouterDeploymentDefinition
routerDeploymentDefinition) {
+final LinkedHashMap>
controlConfig = new LinkedHashMap>(3);
-// 1) Control network
s_logger.debug("Adding nic for Virtual Router in Control network
");
final List offerings =
_networkModel.getSystemAccountNetworkOfferings(NetworkOffering.SystemControlNetwork);
final NetworkOffering controlOffering = offerings.get(0);
-final Network controlConfig =
_networkMgr.setupNetwork(s_systemAccount, controlOffering,
routerDeploymentDefinition.getPlan(), null, null, false).get(0);
+final Network controlNic =
_networkMgr.setupNetwork(s_systemAccount, controlOffering,
routerDeploymentDefinition.getPlan(), null, null, false).get(0);
-networks.put(controlConfig, new ArrayList());
+controlConfig.put(controlNic, new ArrayList());
+
+return controlConfig;
+}
+
+protected LinkedHashMap>
configurePublicNic(final RouterDeploymentDefinition routerDeploymentDefinition,
final boolean hasGuestNic) {
+final LinkedHashMap>
publicConfig = new LinkedHashMap>(3);
--- End diff --
Hi @koushik-das ,
I just refactored the code and did not bother about the initial size - it
was there before. It actually won't change anything in terms of performance.
Cheers,
Wilder
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736721#comment-14736721
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138887313
@koushik-das They have been different for a long time. I think when VPC was
invented, they reordered the nics so that the tiers came last (because you can
have N of them). Recently in a refactor, the order was also changed in VR. This
restores it. If we want the same order, we need to look at all the scripts
(cloud-early-config and friends) that use hardcoded nic names. I think this was
faster to do.
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736722#comment-14736722
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138887396
My issue is also gone, so LGTM from me as well. Thanks for fixing this.
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:40 errors:0 dropped:0 overruns:0 frame:0
> TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:4308 (4.2 KiB) TX bytes:294 (294.0 B)
> loLink encap:Local Loopback
>
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736610#comment-14736610
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138865017
One more doubt. Why the ordering of interfaces are different in regular VR
and VPC VR? Has it changed recently or was like this since the beginning? And
will it cause more issues down the line when VR or VPC VR scripts are modified?
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:40 errors:0 dropped:0 overruns:0 frame:0
> TX packets:7 errors:0 dropped:0 ove
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736583#comment-14736583
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138861606
Other than one minor comment, LGTM
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:40 errors:0 dropped:0 overruns:0 frame:0
> TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:4308 (4.2 KiB) TX bytes:294 (294.0 B)
> loLink encap:Local Loopback
> inet addr:127.0.0.1 Mask:25
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736580#comment-14736580
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/788#discussion_r39025559
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -610,20 +608,22 @@ protected HypervisorType
getClusterToStartDomainRouterForOvm(final long podId) {
throw new CloudRuntimeException(errMsg);
}
-@Override
-public LinkedHashMap>
configureDefaultNics(final RouterDeploymentDefinition
routerDeploymentDefinition) throws ConcurrentOperationException,
InsufficientAddressCapacityException {
-
-final LinkedHashMap> networks
= new LinkedHashMap>(3);
+protected LinkedHashMap>
configureControlNic(final RouterDeploymentDefinition
routerDeploymentDefinition) {
+final LinkedHashMap>
controlConfig = new LinkedHashMap>(3);
-// 1) Control network
s_logger.debug("Adding nic for Virtual Router in Control network
");
final List offerings =
_networkModel.getSystemAccountNetworkOfferings(NetworkOffering.SystemControlNetwork);
final NetworkOffering controlOffering = offerings.get(0);
-final Network controlConfig =
_networkMgr.setupNetwork(s_systemAccount, controlOffering,
routerDeploymentDefinition.getPlan(), null, null, false).get(0);
+final Network controlNic =
_networkMgr.setupNetwork(s_systemAccount, controlOffering,
routerDeploymentDefinition.getPlan(), null, null, false).get(0);
-networks.put(controlConfig, new ArrayList());
+controlConfig.put(controlNic, new ArrayList());
+
+return controlConfig;
+}
+
+protected LinkedHashMap>
configurePublicNic(final RouterDeploymentDefinition routerDeploymentDefinition,
final boolean hasGuestNic) {
+final LinkedHashMap>
publicConfig = new LinkedHashMap>(3);
--- End diff --
In the individual configure methods, why is the initial size of the hash
map 3? :)
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:0
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736529#comment-14736529
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138851642
I've tested the patch as well since I was hitting the exact same issue. All
is working fine, and interfaces are configured correctly. :+1:
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:40 errors:0 dropped:0 overruns:0 frame:0
> TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:4308 (4.2 KiB) TX
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736510#comment-14736510
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138846797
I tested the patch, now isolated network VR is coming up and the interfaces
are configured in correct order.
eth0 - guest
eth1 - link local
eth2 - public
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:40 errors:0 dropped:0 overruns:0 frame:0
> TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
>
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734957#comment-14734957
]
ASF GitHub Bot commented on CLOUDSTACK-8814:
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/788
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers
nics
Hi there,
I refactored the configureDefaultNics() method in order to split the
implementations for Routers and VPC Routers.
The following tests were executed:
* test_vm_life_cycle
* test_routers
* test_vpc_router_nics
* test_vpc_routers
* test_vpc_offerings
@remibergsma @bhaisaab @koushik-das @miguelaferreira @DaanHoogland
@karuturi , could you please have a look/test this PR?
Thanks in advance.
Cheers,
Wilder
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ekholabs/cloudstack
fix/iso_net-CLOUDSTACK-8814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #788
commit 5e9e9b84fb1a4ca029c32e5b1c305124bfa4d4af
Author: wilderrodrigues
Date: 2015-09-08T12:33:25Z
CLOUDSTACK-8814 - Refactoring the configuration of Routers and VPC routers
nics
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734958#comment-14734958 ] ASF GitHub Bot commented on CLOUDSTACK-8814: Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/788#issuecomment-138594852 Tests results: Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS === ok Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS === ok Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS === ok Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS === ok Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS === ok Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS === ok Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS === ok Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS === ok Test migrate VM ... SKIP: At least two hosts should be present in the zone for migration Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS === ok -- Ran 10 tests in 1331.675s OK (SKIP=1) /tmp//MarvinLogs/test_vm_life_cycle_63T0C0/results.txt (END) Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS === ok Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS === ok Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS === ok Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS === ok Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS === ok Test start router ... === TestName: test_08_start_router | Status : SUCCESS === ok Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS === ok -- Ran 7 tests in 640.780s OK /tmp//MarvinLogs/test_routers_5RJ3RR/results.txt (END) Create a vpc with two networks with two vms in each network ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS === ok -- Ran 1 test in 1239.170s OK /tmp//MarvinLogs/test_vpc_router_nics_XE5A1M/results.txt (END) Test start/stop of router after addition of one guest network ... === TestName: test_01_start_stop_router_after_addition_of_one_guest_network | Status : SUCCESS === ok Test reboot of router after addition of one guest network ... === TestName: test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS === ok Test to change service offering of router after addition of one guest network ... === TestName: test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : SUCCESS === ok Test destroy of router after addition of one guest network ... === TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : SUCCESS === ok Test to stop and start router after creation of VPC ... === TestName: test_01_stop_start_router_after_creating_vpc | Status : SUCCESS === ok Test to reboot the router after creating a VPC ... === TestName: test_02_reboot_router_after_creating_vpc | Status : SUCCESS === ok Tests to change service offering of the Router after ... === TestName: test_04_change_service_offerring_vpc | Status : SUCCESS === ok Test to destroy the router after creating a VPC ... === TestName: test_05_destroy_router_after_creating_vpc | Status : SUCCESS === ok -- Ran 8 tests in 1841.429s OK /tmp//MarvinLogs/test_vpc_routers_GVQ115/results.txt (END) Test deploy virtual machines in VPC networks ... === TestName: test_02_deploy_vms_in_vpc_nw | Status : SUCCESS === ok -- Ran 1 test in 298.197s OK /tmp//MarvinLogs/test_vpc_offerings_OCI7B5/results.txt (END) > Order of nics in non-VPC router changed resulting in services to fail > - > > Key: CLOUDSTACK-8814 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814 > Project: CloudStack > Issue
[jira] [Commented] (CLOUDSTACK-8814) Order of nics in non-VPC router changed resulting in services to fail
[
https://issues.apache.org/jira/browse/CLOUDSTACK-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734779#comment-14734779
]
Wilder Rodrigues commented on CLOUDSTACK-8814:
--
I'm already working on this one and a fix will be pushed today!
Cheers,
Wilder
> Order of nics in non-VPC router changed resulting in services to fail
> -
>
> Key: CLOUDSTACK-8814
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8814
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: SystemVM
>Affects Versions: 4.6.0
>Reporter: Remi Bergsma
>Assignee: Wilder Rodrigues
>Priority: Critical
> Fix For: 4.6.0
>
>
> When testing a non-vpc setup, CloudStack was not able to ssh to 169.254.x.y
> because it was not listening on this ip:
> Isolated network, single router doesn't listen on link_local:3922
> tcp0 0 192.168.23.25:3922 0.0.0.0:* LISTEN
> 0 68283487/sshd
> Redundant isolated router:
> tcp0 0 10.20.1.10:3922 0.0.0.0:* LISTEN
> 0 64343068/sshd
> The reason for this, is that the naming of the interfaces now seems to be the
> same (same order) as on VPC routers. This used to be different.
> cloud-early-config uses hard-coded eth devices that seem not to have
> reflected to these changes.
> setup_vpcrouter() {
> ...
> setup_sshd $ETH0_IP "eth0"
> ...
> ==> That works!
> setup_router() {
> ..
> setup_sshd $ETH1_IP "eth1"
> ==> That goes wrong now.
> If we keep this new order, all nics need to be checked. Apache settings,
> keepalived etc etc
> Here you see the difference:
> non-vpc router in 4.4:
> root@r-17809-VM:~# ifconfig
> eth0 Link encap:Ethernet HWaddr 02:00:1c:e5:00:16
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:251172 errors:0 dropped:0 overruns:0 frame:0
> TX packets:223685 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:22836300 (21.7 MiB) TX bytes:106769179 (101.8 MiB)
> Interrupt:24
> eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:01:44
> inet addr:169.254.1.68 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:13052283 errors:0 dropped:0 overruns:0 frame:0
> TX packets:16557626 errors:0 dropped:16 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:7051380496 (6.5 GiB) TX bytes:3279800734 (3.0 GiB)
> Interrupt:25
> eth2 Link encap:Ethernet HWaddr 06:ab:30:00:00:30
> inet addr:178.y.x.22 Bcast:178.y.x.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:308293122 errors:0 dropped:540 overruns:0 frame:0
> TX packets:364798 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:16920767106 (15.7 GiB) TX bytes:33871999 (32.3 MiB)
> Interrupt:26
> non-vpc router in 4.6
> root@r-9-VM:/opt/cloud/bin/cs# ifconfig
> eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:04
> inet addr:169.254.3.4 Bcast:169.254.255.255 Mask:255.255.0.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:1018 errors:0 dropped:0 overruns:0 frame:0
> TX packets:788 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:163208 (159.3 KiB) TX bytes:110389 (107.8 KiB)
> eth1 Link encap:Ethernet HWaddr 06:c3:88:00:00:19
> inet addr:192.168.23.25 Bcast:192.168.23.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:20 errors:0 dropped:0 overruns:0 frame:0
> TX packets:11 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:1344 (1.3 KiB) TX bytes:606 (606.0 B)
> eth2 Link encap:Ethernet HWaddr 02:00:6d:bd:00:02
> inet addr:10.1.1.1 Bcast:10.1.1.255 Mask:255.255.255.0
> UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
> RX packets:40 errors:0 dropped:0 overruns:0 frame:0
> TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:1000
> RX bytes:4308 (4.2 KiB) TX bytes:294 (294.0 B)
> loLink encap:Local Loopback
> inet addr:127.0.0.1 Mask:255.0.0.0
> UP LOOPBACK RUNNING MTU:16436 Metric:1
> RX packets:1 er
