[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111878#comment-16111878 ] ASF subversion and git services commented on CLOUDSTACK-8906: - Commit 5397106a7621e974343927c70ec19abe819237bf in cloudstack's branch refs/heads/master from [~sudharmaj] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=5397106 ] CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver (#883) After integrating XS with CCP the following folder gets created: /var/log/cloud/ however the logs in that are not rotated resulting in root file system fill up. It was a known issue and link http://support.citrix.com/article/CTX138064 describes the issue and solution. Used the article and added corresponding changes to Cloudstack. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953359#comment-15953359 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/883 tag:mergeready > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950392#comment-15950392 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user jayakarteek commented on the issue: https://github.com/apache/cloudstack/pull/883 Tested the PUll Request. Logs are rotated as expected in /var/log/cloud folder > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948948#comment-15948948 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/883 @jayakarteek Thanks for testing. I have made the respective code changes. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948912#comment-15948912 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user jayakarteek commented on the issue: https://github.com/apache/cloudstack/pull/883 Test results; when I executed the setupxenserver.sh file , following is the output iptables: Bad rule (does a matching rule exist in that chain?). mv: invalid option -- n Try `mv --help' for more information. success mv -n option is provided in line 52 > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895634#comment-15895634 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/883 ### ACS CI BVT Run **Sumarry:** Build Number 422 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_routers_network_ops.py test_disk_offerings.py > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891987#comment-15891987 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/883 Previous CI failures were not relevant to my changes. tag:mergeready > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309965#comment-15309965 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/883 ### ACS CI BVT Run **Sumarry:** Build Number 103 Hypervisor xenserver NetworkType Advanced Passed=71 Failed=2 Skipped=3 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_vpc_vpn.py * test_01_vpc_site2site_vpn Failed * test_vm_life_cycle.py * test_10_attachAndDetach_iso Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_login.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_disk_offerings.py > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292675#comment-15292675 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-220513693 Can someone with a xenserver setup validate this one? @bvbharat can you queue this one up for us? Thanks... > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266371#comment-15266371 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-216194579 tag:easypr > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251262#comment-15251262 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212742630 The existing implementation for logrotation that works with xenserver 6.0 and earlier does not works with 6.0.2 and later. That is the reason I have added this implentation. With #861 we are changing the database to point to XenServer600Resource, but this change has no impact on log rotation implementation. Here is an article that described the problem and the solution that I implemented. [http://support.en.ctx.org.cn/ctx138064.citrix](http://support.en.ctx.org.cn/ctx138064.citrix) @harikrishna-patnala can you comment if #861 is going to help in log rotation problem. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250387#comment-15250387 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212537408 I will admit, I don't really understand everything in play here. If I read this quickly, it seems like this PR may not be needed because #861 essentially changes the database to point to the `XenServer600Resource` resource which does not have the logrotate problem. Can I get a clarification from @remibergsma and/or @SudharmaJain. Thanks... > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250070#comment-15250070 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212471834 @SudharmaJain Will @swill is the RM for master/4.9, I'm not following these changes perhaps any Xen guru can comment, @agneya2001 ? @remibergsma do you have any outstanding issues with this PR > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249765#comment-15249765 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-212404120 @bhaisaab Rebased the branch. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119387#comment-15119387 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-175671185 @SudharmaJain Please rebase and send for a re-review > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988982#comment-14988982 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/883#discussion_r43846616 --- Diff: scripts/vm/hypervisor/xenserver/logrotate --- @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Version @VERSION@ +# +# script to perform logrotation on xenserver 6.0.2 and later + +/usr/sbin/logrotate /etc/logrotate.d/cloudlog --- End diff -- @sspans I think the files mentioned in the patch file are the only ones getting deployed to the xenserver. Of these I cloud find cloudlog is the only logrotate configuration file. Please let me know if I missed anything. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985384#comment-14985384 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-153051565 Hi @SudharmaJain can you please fix the conflict? I'll then run some tests and we're ready to merge. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976508#comment-14976508 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user sspans commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/883#discussion_r43131260 --- Diff: scripts/vm/hypervisor/xenserver/logrotate --- @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Version @VERSION@ +# +# script to perform logrotation on xenserver 6.0.2 and later + +/usr/sbin/logrotate /etc/logrotate.d/cloudlog --- End diff -- Should this really be only the cloudlog config? > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973840#comment-14973840 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-151047344 Changes LGTM. I haven't tested it. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972623#comment-14972623 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-150820547 @sspans Can you review this xenserver logrotate change please? Thanks! > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968018#comment-14968018 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-150033996 @koushik-das Any update on this please? Thanks! > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962060#comment-14962060 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-148945004 @koushik-das I merged #861 and @SudharmaJain updated this PR and removed the reimplementation of XenServer 6.0.2 resource. Are you OK with this change now? Please review again, thanks! > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952375#comment-14952375 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-147233273 @remibergsma @koushik-das I have made the changes and have removed reimplementation of XenServer 6.0.2 resource. I have added changes to patch file for XenServer 6.0 resource, so that log rotation will work for 6.0 and 6.0.2. PR #861 will not fix this issue. Now both PR #883 and PR #861 need to be merged to fix the issues. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951961#comment-14951961 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-147112896 We won't merge this PR, we should merge #861 instead. Final call to @SudharmaJain to confirm if PR #861 also fixes your issue. If I do not get a response in the coming days, I will merge #861 and close this PR. See for more info the discussion in #861. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951840#comment-14951840 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-147090189 LGTM (code-wise), let's merge this once tested. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946369#comment-14946369 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-146093740 @SudharmaJain Please test PR #861 and confirm your problem has been solved. We'll then close this PR and merge the other. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946311#comment-14946311 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-146083023 @remibergsma @koushik-das For incorporating the change in XenServer600Resource, I need to test the change for Xenserver 6.0. After checking it for 6.0, I will update the PR. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946296#comment-14946296 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-146081053 @koushik-das This bug exist in xenserver 6.0.2 and later. For XenServer 6.0, logrotation works. Thats is the reason i have implemented XenServer602Resource and didn't used Xenserver600Resource. Contents of patch file for 6.0 and 6.0.2 had a difference of one line. I have added a new file logrotate to be deployed in /etc/cron.hourly for versions 6.0.2 and later. So i have updated the patch file for 6.2 and 6.5 as well. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941777#comment-14941777 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-145157098 @SudharmaJain Please respond to comments. If you agree, please close this PR. Thanks! > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936675#comment-14936675 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-144347154 @SudharmaJain Why can't the XenServer600Resource be used to handle XS 6.0.2 hosts? The only change I see is the patch script (scripts/vm/hypervisor/xenserver/xenserver602/patch). If the content of the patch file is same as that of scripts/vm/hypervisor/xenserver/xenserver60/patch then there is no need for a separate 6.0.2 resource, PR #861 should be used instead. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910056#comment-14910056 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-143645025 @remibergsma Rebased against the current master. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909867#comment-14909867 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-143590005 @SudharmaJain Can you please rebase against current master? Then we can run the tests. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909403#comment-14909403 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-143478261 @remibergsma I didn't checked the PR #861. I was looking to fix the issue with xenserver 6.0.2 and higher. For this I have added a logrotate script and a Patch file for 6.0.2 which is the same as for xenserver 6.0 with an extra entry for logrotate script. same entry is added in patch file for 6.2 and 6.5. In earlier version, you can find logrotate in /etc/cron.hourly. In later versions it was not available which broke the log rotate functionality. > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909380#comment-14909380 ] ASF GitHub Bot commented on CLOUDSTACK-8906: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-143475690 @SudharmaJain The title and the content of your PR do not match. You seem to re-implement the XenServer 6.0.2 resource? If that is what you want, make a PR just for that. Also I'd like to know if the logrotate you make works on 6.2 and 6.5 as well. Did you also see PR #861 on this subject? > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8906) /var/log/cloud/ doesn't get logrotated on xenserver
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906311#comment-14906311 ] ASF GitHub Bot commented on CLOUDSTACK-8906: GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/883 CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver After integrating XS with CCP the following folder gets created: /var/log/cloud/ however the logs in that are not rotated resulting in root file system fill up. It was a known issue and link http://support.citrix.com/article/CTX138064 describes the issue and solution. Used the article and added corresponding changes to Cloudstack. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SudharmaJain/cloudstack cs-8906 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/883.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #883 commit ffc786f40317c05e0a9b2b3ccd47fee21e1f76bb Author: SudharmaJain Date: 2015-09-24T12:34:38Z CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver > /var/log/cloud/ doesn't get logrotated on xenserver > > > Key: CLOUDSTACK-8906 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8906 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: sudharma jain > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
