[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154115#comment-15154115 ] ASF GitHub Bot commented on CLOUDSTACK-9026: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1031 > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154112#comment-15154112 ] ASF subversion and git services commented on CLOUDSTACK-9026: - Commit ee150aa631e66910a7d1cb1203147c6ed5495737 in cloudstack's branch refs/heads/master from sanjeev [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ee150aa ] Merge pull request #1031 from pritisarap12/CLOUDSTACK-9026-Modifying-testpath-for-adding-missing-parameter CLOUDSTACK-9026: Modifying testpath for adding missing parameterAdding service_offering creation in testpath_storage_migration.py testpath which is missing right now * pr/1031: CLOUDSTACK-9026: Modifying testpath for adding missing parameter Signed-off-by: sanjeev > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154114#comment-15154114 ] ASF subversion and git services commented on CLOUDSTACK-9026: - Commit ee150aa631e66910a7d1cb1203147c6ed5495737 in cloudstack's branch refs/heads/master from sanjeev [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ee150aa ] Merge pull request #1031 from pritisarap12/CLOUDSTACK-9026-Modifying-testpath-for-adding-missing-parameter CLOUDSTACK-9026: Modifying testpath for adding missing parameterAdding service_offering creation in testpath_storage_migration.py testpath which is missing right now * pr/1031: CLOUDSTACK-9026: Modifying testpath for adding missing parameter Signed-off-by: sanjeev > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154113#comment-15154113 ] ASF subversion and git services commented on CLOUDSTACK-9026: - Commit ee150aa631e66910a7d1cb1203147c6ed5495737 in cloudstack's branch refs/heads/master from sanjeev [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ee150aa ] Merge pull request #1031 from pritisarap12/CLOUDSTACK-9026-Modifying-testpath-for-adding-missing-parameter CLOUDSTACK-9026: Modifying testpath for adding missing parameterAdding service_offering creation in testpath_storage_migration.py testpath which is missing right now * pr/1031: CLOUDSTACK-9026: Modifying testpath for adding missing parameter Signed-off-by: sanjeev > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154111#comment-15154111 ] ASF subversion and git services commented on CLOUDSTACK-9026: - Commit 207b7e3b5004b930abbb0b2ecbda5aa79909ee5f in cloudstack's branch refs/heads/master from [~pritisarap12] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=207b7e3 ] CLOUDSTACK-9026: Modifying testpath for adding missing parameter > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153959#comment-15153959 ] ASF GitHub Bot commented on CLOUDSTACK-9026: Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/1031#issuecomment-186124001 did cod walk thought. Looks good to me . > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152269#comment-15152269 ] ASF GitHub Bot commented on CLOUDSTACK-9026: Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1031#discussion_r53309123 --- Diff: test/integration/testpaths/testpath_storage_migration.py --- @@ -248,6 +248,11 @@ def setUpClass(cls): DomainName=cls.account.domain ) # Create Service offering +cls.service_offering = ServiceOffering.create( +cls.apiclient, +cls.testdata["service_offering"] +) + --- End diff -- Added service_offering in cleanup. > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152162#comment-15152162 ] ASF GitHub Bot commented on CLOUDSTACK-9026: Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1031#discussion_r53300709 --- Diff: test/integration/testpaths/testpath_storage_migration.py --- @@ -248,6 +248,11 @@ def setUpClass(cls): DomainName=cls.account.domain ) # Create Service offering +cls.service_offering = ServiceOffering.create( +cls.apiclient, +cls.testdata["service_offering"] +) + --- End diff -- please add cls._cleanup.append(cls.service_offering) > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152157#comment-15152157 ] ASF GitHub Bot commented on CLOUDSTACK-9026: Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1031#issuecomment-185662747 LGTM based on test results!! Test migrate Volume (root and data disk) ... === TestName: test_01_migrate_root_and_data_disk_nonlive | Status : SUCCESS === ok -- Ran 1 test in 1778.920s OK > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150179#comment-15150179 ] ASF GitHub Bot commented on CLOUDSTACK-9026: Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/1031#issuecomment-185115938 Testcase result: Test migrate Volume (root and data disk) ... === TestName: test_01_migrate_root_and_data_disk_nonlive | Status : SUCCESS === ok -- Ran 1 test in 1688.400s OK > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146925#comment-15146925 ] ASF GitHub Bot commented on CLOUDSTACK-9026: GitHub user pritisarap12 reopened a pull request: https://github.com/apache/cloudstack/pull/1031 CLOUDSTACK-9026: Modifying testpath for adding missing parameter Adding service_offering creation in testpath_storage_migration.py testpath which is missing right now You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-9026-Modifying-testpath-for-adding-missing-parameter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1031.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1031 commit c2376334592835c30b865c2b08f8c179eed8d328 Author: Priti Sarap Date: 2015-11-04T09:18:38Z CLOUDSTACK-9026: Modifying testpath for adding missing parameter > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146924#comment-15146924 ] ASF GitHub Bot commented on CLOUDSTACK-9026: Github user pritisarap12 closed the pull request at: https://github.com/apache/cloudstack/pull/1031 > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9026) Modifying testpath for adding missing parameter
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989190#comment-14989190 ] ASF GitHub Bot commented on CLOUDSTACK-9026: GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1031 CLOUDSTACK-9026: Modifying testpath for adding missing parameter Addning service_offering creation in testpath_storage_migration.py testpath which is missing right now You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-9026-Modifying-testpath-for-adding-missing-parameter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1031.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1031 commit c2376334592835c30b865c2b08f8c179eed8d328 Author: Priti Sarap Date: 2015-11-04T09:18:38Z CLOUDSTACK-9026: Modifying testpath for adding missing parameter > Modifying testpath for adding missing parameter > --- > > Key: CLOUDSTACK-9026 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9026 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Automation >Reporter: Priti Sarap > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
