[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029550#comment-15029550 ] ASF GitHub Bot commented on CLOUDSTACK-9091: GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1130 CLOUDSTACK-9091: Update testpath for parameter issues In testpath_volume_snapshot testpath creating volume from snapshot function is passing zonid parameter to function in base class but there it doesn't take as separate parameter it takes it from "services" so updating it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-9091-Update-testpath-for-parameter-issues Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1130 commit 358115de151ababd45d31a743f71edadc8cfafae Author: Priti Sarap Date: 2015-11-27T07:21:50Z CLOUDSTACK-9091: Update testpath for parameter issues > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033413#comment-15033413 ] ASF GitHub Bot commented on CLOUDSTACK-9091: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-160908545 LGTM > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069561#comment-15069561 ] ASF GitHub Bot commented on CLOUDSTACK-9091: Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-166878921 @remibergsma can you please merge this in? Thanks, Raja > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069565#comment-15069565 ] ASF GitHub Bot commented on CLOUDSTACK-9091: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-166879268 @pvr9711 Please make sure we have 2xLGTM of which at least one run the test. Will not merge without. > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072682#comment-15072682 ] ASF GitHub Bot commented on CLOUDSTACK-9091: Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-167562545 This is one line change and looks good. I will get test results for this. LGTM!! > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119428#comment-15119428 ] ASF GitHub Bot commented on CLOUDSTACK-9091: Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-175683955 @sanju1010 looking forward to the test results > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151986#comment-15151986 ] ASF GitHub Bot commented on CLOUDSTACK-9091: Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-185610104 Testcase result after modifications: Test Volume (root) Snapshot ... === TestName: test_01_volume_snapshot | Status : SUCCESS === ok -- Ran 1 test in 1012.564s OK > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152059#comment-15152059 ] ASF GitHub Bot commented on CLOUDSTACK-9091: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1130 > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152054#comment-15152054 ] ASF subversion and git services commented on CLOUDSTACK-9091: - Commit 79edac0ee6d63d642e4df6f828295ffceed6149f in cloudstack's branch refs/heads/master from sanjeev [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=79edac0 ] Merge pull request #1130 from pritisarap12/CLOUDSTACK-9091-Update-testpath-for-parameter-issues CLOUDSTACK-9091: Update testpath for parameter issuesIn testpath_volume_snapshot testpath creating volume from snapshot function is passing zonid parameter to function in base class but there it doesn't take as separate parameter it takes it from "services" so updating it. * pr/1130: CLOUDSTACK-9091: Update testpath for parameter issues Signed-off-by: sanjeev > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152053#comment-15152053 ] ASF subversion and git services commented on CLOUDSTACK-9091: - Commit 358115de151ababd45d31a743f71edadc8cfafae in cloudstack's branch refs/heads/master from [~pritisarap12] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=358115d ] CLOUDSTACK-9091: Update testpath for parameter issues > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152055#comment-15152055 ] ASF subversion and git services commented on CLOUDSTACK-9091: - Commit 79edac0ee6d63d642e4df6f828295ffceed6149f in cloudstack's branch refs/heads/master from sanjeev [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=79edac0 ] Merge pull request #1130 from pritisarap12/CLOUDSTACK-9091-Update-testpath-for-parameter-issues CLOUDSTACK-9091: Update testpath for parameter issuesIn testpath_volume_snapshot testpath creating volume from snapshot function is passing zonid parameter to function in base class but there it doesn't take as separate parameter it takes it from "services" so updating it. * pr/1130: CLOUDSTACK-9091: Update testpath for parameter issues Signed-off-by: sanjeev > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9091) Update testpath for parameter issues
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152056#comment-15152056 ] ASF subversion and git services commented on CLOUDSTACK-9091: - Commit 79edac0ee6d63d642e4df6f828295ffceed6149f in cloudstack's branch refs/heads/master from sanjeev [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=79edac0 ] Merge pull request #1130 from pritisarap12/CLOUDSTACK-9091-Update-testpath-for-parameter-issues CLOUDSTACK-9091: Update testpath for parameter issuesIn testpath_volume_snapshot testpath creating volume from snapshot function is passing zonid parameter to function in base class but there it doesn't take as separate parameter it takes it from "services" so updating it. * pr/1130: CLOUDSTACK-9091: Update testpath for parameter issues Signed-off-by: sanjeev > Update testpath for parameter issues > > > Key: CLOUDSTACK-9091 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9091 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Priti Sarap > > In testpath_volume_snapshot testpath creating volume from snapshot function > is passing zonid parameter to function in base class but there it doesn't > take as separate parameter it takes it from "services" so updating it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
